Page MenuHomePhabricator

labath (Pavel Labath)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2013, 6:02 AM (398 w, 3 d)

Recent Activity

Today

labath added a comment to D95261: [lldb/test] Reduce API test tools configuration boilerplate.

I should add, this also ensures one does not need to introduce a similar amount of cruft for each new llvm tool that he wants to use in the tests.

Fri, Jan 22, 12:57 PM · Restricted Project
labath requested review of D95261: [lldb/test] Reduce API test tools configuration boilerplate.
Fri, Jan 22, 12:54 PM · Restricted Project
labath added a comment to D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux.

@labath, you were absolutely correct! It was simply a matter of saving and restoring the terminal struct on the terminalHasColors function in the Process.inc file (I really should've tried that before). I'm currently recompiling and will re-run the tests locally, and will push the changes after that. I do worry this could potentially impact macOS though (I don't know if these low-level terminal functions work differently between differently OSes), so how do we ensure this doesn't break anything there?

Fri, Jan 22, 5:17 AM · Restricted Project
labath added a comment to D77043: Use remote regnums in expedited list, value regs and invalidate regs.

There's still one "opportunistic" snippet in GDBRemoteRegisterContext.cpp, around line 404. Did you forget about that, or is there something special about that case? (if so, then what?)

Fri, Jan 22, 5:10 AM
labath added a comment to D94888: [lldb] Add -Wl,-rpath to make tests run with fresh built libc++.

I am pretty sure they were. This flag is needed to use (system) libc++ with gcc, and this was happening at a time when we were running the test suite with gcc, as it was still the default compiler for android.

Is anyone running tests in this build mode (gcc + libc++) still? Should we keep this support around?

Fri, Jan 22, 5:04 AM · Restricted Project
labath added a comment to D93939: [elf-core] Improve reading memory from core file.

The fact that the test suite passes is not too surprising since we have very few core file tests. However, I agree that we should just remove this zero filling completely.

Fri, Jan 22, 4:51 AM · Restricted Project
labath added a comment to D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux.

Can you be more specific about what is the nature and cause of this breakage?

Fri, Jan 22, 4:15 AM · Restricted Project

Wed, Jan 20

labath added a reverting change for rG079e66466177: [lldb] Re-enable TestPlatformProcessConnect on macos: rG599fdfc5db8f: Revert "[lldb] Re-enable TestPlatformProcessConnect on macos".
Wed, Jan 20, 11:49 AM
labath committed rG599fdfc5db8f: Revert "[lldb] Re-enable TestPlatformProcessConnect on macos" (authored by labath).
Revert "[lldb] Re-enable TestPlatformProcessConnect on macos"
Wed, Jan 20, 11:49 AM

Tue, Jan 19

labath committed rG079e66466177: [lldb] Re-enable TestPlatformProcessConnect on macos (authored by labath).
[lldb] Re-enable TestPlatformProcessConnect on macos
Tue, Jan 19, 2:01 AM
labath added a comment to D94888: [lldb] Add -Wl,-rpath to make tests run with fresh built libc++.

It looks like this is removing the ability to build libc++ tests with gcc (as it does not have the -stdlib option). While having that ability would be nice, I don't believe there's anyone currently using that configuration, so it shouldn't stand in the way of other things. But we should also update the python detection code then (in canRunLibcxxTests in packages/Python/lldbsuite/test/dotest.py -- I guess you just need to remove the if os.path.isdir("/usr/include/c++/v1"): blurb)

As for testing against the system libc++ with clang, I guess that should still work, as the extra rpath will be just ignored in that case...

I do not know whether the following few lines D9426 were intentional.

Tue, Jan 19, 1:23 AM · Restricted Project
labath updated subscribers of D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms.

(sorry for inactivity -- I mostly tuned out of this discussion as I
couldn't keep up with its pace)

Tue, Jan 19, 1:13 AM · Restricted Project
labath added a comment to D94888: [lldb] Add -Wl,-rpath to make tests run with fresh built libc++.

Out of curiousity did you find a way to get lldb-test to print out the stdout/stderr of the underlying lldb process to see what error messages it was producing that demonstrated this failure? I was trying to figure out how to do that, and it seems like a good thing to be able to do for this issue or others down the way.

Tue, Jan 19, 12:10 AM · Restricted Project
labath added a comment to D94888: [lldb] Add -Wl,-rpath to make tests run with fresh built libc++.

It looks like this is removing the ability to build libc++ tests with gcc (as it does not have the -stdlib option). While having that ability would be nice, I don't believe there's anyone currently using that configuration, so it shouldn't stand in the way of other things. But we should also update the python detection code then (in canRunLibcxxTests in packages/Python/lldbsuite/test/dotest.py -- I guess you just need to remove the if os.path.isdir("/usr/include/c++/v1"): blurb)

Tue, Jan 19, 12:07 AM · Restricted Project

Mon, Jan 18

labath added a comment to D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test.

Looks like a nice cleanup. The only part I am not sure of is the part about removing $(RM) $(ARCHIVE_OBJECTS). Is that necessary?
I'm not sure why is that line there, but if I had to guess, I would say it's to ensure that lldb (on macos) reads debug info from the archive file instead of the original .o files. If it's not required, it may be better to leave it in. Otherwise, someone from Apple should say whether that is ok (testing archives is only really interesting on fruity platforms).

Mon, Jan 18, 11:41 PM · Restricted Project
labath accepted D94917: [lldb] Fix crash in "help memory read".
Mon, Jan 18, 11:23 PM · Restricted Project
labath accepted D82863: [LLDB] Add support to resize SVE registers at run-time.

Looks good, thanks.

Mon, Jan 18, 11:02 PM · Restricted Project
labath accepted D94672: Implement vAttachOrWait.
Mon, Jan 18, 10:58 PM · Restricted Project

Sun, Jan 17

labath committed rGa89242d874df: [lldb] Skip TestPlatformProcessConnect on windows and darwin (authored by labath).
[lldb] Skip TestPlatformProcessConnect on windows and darwin
Sun, Jan 17, 11:20 AM

Fri, Jan 15

labath accepted D94754: skip g packet tests on darwin systems.

Yeah, this is fine. I remember running this on darwin and noticing that debugserver only supports G (and lldb-server, amusingly, only supports g). I must have forgotten to add the decorators when copying patches around. Sorry.

Fri, Jan 15, 9:11 AM · Restricted Project

Thu, Jan 14

labath added inline comments to D94672: Implement vAttachOrWait.
Thu, Jan 14, 5:45 AM · Restricted Project
labath added a comment to D94077: Support unscoped enumeration members in the expression evaluator..

Thanks for the explanation, this makes sense. I've checked the mailing list archives and it seems there was already a discussion about the enumerators in the .debug_names index back in 2018 -- http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2018-April/004443.html. You were the one to bring it up and the consensus was that the enumerators should go into the index too.

But it seems this was never actually implemented, the latest version of the toolchain doesn't add DW_TAG_enumerator entries to the .debug_names index. Is there a reason for that or it just slipped through the cracks? Should I bring it up again on the mailing list or we can assume the consensus is still the same and this should be just implemented?

Thu, Jan 14, 5:35 AM · Restricted Project
labath committed rGa997a1d7fbe2: [lldb/test] Ensure launched processes are ready to be attached (authored by labath).
[lldb/test] Ensure launched processes are ready to be attached
Thu, Jan 14, 3:07 AM
labath added a comment to D82863: [LLDB] Add support to resize SVE registers at run-time.

Thanks for your patience. I think this is in a pretty good shape now. Just a couple of quick questions inline...

Thu, Jan 14, 1:24 AM · Restricted Project
labath added a comment to D77043: Use remote regnums in expedited list, value regs and invalidate regs.

Using remote numbers in the lists seems reasonable as well, but I am troubled by the "opportunistic" aspect of the implementation. This pattern

uint32_t lldb_regnum = ConvertRegisterKindToRegisterNumber(
    eRegisterKindProcessPlugin, reg);
if (lldb_regnum != LLDB_INVALID_REGNUM)
  reg = lldb_regnum;
const RegisterInfo *value_reg_info = GetRegisterInfoAtIndex(reg);

is cumbersome to write and easy to get wrong.

Thu, Jan 14, 1:08 AM
labath committed rG4b284b9ca809: [lldb] Fix TestPlatformProcessConnect.py (authored by labath).
[lldb] Fix TestPlatformProcessConnect.py
Thu, Jan 14, 12:50 AM
labath committed rG2bbf724feea9: Implement vAttachWait in lldb-server (authored by augusto2112).
Implement vAttachWait in lldb-server
Thu, Jan 14, 12:28 AM
labath closed D93895: Implement vAttachWait in lldb-server.
Thu, Jan 14, 12:27 AM · Restricted Project

Wed, Jan 13

labath committed rG7ad54d193871: [lldb][wasm] Parse DWO section names (authored by pfaffe).
[lldb][wasm] Parse DWO section names
Wed, Jan 13, 11:53 PM
labath closed D93621: [lldb][wasm] Parse DWO section names.
Wed, Jan 13, 11:53 PM · Restricted Project

Mon, Jan 11

labath committed rGd36e879c21c9: [lldb] Disable PipeTest.OpenAsReader on windows (authored by labath).
[lldb] Disable PipeTest.OpenAsReader on windows
Mon, Jan 11, 4:38 AM

Sun, Jan 10

labath committed rG13dea030b3d7: [lldb] Fix some bugs in the Pipe class and add tests (authored by labath).
[lldb] Fix some bugs in the Pipe class and add tests
Sun, Jan 10, 12:59 PM
labath accepted D93895: Implement vAttachWait in lldb-server.

Looks good, modulo the inline comment.

Sun, Jan 10, 12:09 PM · Restricted Project

Fri, Jan 8

labath added a comment to D94077: Support unscoped enumeration members in the expression evaluator..

This suffers from the same problem as the other patch, where the other index classes (apple_names and debug_names) will essentially never be able to implement this feature. (Unless they re-index the dwarf themselves, that is, but this would defeat the purpose of having the index in the first place.)

I'm not sure I completely understand. Why does changing the manual_dwarf_index mean that the other index classes can't ever implement this feature? If, let's say, debug_names decides to support enum constants, then its data layout should be changed to either include enumerators as globals, or add a new section, or something else. Then it can be properly handled in LLDB too (maybe changing the way manual_dwarf_index works too to keep things consistent). As I understand, manual_dwarf_index can be changed anytime, since we're building it ourselves.

Do I misunderstand how these indexes work and interact with each other?

Fri, Jan 8, 12:54 PM · Restricted Project

Thu, Jan 7

labath accepted D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms.

If it's better to write it using C++ source and custom clang flags I can do that instead (it'll be an -mllvm flag - looks like there's one other test that does that: lldb/test/API/lang/objc/forward-decl/TestForwardDecl.py: dict(CFLAGS_EXTRAS="-dwarf-version=5 -mllvm -accel-tables=Dwarf"))) - means the test will be a bit more convoluted to tickle the subprogram ranges, but not much - just takes two functions+function-sections.

Thu, Jan 7, 12:52 PM · Restricted Project
labath added a comment to D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms.

I don't think that simply setting func_lo_pc to zero will be sufficient to make this work. I would expect this to break in more complicated scenarios (like, even if we just have two of these functions). I think the only reason it works in this case is because for this particular function, it's base address (relative to the CU base) *is* zero.

I certainly don't have high confidence in the change, to be sure - but I think it's a bit more robust than that.

Yes, it seems it is, though just by a bit. :)

Thu, Jan 7, 12:41 PM · Restricted Project

Wed, Jan 6

labath committed rG4e0e79dd349a: [lldb] Simplify some lldb-server tests (authored by labath).
[lldb] Simplify some lldb-server tests
Wed, Jan 6, 6:40 AM
labath added a comment to D93895: Implement vAttachWait in lldb-server.

Thanks. This talk of all these packets has made me realize I did not completely understand the purpose of this packet. To really test the exclusion functionality of this packet, I guess we should be launching two instances of the inferior (one before sending the packet, one after), and then checking we attach to the right one. It looks like it should be easy to add to the existing test. Other than that (and some inline simplifications) this looks fine to me.

Wed, Jan 6, 6:37 AM · Restricted Project
labath added a comment to D93895: Implement vAttachWait in lldb-server.

I don't think it's a good idea to stuff all of this into a single patch. Can we go back to the version which just implements the basic vAttachWait packet (we can bikeshed on what the default interval should be)? I believe new commands/options/packets should be done in separate patches...

Ok. I can open other patches after this one is merged.

Wed, Jan 6, 5:58 AM · Restricted Project
labath added a comment to D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility.

I would mark stmmX as an alias to stX and keep stX as the default for all platforms. stmmX could be an alias for everybody for legacy reasons.

Wed, Jan 6, 5:55 AM · Restricted Project
labath accepted D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility.

I think this is fine -- sorry this dropped off my radar.

Wed, Jan 6, 5:54 AM · Restricted Project
labath accepted D94008: [LLDB] DynamicRegisterInfo calculate offsets in separate function.

LG, modulo inline comment.

Wed, Jan 6, 5:50 AM · Restricted Project
labath added a comment to D93895: Implement vAttachWait in lldb-server.

I don't think it's a good idea to stuff all of this into a single patch. Can we go back to the version which just implements the basic vAttachWait packet (we can bikeshed on what the default interval should be)? I believe new commands/options/packets should be done in separate patches...

Wed, Jan 6, 5:44 AM · Restricted Project
labath added a comment to D94077: Support unscoped enumeration members in the expression evaluator..

This suffers from the same problem as the other patch, where the other index classes (apple_names and debug_names) will essentially never be able to implement this feature. (Unless they re-index the dwarf themselves, that is, but this would defeat the purpose of having the index in the first place.)

Wed, Jan 6, 5:31 AM · Restricted Project
labath added a comment to D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter.

Your argument is correct because the interactive script interpreter always belongs to a single debugger.

Wed, Jan 6, 5:27 AM · Restricted Project
labath added a comment to D94064: lldb: Add support for printing variables with DW_AT_ranges on DW_TAG_subprograms.

I don't think that simply setting func_lo_pc to zero will be sufficient to make this work. I would expect this to break in more complicated scenarios (like, even if we just have two of these functions). I think the only reason it works in this case is because for this particular function, it's base address (relative to the CU base) *is* zero.

Wed, Jan 6, 5:19 AM · Restricted Project
labath added a comment to D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms.

The fix is good, but the test could be improved. Combining assembly input with running the inferior effectively limits the test to a single platform (assembly is not portable, and running requires asm to match the host). AFAICT, we don't actually need to run the binary to test this fix -- checking just the "breakpoint set" command should suffice (if you want to be more explicit in what is being checked, you can also run "breakpoint list -v" and test that). Then you'd just need to replace %clang_host with %clang -target x86_64-pc-linux (or something) and UNSUPPORTED: system-windows with REQUIRES: x86.

Wed, Jan 6, 4:44 AM · Restricted Project
labath accepted D93481: [lldb/Lua] add support for multiline scripted breakpoints.

This looks better. I haven't checked the rest of the patch in detail, but it seems ok at a quick glance and Jonas appeared to be happy with it.

Wed, Jan 6, 4:29 AM · Restricted Project

Sat, Jan 2

labath committed rG54a1c861ca7a: [lldb] Deduplicate more lldb-server tests (authored by labath).
[lldb] Deduplicate more lldb-server tests
Sat, Jan 2, 9:33 AM
labath committed rGd9ba8142c9a4: [lldb/test] Deduplicate the rest of TestLldbGdbServer.py (authored by labath).
[lldb/test] Deduplicate the rest of TestLldbGdbServer.py
Sat, Jan 2, 9:33 AM

Fri, Jan 1

labath added a comment to D93939: [elf-core] Improve reading memory from core file.

Have you by any chance learned why are we zero-filling this buffer in the first place? Seems like an odd thing to do... Maybe we should just stop zero-filling completely?

Fri, Jan 1, 12:39 PM · Restricted Project
labath added a comment to D93874: [process] fix exec support on Linux.

The new version seems ok-ish to me, but I'm leaving it open as I'd like Jim to weigh in here. The immediate cause of the crash is related to the (dangling?) m_thread pointer inside the completed "step instruction" plan. Normally, this pointer clears itself when the thread disappears but I guess this does not happen in the exec case. Jim should know what's the expected behavior here.

Fri, Jan 1, 12:19 PM · Restricted Project
labath added a comment to D93895: Implement vAttachWait in lldb-server.

Thanks for picking this up.

Fri, Jan 1, 1:57 AM · Restricted Project

Tue, Dec 29

labath committed rGa0b68a2925fb: [lldb] Deduplicate some tests in TestLldbGdbServer (authored by labath).
[lldb] Deduplicate some tests in TestLldbGdbServer
Tue, Dec 29, 12:37 AM
labath added a comment to D93874: [process] fix exec support on Linux.

It seems Thread plans already have logic to handle "exec" events. It would be better to figure out why that logic is not sufficient instead of adding another exec handling hook.

Tue, Dec 29, 12:16 AM · Restricted Project

Mon, Dec 28

labath committed rG53f80d6b3a01: [lldb] Fix logging in lldb-server tests (authored by labath).
[lldb] Fix logging in lldb-server tests
Mon, Dec 28, 11:35 PM
labath committed rG76a718ee939e: [lldb] Deduplicate some lldb-server tests (authored by labath).
[lldb] Deduplicate some lldb-server tests
Mon, Dec 28, 11:20 AM

Sun, Dec 27

labath added inline comments to D93481: [lldb/Lua] add support for multiline scripted breakpoints.
Sun, Dec 27, 5:25 AM · Restricted Project
labath committed rGbd39a5cb30a3: [lldb/test] Automatically skip remote lldb-server tests when applicable (authored by labath).
[lldb/test] Automatically skip remote lldb-server tests when applicable
Sun, Dec 27, 5:06 AM
labath committed rGaca4488847b4: [lldb] Surpress "ingoring result" warning in reproducer_handler (authored by labath).
[lldb] Surpress "ingoring result" warning in reproducer_handler
Sun, Dec 27, 5:06 AM
labath accepted D93495: CrashReason: Add MTE tag check faults to the list of crash reasons..
Sun, Dec 27, 5:01 AM · Restricted Project
labath accepted D93621: [lldb][wasm] Parse DWO section names.
Sun, Dec 27, 2:28 AM · Restricted Project

Dec 22 2020

labath added a comment to D92013: [DebugInfo] Don't use DW_OP_implicit_value for fragments.

Thinking about this further, I am not sure if the approach with multiple alternatives is a good solution (for this particular problem at least). If we take x87 long double constants (currently not supported here, but one of the things I wanted to look at) for example, they are 10 bytes long. Representing them with DW_OP_implicit_value is trivial. However, if we wanted to represent them with DW_OP_const, we would need to break it down into smaller chunks, something like DW_OP_const low64, DW_OP_stack_value, DW_OP_piece 8, DW_OP_const high16, DW_OP_stack_value, DW_OP_piece 2. If the DIExpression is empty, then that's fairly easy. However, if the expression already contains some operators (DW_OP_LLVM_fragment in particular), then I fear things would get messy. How messy depends on what is actually allowed to be contained in these expressions, which brings me to my next question:

Dec 22 2020, 2:18 AM · debug-info, Restricted Project
labath committed rG0a8a2453fb84: [lldb/test] Add GdbRemoteTestCaseFactory to avoid duplication in lldb-server… (authored by labath).
[lldb/test] Add GdbRemoteTestCaseFactory to avoid duplication in lldb-server…
Dec 22 2020, 1:08 AM
labath committed rG8d75d902a955: [DebugInfo] Don't use DW_OP_implicit_value for fragments (authored by labath).
[DebugInfo] Don't use DW_OP_implicit_value for fragments
Dec 22 2020, 1:08 AM
labath closed D92013: [DebugInfo] Don't use DW_OP_implicit_value for fragments.
Dec 22 2020, 1:08 AM · debug-info, Restricted Project
labath added a comment to D92013: [DebugInfo] Don't use DW_OP_implicit_value for fragments.

Thanks for the review, and for the explanation Adrian. I want to fix a couple more issues in the general vicinity of this code, so I'll keep this design goal in mind.

Dec 22 2020, 12:52 AM · debug-info, Restricted Project
labath added a comment to D93663: [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC).

You can't put these declarations inside do {} while(0) -- the additional scope works against us in this case, and forces a premature timer termination. Other than that, this seems fine...

Dec 22 2020, 12:45 AM · Restricted Project

Dec 21 2020

labath added inline comments to D93481: [lldb/Lua] add support for multiline scripted breakpoints.
Dec 21 2020, 12:07 PM · Restricted Project
labath accepted D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header..
Dec 21 2020, 11:48 AM · Restricted Project
labath added a comment to D93621: [lldb][wasm] Parse DWO section names.

It would be nice to "mirror" the test case (test/Shell/ObjectFile/ELF/section-types.yaml) too. Other than that, this is fine.

Dec 21 2020, 11:45 AM · Restricted Project
labath added inline comments to D93541: [Process/NetBSD] Copy changes from FreeBSDRemote and reformat.
Dec 21 2020, 11:42 AM · Restricted Project
labath committed rG3f3ab03ab7bb: [lldb] Remove anonymous namespace from NativeRegisterContextLinux_x86_64 (authored by labath).
[lldb] Remove anonymous namespace from NativeRegisterContextLinux_x86_64
Dec 21 2020, 11:42 AM

Dec 20 2020

labath added a comment to D92164: Make CommandInterpreter's execution context the same as debugger's one..

I've included two logs, showing failing and successful runs (the successful run was captured without this patch). Interesting things happen around line 1057, where the "step out" plan decides we should not stop after stepping out. I'm not sure what's the relation to this patch, but I suppose it could have something to do with it not (always) fetching the correct frame (from which it should step out) from the execution context.

Dec 20 2020, 3:01 AM · Restricted Project
labath committed rG37974b493a48: [lldb/test] Enable reverse-connect on windows too (authored by labath).
[lldb/test] Enable reverse-connect on windows too
Dec 20 2020, 1:38 AM
labath accepted D93541: [Process/NetBSD] Copy changes from FreeBSDRemote and reformat.
Dec 20 2020, 1:16 AM · Restricted Project

Dec 18 2020

labath added a comment to D92164: Make CommandInterpreter's execution context the same as debugger's one..

With this version of the patch, I am unable to reproduce the issue using the approach I described in the previous comment. However, it still reproduces when issuing the equivalent commands via the "gui" (either "by hand" or by running TestGuiBasicDebug.py).

Dec 18 2020, 11:53 AM · Restricted Project
labath committed rGc15c29652118: [lldb/test] Reduce boilerplate in lldb-server tests (authored by labath).
[lldb/test] Reduce boilerplate in lldb-server tests
Dec 18 2020, 4:17 AM
labath accepted D93438: ObjectFileELF: Test whether reloc_header is non-null instead of asserting..
Dec 18 2020, 1:38 AM · Restricted Project
labath added a comment to D92013: [DebugInfo] Don't use DW_OP_implicit_value for fragments.

I'd like to also fix this in a more fundamental way, but I think I'd need some guidance from someone more familiar with this code (who would that be?).

One idea I had is to add something like isPureFragment() to the DIExpression class, which would return true if the expression consistent solely of a single DW_OP_LLVM_fragment operand.

You mean DIExpression(DW_OP_LLVM_fragment 0, 1) is "pure" s opposed to DIExpression(DW_OP_deref, DW_OP_LLVM_fragment 0, 1), which isn't? Or something else?

Dec 18 2020, 1:36 AM · debug-info, Restricted Project

Dec 17 2020

labath added a comment to D93225: [lldb] Add helper class for dealing with key:value; GDB responses.

I think that streamlining the packet (de)serialization process is badly needing. I'm not so sure about the approach though. On one hand, it's definitely an improvement. On the other, it does not handle the deserialization process, and I was hoping we could have a solution which handles both, for two reasons:

  • it makes things simpler
  • it allows us to avoid the need for tests which explicitly test serialization and deserialization of each packet, as the things is implemented (and tested) once, centrally.
Dec 17 2020, 12:36 PM · Restricted Project
labath accepted D93396: [lldb] [Process/FreeBSDRemote] Replace GetRegisterSetCount().
Dec 17 2020, 8:55 AM · Restricted Project
labath accepted D93450: [lldb] [Process/FreeBSDRemote] Use RegSetKind consistently [NFC].
Dec 17 2020, 8:54 AM · Restricted Project
labath committed rG122a4ebde3f4: Revert "[lldb] Make CommandInterpreter's execution context the same as… (authored by labath).
Revert "[lldb] Make CommandInterpreter's execution context the same as…
Dec 17 2020, 8:48 AM
labath added a reverting change for rGa01b26fb51c7: [lldb] Make CommandInterpreter's execution context the same as debugger's one.: rG122a4ebde3f4: Revert "[lldb] Make CommandInterpreter's execution context the same as….
Dec 17 2020, 8:48 AM
labath added a reverting change for D92164: Make CommandInterpreter's execution context the same as debugger's one.: rG122a4ebde3f4: Revert "[lldb] Make CommandInterpreter's execution context the same as….
Dec 17 2020, 8:48 AM · Restricted Project
labath added a comment to D92164: Make CommandInterpreter's execution context the same as debugger's one..

Sorry for not keeping track of this patch -- I'm not very active these days.

Dec 17 2020, 8:48 AM · Restricted Project
labath committed rGe7a3c4c11e84: [lldb-vscode] Speculative fix for raciness in TestVSCode_attach (authored by labath).
[lldb-vscode] Speculative fix for raciness in TestVSCode_attach
Dec 17 2020, 5:21 AM
labath accepted D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes.

Looks good.

Dec 17 2020, 4:38 AM · Restricted Project
labath accepted D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes.
Dec 17 2020, 2:04 AM · Restricted Project
labath added a comment to D93438: ObjectFileELF: Test whether reloc_header is non-null instead of asserting..

The fix seems reasonable but it would use a test case. Is it possible to generate appropriate input with yaml2obj? If so you could run lldb-test symbols on the resulting object file, and verify that the Symbol table is printed out correctly (whatever "correct" means in this case).

Dec 17 2020, 1:58 AM · Restricted Project
labath added a comment to D93421: Fix how ValueObject deals with getting unsigned values.

This seems suspicious to me, on a couple of levels. You claim that BOOL is an unsigned type, but the apple documentation says "BOOL is explicitly signed so @encode(BOOL) is c rather than C even if -funsigned-char is used." Which one is true? Could this have something to do with the fact that the documentation assumes obj-c (which does not have a native bool type) but in lldb, we use obj-c++ (which, I guess, inherits bool from c++) everywhere?

Dec 17 2020, 1:52 AM
labath accepted D93382: [lldb] Unify the two CreateTypedef implementations in TypeSystemClang.

I wouldn't dismiss the jetliner idea completely. With all the recent upsets in the aviation industry, there may be an opening for us yet. :P

Dec 17 2020, 12:28 AM · Restricted Project
labath added inline comments to D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes.
Dec 17 2020, 12:10 AM · Restricted Project
labath accepted D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

Let's give this another shot.

Dec 17 2020, 12:03 AM · Restricted Project

Dec 14 2020

labath added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

Another fix: we should only unload duplicate ld.so if it's actually a duplicate, i.e. the path differs. Otherwise, we've ended up unloading the only copy.

Would comparing the module shared_pointers work? I think that's exactly what we want here. I think it's possible for LoadModuleAtAddress to return the same module, even with paths which don't match exactly. But if it does that, then we will still end up unloading the original interpreter module...

How do you suggest we get the shared pointer for comparison? Store in class instance, or search for it somehow?

Dec 14 2020, 4:13 AM · Restricted Project

Dec 13 2020

labath added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

Another fix: we should only unload duplicate ld.so if it's actually a duplicate, i.e. the path differs. Otherwise, we've ended up unloading the only copy.

Dec 13 2020, 12:24 PM · Restricted Project

Dec 10 2020

labath committed rGb505142fa5d3: [lldb/test] Change base class of lldb-server tests (authored by labath).
[lldb/test] Change base class of lldb-server tests
Dec 10 2020, 7:22 AM
labath committed rGdb8420825073: [lldb/test] Replace ad-hoc server test choice with test categories (authored by labath).
[lldb/test] Replace ad-hoc server test choice with test categories
Dec 10 2020, 7:22 AM
labath accepted D92872: [lldb] [docs] Add a manpage for lldb-server.

Thanks for writing this.

Dec 10 2020, 5:19 AM · Restricted Project