Page MenuHomePhabricator

kristof.beyls (Kristof Beyls)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2014, 12:59 AM (327 w, 5 d)

Recent Activity

Jul 6 2020

kristof.beyls accepted D76291: [Support] Fix formatted_raw_ostream for UTF-8.

LGTM, thanks!

Jul 6 2020, 2:21 AM · Restricted Project, Restricted Project

Jun 22 2020

Herald added a project to D76291: [Support] Fix formatted_raw_ostream for UTF-8: Restricted Project.

This looks fine to me; I just have a number of nit picks.
The only part where I don't understand the code logic is around the comment starting with "If this is the final byte of a multi-byte sequence".

Jun 22 2020, 4:48 AM · Restricted Project, Restricted Project

Jun 19 2020

kristof.beyls added inline comments to D81404: [AArch64] Add clang command line support for -mharden-sls=.
Jun 19 2020, 2:07 AM · Restricted Project

Jun 18 2020

kristof.beyls committed rGc113b59ef525: [AArch64] Add clang command line support for -mharden-sls= (authored by kristof.beyls).
[AArch64] Add clang command line support for -mharden-sls=
Jun 18 2020, 11:58 PM
kristof.beyls closed D81404: [AArch64] Add clang command line support for -mharden-sls=.
Jun 18 2020, 11:57 PM · Restricted Project
kristof.beyls committed rGd938ec4509c4: [AArch64] Avoid incompatibility between SLSBLR mitigation and BTI codegen. (authored by kristof.beyls).
[AArch64] Avoid incompatibility between SLSBLR mitigation and BTI codegen.
Jun 18 2020, 10:52 PM
kristof.beyls closed D81405: [AArch64] Avoid incompatibility between SLSBLR mitigation and BTI codegen..
Jun 18 2020, 10:52 PM · Restricted Project
kristof.beyls added inline comments to D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 18 2020, 12:30 AM · Restricted Project

Jun 17 2020

kristof.beyls committed rG832cfc767246: [IndirectThunks] Make generated MF structure as expected by all instruction… (authored by kristof.beyls).
[IndirectThunks] Make generated MF structure as expected by all instruction…
Jun 17 2020, 11:12 PM
kristof.beyls committed rGf7455da2633d: [IndirectThunks] Tiny comment fix (authored by kristof.beyls).
[IndirectThunks] Tiny comment fix
Jun 17 2020, 11:11 PM
kristof.beyls closed D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 17 2020, 11:11 PM · Restricted Project
kristof.beyls committed rG3f0cc96a9694: [AArch64] SLSHardening: compute correct thunk name for X29. (authored by kristof.beyls).
[AArch64] SLSHardening: compute correct thunk name for X29.
Jun 17 2020, 10:39 PM
kristof.beyls closed D81997: [AArch64] SLSHardening: compute correct thunk name for X29..
Jun 17 2020, 10:39 PM · Restricted Project
kristof.beyls added a comment to D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..

LGTM

Could you explain how not adding the MBB entry block is different from removing extra MBB later? Curious on the details about the differences here since the change makes sense functionally and I don't see any issues, but I can't understand why adding the extra MBB entry block at the point we create the machine function and then deleting extra blocks results in something different than the automatically created entry block. Is it some attributes or configuration in the basic block or something?

Jun 17 2020, 7:31 AM · Restricted Project
kristof.beyls added inline comments to D81997: [AArch64] SLSHardening: compute correct thunk name for X29..
Jun 17 2020, 6:58 AM · Restricted Project
kristof.beyls updated the diff for D81997: [AArch64] SLSHardening: compute correct thunk name for X29..

Updated version based on @ostannard feedback.

Jun 17 2020, 6:58 AM · Restricted Project
kristof.beyls created D81997: [AArch64] SLSHardening: compute correct thunk name for X29..
Jun 17 2020, 2:40 AM · Restricted Project

Jun 16 2020

kristof.beyls committed rG503a26d8e4d0: Silence GCC 7 warning (authored by kristof.beyls).
Silence GCC 7 warning
Jun 16 2020, 3:51 AM

Jun 11 2020

kristof.beyls committed rGc35ed40f4f1b: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions. (authored by kristof.beyls).
[AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions.
Jun 11 2020, 11:58 PM
kristof.beyls closed D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 11 2020, 11:57 PM · Restricted Project
kristof.beyls added inline comments to D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 11 2020, 11:57 PM · Restricted Project
kristof.beyls updated the diff for D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..

This new revision fixes the root cause of GlobalISel asserting on an IndirectThunk: the IndirectThunk creation code was producing a MachineFunction with a slightly different structure than what gets produced from a naked function implemented in C code and processed by clang.
This fixes this by letting the IndirectThunk generator produce a MachineFunction structure that is the same as what gets produced by clang for an empty naked function written in C.

Jun 11 2020, 12:07 PM · Restricted Project
kristof.beyls added inline comments to D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 11 2020, 7:09 AM · Restricted Project
kristof.beyls updated the diff for D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 11 2020, 7:08 AM · Restricted Project
kristof.beyls committed rG994748770c35: [NFC] Refactor ThunkInserter to make it available for all targets. (authored by kristof.beyls).
[NFC] Refactor ThunkInserter to make it available for all targets.
Jun 11 2020, 1:15 AM
kristof.beyls closed D81401: [NFC] Refactor ThunkInserter to make it available for all targets..
Jun 11 2020, 1:15 AM · Restricted Project
kristof.beyls committed rG0ee176edc8b4: [AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and… (authored by kristof.beyls).
[AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and…
Jun 11 2020, 12:01 AM
kristof.beyls closed D81400: [AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and BR instructions..
Jun 11 2020, 12:01 AM · Restricted Project

Jun 10 2020

kristof.beyls updated the diff for D81405: [AArch64] Avoid incompatibility between SLSBLR mitigation and BTI codegen..

Based on the review feedback that using X16 or X17 could be problematic since a linker can clobber those registers on a call, this patch goes for a different approach to achieve compatibility with BTI-enabled callees.
It simply moves the register to be called always to be in X16, and then does BR X16.
It seems it's simplest to do that unconditionally, as it may not always be easy to find out if the call target has been BTI-enabled.

Jun 10 2020, 7:37 AM · Restricted Project
kristof.beyls updated the diff for D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 10 2020, 7:37 AM · Restricted Project
kristof.beyls added inline comments to D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 10 2020, 7:37 AM · Restricted Project
kristof.beyls added inline comments to D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 10 2020, 7:37 AM · Restricted Project
kristof.beyls updated the diff for D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..

The updated patch addresses Oliver's review comments.
Especially, it addresses the review feedback regarding potential clobbering of X16 or X17 when the call to the thunks go through a long veneer.
It addresses this by avoiding generating indirect calls that use X16 or X17.

Jun 10 2020, 7:37 AM · Restricted Project

Jun 9 2020

kristof.beyls added a comment to D81400: [AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and BR instructions..

Thanks for the feedback!

Jun 9 2020, 9:19 AM · Restricted Project
kristof.beyls updated the diff for D81400: [AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and BR instructions..
Jun 9 2020, 9:19 AM · Restricted Project
kristof.beyls committed rG7e6f891df850: Fix race condition in llvm/test/MC/AArch64/mov-expr* tests (authored by kristof.beyls).
Fix race condition in llvm/test/MC/AArch64/mov-expr* tests
Jun 9 2020, 5:27 AM
kristof.beyls added a comment to rG0e1accd0f726: [AArch64] Support expression results as immediate values in mov.

I ended up pushing a fix for the racy tests in 7e6f891df85

Jun 9 2020, 5:27 AM
kristof.beyls added a comment to D80028: [AArch64] Support expression results as immediate values in mov.

I ended up pushing a fix for the racy tests in 7e6f891df85

Jun 9 2020, 5:27 AM · Restricted Project
kristof.beyls added inline comments to D80028: [AArch64] Support expression results as immediate values in mov.
Jun 9 2020, 2:09 AM · Restricted Project
kristof.beyls committed rG09d098506bb9: [AArch64] Fix branch, terminator, etc properties for BRA* instructions. (authored by kristof.beyls).
[AArch64] Fix branch, terminator, etc properties for BRA* instructions.
Jun 9 2020, 12:31 AM
kristof.beyls closed D81399: [AArch64] Fix branch, terminator, etc properties for BRA* instructions..
Jun 9 2020, 12:31 AM · Restricted Project

Jun 8 2020

kristof.beyls created D81405: [AArch64] Avoid incompatibility between SLSBLR mitigation and BTI codegen..
Jun 8 2020, 8:47 AM · Restricted Project
kristof.beyls created D81404: [AArch64] Add clang command line support for -mharden-sls=.
Jun 8 2020, 8:17 AM · Restricted Project
kristof.beyls created D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 8 2020, 8:15 AM · Restricted Project
kristof.beyls created D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 8 2020, 8:14 AM · Restricted Project
kristof.beyls created D81401: [NFC] Refactor ThunkInserter to make it available for all targets..
Jun 8 2020, 8:12 AM · Restricted Project
kristof.beyls created D81400: [AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and BR instructions..
Jun 8 2020, 8:11 AM · Restricted Project
kristof.beyls created D81399: [AArch64] Fix branch, terminator, etc properties for BRA* instructions..
Jun 8 2020, 8:11 AM · Restricted Project

Jun 4 2020

kristof.beyls added a comment to D81116: [AArch64][GlobalISel] Move GlobalISel source files to a dedicated subdir.

I think I'd like the proposed organization better; but I only have a weak preference.
LGTM.

Jun 4 2020, 2:40 AM · Restricted Project

May 12 2020

kristof.beyls committed rG5d7f5ca0e385: Add Linux SVE Ptrace macros. (authored by kristof.beyls).
Add Linux SVE Ptrace macros.
May 12 2020, 6:25 AM
kristof.beyls closed D79623: [LLDB] Add Linux SVE Ptrace macros..
May 12 2020, 6:25 AM · Restricted Project

May 8 2020

kristof.beyls created D79623: [LLDB] Add Linux SVE Ptrace macros..
May 8 2020, 3:11 AM · Restricted Project

Apr 22 2020

kristof.beyls accepted D78481: [ARM] Release notes for the Custom Datapath Extension (CDE).

LGTM

Apr 22 2020, 8:38 AM · Restricted Project

Apr 2 2020

kristof.beyls committed rGdeb902252ac8: Fix RUN line in AArch64/speculation-hardening.ll (authored by kristof.beyls).
Fix RUN line in AArch64/speculation-hardening.ll
Apr 2 2020, 2:09 AM

Mar 30 2020

kristof.beyls accepted D77051: [test-suite] Work around undefined behaviour in lencod.

Assuming there is no change in output, LGTM.

Mar 30 2020, 5:55 AM

Mar 25 2020

kristof.beyls accepted D76334: [VE] Support VE architecture.

This seems OK to me.
I'd just remark that these days, I think most people using LNT to compile/run/benchmark test-suite use "lnt runtest test-suite" rather than "lnt runtest nt".
Therefore, maybe it'd be better if you'd look into how to make that working on the VE architecture (i.e. look at file lnt/tests/test_suite.py).

Mar 25 2020, 6:27 AM · Restricted Project

Mar 24 2020

kristof.beyls accepted D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.

LGTM. Thanks!

Mar 24 2020, 4:16 AM · Restricted Project, Restricted Project

Mar 20 2020

kristof.beyls updated subscribers of D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.
Mar 20 2020, 10:49 AM · Restricted Project, Restricted Project

Mar 17 2020

kristof.beyls added a comment to D74918: Add method to TargetInfo to get CPU cache line size.

There are a lot of different ways we could implement the feature. We may want to only enable it when -march=native, or maybe only in the unstable ABI, and maybe we want to support aligned pairs on some architectures. I think that's an important discussion to have but I'm not sure _this_ patch is the best place to have that discussion.

Even if we don't use this patch in the implementation I think it would still be a good utility to have. Here's what I suggest: I commit this, create another patch to add a builtin that exposes this API, and then open a libc++ patch with a _possible_ implementation. In that patch, we can discuss how we should actually implement the feature and after we have a consensus I can do the work to implement it. Any objections to that plan?

Mar 17 2020, 12:52 AM · Restricted Project

Feb 29 2020

kristof.beyls added a comment to D74918: Add method to TargetInfo to get CPU cache line size.

If these values are part of the C++ target platform ABI, it seems to me the values for std::hardware_{constructive,destructive}_interference_size should be set by whoever has the authority to decide C++ platform ABI for specific platforms.
Assuming my thought in the previous sentence is correct; discussions on which values to chose for std::hardware_{constructive,destructive}_interference_size should happen in whichever forums decide C++ platform ABI for the various platforms? (Maybe for some platforms that forum might be clang-related fora like reviews.llvm.org, but probably not for all platforms).
With my (probably limited) understanding of the requirements, it seems like deriving std::hardware_{constructive,destructive}_interference_size from actual cache line size on a specific micro-architecture doesn't seem to be the right approach?

They will be in the library ABI, meaning the libc++ ABI.

It's valid for libstdc++ and libc++ to have different values there. If we wish, we could try for an alignment (no pun intended) on these values, but even then that's just between these two libraries.

Which is good and encouraging, because I don't know what forum we would have to go to.

Feb 29 2020, 12:59 AM · Restricted Project

Feb 28 2020

kristof.beyls created D75355: [libc] Provide Arm Optimized Routines for the LLVM libc project.
Feb 28 2020, 8:24 AM
kristof.beyls added a comment to D74918: Add method to TargetInfo to get CPU cache line size.

(I assume I'm not seeing a code review being used to veto a C++ Standard feature, but actually the other points are the reason for the red flag.)

I can see a desire for hyper-precise definitions to achieve the best possible performance, but we really need a healthy does of conservatism here.

The C++ values can't change as a result of selecting between microarchitecture variations that are supposed to link, it takes an ABI break to change these.

Feb 28 2020, 3:24 AM · Restricted Project

Feb 24 2020

kristof.beyls added a comment to D74969: [ReleaseNotes] Mention the `vector-function-abi-variant` attribute..

As someone who isn't up to speed on the design of vector-function-abi-variant, this release note makes sense to me.
It'd probably be best though for this to be approved by someone who understands the design.

Feb 24 2020, 7:44 AM · Restricted Project

Feb 19 2020

kristof.beyls accepted D74770: [test-suite] Work around undefined behaviour in ldecod.

After chatting with Oliver, he states that he did run ubsan before and after this change, and the undefined behaviour that was causing the segfaults is gone with this change.
(There are apparently other undefined behaviours flagged by ubsan, but they are unrelated).
I also don't know much about H264 decoding, but the removal of undefined behaviour as indicated by ubsan together with no change in output makes me believe this change is good enough for how the test-suite is used.
LGTM.

Feb 19 2020, 5:13 AM · Restricted Project

Jan 22 2020

kristof.beyls added a comment to D73070: Add function attribute "patchable-function-prefix" to support -fpatchable-function-entry=N,M where M>0.

I don't mind landing this without aarch64 bti interplay matching GCC precisely; I think it can be done in a follow up. I just request we don't try to land this in the clang-10 release unless that is also resolved. Otherwise clang-11.

Jan 22 2020, 9:55 AM · Restricted Project

Jan 9 2020

kristof.beyls added inline comments to D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test.
Jan 9 2020, 6:56 AM · Restricted Project

Dec 23 2019

kristof.beyls committed rG5bd9eee53d12: [find_interesting_reviews.py] Add git blame output cache (authored by kristof.beyls).
[find_interesting_reviews.py] Add git blame output cache
Dec 23 2019, 4:12 AM

Dec 17 2019

kristof.beyls committed rG870f39d310d6: Fix assertion failure in getMemOperandWithOffsetWidth (authored by kristof.beyls).
Fix assertion failure in getMemOperandWithOffsetWidth
Dec 17 2019, 3:10 AM
kristof.beyls closed D71359: Fix assertion failure in getMemOperandWithOffsetWidth.
Dec 17 2019, 3:10 AM · Restricted Project

Dec 16 2019

kristof.beyls committed rG9d3f4a497103: find_interesting_reviews.py: adapt to github monorepo (authored by kristof.beyls).
find_interesting_reviews.py: adapt to github monorepo
Dec 16 2019, 5:40 AM
kristof.beyls committed rG7f4f07ddf320: [AArch64] Enable emission of stack maps for non-Mach-O binaries on AArch64. (authored by kristof.beyls).
[AArch64] Enable emission of stack maps for non-Mach-O binaries on AArch64.
Dec 16 2019, 4:19 AM
kristof.beyls closed D70069: [AArch64] Enable emission of stack maps for non-Mach-O binaries on AArch64..
Dec 16 2019, 4:19 AM · Restricted Project
kristof.beyls added inline comments to D71359: Fix assertion failure in getMemOperandWithOffsetWidth.
Dec 16 2019, 3:16 AM · Restricted Project
kristof.beyls updated the diff for D71359: Fix assertion failure in getMemOperandWithOffsetWidth.

Addressed Sander's comments.

Dec 16 2019, 3:16 AM · Restricted Project

Dec 12 2019

kristof.beyls retitled D71359: Fix assertion failure in getMemOperandWithOffsetWidth from [PATCH] Fix assertion failure in getMemOperandWithOffsetWidth to Fix assertion failure in getMemOperandWithOffsetWidth.
Dec 12 2019, 2:08 AM · Restricted Project

Dec 11 2019

kristof.beyls accepted D70069: [AArch64] Enable emission of stack maps for non-Mach-O binaries on AArch64..

I agree that the disabling of emission of stack maps in non-MachO AArch64 objects in rL206610 looks like an accidental mistake.

Dec 11 2019, 7:53 AM · Restricted Project
kristof.beyls created D71359: Fix assertion failure in getMemOperandWithOffsetWidth.
Dec 11 2019, 7:13 AM · Restricted Project

Nov 28 2019

kristof.beyls added inline comments to D70779: AArch64: add support for newer Apple CPUs.
Nov 28 2019, 1:42 AM · Restricted Project

Nov 27 2019

kristof.beyls added a comment to D70779: AArch64: add support for newer Apple CPUs.

I agree the bare names could cause a lot of confusion, and that the naming scheme proposed in this patch resolves that potential confusion.

Nov 27 2019, 5:30 AM · Restricted Project

Nov 18 2019

kristof.beyls added a comment to D70329: [AArch64] Add isAuthenticating predicate to MCInstDesc.

IIUC, I think "isAuthenticating" would be a more accurate description/name than "isAuthenticated".
In that the instruction on which this property is set does authenticate a pointer, rather than the instruction itself having been authenticated (whatever that may mean) before.
Does that seem fair?

Nov 18 2019, 1:33 AM · Restricted Project

Nov 8 2019

kristof.beyls committed rG1f592ecf8238: find_interesting_reviews.py: avoid crash on non-ascii data. (authored by kristof.beyls).
find_interesting_reviews.py: avoid crash on non-ascii data.
Nov 8 2019, 6:53 AM

Nov 3 2019

kristof.beyls added inline comments to D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer..
Nov 3 2019, 7:07 AM · Restricted Project

Oct 30 2019

kristof.beyls added inline comments to D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer..
Oct 30 2019, 1:08 AM · Restricted Project

Oct 9 2019

kristof.beyls added a comment to D67160: [clang,ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M..

Would it still make sense to have this patch after D68683 lands? At first sight, it seems this patch might no longer make sense then?

Oct 9 2019, 6:13 AM · Restricted Project

Oct 8 2019

kristof.beyls accepted D66887: [test-suite] Add GCC C Torture Suite.

LGTM, thanks!

Oct 8 2019, 8:35 AM · Restricted Project
kristof.beyls added a comment to D66887: [test-suite] Add GCC C Torture Suite.

Thanks for persevering Sam.

Oct 8 2019, 8:16 AM · Restricted Project
kristof.beyls committed rG78bfe3ab9475: [ARM] Generate vcmp instead of vcmpe (authored by kristof.beyls).
[ARM] Generate vcmp instead of vcmpe
Oct 8 2019, 1:26 AM
kristof.beyls closed D68463: [ARM] Generate vcmp instead of vcmpe.
Oct 8 2019, 1:26 AM · Restricted Project

Oct 7 2019

kristof.beyls added a comment to D29011: [IR] Add Freeze instruction.

Given this seems to add a new IR instruction, shouldn't there also be good quality documentation for this new instruction in docs/LangRef.rst?

Oct 7 2019, 1:00 AM · Restricted Project

Oct 4 2019

kristof.beyls created D68463: [ARM] Generate vcmp instead of vcmpe.
Oct 4 2019, 6:45 AM · Restricted Project

Sep 23 2019

kristof.beyls added a comment to D67485: AArch64: use ldp/stp for atomic & volatile 128-bit where appropriate..

Enabling the corresponding subtarget feature on cyclone doesn't seem safe to me. If we ever implement -mtune, then a command line like clang -march=armv8a -mtune=cyclone should mean “generated correct code for the v8.0 architecture, but optimize for cyclone". Adding this feature to cyclone as is would probably result in the above command line producing code that isn’t architecturally correct for v8.0.

I don't think Clang really does anything with -mtune yet. The most it could do based on the way CPUs are implemented in LLVM now would be something like applying the scheduling model. Almost all of the features in the list are going to break older CPUs.

Sep 23 2019, 7:46 AM · Restricted Project

Sep 20 2019

kristof.beyls added a comment to D66887: [test-suite] Add GCC C Torture Suite.

Thanks Sam, I think this is starting to look good!
I just had a few more nit-picky comments.

Sep 20 2019, 1:25 AM · Restricted Project

Sep 19 2019

kristof.beyls accepted D67762: [docs] Break long (>80) line. NFC.

LGTM

Sep 19 2019, 7:15 AM · Restricted Project

Sep 18 2019

kristof.beyls added a reviewer for D66012: [AArch64][Statepoints] Statepoint support for AArch64.: sanjoy.

I'm afraid I'm not up to speed on statepoints, but I thought I'd give some feedback nonetheless on the code as is.
I hope it's useful.

Sep 18 2019, 6:41 AM · Restricted Project

Sep 17 2019

kristof.beyls added inline comments to D66887: [test-suite] Add GCC C Torture Suite.
Sep 17 2019, 5:07 AM · Restricted Project
kristof.beyls added a comment to D66887: [test-suite] Add GCC C Torture Suite.

I think you also need to call out the new SingleSource/Regression/C/gcc-c-torture directory in the top-level LICENSE.TXT file as a directory containing non-LLVM licensed material (see bottom of the top-level LICENSE.TXT file).

Sep 17 2019, 3:16 AM · Restricted Project

Aug 12 2019

kristof.beyls added inline comments to D65019: [ARM] push LR before __gnu_mcount_nc.
Aug 12 2019, 12:07 AM · Restricted Project, Restricted Project

Aug 9 2019

kristof.beyls added a comment to D65019: [ARM] push LR before __gnu_mcount_nc.

I've just added a few fly-by nits; I'm afraid I didn't do an in-depth review.

Aug 9 2019, 6:35 AM · Restricted Project, Restricted Project

Aug 8 2019

kristof.beyls added inline comments to D65653: [AArch64] Change location of frame-record within callee-save area..
Aug 8 2019, 12:16 AM · Restricted Project

Aug 5 2019

kristof.beyls added inline comments to D65653: [AArch64] Change location of frame-record within callee-save area..
Aug 5 2019, 1:03 AM · Restricted Project