Page MenuHomePhabricator

[analyzer] Add 12.0.0. release notes
AcceptedPublic

Authored by Szelethus on Feb 5 2021, 11:05 AM.

Details

Summary

Seems like we're a bit late again, but not too late! I've been absent for a large portion of the 12.0.0's development, so please feel free to point out if I missed anything. Same thing with contributors I forgot to add as a reviewer.

We have a bad track record of finishing, but forgetting to enable GSoC projects -- did the same happen to SmartPtrChecker or that still needs refinement?

Diff Detail

Event Timeline

Szelethus created this revision.Feb 5 2021, 11:05 AM
Szelethus requested review of this revision.Feb 5 2021, 11:05 AM

You can push this directly to the release/12.x branch when it's ready.

NoQ added a comment.Feb 5 2021, 12:37 PM

Thanks!!

We have a bad track record of finishing, but forgetting to enable GSoC projects -- did the same happen to SmartPtrChecker or that still needs refinement?

Still needs refinement. One large missing piece is that inlined defensive check suppressions weren't generalized for smart pointers.

clang/docs/ReleaseNotes.rst
329

I suggest expanding a bit: "... is a WebKit coding convention checker that flags raw pointers to reference-counted objects captured by lambdas and suggests using intrusive reference-counting smart pointers instead." Something similar for the next item.

Szelethus marked an inline comment as done.Feb 9 2021, 5:28 PM

I'm ok with this on my part.

isthismyaccount accepted this revision.Feb 15 2021, 10:39 AM

LGTM on my part.

This revision is now accepted and ready to land.Feb 15 2021, 10:39 AM