Page MenuHomePhabricator

gamesh411 (Endre Fülöp)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2016, 5:58 AM (190 w, 1 d)

Recent Activity

Tue, Aug 4

gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

rename file name in header

Tue, Aug 4, 2:13 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 committed rG141cb8a1eecc: [analyzer] Model iterator random incrementation symmetrically (authored by gamesh411).
[analyzer] Model iterator random incrementation symmetrically
Tue, Aug 4, 2:04 AM
gamesh411 closed D83190: [analyzer] Model iterator random incrementation symmetrically.
Tue, Aug 4, 2:04 AM · Restricted Project
gamesh411 added a comment to D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker..

I would add one more test for the undefined case. Like a local array variable that is uninitialized. That could mirror some of the null-dereference cases.

Tue, Aug 4, 12:46 AM · Restricted Project

Mon, Aug 3

gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

rebase

Mon, Aug 3, 2:15 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

I have updated the revision to use llvm::move algorithm (available thanks to @njames93).
Friendly ping :)

Mon, Aug 3, 2:04 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

ensure lint in path

Mon, Aug 3, 2:01 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

use llvm::move algorithm

Mon, Aug 3, 1:58 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 abandoned D85112: use llvm::move algorithm.

arcanist misfire, see D83717

Mon, Aug 3, 1:54 AM · Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

use llvm::move algorithm

Mon, Aug 3, 1:52 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 requested review of D85112: use llvm::move algorithm.
Mon, Aug 3, 1:50 AM · Restricted Project

Tue, Jul 21

gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Tue, Jul 21, 11:59 AM · Restricted Project
gamesh411 added a comment to D83190: [analyzer] Model iterator random incrementation symmetrically.

I experienced 2 crashes with and without this patch using commit 1af9fc82132da7c876e8f70c4e986cc9c59010ee on master:
I have used the clang built on that revision to analyse itself, and also used the patched version (with this current revision applied) to do the same.

Tue, Jul 21, 8:25 AM · Restricted Project
gamesh411 added a comment to D83902: [ADT] Add a range-based version of std::move.

To further investigate the moving story, I also created a small example on Godbolt:
https://godbolt.org/z/5qMf1o

Tue, Jul 21, 7:59 AM · Restricted Project

Fri, Jul 17

gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Fri, Jul 17, 5:35 PM · Restricted Project
gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Fri, Jul 17, 4:35 PM · Restricted Project
gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Fri, Jul 17, 4:24 PM · Restricted Project
gamesh411 accepted D83902: [ADT] Add a range-based version of std::move.

LGTM!

Fri, Jul 17, 4:00 PM · Restricted Project
gamesh411 added inline comments to D83902: [ADT] Add a range-based version of std::move.
Fri, Jul 17, 2:25 PM · Restricted Project
gamesh411 added a comment to D83902: [ADT] Add a range-based version of std::move.

I am happy to see this change, as I could use it inside my clang-tidy check as well!

Fri, Jul 17, 12:13 PM · Restricted Project
gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

rename Offset -> Amount inside handleRandomIncrOrDecl
minor local variable renaming

Fri, Jul 17, 11:37 AM · Restricted Project
gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

apply review suggestions

  • rename variables
  • remove 1 assert
  • rename tests
Fri, Jul 17, 11:10 AM · Restricted Project
gamesh411 added a comment to D83190: [analyzer] Model iterator random incrementation symmetrically.

Thanks for reviewing this patch this quickly!
I have updated the diff according to your suggestions, but I will not land it till I run a llvm+clang analysis with it.
Do you think non-ctu mode is enough to test the stability?

Fri, Jul 17, 11:09 AM · Restricted Project
gamesh411 added a comment to D83190: [analyzer] Model iterator random incrementation symmetrically.

It would be nice to see the measurements on llvm as this patch introduced some (IMO reasonable) asserts. Also in the unlikely case, there is an expression like 1 + iter, there could be more results.

Fri, Jul 17, 6:28 AM · Restricted Project
gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

rebase upon hotfix patch

Fri, Jul 17, 6:14 AM · Restricted Project
gamesh411 committed rGfd02a86260b3: [analyzer] Add system header simulator a symmetric random access iterator… (authored by gamesh411).
[analyzer] Add system header simulator a symmetric random access iterator…
Fri, Jul 17, 5:39 AM
gamesh411 closed D83226: [analyzer] Add system header simulator a symmetric random access iterator operator+.
Fri, Jul 17, 5:39 AM · Restricted Project
gamesh411 added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Fri, Jul 17, 5:07 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

extend test cases
add comments to non-obvious cases

Fri, Jul 17, 5:00 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

move tests to one file

Fri, Jul 17, 3:10 AM · Restricted Project
gamesh411 added a comment to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

I am now experimenting with the suggestions. The other issues are on the worklist. Thanks for these so far.

Fri, Jul 17, 1:36 AM · Restricted Project

Thu, Jul 16

gamesh411 accepted D83295: [Analyzer] Hotfix for various crashes in iterator checkers.
Thu, Jul 16, 6:09 AM · Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

I have bitten the bullet, and have gone down this route. With relative numbering, the sections themselves are at least translation-invariant. Not the prettiest sight, tho.
Thanks!

I almost think it would be nice FileCheck supported some directive like:

// LINE-NAME: <LINENAME>

And corresponding check lines:

[[<LINENAME>]]
[[<LINENAME>+N]] 
[[<LINENAME>-N]]

Would result in the ability to write checks like this:

void longjmp_handler() {// LINE-NAME: LONGJMP
    longjmp(env, 255); 
}

...

void foo(){
  atexit(longjmp_handler);
   // CHECK-NOTES: :[[@LINE-1]]:3: warning: exit-handler potentially calls a jump function. Handlers should terminate by returning [cert-env32-c]
  // CHECK-NOTES: :[[LONGJMP]]:1: note: handler function declared here
  // CHECK-NOTES: :[[LONGJMP+1]]:3: note: jump function called here
}

Anyway that's a story for another day.

Thu, Jul 16, 1:31 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jul 15

gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

@Eugene.Zelenko I have just rebase-d, and seen that the release notes page itself was bumped to clang-tidy 12. I have added my check as a new check there. Should I also add the other subsections (like improvements in existing checks, and new check aliases), or authors will add them as needed?

No, that sections will be filled when related changes will be made. Release Notes are reset to blank state in master after branching release.

Wed, Jul 15, 7:41 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

@Eugene.Zelenko I have just rebase-d, and seen that the release notes page itself was bumped to clang-tidy 12. I have added my check as a new check there. Should I also add the other subsections (like improvements in existing checks, and new check aliases), or authors will add them as needed?

Wed, Jul 15, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

rebase

Wed, Jul 15, 7:30 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

tidy up release notes, make all new check entries uniform

Wed, Jul 15, 7:21 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Wed, Jul 15, 7:16 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

add missing newline in release notes

Wed, Jul 15, 7:15 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

.

Wed, Jul 15, 7:07 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Wed, Jul 15, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

fix documentation header

Wed, Jul 15, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

@steakhal @Eugene.Zelenko Thanks for checking this patch! I have tried my best to adhere to your suggestions.

Wed, Jul 15, 2:41 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Wed, Jul 15, 2:40 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Wed, Jul 15, 2:31 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

use move instead of copy
fix documentation issues
fix tests

Wed, Jul 15, 2:23 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 14

gamesh411 added a comment to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

Thanks @njames93 :) I have extended the check with notes, but I have to figure out how to appease file-check, so its still WIP until I do.

Tue, Jul 14, 5:55 AM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

extend with notes
apply minor fixes
tests are WIP until I figure out how to properly use file-check

Tue, Jul 14, 5:50 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 13

gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

mention iterator header

Mon, Jul 13, 3:22 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

use std::copy algorithm
polish

Mon, Jul 13, 3:21 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

fix test diag location changes resulting from autoformatting

Mon, Jul 13, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

simplify VisitCallExpr

Mon, Jul 13, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 updated the diff for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.

update includes

Mon, Jul 13, 2:31 PM · Restricted Project, Restricted Project, Restricted Project
gamesh411 added reviewers for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C: aaron.ballman, dkrupp, Szelethus, steakhal, martong.
Mon, Jul 13, 2:16 PM · Restricted Project, Restricted Project, Restricted Project
Herald added projects to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C: Restricted Project, Restricted Project.
Mon, Jul 13, 2:11 PM · Restricted Project, Restricted Project, Restricted Project

Jul 10 2020

gamesh411 added a comment to D83555: [analyzer] Fix ctu-on-demand-parsing: REQUIRES: linux -> REQUIRES: system-linux.

In addition, IMHO the test infra should then be extended to throw an exception, when a feature is referenced that is not mentioned anywhere. That would be helpful in the future.

Jul 10 2020, 7:36 AM · Restricted Project
gamesh411 accepted D83555: [analyzer] Fix ctu-on-demand-parsing: REQUIRES: linux -> REQUIRES: system-linux.

Good thing you were looking inside the test infra code to catch this, kudos!

Jul 10 2020, 6:58 AM · Restricted Project

Jul 9 2020

gamesh411 added a comment to D83295: [Analyzer] Hotfix for various crashes in iterator checkers.

@Szelethus thanks for being watchful, appreciated c:

Jul 9 2020, 7:25 AM · Restricted Project
gamesh411 accepted D83295: [Analyzer] Hotfix for various crashes in iterator checkers.
Jul 9 2020, 7:22 AM · Restricted Project
gamesh411 added inline comments to D83475: [analyzer] Add CTUImportCppThreshold for C++ files.
Jul 9 2020, 6:00 AM · Restricted Project
gamesh411 accepted D83475: [analyzer] Add CTUImportCppThreshold for C++ files.

It will be interesting to see how different C and C++ projects will prove in terms of AST complexity, and Decl-size, but I understand that for now, these two options are necessary to not penalize C project analysis because of C++ AST complexity.

Jul 9 2020, 5:59 AM · Restricted Project

Jul 8 2020

gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

apply review suggestions

Jul 8 2020, 2:19 AM · Restricted Project
gamesh411 added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Jul 8 2020, 1:43 AM · Restricted Project

Jul 7 2020

gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

fix tidy diagnostic

Jul 7 2020, 2:20 AM · Restricted Project
gamesh411 added a comment to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

The checker has been updated, the comments and the logic polished. I would still take a stab at this being a ClangSa checker (as opposed to being a Tidy check). What do you think?

Jul 7 2020, 1:41 AM · Restricted Project
gamesh411 added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Jul 7 2020, 1:36 AM · Restricted Project
gamesh411 added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Jul 7 2020, 1:35 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

fix detection logic
fix license header
add missing warning to test

Jul 7 2020, 1:31 AM · Restricted Project
gamesh411 added a reviewer for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker: balazske.
Jul 7 2020, 1:19 AM · Restricted Project

Jul 6 2020

gamesh411 added inline comments to D83190: [analyzer] Model iterator random incrementation symmetrically.
Jul 6 2020, 2:47 PM · Restricted Project
gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

implement traditional iterator support as well

Jul 6 2020, 2:39 PM · Restricted Project
gamesh411 added a comment to D83190: [analyzer] Model iterator random incrementation symmetrically.

In order to test the non-pointer iterators, an extension has to be made to the system header simulator. Please check the related patch (parent of this one in the stack) https://reviews.llvm.org/D83226.

Jul 6 2020, 7:42 AM · Restricted Project
gamesh411 added a reviewer for D83226: [analyzer] Add system header simulator a symmetric random access iterator operator+: baloghadamsoftware.
Jul 6 2020, 7:26 AM · Restricted Project
Herald added a project to D83226: [analyzer] Add system header simulator a symmetric random access iterator operator+: Restricted Project.
Jul 6 2020, 7:17 AM · Restricted Project
gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

rename misleading variables
apply local consts

Jul 6 2020, 6:18 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

modernize the memory modeling code, still WIP

Jul 6 2020, 5:11 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

make single bug-type
fix checker registration

Jul 6 2020, 2:47 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

move to core.alpha

Jul 6 2020, 2:08 AM · Restricted Project
gamesh411 updated the diff for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.

change license

Jul 6 2020, 1:53 AM · Restricted Project
gamesh411 added inline comments to D83190: [analyzer] Model iterator random incrementation symmetrically.
Jul 6 2020, 1:19 AM · Restricted Project
gamesh411 updated the diff for D83190: [analyzer] Model iterator random incrementation symmetrically.

remove unrelated comment formatting

Jul 6 2020, 12:06 AM · Restricted Project
gamesh411 added a reviewer for D83190: [analyzer] Model iterator random incrementation symmetrically: baloghadamsoftware.
Jul 6 2020, 12:04 AM · Restricted Project
Herald added a project to D83190: [analyzer] Model iterator random incrementation symmetrically: Restricted Project.
Jul 6 2020, 12:02 AM · Restricted Project

Jul 1 2020

gamesh411 committed rG52f653236600: [analyzer][CrossTU] Lower CTUImportThreshold default value (authored by gamesh411).
[analyzer][CrossTU] Lower CTUImportThreshold default value
Jul 1 2020, 1:35 AM
gamesh411 closed D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value.
Jul 1 2020, 1:35 AM · Restricted Project

Jun 30 2020

gamesh411 accepted D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers.

Thanks, it LGTM now!

Jun 30 2020, 9:12 AM · Restricted Project
gamesh411 accepted D81750: [analyzer] Don't allow hidden checkers to emit diagnostics.

LGTM if nobody is against moving the checker. I will accept nevertheless.

Jun 30 2020, 3:14 AM · Restricted Project
gamesh411 added a comment to D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.

Good job, massive props to you for such an overhaul.

Jun 30 2020, 3:14 AM · Restricted Project

Jun 26 2020

gamesh411 accepted D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition..

I have found this in ASTContext.h:

// A traversal scope limits the parts of the AST visible to certain analyses.
   // RecursiveASTVisitor::TraverseAST will only visit reachable nodes, and
   // getParents() will only observe reachable parent edges.
   //
   // The scope is defined by a set of "top-level" declarations.
   // Initially, it is the entire TU: {getTranslationUnitDecl()}.
   // Changing the scope clears the parent cache, which is expensive to rebuild.
   std::vector<Decl *> getTraversalScope() const { return TraversalScope; }

The setTraversalScope resets the parentmap in ASTContext.cpp:

void ASTContext::setTraversalScope(const std::vector<Decl *> &TopLevelDecls) {
   TraversalScope = TopLevelDecls;
   getParentMapContext().clear();
 }
Jun 26 2020, 12:02 PM · Restricted Project
gamesh411 added a comment to D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value.

The analyzer inlines small functions within a TU regardless of the thresholds. I think it would be sensible to do the same across TUs in the case we don't do this already.

That means perform a get CTU definition if the TU to be imported (where the function comes from) is small? Otherwise it does not matter how small the function is, it can result in importing of large amount of code. Determining parameters (like "smallness") of the TU is probably not simple.

Jun 26 2020, 1:36 AM · Restricted Project

Jun 25 2020

gamesh411 updated the diff for D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value.

update test value

Jun 25 2020, 8:33 AM · Restricted Project
gamesh411 created D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value.
Jun 25 2020, 8:33 AM · Restricted Project

Jun 24 2020

gamesh411 accepted D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions.

I see a lot of NoEvalCall, but I wonder whether modifying errno warrants this. Shouldn't we have a alongside NoEvalCall and EvalCallAsPure an EvalCallAsPureButInvalidateErrno invalidation kind?

Also, I'm kind of worried by this checker taking on the responsibility of modeling functions by EvalCall, except for a few functions that it also models, but not with EvalCall, it feels clunky. I remember this one time when I [[ https://reviews.llvm.org/D68165?id=222257#inline-612891 | wanted to model alloca()]], which has a __builtin_alloca variant as well, and I spent a good couple hours figuring out that why the descpription {CDF_MaybeBuiltin, "alloca", 1} was causing crashes. Turns out that BuiltinFunctionsChecker EvalCalled the builtin version, but not the other.

In general, I don't think we have a well established stance on whether we use EvalCall, or PreCall+PostCall, and what roles do batch modeling checkers like StdLibraryFunctionsChecker, GenericTaintChecker and BuiltinFunctionsChecker should play alongside mode sophisticated modeling checkers like CStringModeling, DynamicMemoryModeling and StreamChecker. I bet some of us have ideas how this is supposed to be done, but I feel like there is no unified, agreed upon road we're moving towards. This problem came up in D69662 as well. D75612 introduces EvalCalls to StreamChecker, and I was puzzled why this hasn't been a thing in all similar chekers like MallocChecker, which I commented on in D81315#2079457.

It would also be great if we could enforce that no two checkers evaluate the same function.

None of what I said is a problem introduced by this specific patch, but it definitely amplifies it with the modeling of functions such as strncasecmp (should be the responsibility of CStringModeling), strdup (MallocChecker) and popen (StreamChecker). I'd like to see something set in stone, such as what you're eluding to in D75612#inline-690087, that the role of this checker is to model numerical (null-ness, ranges, etc) pre- and post conditions for standard functions, nothing less, nothing more, and it is technically an error to reimplement this in other checkers. If that is the goal, I guess we have to implement tests for individual functions added in this patch to make sure that these conditions aren't already checked elsewhere.

I didn't read this patch line-by-line, but I trust that its okay if Endre did so.

Jun 24 2020, 8:04 AM · Restricted Project
gamesh411 accepted D82385: [Analyzer] Fix errors in iterator modeling.
Jun 24 2020, 6:59 AM · Restricted Project
gamesh411 added a comment to D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions.

Good job, I really fancy the Summary syntax 👍

Jun 24 2020, 2:40 AM · Restricted Project
gamesh411 added inline comments to D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers.
Jun 24 2020, 1:02 AM · Restricted Project
gamesh411 added a comment to D82385: [Analyzer] Fix errors in iterator modeling.

Hey! See my inline comments, but after those and a quick clang-format, it looks good.

Jun 24 2020, 1:02 AM · Restricted Project

Jun 18 2020

gamesh411 added inline comments to D77493: [clang-tidy] Add do-not-refer-atomic-twice check.
Jun 18 2020, 11:27 AM · Restricted Project, Restricted Project

Jun 17 2020

gamesh411 added a comment to D75229: [clang-tidy] Add signal-in-multithreaded-program check.

Minor nits inline. Good job, I am not entitled to accept it, but LGTM!

Jun 17 2020, 2:39 AM · Restricted Project, Restricted Project
gamesh411 added inline comments to D75229: [clang-tidy] Add signal-in-multithreaded-program check.
Jun 17 2020, 2:07 AM · Restricted Project, Restricted Project