Page MenuHomePhabricator

vrnithinkumar (Nithin VR)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2019, 6:52 AM (41 w, 5 d)

Recent Activity

Yesterday

vrnithinkumar updated the summary of D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Tue, Aug 11, 4:52 PM · Restricted Project
vrnithinkumar requested review of D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Tue, Aug 11, 4:39 PM · Restricted Project
vrnithinkumar committed rG06d100a69a08: [Analyzer] Support note tags for smart ptr checker (authored by vrnithinkumar).
[Analyzer] Support note tags for smart ptr checker
Tue, Aug 11, 2:28 PM
vrnithinkumar closed D84600: [Analyzer] Support note tags for smart ptr checker.
Tue, Aug 11, 2:27 PM · Restricted Project

Sun, Aug 9

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Sun, Aug 9, 3:57 PM · Restricted Project
vrnithinkumar updated the diff for D84600: [Analyzer] Support note tags for smart ptr checker.
  • Updating test with tags from header file
Sun, Aug 9, 3:56 PM · Restricted Project

Sat, Aug 8

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Sat, Aug 8, 10:30 AM · Restricted Project
vrnithinkumar added a comment to D84600: [Analyzer] Support note tags for smart ptr checker.

Layering violations are a running theme in the analyzer -- CheckerRegistry and the entire MallocChecker fiasco are two glaring examples. Luckily, this isn't a severe case so I wouldn't worry about it much.

I've been following your patches, but them mentors answer way ahead of me and are very thorough :^) Best of luck with the finale!

Sat, Aug 8, 10:27 AM · Restricted Project
vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Sat, Aug 8, 10:18 AM · Restricted Project
vrnithinkumar updated the diff for D84600: [Analyzer] Support note tags for smart ptr checker.
  • Review comment changes
Sat, Aug 8, 10:18 AM · Restricted Project

Thu, Aug 6

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Thu, Aug 6, 7:30 AM · Restricted Project
vrnithinkumar updated the diff for D84600: [Analyzer] Support note tags for smart ptr checker.
  • Changes from review comments
Thu, Aug 6, 7:30 AM · Restricted Project

Wed, Aug 5

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Wed, Aug 5, 2:51 PM · Restricted Project

Tue, Aug 4

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Tue, Aug 4, 9:33 AM · Restricted Project

Mon, Aug 3

vrnithinkumar closed D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Mon, Aug 3, 5:06 PM · Restricted Project
vrnithinkumar closed D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
Mon, Aug 3, 5:05 PM · Restricted Project
vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Mon, Aug 3, 5:05 PM · Restricted Project
vrnithinkumar updated the diff for D84600: [Analyzer] Support note tags for smart ptr checker.
  • Addressing review comments
Mon, Aug 3, 5:04 PM · Restricted Project

Sun, Aug 2

vrnithinkumar added a comment to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
In D83836#2189636, @NoQ wrote:

These patches look like they're done, maybe let's land them?

Sun, Aug 2, 1:35 PM · Restricted Project
vrnithinkumar added a comment to D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
In D83877#2189637, @NoQ wrote:

These patches look like they're done, maybe let's land them?

Sun, Aug 2, 1:34 PM · Restricted Project

Fri, Jul 31

vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Fri, Jul 31, 5:31 PM · Restricted Project
vrnithinkumar added inline comments to D84600: [Analyzer] Support note tags for smart ptr checker.
Fri, Jul 31, 5:09 PM · Restricted Project

Sun, Jul 26

vrnithinkumar added reviewers for D84600: [Analyzer] Support note tags for smart ptr checker: NoQ, vsavchenko, xazax.hun, Szelethus.
Sun, Jul 26, 10:14 AM · Restricted Project
Herald added a project to D84600: [Analyzer] Support note tags for smart ptr checker: Restricted Project.
Sun, Jul 26, 10:09 AM · Restricted Project

Tue, Jul 21

vrnithinkumar committed rG76c057776350: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling (authored by vrnithinkumar).
[Analyzer] Handle unique_ptr::swap() in SmartPtrModeling
Tue, Jul 21, 3:05 AM

Mon, Jul 20

vrnithinkumar committed rGa5609102117d: [Analyzer] Add checkRegionChanges for SmartPtrModeling (authored by vrnithinkumar).
[Analyzer] Add checkRegionChanges for SmartPtrModeling
Mon, Jul 20, 9:19 PM

Fri, Jul 17

vrnithinkumar added inline comments to D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
Fri, Jul 17, 6:52 AM · Restricted Project
vrnithinkumar updated the diff for D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
  • Changes from review comments
Fri, Jul 17, 6:51 AM · Restricted Project
vrnithinkumar retitled D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling from [Analyzer] Changed in SmartPtrModeling to handle Swap to [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
Fri, Jul 17, 2:46 AM · Restricted Project

Thu, Jul 16

vrnithinkumar added inline comments to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Thu, Jul 16, 4:34 PM · Restricted Project
vrnithinkumar updated the diff for D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
  • Adding a missed todo
Thu, Jul 16, 4:32 PM · Restricted Project
vrnithinkumar updated the diff for D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
  • Addressing review comments
  • Enabling commented out tests
Thu, Jul 16, 4:14 PM · Restricted Project
vrnithinkumar retitled D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling from [Analyzer] Implementing checkRegionChanges for SmartPtrModeling to [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Thu, Jul 16, 3:31 PM · Restricted Project

Wed, Jul 15

vrnithinkumar added inline comments to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Wed, Jul 15, 8:48 AM · Restricted Project
vrnithinkumar updated the diff for D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.

Untrack all changing regions in checkRegionChanges

Wed, Jul 15, 8:46 AM · Restricted Project
vrnithinkumar added inline comments to D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling.
Wed, Jul 15, 8:04 AM · Restricted Project
vrnithinkumar added reviewers for D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling: NoQ, vsavchenko, xazax.hun, Szelethus.
Wed, Jul 15, 8:03 AM · Restricted Project
Herald added a project to D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling: Restricted Project.
Wed, Jul 15, 8:01 AM · Restricted Project

Tue, Jul 14

vrnithinkumar added inline comments to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling.
Tue, Jul 14, 6:16 PM · Restricted Project
vrnithinkumar added reviewers for D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling: NoQ, Szelethus, vsavchenko, xazax.hun.
Tue, Jul 14, 6:06 PM · Restricted Project
Herald added a project to D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling: Restricted Project.
Tue, Jul 14, 5:58 PM · Restricted Project

Jul 8 2020

vrnithinkumar committed rG20e271a98de5: [analyzer] Warning for default constructed unique_ptr dereference (authored by vrnithinkumar).
[analyzer] Warning for default constructed unique_ptr dereference
Jul 8 2020, 12:52 AM
vrnithinkumar closed D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jul 8 2020, 12:52 AM · Restricted Project

Jul 7 2020

vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jul 7 2020, 3:52 PM · Restricted Project

Jul 3 2020

vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jul 3 2020, 11:17 AM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

addressing review comments

Jul 3 2020, 11:17 AM · Restricted Project

Jul 2 2020

vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Addressing review comments

Jul 2 2020, 4:13 PM · Restricted Project
vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jul 2 2020, 4:13 PM · Restricted Project
vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jul 2 2020, 5:52 AM · Restricted Project
vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jul 2 2020, 5:52 AM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.
  • Created a new checker for smart point derference diagnostic
  • Moved checking part to this checker
  • Kept all the modeling in SmartPtrModeling
  • Created a header file for shared API -calls
Jul 2 2020, 5:52 AM · Restricted Project

Jun 26 2020

vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jun 26 2020, 3:10 PM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Moving dereference precondition checks into checkPreCall.

Jun 26 2020, 3:10 PM · Restricted Project

Jun 25 2020

vrnithinkumar added a comment to D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Best of luck on your GSoC! I don't have much else to add to your patch, but you seem to have made good progress already!

Thanks!

some folks have automated scripts based on that tag to add themselves as subscriber/reviewer.

Hope you don't mind my intrusion :)

Not at all.

I am not sure about whether I should use eval::Call or both check::PreCall and check::PostCall. In the eval::Call documentation I found this "Note, that only one checker can evaluate a call.". So I am little bit confused about using it.

Inlining (when we model a function call, https://youtu.be/yh2qdnJjizE?t=238) is rather expensive. Creating a new stack frame, parameters, new ExplodedNodes, running checkers, etc., eats memory for breakfast, is slow and limits how deep the analysis can go. Worse still, the analysis could lose precision if the called function's definition isn't available. eval::Call serves to circumvent this by allowing the analyzer to give a precise summary of the function. StreamChecker, for instance, uses this for functions such as clearerr() -- the C standard defines how this function should behave, so upon encountering a call to it, we don't need all the extra work regular inlining demands, just ask StreamChecker to model it for us.

Use eval::Call if you can provide a precise model for a function. Only a single checker is allowed to do that -- you can see that it returns with a boolean value to sign whether the checker could provide an evaluation, and as far as I know, the first checker that returns true will be doing it.

I think it would be appropriate in this instance, because we're modeling a well established API. In general, I think we should use it when appropriate more often, like in MallocChecker.

Thank you for the detailed help.

Jun 25 2020, 6:02 PM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Addressing review comments

Jun 25 2020, 6:02 PM · Restricted Project
vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jun 25 2020, 6:02 PM · Restricted Project
Artem Dergachev <adergachev@apple.com> committed rG37c1bf21d1da: [analyzer] Enable constructor support in evalCall event. (authored by vrnithinkumar).
[analyzer] Enable constructor support in evalCall event.
Jun 25 2020, 10:14 AM
vrnithinkumar closed D82256: [analyzer] Enable constructor support in evalCall event.
Jun 25 2020, 10:14 AM · Restricted Project
vrnithinkumar added a comment to D82256: [analyzer] Enable constructor support in evalCall event.
In D82256#2113233, @NoQ wrote:

@vrnithinkumar what's your preferred Full Name <email> for llvm's git?

Jun 25 2020, 3:12 AM · Restricted Project

Jun 24 2020

vrnithinkumar updated the diff for D82256: [analyzer] Enable constructor support in evalCall event.

clang-format fix

Jun 24 2020, 2:40 PM · Restricted Project
vrnithinkumar retitled D82256: [analyzer] Enable constructor support in evalCall event from [analyzer] Enabling ctr in evalCall event to [analyzer] Enable constructor support in evalCall event.
Jun 24 2020, 12:29 PM · Restricted Project
vrnithinkumar added inline comments to D82256: [analyzer] Enable constructor support in evalCall event.
Jun 24 2020, 12:28 PM · Restricted Project
vrnithinkumar updated the diff for D82256: [analyzer] Enable constructor support in evalCall event.

Fixing test failures

Jun 24 2020, 11:55 AM · Restricted Project

Jun 20 2020

vrnithinkumar updated the diff for D82256: [analyzer] Enable constructor support in evalCall event.

Addressing review comment adding miised new line

Jun 20 2020, 4:25 PM · Restricted Project
vrnithinkumar added inline comments to D82256: [analyzer] Enable constructor support in evalCall event.
Jun 20 2020, 4:25 PM · Restricted Project
vrnithinkumar updated the diff for D82256: [analyzer] Enable constructor support in evalCall event.

Fixing wrongly deleted the old commit via arc

Jun 20 2020, 4:25 PM · Restricted Project
vrnithinkumar added inline comments to D82256: [analyzer] Enable constructor support in evalCall event.
Jun 20 2020, 5:16 AM · Restricted Project
vrnithinkumar retitled D82256: [analyzer] Enable constructor support in evalCall event from Enabling ctr in evalCall event to [analyzer] Enabling ctr in evalCall event.
Jun 20 2020, 5:16 AM · Restricted Project
vrnithinkumar created D82256: [analyzer] Enable constructor support in evalCall event.
Jun 20 2020, 4:44 AM · Restricted Project

Jun 12 2020

vrnithinkumar added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jun 12 2020, 7:31 AM · Restricted Project
vrnithinkumar updated the diff for D81315: [analyzer] Warning for default constructed unique pointer dereferences.

Addressing the review comments

Jun 12 2020, 7:31 AM · Restricted Project
vrnithinkumar abandoned D81734: Initial smart pointer check.

It was a mistake
I was supposed to update an existing review.
first time use of arc

Jun 12 2020, 6:58 AM · Restricted Project
vrnithinkumar created D81734: Initial smart pointer check.
Jun 12 2020, 6:58 AM · Restricted Project

Jun 5 2020

vrnithinkumar created D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jun 5 2020, 4:16 PM · Restricted Project

May 24 2020

vrnithinkumar updated the diff for D80490: [clang-tidy] Check for rule of five and zero..

fixed the clang-tidy warnig

May 24 2020, 5:51 AM · Restricted Project
vrnithinkumar created D80490: [clang-tidy] Check for rule of five and zero..
May 24 2020, 4:16 AM · Restricted Project