Page MenuHomePhabricator

tstellar (Tom Stellard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 1:53 PM (188 w, 3 d)

Recent Activity

Aug 17 2020

tstellar committed rGc37145cab121: libclc: Add Mesa/SPIR-V target (authored by airlied).
libclc: Add Mesa/SPIR-V target
Aug 17 2020, 2:02 PM
tstellar closed D77589: libclc: Add Mesa/SPIR-V target.
Aug 17 2020, 2:02 PM · Restricted Project
tstellar committed rG3d21fa56f5f5: libclc: Make all built-ins overloadable (authored by daniels).
libclc: Make all built-ins overloadable
Aug 17 2020, 1:56 PM
tstellar closed D82078: libclc: Make all built-ins overloadable.
Aug 17 2020, 1:56 PM · Restricted Project
tstellar committed rG3a7051d9c28e: libclc: Fix FP_ILOGBNAN definition (authored by bbrezillon).
libclc: Fix FP_ILOGBNAN definition
Aug 17 2020, 1:48 PM
tstellar closed D83473: libclc: Fix FP_ILOGBNAN definition.
Aug 17 2020, 1:47 PM · Restricted Project
tstellar added a comment to D84392: libclc: add printf support on amd target.

This is fine with me.

Aug 17 2020, 7:56 AM
tstellar added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.
In D85630#2220694, @ro wrote:

Ping? It's been a week, the patch fixes ca. 250 testsuite failures and is this a candidate for LLVM 11.0.0 rc2.

Aug 17 2020, 7:56 AM · Restricted Project

Aug 12 2020

tstellar accepted D85844: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection.

LGTM. Thanks.

Aug 12 2020, 9:33 AM · Restricted Project

Aug 11 2020

tstellar added a comment to D74051: Move update_cc_test_checks.py tests to clang.

Nevermind, I figured out good enough workaround.

Aug 11 2020, 4:27 PM · Restricted Project, Restricted Project
tstellar added a comment to D82847: [CMAKE] Fix 'clean' target not working.

Reverting this patch seems to fix the error for me. Are you still seeing this same error in trunk?

Aug 11 2020, 2:55 PM · Restricted Project
tstellar added a comment to D82847: [CMAKE] Fix 'clean' target not working.

This commit appears to be causing an error when I run CMake:

Aug 11 2020, 2:51 PM · Restricted Project

Aug 7 2020

tstellar added a comment to D85007: [PowerPC] PPCBoolRetToInt: Don't translate Constant's operands.

I can confirm that this patch also fixes the full test case.

Aug 7 2020, 3:52 PM · Restricted Project

Aug 6 2020

tstellar added a comment to D79279: Add overloaded versions of builtin mem* functions.

I thought part of the point of __builtin_memcpy was so that C library headers could do #define memcpy(x, y, z) __builtin_memcpy(x, y, z). If so, the conformance issue touches __builtin_memcpy as well, not just calls to the library builtin.

They would have to declare it as well (because C code can #undef memcpy and expect to then be able to call a real function), so the #define would be pointless. It doesn't look like glibc does anything like this; do you know of a C standard library implementation that does?

If we want to follow that path, then we'll presumably (eventually) want address-space-_overloaded versions of all lib builtins that take pointers -- looks like that's around 60 functions total. That said, I do wonder how many of the functions in question that we're implicitly overloading on address space actually support such overloading -- certainly any of them that we lower to a call to a library function is going to go wrong at runtime.

+@tstellar, who added this functionality in r233706 -- what was the intent here?

Aug 6 2020, 1:10 PM · Restricted Project, Restricted Project

Aug 3 2020

tstellar added inline comments to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Aug 3 2020, 10:51 AM · Restricted Project, Restricted Project

Jul 28 2020

tstellar added inline comments to D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int).
Jul 28 2020, 4:48 PM · Restricted Project
tstellar updated the diff for D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int).

Add volatile test.

Jul 28 2020, 4:47 PM · Restricted Project

Jul 27 2020

tstellar added a comment to D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int).

Here is the assembly comparison for the 64-bit test I added between gcc and clang trunk + patch: https://reviews.llvm.org/P8227

Jul 27 2020, 6:19 PM · Restricted Project
tstellar added a comment to D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int).

This is the test driver I used for testing. I compared the clang 11 + this patch with gcc 10 and saw no differences: https://gist.github.com/tstellar/80dae2ab8a18d810b10b8e42777f4fe4

Jul 27 2020, 6:10 PM · Restricted Project
tstellar updated the diff for D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int).

Add 64-bit test.

Jul 27 2020, 6:05 PM · Restricted Project

Jul 23 2020

tstellar added a comment to D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int).
In D84405#2170110, @vsk wrote:

How were you able to show that the specialized IRGen is equivalent to the generic kind? I tried doing this with direct inspection (https://godbolt.org/z/o5WEn3), but wasn't able to convince myself. In the past I used a test driver to compare the before/after compiler output -- you might find that useful (https://gist.github.com/vedantk/3eb9c88f82e5c32f2e590555b4af5081).

Jul 23 2020, 10:51 AM · Restricted Project
tstellar updated the diff for D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int).

Remove stray comment.

Jul 23 2020, 7:18 AM · Restricted Project
Herald added a project to D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int): Restricted Project.
Jul 23 2020, 7:16 AM · Restricted Project

Jul 22 2020

tstellar updated the diff for D80395: HowToReleaseLLVM: Clean up document and remove references to SVN.

Add example for tagging the -init tag.

Jul 22 2020, 10:59 AM · Restricted Project

Jul 10 2020

tstellar committed rG1d68a780b34e: [clang-shlib] Don't link with static clang libraries (authored by tstellar).
[clang-shlib] Don't link with static clang libraries
Jul 10 2020, 2:29 PM
tstellar closed D82694: [clang-shlib] Don't link with static clang libraries.
Jul 10 2020, 2:28 PM · Restricted Project

Jul 9 2020

tstellar accepted D82078: libclc: Make all built-ins overloadable.

LGTM.

Jul 9 2020, 9:06 AM · Restricted Project

Jul 7 2020

tstellar committed rGef32c611aa21: [tests] Revert unhelpful change from d73eed42d1dc (authored by hubert.reinterpretcast).
[tests] Revert unhelpful change from d73eed42d1dc
Jul 7 2020, 2:31 PM

Jul 6 2020

tstellar committed rG70919a46facc: [tests] Speculative fix for buildbot breakage from c5f7c039efe7 (authored by hubert.reinterpretcast).
[tests] Speculative fix for buildbot breakage from c5f7c039efe7
Jul 6 2020, 3:43 PM

Jun 29 2020

tstellar accepted D82291: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB.

LGTM.

Jun 29 2020, 2:12 PM · Restricted Project

Jun 26 2020

tstellar created D82694: [clang-shlib] Don't link with static clang libraries.
Jun 26 2020, 5:05 PM · Restricted Project
tstellar committed rG77d76b71d7df: [libc++] Fix recursive instantiation in std::array. (authored by EricWF).
[libc++] Fix recursive instantiation in std::array.
Jun 26 2020, 2:09 PM
tstellar committed rG76ceebb0d963: [DAGCombine] Check the uses of negated floating constant and remove the hack (authored by steven.zhang).
[DAGCombine] Check the uses of negated floating constant and remove the hack
Jun 26 2020, 2:09 PM

Jun 25 2020

tstellar committed rGa110c3fc8cd9: [AArch64] Change AArch64 Windows EH UnwindHelp object to be a fixed object (authored by danielframpton).
[AArch64] Change AArch64 Windows EH UnwindHelp object to be a fixed object
Jun 25 2020, 11:27 PM
tstellar committed rG69fb858731e8: [AArch64] Fix mismatch in prologue and epilogue for funclets on Windows (authored by danielframpton).
[AArch64] Fix mismatch in prologue and epilogue for funclets on Windows
Jun 25 2020, 11:27 PM
tstellar committed rG04b0a4e22e3b: Provide anchor for compiler extensions (authored by serge-sans-paille).
Provide anchor for compiler extensions
Jun 25 2020, 11:27 PM
tstellar committed rGb294e611271a: [PPCAsmPrinter] support 'L' output template for memory operands (authored by nickdesaulniers).
[PPCAsmPrinter] support 'L' output template for memory operands
Jun 25 2020, 11:26 PM
tstellar committed rG43ca67c05d28: [RISCV] Fix incorrect FP base CFI offset for variable argument functions (authored by shiva0217).
[RISCV] Fix incorrect FP base CFI offset for variable argument functions
Jun 25 2020, 11:26 PM
tstellar committed rG5fa1f1e9f44b: [RISCV-V] Provide muldi3 builtin assembly implementation (authored by kamleshbhalui).
[RISCV-V] Provide muldi3 builtin assembly implementation
Jun 25 2020, 11:26 PM
tstellar committed rG71c14cd5aee7: [RISCV] Fix passing two floating-point values in complex separately by two GPRs… (authored by Jim).
[RISCV] Fix passing two floating-point values in complex separately by two GPRs…
Jun 25 2020, 11:26 PM
tstellar committed rG249fef00d925: [RISCV64] Emit correct lib call for fp(float/double) to ui/si (authored by kamleshbhalui).
[RISCV64] Emit correct lib call for fp(float/double) to ui/si
Jun 25 2020, 11:26 PM
tstellar committed rG9bf7ca2c92a8: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC (authored by luismarques).
[RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC
Jun 25 2020, 11:25 PM
tstellar committed rGf8e49af4f1ad: [LegalizeTypes][RISCV] Correctly sign-extend comparison for ATOMIC_CMP_XCHG (authored by asb).
[LegalizeTypes][RISCV] Correctly sign-extend comparison for ATOMIC_CMP_XCHG
Jun 25 2020, 11:25 PM

Jun 24 2020

tstellar committed rG72bff7855d8c: [X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass (authored by sconstab).
[X86] Add an Unoptimized Load Value Injection (LVI) Load Hardening Pass
Jun 24 2020, 9:46 AM
tstellar committed rGd24d5c8e308e: fixed broken test after cherry pick (authored by sconstab).
fixed broken test after cherry pick
Jun 24 2020, 9:46 AM
tstellar committed rG8aa8abae349d: [X86] Add Support for Load Hardening to Mitigate Load Value Injection (LVI) (authored by sconstab).
[X86] Add Support for Load Hardening to Mitigate Load Value Injection (LVI)
Jun 24 2020, 9:45 AM
tstellar committed rG363720c2b0f6: [X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI)… (authored by sconstab).
[X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI)…
Jun 24 2020, 9:45 AM
tstellar committed rG1d8639336d96: [X86] Add tests to clang Driver to ensure that SLH/Retpoline features are not… (authored by sconstab).
[X86] Add tests to clang Driver to ensure that SLH/Retpoline features are not…
Jun 24 2020, 9:45 AM
tstellar committed rGac40e7a02efb: [X86] Fix to X86LoadValueInjectionRetHardeningPass for possible segfault (authored by sconstab).
[X86] Fix to X86LoadValueInjectionRetHardeningPass for possible segfault
Jun 24 2020, 9:45 AM
tstellar committed rGd758416a9152: Revert "[X86] Add a Pass that builds a Condensed CFG for Load Value Injection… (authored by craig.topper).
Revert "[X86] Add a Pass that builds a Condensed CFG for Load Value Injection…
Jun 24 2020, 9:45 AM
tstellar added a reverting change for rGc74dd640fd74: [X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI)…: rGd758416a9152: Revert "[X86] Add a Pass that builds a Condensed CFG for Load Value Injection….
Jun 24 2020, 9:45 AM
tstellar committed rG5bc4d476f344: Revert "[X86] Add Support for Load Hardening to Mitigate Load Value Injection… (authored by craig.topper).
Revert "[X86] Add Support for Load Hardening to Mitigate Load Value Injection…
Jun 24 2020, 9:45 AM
tstellar added a reverting change for rG62c42e29ba43: [X86] Add Support for Load Hardening to Mitigate Load Value Injection (LVI): rG5bc4d476f344: Revert "[X86] Add Support for Load Hardening to Mitigate Load Value Injection….
Jun 24 2020, 9:45 AM
tstellar committed rG2530f4e0ce44: [X86] Add Support for Load Hardening to Mitigate Load Value Injection (LVI) (authored by sconstab).
[X86] Add Support for Load Hardening to Mitigate Load Value Injection (LVI)
Jun 24 2020, 9:45 AM
tstellar committed rGe3ba468fc3c1: [X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI)… (authored by sconstab).
[X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI)…
Jun 24 2020, 9:44 AM
tstellar committed rG6a4589599d74: [X86] Add RET-hardening Support to mitigate Load Value Injection (LVI) (authored by sconstab).
[X86] Add RET-hardening Support to mitigate Load Value Injection (LVI)
Jun 24 2020, 9:44 AM
tstellar committed rG071acfdd4694: [X86] Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) (authored by sconstab).
[X86] Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI)
Jun 24 2020, 9:44 AM
tstellar committed rGfe73b9416dea: [X86][NFC] Generalize the naming of "Retpoline Thunks" and related code to… (authored by sconstab).
[X86][NFC] Generalize the naming of "Retpoline Thunks" and related code to…
Jun 24 2020, 9:44 AM
tstellar committed rGa09ebfdafb9d: [X86] Refactor X86IndirectThunks.cpp to Accommodate Mitigations other than… (authored by sconstab).
[X86] Refactor X86IndirectThunks.cpp to Accommodate Mitigations other than…
Jun 24 2020, 9:44 AM
tstellar committed rG34f7e00333ac: Move RDF from Hexagon to Codegen (authored by sconstab).
Move RDF from Hexagon to Codegen
Jun 24 2020, 9:44 AM
tstellar committed rGf9da0a7f36f7: [Driver] Support -fsanitize=shadow-call-stack and cfi-icall on aarch64_be (authored by MaskRay).
[Driver] Support -fsanitize=shadow-call-stack and cfi-icall on aarch64_be
Jun 24 2020, 9:44 AM
tstellar committed rG1a25347f574f: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be (authored by MaskRay).
[Driver] Support -fsanitize=shadow-call-stack on aarch64_be
Jun 24 2020, 9:43 AM

Jun 23 2020

tstellar committed rGbe4501f6e487: [InstCombine] prevent infinite loop with sub/abs of constant expression (authored by tstellar).
[InstCombine] prevent infinite loop with sub/abs of constant expression
Jun 23 2020, 10:39 PM
tstellar committed rG28a6713e107c: [ManagedStatic] Fix build errors with clang-tblgen in Debug mode using MSVC… (authored by ASDenysPetrov).
[ManagedStatic] Fix build errors with clang-tblgen in Debug mode using MSVC…
Jun 23 2020, 4:12 PM
tstellar committed rG5ccc104c206c: [compiler-rt] Reduce the number of threads in gcov test to avoid failure (authored by Calixte Denizet <calixte.denizet@gmail.com>).
[compiler-rt] Reduce the number of threads in gcov test to avoid failure
Jun 23 2020, 4:12 PM
tstellar committed rGcaa755f90e37: [BasicAA] Make BasicAA a cfg pass. (authored by asbirlea).
[BasicAA] Make BasicAA a cfg pass.
Jun 23 2020, 4:12 PM
tstellar committed rG1f3be0e9b7b4: [PowerPC] Do not assume operand of ADDI is an immediate (authored by nemanjai).
[PowerPC] Do not assume operand of ADDI is an immediate
Jun 23 2020, 3:06 PM
tstellar committed rGf5bad9cac5d3: [BPF] fix incorrect type in BPFISelDAGToDAG readonly load optimization (authored by yonghong-song).
[BPF] fix incorrect type in BPFISelDAGToDAG readonly load optimization
Jun 23 2020, 3:06 PM
tstellar committed rG0777c907268a: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well. (authored by thakis).
Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.
Jun 23 2020, 3:06 PM
tstellar committed rG177a9ac3c6bc: [PowerPC] Unaligned FP default should apply to scalars only (authored by nemanjai).
[PowerPC] Unaligned FP default should apply to scalars only
Jun 23 2020, 2:33 PM
tstellar committed rG97065683c6a9: [clangd] Fix DocumentOutline for concepts (authored by kadircet).
[clangd] Fix DocumentOutline for concepts
Jun 23 2020, 2:33 PM
tstellar committed rGc69ed62ea195: [BPF] fix a bug for BTF pointee type pruning (authored by yonghong-song).
[BPF] fix a bug for BTF pointee type pruning
Jun 23 2020, 2:33 PM

Jun 22 2020

tstellar committed rG8f299fd2cff7: Fixed false ThinLTO cache misses problem (PR 45819). (authored by kromanova).
Fixed false ThinLTO cache misses problem (PR 45819).
Jun 22 2020, 4:40 PM
tstellar committed rGa8eb6a5db7f9: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint (authored by nemanjai).
[PowerPC] Treat 'Z' inline asm constraint as a true memory constraint
Jun 22 2020, 4:08 PM
tstellar committed rG1abba52044dd: [PowerPC] Add missing handling for half precision (authored by tstellar).
[PowerPC] Add missing handling for half precision
Jun 22 2020, 3:37 PM
tstellar committed rGeac91d586401: [PowerPC] Prevent legalization loop from promoting SELECT_CC from v4i32 to v4i32 (authored by nemanjai).
[PowerPC] Prevent legalization loop from promoting SELECT_CC from v4i32 to v4i32
Jun 22 2020, 3:37 PM
tstellar committed rG3428405fc4ec: [PowerPC] Add support for vmsumudm (authored by saghir).
[PowerPC] Add support for vmsumudm
Jun 22 2020, 3:04 PM

Jun 18 2020

tstellar accepted D82135: [BFloat] Move LLVMBFloatTypeKind to the end of the enum.

LGTM. Thanks.

Jun 18 2020, 5:31 PM · Restricted Project

Jun 17 2020

tstellar committed rG6f71678ecd29: Make Polly tests dependencies explicit (authored by serge-sans-paille).
Make Polly tests dependencies explicit
Jun 17 2020, 5:50 PM
tstellar committed rG3ca8b23cf5b9: Fix spurious warning in ExtensionDependencies.inc [nfc] (authored by serge-sans-paille).
Fix spurious warning in ExtensionDependencies.inc [nfc]
Jun 17 2020, 5:50 PM
tstellar committed rG576559ed5d08: Use components instead of libraries in Polly linkage step (authored by serge-sans-paille).
Use components instead of libraries in Polly linkage step
Jun 17 2020, 5:50 PM
tstellar committed rG2f6b23d4d00c: Do not declare compiler extension member as const (authored by serge-sans-paille).
Do not declare compiler extension member as const
Jun 17 2020, 5:50 PM
tstellar committed rG5f510e51dd4e: Update compiler extension integration into the build system (authored by serge-sans-paille).
Update compiler extension integration into the build system
Jun 17 2020, 5:50 PM
tstellar committed rG0c05269e0232: [nfc] Cleanup extension header generation (authored by serge-sans-paille).
[nfc] Cleanup extension header generation
Jun 17 2020, 5:50 PM
tstellar committed rG4b932da77db7: Fix compiler extension in standalone mode (authored by serge-sans-paille).
Fix compiler extension in standalone mode
Jun 17 2020, 5:50 PM
tstellar committed rG7831c48b0667: Fix standalone build interaction with compiler extension (authored by serge-sans-paille).
Fix standalone build interaction with compiler extension
Jun 17 2020, 5:50 PM
tstellar committed rGf14919564d85: Fix integration of pass plugins with llvm dylib (authored by serge-sans-paille).
Fix integration of pass plugins with llvm dylib
Jun 17 2020, 5:50 PM
tstellar committed rG783f5c6c5e2a: Fix alignment of thunks for ARM/ARM64 (authored by mstorsjo).
Fix alignment of thunks for ARM/ARM64
Jun 17 2020, 5:50 PM
tstellar committed rGf5a9c661a356: [AARch64] Add Marvell ThunderX3T110 support (authored by wxz2020).
[AARch64] Add Marvell ThunderX3T110 support
Jun 17 2020, 3:42 PM
tstellar committed rG320907788da9: [X86] make sure POP has implicit def/use of stack pointer when materializing 8… (authored by ychen).
[X86] make sure POP has implicit def/use of stack pointer when materializing 8…
Jun 17 2020, 3:41 PM
tstellar added inline comments to D78190: Add Bfloat IR type.
Jun 17 2020, 12:23 PM · Restricted Project, Restricted Project
tstellar added a reviewer for D82001: [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup: serge-sans-paille.
Jun 17 2020, 10:13 AM · Restricted Project

Jun 16 2020

tstellar committed rG4d0626a822be: [IndVarSimplify][LoopUtils] Avoid TOCTOU/ordering issues (PR45835) (authored by tstellar).
[IndVarSimplify][LoopUtils] Avoid TOCTOU/ordering issues (PR45835)
Jun 16 2020, 8:18 PM
tstellar committed rGbf89c5aeb891: [AArch64] Fix BTI instruction emission. (authored by danielkiss).
[AArch64] Fix BTI instruction emission.
Jun 16 2020, 8:15 PM
tstellar committed rGaab506959716: [AArch64] Fix BTI landing pad generation. (authored by danielkiss).
[AArch64] Fix BTI landing pad generation.
Jun 16 2020, 8:15 PM
tstellar committed rGea65b89665c7: [X86] Fold undef elts to 0 in getTargetVShiftByConstNode. (authored by craig.topper).
[X86] Fold undef elts to 0 in getTargetVShiftByConstNode.
Jun 16 2020, 12:40 PM
tstellar committed rGd970ab63e22e: Driver: Accept multiple --config options if filenames are the same (authored by tstellar).
Driver: Accept multiple --config options if filenames are the same
Jun 16 2020, 12:40 PM
tstellar committed rG0f99a730e3bf: [X86] Teach combineVectorShiftImm to constant fold undef elements to 0 not… (authored by craig.topper).
[X86] Teach combineVectorShiftImm to constant fold undef elements to 0 not…
Jun 16 2020, 12:40 PM
tstellar committed rG756b482c69be: lit googletest.py: Don't raise StopIteration in generator (authored by hans).
lit googletest.py: Don't raise StopIteration in generator
Jun 16 2020, 12:40 PM
tstellar closed D81424: Driver: Accept multiple --config options if filenames are the same.
Jun 16 2020, 12:40 PM · Restricted Project