Page MenuHomePhabricator

nullptr.cpp (Yang Fan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2019, 7:08 PM (79 w, 3 d)

Recent Activity

Mon, Jan 18

nullptr.cpp committed rG9a0900dc4c6b: [NFC][AIX][XCOFF] Fix compile warning on strncpy (authored by nullptr.cpp).
[NFC][AIX][XCOFF] Fix compile warning on strncpy
Mon, Jan 18, 10:07 PM
nullptr.cpp closed D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.
Mon, Jan 18, 10:07 PM · Restricted Project
nullptr.cpp updated the diff for D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.

Use StringRef

Mon, Jan 18, 7:27 PM · Restricted Project
nullptr.cpp added inline comments to D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.
Mon, Jan 18, 3:33 PM · Restricted Project
nullptr.cpp added a reviewer for D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy: hubert.reinterpretcast.
Mon, Jan 18, 2:20 AM · Restricted Project
nullptr.cpp updated the diff for D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.

Use memcpy

Mon, Jan 18, 1:18 AM · Restricted Project

Sat, Jan 16

nullptr.cpp updated the diff for D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.

rebase

Sat, Jan 16, 10:51 PM · Restricted Project
nullptr.cpp requested review of D94872: [NFC][AIX][XCOFF] Fix compile warning on strncpy.
Sat, Jan 16, 8:40 PM · Restricted Project

Tue, Jan 12

nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

rebase

Tue, Jan 12, 6:34 PM · Restricted Project

Tue, Jan 5

nullptr.cpp committed rGa032a4e7998c: [-Wcalled-once-parameter][NFC] Fix operator precedence warning (authored by nullptr.cpp).
[-Wcalled-once-parameter][NFC] Fix operator precedence warning
Tue, Jan 5, 8:17 PM
nullptr.cpp committed rG74f93bc373d0: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp).
[Sema] Fix deleted function problem in implicitly movable test
Tue, Jan 5, 6:06 PM
nullptr.cpp closed D92936: [Sema] Fix deleted function problem in implicitly movable test.
Tue, Jan 5, 6:06 PM · Restricted Project

Mon, Jan 4

nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

Fix use-of-uninitialized-value and -Wreturn-std-move with delete function

Mon, Jan 4, 11:34 PM · Restricted Project
nullptr.cpp reopened D92936: [Sema] Fix deleted function problem in implicitly movable test.
Mon, Jan 4, 11:25 PM · Restricted Project
nullptr.cpp added a reverting change for rG89b0972aa2f5: [Sema] Fix deleted function problem in implicitly movable test: rGe43b3d1f5e05: Revert "[Sema] Fix deleted function problem in implicitly movable test".
Mon, Jan 4, 1:22 AM
nullptr.cpp committed rGe43b3d1f5e05: Revert "[Sema] Fix deleted function problem in implicitly movable test" (authored by nullptr.cpp).
Revert "[Sema] Fix deleted function problem in implicitly movable test"
Mon, Jan 4, 1:22 AM
nullptr.cpp added a reverting change for D92936: [Sema] Fix deleted function problem in implicitly movable test: rGe43b3d1f5e05: Revert "[Sema] Fix deleted function problem in implicitly movable test".
Mon, Jan 4, 1:22 AM · Restricted Project

Fri, Jan 1

nullptr.cpp committed rG471dec3801b3: [CodeGen][NFC] Fix a build warning due to an extra semicolon (authored by nullptr.cpp).
[CodeGen][NFC] Fix a build warning due to an extra semicolon
Fri, Jan 1, 6:43 PM
nullptr.cpp updated the diff for D93955: [Sema] Add support for reporting multiple errors during initialization.

Separate out D93962

Fri, Jan 1, 1:56 AM · Restricted Project
nullptr.cpp requested review of D93962: [Sema] Fix the program state in reference initialization.
Fri, Jan 1, 1:42 AM · Restricted Project
nullptr.cpp committed rGd5324c052b21: [clang-tidy][NFC] Fix a build warning due to an extra semicolon (authored by nullptr.cpp).
[clang-tidy][NFC] Fix a build warning due to an extra semicolon
Fri, Jan 1, 12:00 AM
nullptr.cpp closed D93961: [clang-tidy][NFC] Fix a build warning due to an extra semicolon.
Fri, Jan 1, 12:00 AM · Restricted Project

Thu, Dec 31

nullptr.cpp committed rG89b0972aa2f5: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp).
[Sema] Fix deleted function problem in implicitly movable test
Thu, Dec 31, 11:48 PM
nullptr.cpp closed D92936: [Sema] Fix deleted function problem in implicitly movable test.
Thu, Dec 31, 11:48 PM · Restricted Project
nullptr.cpp requested review of D93961: [clang-tidy][NFC] Fix a build warning due to an extra semicolon.
Thu, Dec 31, 10:19 PM · Restricted Project
nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

rebase

Thu, Dec 31, 10:14 PM · Restricted Project
nullptr.cpp updated the diff for D93955: [Sema] Add support for reporting multiple errors during initialization.

Update

Thu, Dec 31, 2:03 AM · Restricted Project
nullptr.cpp requested review of D93955: [Sema] Add support for reporting multiple errors during initialization.
Thu, Dec 31, 1:42 AM · Restricted Project

Tue, Dec 29

nullptr.cpp added a comment to D88220: [C++20] P1825R0: More implicit moves.

Ping

Tue, Dec 29, 1:52 AM · Restricted Project

Mon, Dec 28

nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

rebase

Mon, Dec 28, 12:29 AM · Restricted Project

Sun, Dec 27

nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

rebase

Sun, Dec 27, 11:47 PM · Restricted Project

Wed, Dec 23

nullptr.cpp added a comment to D92936: [Sema] Fix deleted function problem in implicitly movable test.

Ping

Wed, Dec 23, 12:04 AM · Restricted Project

Tue, Dec 22

nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

Add more tests

Tue, Dec 22, 11:57 PM · Restricted Project

Dec 11 2020

nullptr.cpp added a comment to D92936: [Sema] Fix deleted function problem in implicitly movable test.

Note: The failed test has nothing to do with this patch.

Dec 11 2020, 4:57 AM · Restricted Project
nullptr.cpp updated the summary of D92936: [Sema] Fix deleted function problem in implicitly movable test.
Dec 11 2020, 3:31 AM · Restricted Project
nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

Fix format

Dec 11 2020, 3:22 AM · Restricted Project
nullptr.cpp updated the diff for D92936: [Sema] Fix deleted function problem in implicitly movable test.

Update

Dec 11 2020, 1:17 AM · Restricted Project

Dec 9 2020

nullptr.cpp requested review of D92936: [Sema] Fix deleted function problem in implicitly movable test.
Dec 9 2020, 6:52 AM · Restricted Project

Dec 7 2020

nullptr.cpp updated the summary of D88220: [C++20] P1825R0: More implicit moves.
Dec 7 2020, 5:02 AM · Restricted Project
nullptr.cpp updated the summary of D88220: [C++20] P1825R0: More implicit moves.
Dec 7 2020, 5:01 AM · Restricted Project
nullptr.cpp added inline comments to D88220: [C++20] P1825R0: More implicit moves.
Dec 7 2020, 4:55 AM · Restricted Project
nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

Update

Dec 7 2020, 4:22 AM · Restricted Project

Nov 22 2020

nullptr.cpp added a comment to D88220: [C++20] P1825R0: More implicit moves.

Ping

Nov 22 2020, 6:39 PM · Restricted Project

Nov 11 2020

nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

rebase

Nov 11 2020, 3:08 AM · Restricted Project

Nov 10 2020

nullptr.cpp added a comment to D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

Thanks for all your suggestions!
But I don't have commit access, can anyone help me commit this with "Yang Fan <nullptr.cpp@gmail.com>" ?
Thanks!

Nov 10 2020, 5:30 AM · Restricted Project

Nov 3 2020

nullptr.cpp retitled D88220: [C++20] P1825R0: More implicit moves from [C++20] Implement more implicit moves for return statements(Part of P1825R0) to [C++20] P1825R0: More implicit moves.
Nov 3 2020, 5:00 AM · Restricted Project
nullptr.cpp updated the diff for D88220: [C++20] P1825R0: More implicit moves.

Implement whole P1825R0

Nov 3 2020, 4:55 AM · Restricted Project

Oct 31 2020

nullptr.cpp updated the diff for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

move test to class/class.init/class.copy.elision/p1.cpp

Oct 31 2020, 2:19 AM · Restricted Project

Oct 29 2020

nullptr.cpp updated the diff for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

rebase

Oct 29 2020, 11:56 PM · Restricted Project
nullptr.cpp added a comment to D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

Could you perhaps integrate this into the existing test clang/test/CXX/special/class.copy/implicit-move.cpp instead?
Whenever you have something that closely corresponds to the standard, CXX is probably the right place for a test.

clang/test/CXX/special/class.copy/implicit-move.cpp and clang/test/CXX/special/class.copy/implicit-move-def.cpp are tests for implicit (non-)declaration of move constructor and assignment, they have nothing to do with this patch.
Because copy/move elision is defined in section [class.copy.elision] in standard, so I put the test in clang/test/CXX/special/class.copy/copy-elision.cpp.

Oct 29 2020, 9:44 PM · Restricted Project
nullptr.cpp updated the diff for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

make test more clearly

Oct 29 2020, 9:25 PM · Restricted Project

Oct 28 2020

nullptr.cpp added a comment to D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

Ping
I don't have commit access, can anyone help me commit this with "Yang Fan <nullptr.cpp@gmail.com>" ?
Thanks!

Oct 28 2020, 1:29 AM · Restricted Project
nullptr.cpp added reviewers for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move: nlewycky, rjmccall, aaronpuchert.
Oct 28 2020, 1:29 AM · Restricted Project

Oct 15 2020

nullptr.cpp added a comment to D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

Ping!
I don't have commit access, can anyone help me commit this with "Yang Fan <nullptr.cpp@gmail.com>" ?
Thanks!

Oct 15 2020, 12:40 AM · Restricted Project

Sep 26 2020

nullptr.cpp added a comment to D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.
  • C++11:

[class.copy]p32:
When the criteria for elision of a copy operation are met or would be met save for the fact that the source object is a function parameter, and the object to be copied is designated by an lvalue, overload resolution to select the constructor for the copy is first performed as if the object were designated by an rvalue.

Thus should use rules at:

[class.copy]p31:
— in a return statement in a function with a class return type, when the expression is the name of a non-volatile automatic object ...

Volatile automatic objects cannot pass this check.

Sep 26 2020, 1:11 AM · Restricted Project
nullptr.cpp updated the diff for D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.

Add test.

Sep 26 2020, 1:06 AM · Restricted Project

Sep 25 2020

nullptr.cpp requested review of D88295: [Sema] Fix volatile check when test if a return object can be implicitly move.
Sep 25 2020, 5:09 AM · Restricted Project

Sep 24 2020

nullptr.cpp requested review of D88220: [C++20] P1825R0: More implicit moves.
Sep 24 2020, 5:18 AM · Restricted Project

Sep 10 2020

nullptr.cpp removed 1 auditor(s) for rG24ecfdac7b7d: [APFloat] Fix uninitialized variable in IEEEFloat constructors: nullptr.cpp.
Sep 10 2020, 5:43 AM
nullptr.cpp added 1 auditor(s) for rG24ecfdac7b7d: [APFloat] Fix uninitialized variable in IEEEFloat constructors: nullptr.cpp.
Sep 10 2020, 5:37 AM
nullptr.cpp updated the diff for D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 10 2020, 4:59 AM · Restricted Project, Restricted Project
nullptr.cpp updated the diff for D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 10 2020, 2:42 AM · Restricted Project, Restricted Project

Sep 9 2020

nullptr.cpp added a comment to D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.

I don't have commit access, can anyone help me commit this with "Yang Fan <nullptr.cpp@gmail.com>" ?
Thanks!

Sep 9 2020, 8:08 PM · Restricted Project, Restricted Project
nullptr.cpp updated the summary of D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 9 2020, 7:28 PM · Restricted Project, Restricted Project
nullptr.cpp updated the diff for D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.

Fix by directly using INT_MAX and INT32_MAX.

Sep 9 2020, 7:27 PM · Restricted Project, Restricted Project
nullptr.cpp added a comment to D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.

I don't have commit access, can anyone help me commit this and D86997?
Yang Fan <nullptr.cpp@gmail.com>
Thanks!

Sep 9 2020, 1:14 AM · Restricted Project, Restricted Project
nullptr.cpp added reviewers for D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness: Eugene.Zelenko, spatel, aardappel, aheejin, sbc100, hiraditya.
Sep 9 2020, 1:13 AM · Restricted Project, Restricted Project
nullptr.cpp requested review of D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 9 2020, 12:09 AM · Restricted Project, Restricted Project

Sep 3 2020

nullptr.cpp added a comment to D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.

I don't have commit access, can anyone help commit this?
Yang Fan <nullptr.cpp@gmail.com>
Thanks!

Sep 3 2020, 4:47 PM · Restricted Project
nullptr.cpp retitled D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors from [APFloat] Fix uninitialized variable in IEEEFloat constructor to [APFloat] Fix uninitialized variable in IEEEFloat constructors.
Sep 3 2020, 2:46 AM · Restricted Project
nullptr.cpp updated the diff for D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.

Also fix other constructors.

Sep 3 2020, 2:43 AM · Restricted Project

Sep 1 2020

nullptr.cpp added a comment to D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.

What problem does this cause? IEEEFloat::initFromFloatAPInt which is called for IEEEFloat::IEEEFloat(float f) also doesn't assign exponent from what I can see.

Sep 1 2020, 7:37 PM · Restricted Project
nullptr.cpp added reviewers for D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors: craig.topper, lattner, ekatz.
Sep 1 2020, 7:37 PM · Restricted Project
nullptr.cpp requested review of D86997: [APFloat] Fix uninitialized variable in IEEEFloat constructors.
Sep 1 2020, 6:46 PM · Restricted Project

Aug 31 2020

nullptr.cpp added a comment to D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

@jdoerfert @ABataev
I don't have commit access, can you help commit this?
Yang Fan <nullptr.cpp@gmail.com>
Thanks!

Aug 31 2020, 9:16 PM · Restricted Project
nullptr.cpp updated the diff for D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

trigger rebuild

Aug 31 2020, 8:45 PM · Restricted Project
nullptr.cpp added a comment to D86691: [analyzer] Fix wrong parameter name in printFormattedEntry.

Nice, thank you! Did you stumble across this, or found it with a tool?

I just happened to see these code:-).
Maybe we should write a checker to check this situation? I will start doing this!

Good idea! And thanks for the fix! :)

Aug 31 2020, 12:42 AM · Restricted Project

Aug 30 2020

nullptr.cpp added a comment to D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

Can you add the test that exposed this?

Aug 30 2020, 11:56 PM · Restricted Project
nullptr.cpp updated the summary of D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().
Aug 30 2020, 11:49 PM · Restricted Project
nullptr.cpp updated the diff for D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

Fix by changing the loop condition to Level > 0.

Aug 30 2020, 11:48 PM · Restricted Project
nullptr.cpp requested review of D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().
Aug 30 2020, 9:33 PM · Restricted Project
nullptr.cpp requested review of D86856: [ORC][NFC] Fix gcc warning by remove the extra semicolon.
Aug 30 2020, 8:49 PM · Restricted Project

Aug 27 2020

nullptr.cpp added a comment to D86691: [analyzer] Fix wrong parameter name in printFormattedEntry.

@Szelethus @martong
Sorry to interrupt, I don't have commit access, can you help commit this and D86334?
Yang Fan <nullptr.cpp@gmail.com>
Thanks!

Aug 27 2020, 6:49 AM · Restricted Project
nullptr.cpp added a comment to D86691: [analyzer] Fix wrong parameter name in printFormattedEntry.

Nice, thank you! Did you stumble across this, or found it with a tool?

Aug 27 2020, 4:19 AM · Restricted Project
nullptr.cpp requested review of D86691: [analyzer] Fix wrong parameter name in printFormattedEntry.
Aug 27 2020, 1:56 AM · Restricted Project

Aug 21 2020

nullptr.cpp added a comment to D86334: [analyzer] Remove redundant output errs.

I don't have commit access, can you help commit it?

Aug 21 2020, 2:59 AM · Restricted Project
nullptr.cpp added a reviewer for D86334: [analyzer] Remove redundant output errs: xazax.hun.
Aug 21 2020, 1:57 AM · Restricted Project
nullptr.cpp added reviewers for D86334: [analyzer] Remove redundant output errs: dcoughlin, NoQ, george.karpenkov.
Aug 21 2020, 12:52 AM · Restricted Project
nullptr.cpp requested review of D86334: [analyzer] Remove redundant output errs.
Aug 21 2020, 12:50 AM · Restricted Project

Aug 20 2020

nullptr.cpp updated nullptr.cpp.
Aug 20 2020, 11:43 PM