Page MenuHomePhabricator

Szelethus (Kristóf Umann)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 6:59 AM (159 w, 4 d)

Recent Activity

Fri, Aug 7

Szelethus added a comment to D84600: [Analyzer] Support note tags for smart ptr checker.

Layering violations are a running theme in the analyzer -- CheckerRegistry and the entire MallocChecker fiasco are two glaring examples. Luckily, this isn't a severe case so I wouldn't worry about it much.

Fri, Aug 7, 12:43 PM · Restricted Project
Szelethus added a comment to D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'..

Test results for tmux are available here. (Could not manage to get other results uploaded.)

Fri, Aug 7, 8:20 AM · Restricted Project

Thu, Aug 6

Szelethus added a comment to D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange.

Yeah, this looks straightforward, but how come you didn't manage to get a small test case? creduce gave up?

Thu, Aug 6, 6:27 AM · Restricted Project

Tue, Aug 4

Szelethus accepted D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling.

LGTM on my end, but please wait for approval from either @gamesh411 or @NoQ.

Tue, Aug 4, 7:53 AM · Restricted Project
Szelethus added a comment to D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'..

Would it be possible to publish these results on a public CodeChecker server?

Tue, Aug 4, 3:55 AM · Restricted Project
Szelethus added a comment to D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker..

We definitely need more tests. The idea overall however is amazing, thanks!

Tue, Aug 4, 3:29 AM · Restricted Project
Szelethus added a comment to D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis..
In D67422#2192407, @NoQ wrote:

One bit that's not directly related but i decided to keep it from the original patch was moving the plist-html diagnostic builder function into its own file.

Tue, Aug 4, 2:59 AM · Restricted Project

Tue, Jul 28

Szelethus requested changes to D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling.

Let me double down -- just because we let some select people know about an option, I still don't think it should be user facing. I'm strongly against the philosophy that a core-modifying decision, such as configuring a state split should be presented on the default interface. Having "smart users" isn't an excuse to that either -- the last thing I'd like to see broadcasted is that you need to be a genius to use or configure a tool that is suppose to serve you, not the other way around.

Tue, Jul 28, 5:29 AM · Restricted Project
Szelethus accepted D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC)..

Lets make sure that we invite others from the community to participate, here and on other patches as well. Otherwise, LGTM.

Tue, Jul 28, 1:13 AM · Restricted Project

Fri, Jul 24

Szelethus added a comment to D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.
In D82598#2172416, @NoQ wrote:

I still wonder what made this statement live in my example. There must have been some non-trivial liveness analysis going on that caused a statement to be live; probably something to do with the C++ destructor elements.

Fri, Jul 24, 12:36 PM · Restricted Project
Szelethus committed rG032b78a0762b: [analyzer] Revert the accidental commit of D82122 (authored by Szelethus).
[analyzer] Revert the accidental commit of D82122
Fri, Jul 24, 12:34 PM
Szelethus added a comment to D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.

Wow, I never realized I accidentally landed that assert (D82122#2172360), but I guess its great to have that covered. Would you prefer to have that reverted as I'm looking to fix this for good?

Fri, Jul 24, 8:20 AM · Restricted Project
Szelethus added a comment to D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness.

This was accidentally committed as a part of rGb6cbe6cb0399d4671e5384dcc326af56bc6bd122.

Fri, Jul 24, 8:14 AM · Restricted Project
Szelethus added a comment to D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.

Thank you so much, you really went out of your way to dig that out! I'll try to patch this somehow.

Fri, Jul 24, 8:04 AM · Restricted Project
Szelethus added a comment to D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting.
In D84316#2171270, @NoQ wrote:

Imagine something like re-using the state trait implementation between MallocChecker and StreamChecker because they both model "resources that can be deallocated twice or leaked" - regardless of the specific nature of these resources. These checkers can implement their own API modeling maps, escape rules, warning messages, maybe model additional aspects of their problems, but fundamentally they're solving the same problem: finding leaks and overreleases of resources. This problem should ideally be solved once. This is why i advocate for abstract, generalized, "half-baked" state trait boilerplate implementations that can be re-used across checkers.

Fri, Jul 24, 4:41 AM · Restricted Project
Szelethus added a comment to D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting.

I personally preferred the previous diff, the reporting part of the checker and the string length modeling was separated far more cleanly.

Fri, Jul 24, 4:37 AM · Restricted Project

Thu, Jul 23

Szelethus added a comment to D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting.

You could do it in the code, but if the modeling wouldn't be present from CStringModeling, CStringChecker wouldn't work properly. So you should make it a strong dependency, just as you did in this patch. My comment was mainly a response to @NoQ :)

Thu, Jul 23, 10:58 AM · Restricted Project
Szelethus added a comment to D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting.

Yay! This checker has become a major headache as the analyzer grew. Not on a RetainCount scale, but on a MallocChecker one. Cheap shots, I know :)

Thu, Jul 23, 6:31 AM · Restricted Project

Wed, Jul 22

Szelethus added a comment to D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.

Ouch. Let me know how severe this is, because this is a big milestone in my project.

Wed, Jul 22, 5:41 AM · Restricted Project

Tue, Jul 21

Szelethus added inline comments to D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.
Tue, Jul 21, 9:47 AM · Restricted Project
Szelethus added a comment to D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.

I chased my own tail for weeks before realizing that there is indeed another instance when a live statement is stored, other then ObjCForCollectionStmt...

void clang_analyzer_eval(bool);

void test_lambda_refcapture() {
  int a = 6;
  [&](int &a) { a = 42; }(a);
  clang_analyzer_eval(a == 42); // expected-warning{{TRUE}}
}

Hmm, interesting. I don't really understand why do we need to keep that block live, as we definitely won't use any of the value it provides (since it does not provide a value at all).

Tue, Jul 21, 8:26 AM · Restricted Project

Mon, Jul 20

Szelethus added a comment to D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.

I chased my own tail for weeks before realizing that there is indeed another instance when a live statement is stored, other then ObjCForCollectionStmt...

Mon, Jul 20, 7:44 AM · Restricted Project
Szelethus added a comment to D83961: [Analyzer] Fix bug report source locations in minimal output..

I find the summary here a bit lacking. We detected this issue in D83120, where a lot of discussion can be found, so its worth linking in. On its own, I'm not immediately sold on whether this is the correct solution, and even if it is, how does it solve the problem. I bet you had to struggle a bit to understand the related machinery to fix this, it'd be invaluable to share the knowledge you gained here as well.

Mon, Jul 20, 4:05 AM · Restricted Project
Szelethus accepted D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions.

LGTM!

Mon, Jul 20, 3:39 AM · Restricted Project

Sat, Jul 18

Szelethus added a comment to D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'..

I hope you don't mind if I bring up a point you mentioned during a daily meeting.

Sat, Jul 18, 7:12 AM · Restricted Project
Szelethus accepted D84084: [analyzer] scan-build: Fix silencing multiple core checkers..

I do not get why my solution -analyzer-config silence-checkers=core.NullDereference -analyzer-config silence-checkers=core.DivideZero was insufficient, whereas -analyzer-config silence-checkers=core.NullDereference;core.DivideZero is working.

Sat, Jul 18, 6:27 AM

Thu, Jul 16

Szelethus added a comment to D83942: [analyzer][tests] Add a notion of project sizes.

I suppose LLVM could be a HUGE project?

Thu, Jul 16, 7:21 AM · Restricted Project
Szelethus added a comment to D83942: [analyzer][tests] Add a notion of project sizes.

I don't speak snek, but I approve this message!

Thu, Jul 16, 7:20 AM · Restricted Project

Wed, Jul 15

Szelethus added a comment to D70411: [analyzer] CERT STR rule checkers: STR31-C.

Please do not bypass the previous comments that hadn't reached a conclusion -- littering inlines about miscellaneous stuff at this stage does more harm then good, and derails the discussion.

Wed, Jul 15, 9:06 AM · Restricted Project
Szelethus added inline comments to D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report..
Wed, Jul 15, 8:46 AM · Restricted Project
Szelethus added a comment to D69726: [analyzer] DynamicSize: Store the dynamic size.

While this patch spans across a lot of files, it is actually rather straightforward. I'm stunned to see that we never really had a proper dynamic size support, especially that this patch has been out there for a good long time :) Oh well, better learn that now than never.

Wed, Jul 15, 7:37 AM · Restricted Project
Szelethus added a comment to D83678: [analyzer] Move ReturnPtrRange checker out of alpha by fixing a false positive on end() iterator.

I almost feel like this should play a similar role to CXXSelfAssignmentChecker -- returning an out-of-range pointer isn't a bug in itself (certainly not a fatal one), just a big time code smell.

I vaguely recall that any pointer is expected to point either into a valid object or immediately past its end. I don't remember when exactly is this rule applied but i think it's a lot more UB in the standard than it's UB in practice.

I'd be interested to see that rule, though I can't imagine many circumstances under which one would go against it -- the only kind of programmer I would expect to come up with a valid use case would be a C programmer. :)

Wed, Jul 15, 5:05 AM · Restricted Project
Szelethus added a comment to D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report..

Unless @NoQ has anything else to add :)

Wed, Jul 15, 4:55 AM · Restricted Project
Szelethus accepted D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report..

Now that we found the answer to the only lingering question this revision raised, I think you can safely land it while we start looking into fixing this newfound bug. LGTM.

Wed, Jul 15, 4:55 AM · Restricted Project

Tue, Jul 14

Artem Dergachev <adergachev@apple.com> committed rG76b38c6d053b: [analyzer][NFC] Refactor the checker registration unit test file (authored by Szelethus).
[analyzer][NFC] Refactor the checker registration unit test file
Tue, Jul 14, 4:40 PM
Szelethus added reviewers for D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C: Szelethus, martong, steakhal, dkrupp.

@Eugene.Zelenko Thanks for cleaning up revisions -- same as D69560#1725399, we are working in the same office and have worked on some forms of static analysis for a while now. Adding us as reviewers helps this revision being more visible. Its clear that we don't have the authority to approve changes to clang-tidy, but we can confidently request changes or add to the discussion while still respecting that.

Tue, Jul 14, 7:01 AM · Restricted Project, Restricted Project, Restricted Project
Szelethus added inline comments to D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions.
Tue, Jul 14, 6:40 AM · Restricted Project
Szelethus requested changes to D83678: [analyzer] Move ReturnPtrRange checker out of alpha by fixing a false positive on end() iterator.

Lets just postpone moving out-of-alpha to a standalone revision. That, without any other changes demands discussion.

Tue, Jul 14, 6:24 AM · Restricted Project
Szelethus added a comment to D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis..
In D67422#1667079, @NoQ wrote:

Casually rename ClangDiagPathDiagConsumer to TextDiagnostics according to the local naming tradition.

Tue, Jul 14, 6:16 AM · Restricted Project
Szelethus added inline comments to D67421: [analyzer] NFC: Move IssueHash to libAnalysis..
Tue, Jul 14, 6:15 AM · Restricted Project
Szelethus accepted D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..

LGTM! Very well done!

Tue, Jul 14, 5:41 AM · Restricted Project
Szelethus added a comment to D67381: [analyzer] NFC: Move stack hints to a side map..

Aren't StackHints basically ancient NoteTags?

Tue, Jul 14, 4:50 AM · Restricted Project, Restricted Project
Szelethus accepted D83226: [analyzer] Add system header simulator a symmetric random access iterator operator+.

Yay!

Tue, Jul 14, 4:23 AM · Restricted Project
Szelethus added a comment to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..

I've seen you resurrecting the thread, I'll just take a bit of time to remember what happened in the previous episodes!

Tue, Jul 14, 3:57 AM · Restricted Project
Szelethus added a comment to D83701: [analyzer][tests] Add 5 more projects for testing.

Post-commit LGTM!

Tue, Jul 14, 1:45 AM · Restricted Project

Mon, Jul 13

Szelethus added inline comments to D83677: [analyzer] Rework Z3 requirements in the CSA testsuite.
Mon, Jul 13, 8:07 AM · Restricted Project
Szelethus added a comment to D83677: [analyzer] Rework Z3 requirements in the CSA testsuite.

I lack the confidence to accept this straight away, but the overall direction looks great. LGTM!

Mon, Jul 13, 8:07 AM · Restricted Project
Szelethus added a comment to D83678: [analyzer] Move ReturnPtrRange checker out of alpha by fixing a false positive on end() iterator.
Mon, Jul 13, 6:58 AM · Restricted Project
Szelethus added a comment to D83678: [analyzer] Move ReturnPtrRange checker out of alpha by fixing a false positive on end() iterator.

Please know that the criteria for moving checkers (or anything, really) out of alpha includes testing on open source code bases. Could you create a public CodeChecker link with some evaluations? How does this, if at all, interact with other alpha array bound checkers?

Mon, Jul 13, 6:56 AM · Restricted Project
Szelethus retitled D83678: [analyzer] Move ReturnPtrRange checker out of alpha by fixing a false positive on end() iterator from [analyzer] ReturnPtrRange checker false positive on end() iterator to [analyzer] Move ReturnPtrRange checker out of alpha by fixing a false positive on end() iterator.
Mon, Jul 13, 6:25 AM · Restricted Project
Szelethus added a project to D83678: [analyzer] Move ReturnPtrRange checker out of alpha by fixing a false positive on end() iterator: Restricted Project.
Mon, Jul 13, 6:24 AM · Restricted Project
Szelethus added inline comments to D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report..
Mon, Jul 13, 6:22 AM · Restricted Project
Szelethus added inline comments to D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report..
Mon, Jul 13, 6:21 AM · Restricted Project
Szelethus added a comment to D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling.

There is a parallel discussion in this patch on how we should cater to user requests, I wrote a lengthy comment about my opinion, but I just don't think it adds much -- at the end of the day, it is fair that if we implement an feature for a small subset of users that is known to cause unpleasant side effects, we shouldn't make it a part of the default user interface, because among many other things it inevitably forces other contributors to maintain it, even if they weren't enthusiastic about the idea, but its also fair to prioritize direct users within reason.

Mon, Jul 13, 5:43 AM · Restricted Project

Jul 10 2020

Szelethus added a comment to D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions.

I'm yet to go over line-by-line, but the overall logic looks great.

Jul 10 2020, 5:10 AM · Restricted Project
Szelethus added a comment to D78280: [Analyzer][StreamChecker] Track streams that were not found to be opened..

Its a bit hard to judge this. Have you tested this on open source projects?

Jul 10 2020, 4:33 AM · Restricted Project
Szelethus added a comment to D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption..

I don't have much to say here, this goes a bit outside my expertise. @NoQ?

Jul 10 2020, 4:31 AM · Restricted Project
Szelethus added reviewers for D83115: [Analyzer] Report every bug if only uniqueing location differs.: NoQ, vsavchenko, xazax.hun, martong.
Jul 10 2020, 4:29 AM · Restricted Project
Szelethus accepted D82845: [Analyzer][StreamChecker] Report every leak, clean up state..

I'd prefer if you moved f_leak_2 to stream-notes.c. Otherwise, LGTM.

Jul 10 2020, 4:17 AM · Restricted Project
Szelethus accepted D83120: [Analyzer][StreamChecker] Use BugType::SuppressOnSink at resource leak report..

LGTM! Though, the test file change is interesting. You could add a test that behaves differently from the previous implementation:

Jul 10 2020, 4:06 AM · Restricted Project
Szelethus added a comment to D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'..

We must check on every execution path that a specific condition on a value is satisfied (or: find one where the condition is not satisfied). This would be the most simple form of this checker. This can be done with the path sensitive check and checkDeadSymbols. If the symbol becomes dead with unsatisfied condition a warning is emitted. The "condition" is a syntactic-like check that looks for code like "X != EOF". This is probably done best by using StmtVisitor if a value is evaluated (at assignment or condition in if or other statements), different than the current form.

Jul 10 2020, 3:47 AM · Restricted Project

Jul 9 2020

Szelethus added inline comments to D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions.
Jul 9 2020, 7:42 AM · Restricted Project
Szelethus accepted D83295: [Analyzer] Hotfix for various crashes in iterator checkers.

LGTM, but if we knowingly a subpar solution, we should make that clear in the surrounding code. I know the followup patch is around the corner, but just to be sure.

Jul 9 2020, 7:36 AM · Restricted Project
Szelethus added inline comments to D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions.
Jul 9 2020, 6:59 AM · Restricted Project
Szelethus added a comment to D83475: [analyzer] Add CTUImportCppThreshold for C++ files.

I don't like this solution toooo much, but I respect the urgency, and since we don't introduce a compatibility issue, I trust we can remove this if we decide to change to TableGen. Post-commit LGTM!

Jul 9 2020, 6:42 AM · Restricted Project
Szelethus added inline comments to D83475: [analyzer] Add CTUImportCppThreshold for C++ files.
Jul 9 2020, 6:38 AM · Restricted Project
Szelethus added inline comments to D83295: [Analyzer] Hotfix for various crashes in iterator checkers.
Jul 9 2020, 6:22 AM · Restricted Project
Szelethus added a comment to D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'..

After reading @martong's comment D72705#2035844 and @balazske's comment D72705#2086994, I think there is a need to argue across all paths of execution within the function, and as such this is a dataflow problem.

Jul 9 2020, 5:05 AM · Restricted Project

Jul 6 2020

Szelethus added a comment to D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.
Jul 6 2020, 8:57 AM · Restricted Project
Szelethus added a comment to D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.

I'm on it!

Jul 6 2020, 8:31 AM · Restricted Project
Szelethus committed rGcfd6b4b811aa: [analyzer] Don't allow hidden checkers to emit diagnostics (authored by Szelethus).
[analyzer] Don't allow hidden checkers to emit diagnostics
Jul 6 2020, 6:35 AM
Szelethus closed D81750: [analyzer] Don't allow hidden checkers to emit diagnostics.
Jul 6 2020, 6:35 AM · Restricted Project
Szelethus committed rGb2956076976c: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics (authored by Szelethus).
[analyzer][NFC] Don't allow dependency checkers to emit diagnostics
Jul 6 2020, 5:52 AM
Szelethus closed D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics.
Jul 6 2020, 5:52 AM · Restricted Project
Szelethus committed rG690ff37a2869: [analyzer] Force dependency checkers to be hidden (authored by Szelethus).
[analyzer] Force dependency checkers to be hidden
Jul 6 2020, 4:07 AM
Szelethus closed D81761: [analyzer] Force dependency checkers to be hidden.
Jul 6 2020, 4:07 AM · Restricted Project
Szelethus accepted D81315: [analyzer] Warning for default constructed unique pointer dereferences.

LGTM! You packed a lot of punch into this patch, and I like it very much. I read the code and everything looks great. I nitpicked on one thing, the updateTrackedRegion function is a bit awkward, but if you place a TODO there, I'm happy to have that addressed in a later patch. I don't think this is reason to postpone the landing of this any further.

Jul 6 2020, 3:39 AM · Restricted Project

Jul 4 2020

Szelethus committed rGb6cbe6cb0399: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core… (authored by Szelethus).
[analyzer][NFC] Move the data structures from CheckerRegistry to the Core…
Jul 4 2020, 5:23 AM
Szelethus closed D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.
Jul 4 2020, 5:22 AM · Restricted Project

Jul 3 2020

Szelethus added a comment to D81059: [analyzer] CallDescriptionMap: Support CXXOperatorCallExpr.

Well said!

Jul 3 2020, 12:24 PM · Restricted Project
Szelethus added inline comments to D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.
Jul 3 2020, 5:53 AM · Restricted Project
Szelethus updated the diff for D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.

Small fixes according to reviewer comments.

Jul 3 2020, 5:53 AM · Restricted Project
Szelethus updated the summary of D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.
Jul 3 2020, 3:12 AM · Restricted Project

Jul 2 2020

Szelethus added a comment to D81059: [analyzer] CallDescriptionMap: Support CXXOperatorCallExpr.

Mind that Signature in StdLibraryFunctionsChecker aims to achieve precise function call matching as well, and at the moment its a bit ahead. Some discussions can be found in D77410, D81745 and https://bugs.llvm.org/show_bug.cgi?id=46253.

Jul 2 2020, 9:10 AM · Restricted Project
Szelethus added a comment to D81315: [analyzer] Warning for default constructed unique pointer dereferences.

I only looked at the checker naming issue, and that seems to have been resolved perfectly, thanks! :)

Jul 2 2020, 6:57 AM · Restricted Project

Jul 1 2020

Szelethus accepted D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions.

The changes proposed in mailing list thread (http://lists.llvm.org/pipermail/cfe-dev/2020-June/066017.html) seem ortogonal to this change. Sorry for the slack today, I just peeked around in MallocChecker to look for conflicts, but it seems like there isn't any :) LGTM!

Jul 1 2020, 7:00 AM · Restricted Project

Jun 30 2020

Szelethus added a comment to D82845: [Analyzer][StreamChecker] Report every leak, clean up state..

I checked it with simple debug print, the LeakedSyms will contain 2 items with different StreamOpenNode. So I think these should be independent problem reports for the bug reporter.

I wonder whether you can report two bugs on the same error node.

Jun 30 2020, 10:20 AM · Restricted Project
Szelethus added a comment to D82845: [Analyzer][StreamChecker] Report every leak, clean up state..

I checked it with simple debug print, the LeakedSyms will contain 2 items with different StreamOpenNode. So I think these should be independent problem reports for the bug reporter.

Jun 30 2020, 9:44 AM · Restricted Project
Szelethus updated the diff for D81761: [analyzer] Force dependency checkers to be hidden.

Revert changes to plugins and to the related tests, allow the example package to bypass the new restriction.

Jun 30 2020, 7:33 AM · Restricted Project
Szelethus added a comment to D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.

It looks like that the dependency manipulation and computation functions

Jun 30 2020, 7:00 AM · Restricted Project
Szelethus updated the diff for D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.

Fixes according to reviewer comments!

Jun 30 2020, 6:28 AM · Restricted Project
Szelethus added inline comments to D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library.
Jun 30 2020, 3:46 AM · Restricted Project
Szelethus added a comment to D82845: [Analyzer][StreamChecker] Report every leak, clean up state..

Why does this not work?
I get only warning for the first resource leak (in the test f_leak_2). How to fix this?

Jun 30 2020, 3:14 AM · Restricted Project

Jun 29 2020

Szelethus added inline comments to D81315: [analyzer] Warning for default constructed unique pointer dereferences.
Jun 29 2020, 9:10 AM · Restricted Project
Szelethus added a comment to D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.

Note to self: rename debug.DumpLiveStmts to debug.DumpLiveExprs. Thanks for the review btw! I don't immediately have something to add to your discussion though :)

Jun 29 2020, 5:54 AM · Restricted Project
Szelethus accepted D82741: [Analyzer][StreamChecker] Use BugType instead of BuiltinBug (NFC) ..

I just checked BuiltinBug -- why do we even have this??? Anyways, LGTM. We should probably delete the whole thing.

Jun 29 2020, 3:12 AM · Restricted Project

Jun 28 2020

Szelethus requested changes to D81315: [analyzer] Warning for default constructed unique pointer dereferences.

I have a few pending patches that enforce some long desired restrictions on which checkers can emit diagnostics, and I'd prefer not to mess with your checker after you land this :/

Jun 28 2020, 10:16 AM · Restricted Project
Szelethus updated the summary of D81750: [analyzer] Don't allow hidden checkers to emit diagnostics.
Jun 28 2020, 10:16 AM · Restricted Project

Jun 25 2020

Szelethus abandoned D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness.

This revision has done its job.

Jun 25 2020, 3:51 PM · Restricted Project
Szelethus accepted D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value.

Based on discussions I heard in between @dkrupp, @martong and You, this seems appropriate.

Jun 25 2020, 2:11 PM · Restricted Project