Page MenuHomePhabricator

balazske (Balázs Kéri)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
May 23 2018, 7:08 AM (151 w, 8 h)

Recent Activity

Today

balazske committed rGbda20282cb94: [clang-tidy] Add exception flag to bugprone-unhandled-exception-at-new test. (authored by balazske).
[clang-tidy] Add exception flag to bugprone-unhandled-exception-at-new test.
Wed, Apr 14, 12:50 AM
balazske committed rG530456caf908: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'. (authored by balazske).
[clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.
Wed, Apr 14, 12:24 AM
balazske closed D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Wed, Apr 14, 12:24 AM · Restricted Project, Restricted Project

Yesterday

balazske updated the diff for D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

Add another test.

Tue, Apr 13, 11:33 PM · Restricted Project, Restricted Project
balazske added inline comments to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Tue, Apr 13, 3:49 AM · Restricted Project, Restricted Project
balazske added inline comments to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Tue, Apr 13, 2:43 AM · Restricted Project, Restricted Project
balazske updated the diff for D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

Rebase, changed documentation, small fix in the code, more tests added.

Tue, Apr 13, 2:42 AM · Restricted Project, Restricted Project

Mon, Apr 12

balazske added a comment to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

Ping.
The check now handles only check of allocation failure at new.

Mon, Apr 12, 3:31 AM · Restricted Project, Restricted Project
balazske added inline comments to D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..
Mon, Apr 12, 12:34 AM · Restricted Project
balazske committed rG6e5199104914: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType. (authored by balazske).
[clang][AST] Handle overload callee type in CallExpr::getCallReturnType.
Mon, Apr 12, 12:33 AM
balazske closed D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..
Mon, Apr 12, 12:33 AM · Restricted Project

Fri, Apr 9

balazske updated subscribers of D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain.

I think call stack may be useful for other checks too. May be code should be moved to utilities?

Fri, Apr 9, 7:14 AM · Restricted Project, Restricted Project
balazske updated the summary of D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..
Fri, Apr 9, 1:04 AM · Restricted Project
balazske added inline comments to D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..
Fri, Apr 9, 1:01 AM · Restricted Project
balazske updated the diff for D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..

Rebase, changed test according to review comments.

Fri, Apr 9, 12:59 AM · Restricted Project

Wed, Apr 7

balazske updated the diff for D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

Fix a crash, update documentation.

Wed, Apr 7, 2:47 AM · Restricted Project, Restricted Project

Tue, Apr 6

balazske added a comment to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

Rename the check to "unhandled-bad_alloc" (or similar")? And the error message to " missing exception handler 'std::bad_alloc' "?

Tue, Apr 6, 7:19 AM · Restricted Project, Restricted Project
balazske updated the diff for D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

Removed check of possible exceptions from constructor call.

Tue, Apr 6, 7:14 AM · Restricted Project, Restricted Project
balazske committed rGbee4813789a3: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol. (authored by balazske).
[clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol.
Tue, Apr 6, 2:05 AM
balazske closed D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol..
Tue, Apr 6, 2:04 AM · Restricted Project

Thu, Apr 1

balazske added a reviewer for D99714: [clang][Analyzer] Handle flexible arrays better in ArrayBoundV2 checker.: steakhal.
Thu, Apr 1, 6:10 AM · Restricted Project
balazske added a comment to D99714: [clang][Analyzer] Handle flexible arrays better in ArrayBoundV2 checker..

It works not reliable for all data types. If char is used instead of int (in the test), the allocated size may be larger than the intended size of the array, probably because memory alignment adjustments. In the following case it is possible to index "past the end" of the array for some first indices (until 12?).

struct S {
  int n;
  char x;
  char s[];
};
struct S *s = (struct S *)malloc(sizeof(struct S) + 10);
s.s[12] = 12;
Thu, Apr 1, 6:07 AM · Restricted Project
balazske requested review of D99714: [clang][Analyzer] Handle flexible arrays better in ArrayBoundV2 checker..
Thu, Apr 1, 3:22 AM · Restricted Project
balazske committed rGdf4fa53fddb6: [clang][Checkers] Extend PthreadLockChecker state dump (NFC). (authored by balazske).
[clang][Checkers] Extend PthreadLockChecker state dump (NFC).
Thu, Apr 1, 2:49 AM
balazske closed D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..
Thu, Apr 1, 2:48 AM · Restricted Project
balazske updated the diff for D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..

Add 'core' to enabled checks in test.

Thu, Apr 1, 1:56 AM · Restricted Project
balazske updated the diff for D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..

Split the test file.

Thu, Apr 1, 12:51 AM · Restricted Project
balazske reopened D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..

Test should be updated.

Thu, Apr 1, 12:50 AM · Restricted Project

Wed, Mar 31

balazske added a comment to D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..

Test failures occurred, fix of the problem is not trivial, probably the test file should be split.

Wed, Mar 31, 6:21 AM · Restricted Project
balazske added a reverting change for rG49c0ab6d7611: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).: rGffcb4b43b799: Revert "[clang][Checkers] Extend PthreadLockChecker state dump (NFC).".
Wed, Mar 31, 6:19 AM
balazske committed rGffcb4b43b799: Revert "[clang][Checkers] Extend PthreadLockChecker state dump (NFC)." (authored by balazske).
Revert "[clang][Checkers] Extend PthreadLockChecker state dump (NFC)."
Wed, Mar 31, 6:19 AM
balazske added a reverting change for D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).: rGffcb4b43b799: Revert "[clang][Checkers] Extend PthreadLockChecker state dump (NFC).".
Wed, Mar 31, 6:19 AM · Restricted Project
balazske added inline comments to D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..
Wed, Mar 31, 5:36 AM · Restricted Project
balazske committed rG49c0ab6d7611: [clang][Checkers] Extend PthreadLockChecker state dump (NFC). (authored by balazske).
[clang][Checkers] Extend PthreadLockChecker state dump (NFC).
Wed, Mar 31, 2:09 AM
balazske closed D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..
Wed, Mar 31, 2:09 AM · Restricted Project

Tue, Mar 30

balazske updated the diff for D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

Use mayThrow, improve test (user and class-specific cases).

Tue, Mar 30, 7:03 AM · Restricted Project, Restricted Project
balazske added inline comments to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Tue, Mar 30, 3:47 AM · Restricted Project, Restricted Project

Mon, Mar 29

balazske added inline comments to D99421: [ASTImporter] Import member specialization/instantiation of enum decls.
Mon, Mar 29, 6:45 AM · Restricted Project
balazske added a comment to D99348: [ASTImporter] Add ability to convert CXXRecordDecls to RecordDecls when importing to C language TUs.

My idea was that if we have an already existing C AST then the mode of it could be changed to C++, without changing other nodes. Then it is possible to import C++ nodes.
For ASTConverter, I think about something similar to ASTImporter, but the To AST is always empty at start and one correct From AST can be imported into it. This "import" performs the conversion and build of AST nodes. This converted AST can then be processed with normal ASTImporter.

Mon, Mar 29, 3:22 AM · Restricted Project
balazske added a comment to D99348: [ASTImporter] Add ability to convert CXXRecordDecls to RecordDecls when importing to C language TUs.

I did not mean to reuse ASTImporter, that is a possibility too. Probably it can be more easy to handle AST conversion only without importing, specially if during the conversion no kind of error can occur, so no error handling or ODR search are needed. The conversion can happen before doing the AST import (with converted AST).

Mon, Mar 29, 2:13 AM · Restricted Project

Fri, Mar 26

balazske added inline comments to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Fri, Mar 26, 9:31 AM · Restricted Project, Restricted Project
balazske added a comment to D99348: [ASTImporter] Add ability to convert CXXRecordDecls to RecordDecls when importing to C language TUs.

I think it would be better to have a fully new module for converting AST between language versions. It would do only conversion, not AST merge. The ASTImporter is already too large and complicated (should be split into files) code, with this conversion logic embedded into other import functions and with multiple language versions (in the future) it would be really hard to debug (number of special cases at import increases and is already big).

Fri, Mar 26, 1:01 AM · Restricted Project

Wed, Mar 24

balazske committed rGf6cdb2c0a714: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType. (authored by balazske).
[clang][ASTImporter] Add import of DeducedTemplateSpecializationType.
Wed, Mar 24, 1:33 AM
balazske closed D99188: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType..
Wed, Mar 24, 1:33 AM · Restricted Project

Tue, Mar 23

balazske added a comment to D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..

Ping.
I am not sure how to the test should be changed.

Tue, Mar 23, 8:50 AM · Restricted Project
balazske updated the diff for D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..

Fixed according to the comments.

Tue, Mar 23, 8:42 AM · Restricted Project
balazske requested review of D99188: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType..
Tue, Mar 23, 7:32 AM · Restricted Project
balazske committed rG3cde27bc563c: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl. (authored by balazske).
[clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.
Tue, Mar 23, 1:45 AM
balazske closed D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl..
Tue, Mar 23, 1:44 AM · Restricted Project
balazske updated the diff for D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl..

Rebase and changed test code format.

Tue, Mar 23, 12:58 AM · Restricted Project

Mon, Mar 22

balazske updated the diff for D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..

Simplified the test somewhat.

Mon, Mar 22, 8:16 AM · Restricted Project
balazske committed rGce9bade1f2c6: [clang][ASTImporter] Add import API for 'const Type *' (NFC). (authored by balazske).
[clang][ASTImporter] Add import API for 'const Type *' (NFC).
Mon, Mar 22, 6:28 AM
balazske closed D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC)..
Mon, Mar 22, 6:28 AM · Restricted Project
balazske added inline comments to D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..
Mon, Mar 22, 4:58 AM · Restricted Project
balazske updated the diff for D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..

Add regular expression to test, removed space characters from line endings.

Mon, Mar 22, 4:56 AM · Restricted Project
balazske added a reviewer for D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.: teemperor.
Mon, Mar 22, 3:11 AM · Restricted Project
balazske added a comment to D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC)..

Can we add a test for the getCapturedVLAType case?

Mon, Mar 22, 3:10 AM · Restricted Project
balazske requested review of D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl..
Mon, Mar 22, 3:09 AM · Restricted Project

Fri, Mar 19

balazske committed rG96e675bdd5c8: [clang][ASTImporter] Add import support for SourceLocExpr. (authored by balazske).
[clang][ASTImporter] Add import support for SourceLocExpr.
Fri, Mar 19, 8:23 AM
balazske closed D98876: [clang][ASTImporter] Add import support for SourceLocExpr..
Fri, Mar 19, 8:23 AM · Restricted Project
balazske retitled D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC). from [clang][ASTImporter] Add import API for 'const Type *'. to [clang][ASTImporter] Add import API for 'const Type *' (NFC)..
Fri, Mar 19, 7:56 AM · Restricted Project
balazske requested review of D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC)..
Fri, Mar 19, 7:49 AM · Restricted Project

Thu, Mar 18

balazske requested review of D98876: [clang][ASTImporter] Add import support for SourceLocExpr..
Thu, Mar 18, 10:06 AM · Restricted Project
balazske updated the diff for D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..

Add accidentally removed empty line.

Thu, Mar 18, 1:39 AM · Restricted Project
balazske updated the diff for D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..

Change of text in dump, add a test.

Thu, Mar 18, 1:36 AM · Restricted Project
balazske accepted D98707: [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec.
Thu, Mar 18, 12:29 AM · Restricted Project

Wed, Mar 17

balazske added a comment to D98707: [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec.

I did not notice that ImportVariables is different than ImportDecl, I like the first version of the test better (with ImportDecl) (but the current is not wrong), can you change it back only at a different position (line 738 can be good, before test "ImportRecordTypeInFunc")?

Wed, Mar 17, 9:14 AM · Restricted Project
balazske added inline comments to D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..
Wed, Mar 17, 1:31 AM · Restricted Project

Tue, Mar 16

balazske added a comment to D98707: [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec.

Looks good, just find a better place for the test.

Tue, Mar 16, 8:05 AM · Restricted Project
balazske added a comment to D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol..

Exactly the case is (I think) that the mutex goes out of scope and we have not checked if it was really destroyed. Still the program can check later if it was destroyed (like the if in the test case). A resource leak may be the problem (if destroy failed) so a warning like "possible resource leak if destroy call fails" can be added to the pthread_mutex_destroy call.

Tue, Mar 16, 1:08 AM · Restricted Project
balazske added reviewers for D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).: NoQ, ASDenysPetrov.

This patch makes one TODO less and it is possible to debug cases like in the next (in stack) change.

Tue, Mar 16, 12:44 AM · Restricted Project
balazske added inline comments to D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..
Tue, Mar 16, 12:32 AM · Restricted Project

Mar 12 2021

balazske retitled D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol. from [clang][Checkers] Fix state cleanup at dead symbol. to [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol..
Mar 12 2021, 7:27 AM · Restricted Project
balazske updated the diff for D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol..

Improved commit message.

Mar 12 2021, 7:17 AM · Restricted Project
balazske requested review of D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol..
Mar 12 2021, 7:10 AM · Restricted Project
balazske requested review of D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC)..
Mar 12 2021, 6:32 AM · Restricted Project

Mar 10 2021

balazske updated the diff for D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..

rebase, split the test case

Mar 10 2021, 6:29 AM · Restricted Project

Mar 9 2021

balazske added a comment to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

Ping.

Mar 9 2021, 3:49 AM · Restricted Project, Restricted Project

Mar 8 2021

balazske added reviewers for D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain: aaron.ballman, njames93, Eugene.Zelenko, alexfh.
Mar 8 2021, 9:03 AM · Restricted Project, Restricted Project
balazske updated the diff for D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain.

Adding test of notes.
Tests are re-arranged significantly.

Mar 8 2021, 7:51 AM · Restricted Project, Restricted Project

Mar 5 2021

balazske added a comment to D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain.

I tried to test the notes but could not get it to work. I think the problem is related to the fact that the notes are displayed at different locations that are past or before the current warning. The solution could be to manually specify line numbers in the CHECK-NOTE parts but I do not like this (and did not tried it). Or is there other solution?

Mar 5 2021, 7:01 AM · Restricted Project, Restricted Project

Mar 4 2021

balazske added a comment to D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..

Ping.

Mar 4 2021, 8:59 AM · Restricted Project
balazske requested review of D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain.
Mar 4 2021, 8:53 AM · Restricted Project, Restricted Project

Mar 2 2021

balazske added a reviewer for D91164: [clang-tidy] Improve C++ support in bugprone-signal-handler.: jfb.
Mar 2 2021, 2:17 AM · Restricted Project, Restricted Project
balazske added inline comments to D91164: [clang-tidy] Improve C++ support in bugprone-signal-handler..
Mar 2 2021, 1:05 AM · Restricted Project, Restricted Project

Mar 1 2021

balazske added reviewers for D91164: [clang-tidy] Improve C++ support in bugprone-signal-handler.: alexfh, aaron.ballman, hokein, njames93.
Mar 1 2021, 7:40 AM · Restricted Project, Restricted Project
balazske abandoned D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'..

Checks about code formatting are likely not to be accepted. Formatting can be done in external tool and is not subject for checks. The difference is that it is not possible to format separately for one rule only (with clang-format). But the better option should be to format the whole code instead of parts of it.

Mar 1 2021, 4:02 AM · Restricted Project, Restricted Project

Feb 26 2021

balazske updated the diff for D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..

Rebase, fixes according to review comments.

Feb 26 2021, 3:20 AM · Restricted Project, Restricted Project
balazske added a comment to D97361: [clang-tidy] Add readability-redundant-using check.

There should be already a name lookup implemented somewhere in clang (DeclContext? or Sema) that maybe usable here (check if the name of the "used" entity is visible in the declaration context of the using statement). Probably it is not as simple to do because the using is already there and it may depend on the order.

Feb 26 2021, 12:53 AM · Restricted Project, Restricted Project
balazske added a comment to D97361: [clang-tidy] Add readability-redundant-using check.

You can look into misc/UnusedUsingDeclsCheck.cpp (if not done yet), that check handles using too. And that check is related to this check, the module should be the same too (misc)?

Feb 26 2021, 12:48 AM · Restricted Project, Restricted Project

Feb 25 2021

balazske added inline comments to D97361: [clang-tidy] Add readability-redundant-using check.
Feb 25 2021, 5:57 AM · Restricted Project, Restricted Project

Feb 23 2021

balazske committed rG2c54b293373c: [clang-tidy] Extending bugprone-signal-handler with POSIX functions. (authored by balazske).
[clang-tidy] Extending bugprone-signal-handler with POSIX functions.
Feb 23 2021, 5:38 AM
balazske closed D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions..
Feb 23 2021, 5:38 AM · Restricted Project, Restricted Project

Feb 22 2021

balazske updated the diff for D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions..

Rebase, improved documentation.

Feb 22 2021, 8:24 AM · Restricted Project, Restricted Project
balazske added a comment to D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType..

Ping

Feb 22 2021, 7:59 AM · Restricted Project
balazske requested review of D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Feb 22 2021, 7:57 AM · Restricted Project, Restricted Project
balazske committed rG7dc7f0c2ecc0: [clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and… (authored by balazske).
[clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and…
Feb 22 2021, 3:33 AM
balazske closed D96719: [clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and alias 'cert-pos47-c'..
Feb 22 2021, 3:32 AM · Restricted Project, Restricted Project

Feb 19 2021

balazske retitled D96719: [clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and alias 'cert-pos47-c'. from [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'. to [clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and alias 'cert-pos47-c'..
Feb 19 2021, 5:49 AM · Restricted Project, Restricted Project

Feb 18 2021

balazske updated the diff for D96719: [clang-tidy] Add new check 'concurrency-thread-canceltype-asynchronous' and alias 'cert-pos47-c'..
  • Fixed remaining formatting and rename problems.
  • Removed tryExpandAsInteger, use matcher instead.
  • Improved test.
Feb 18 2021, 7:26 AM · Restricted Project, Restricted Project