Page MenuHomePhabricator

[PowerPC][Clang] Remove QPX support
ClosedPublic

Authored by jsji on Nov 30 2020, 8:30 AM.

Details

Reviewers
jdoerfert
qiucf
steven.zhang
Group Reviewers
Restricted Project
Commits
rGb49b8f096c03: [PowerPC][Clang] Remove QPX support
Summary

Clean up QPX code in clang missed in https://reviews.llvm.org/D83915

Diff Detail

Event Timeline

jsji created this revision.Nov 30 2020, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2020, 8:30 AM
jsji requested review of this revision.Nov 30 2020, 8:30 AM
jsji added reviewers: Restricted Project, qiucf, qshanz.Nov 30 2020, 8:31 AM
jsji edited reviewers, added: steven.zhang; removed: qshanz.
qiucf added a comment.Nov 30 2020, 8:44 AM

Another small place also needs remove? (but not related to clang)

llvm/test/Transforms/LoopVectorize/PowerPC/vectorize-only-for-real.ll:

attributes #0 = { nounwind "target-cpu"="a2q" "target-features"="+qpx,-altivec,-bpermd,-crypto,-direct-move,-extdiv,-power8-vector,-vsx" }
attributes #1 = { argmemonly nounwind }
attributes #2 = { "target-cpu"="a2q" "target-features"="+qpx,-altivec,-bpermd,-crypto,-direct-move,-extdiv,-power8-vector,-vsx" }
attributes #3 = { nounwind }
jsji updated this revision to Diff 308405.Nov 30 2020, 9:34 AM

Fix llvm test as well

Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2020, 9:34 AM
steven.zhang accepted this revision.Dec 6 2020, 5:26 PM

LGTM as I grep the whole repo with this patch applied, no QPX any more.

This revision is now accepted and ready to land.Dec 6 2020, 5:26 PM
This revision was automatically updated to reflect the committed changes.