Page MenuHomePhabricator

qiucf (Qiu Chaofan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 3 2019, 9:30 PM (98 w, 4 d)

I'm identical to @ecnelises .

Recent Activity

Yesterday

qiucf committed rG449f2f7140e1: [PowerPC] Duplicate inherited heuristic from base scheduler (authored by qiucf).
[PowerPC] Duplicate inherited heuristic from base scheduler
Thu, Jan 21, 6:11 PM
qiucf closed D94464: [PowerPC] Duplicate inherited heuristic from base scheduler.
Thu, Jan 21, 6:11 PM · Restricted Project

Mon, Jan 18

qiucf added reviewers for D94898: [llvm-exegesis] Ignore instructions using custom inserter: nemanjai, Restricted Project, steven.zhang.
Mon, Jan 18, 1:48 AM · Restricted Project
qiucf requested review of D94898: [llvm-exegesis] Ignore instructions using custom inserter.
Mon, Jan 18, 1:48 AM · Restricted Project
qiucf requested review of D94897: [llvm-exegesis] [PowerPC] Add basic LIT test.
Mon, Jan 18, 1:27 AM · Restricted Project

Sun, Jan 17

qiucf committed rGf776d8b12f0e: [Legalizer] Promote result type in expanding FP_TO_XINT (authored by qiucf).
[Legalizer] Promote result type in expanding FP_TO_XINT
Sun, Jan 17, 7:57 PM
qiucf closed D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.
Sun, Jan 17, 7:57 PM · Restricted Project
qiucf committed rG2d9890775f52: [PowerPC] [NFC] Add AIX triple to some regression tests (authored by qiucf).
[PowerPC] [NFC] Add AIX triple to some regression tests
Sun, Jan 17, 7:45 PM
qiucf closed D94159: [PowerPC] [NFC] Add AIX triple to some regression tests.
Sun, Jan 17, 7:45 PM · Restricted Project
qiucf added a comment to D94282: [PowerPC] Support ppc-asm-full-reg-names for AIX.

Historically, the letter prefixes were always stripped out because AIX and Linux assemblers don't accept them. The mentioned patch added the ability to produce prefixes with percent sign and letter which is actually accepted by the Linux assembler (GNU as). It was thought (not known) at the time that AIX does not accept this %<letter> syntax either so the guard for AIX was kept. If you can confirm that the AIX system assembler accepts this syntax, then this is fine.

I suppose it is fine either way since we never took the extra step of making -ppc-reg-with-percent-prefix the default, but if we do choose to make that the default at some point, we can only do so if the AIX assembler also supports it.

Sun, Jan 17, 7:28 PM · Restricted Project

Fri, Jan 15

qiucf committed rG168be4208304: [Clang] Mutate long-double math builtins into f128 under IEEE-quad (authored by qiucf).
[Clang] Mutate long-double math builtins into f128 under IEEE-quad
Fri, Jan 15, 12:57 AM
qiucf closed D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad.
Fri, Jan 15, 12:56 AM · Restricted Project

Thu, Jan 14

qiucf added inline comments to D94211: [NFC][PowerPC] Format and clean the logic for setOperationActions to make it easier to maintain.
Thu, Jan 14, 8:11 AM · Restricted Project

Wed, Jan 13

qiucf added a comment to D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad.

Ping..

Wed, Jan 13, 10:41 PM · Restricted Project

Tue, Jan 12

qiucf added a comment to D94159: [PowerPC] [NFC] Add AIX triple to some regression tests.

It surprises to me that you didn't see the difference between LE and AIX, which doesn't make sense to me. Please double confirm to see if there is any conflict when update the test with the script.

Tue, Jan 12, 1:44 AM · Restricted Project

Mon, Jan 11

qiucf requested review of D94467: [PowerPC] Use mtvsrdd+vpku instructions to optimize build_vector.
Mon, Jan 11, 9:24 PM · Restricted Project
qiucf updated the diff for D94159: [PowerPC] [NFC] Add AIX triple to some regression tests.

Rebase after rG6175fcf01f17e0bd1155aaaba977b9baa88ee61d and rG7200d2cf0891ef56607fd0336029b33bd4097eed

Mon, Jan 11, 7:33 PM · Restricted Project
qiucf requested review of D94464: [PowerPC] Duplicate inherited heuristic from base scheduler.
Mon, Jan 11, 7:19 PM · Restricted Project
qiucf added a comment to D94449: [PowerPC][NFCI] PassSubtarget to ASMWriter.

This looks like an NFC change?

Mon, Jan 11, 5:52 PM · Restricted Project

Sun, Jan 10

qiucf updated the diff for D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.

Assert target type is simple

Sun, Jan 10, 7:47 PM · Restricted Project

Fri, Jan 8

qiucf committed rG6175fcf01f17: [NFC] Update some PPC tests marked as auto-generated (authored by qiucf).
[NFC] Update some PPC tests marked as auto-generated
Fri, Jan 8, 1:59 AM

Thu, Jan 7

qiucf requested review of D94282: [PowerPC] Support ppc-asm-full-reg-names for AIX.
Thu, Jan 7, 7:14 PM · Restricted Project
qiucf added a comment to D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel..
Thu, Jan 7, 8:10 AM · Restricted Project
qiucf added inline comments to D94211: [NFC][PowerPC] Format and clean the logic for setOperationActions to make it easier to maintain.
Thu, Jan 7, 1:49 AM · Restricted Project
qiucf added a comment to D94211: [NFC][PowerPC] Format and clean the logic for setOperationActions to make it easier to maintain.

Maybe better to add some comments before each section? Like D78132 or X86ISelLowering.

Thu, Jan 7, 12:13 AM · Restricted Project

Tue, Jan 5

qiucf requested review of D94159: [PowerPC] [NFC] Add AIX triple to some regression tests.
Tue, Jan 5, 11:58 PM · Restricted Project

Mon, Jan 4

qiucf committed rGb6c8feb29fce: [NFC] [PowerPC] Remove dead code in BUILD_VECTOR peephole (authored by qiucf).
[NFC] [PowerPC] Remove dead code in BUILD_VECTOR peephole
Mon, Jan 4, 7:36 PM
qiucf closed D93937: [PowerPC] [NFC] Remove dead code in BUILD_VECTOR peephole.
Mon, Jan 4, 7:36 PM · Restricted Project
qiucf added inline comments to D93937: [PowerPC] [NFC] Remove dead code in BUILD_VECTOR peephole.
Mon, Jan 4, 7:30 PM · Restricted Project
qiucf committed rG48340fbe6a1a: [NFC] [PowerPC] Update vec_constants test to reflect more patterns (authored by qiucf).
[NFC] [PowerPC] Update vec_constants test to reflect more patterns
Mon, Jan 4, 7:29 PM
qiucf committed rGae6148516313: [UpdateTestChecks] Fix PowerPC RE to support AIX assembly (authored by qiucf).
[UpdateTestChecks] Fix PowerPC RE to support AIX assembly
Mon, Jan 4, 6:28 PM
qiucf closed D93676: [UpdateTestChecks] Fix PowerPC RE to support AIX assembly.
Mon, Jan 4, 6:28 PM · Restricted Project

Tue, Dec 29

qiucf requested review of D93937: [PowerPC] [NFC] Remove dead code in BUILD_VECTOR peephole.
Tue, Dec 29, 11:47 PM · Restricted Project
qiucf updated the diff for D93676: [UpdateTestChecks] Fix PowerPC RE to support AIX assembly.

Update with tests

Tue, Dec 29, 9:42 PM · Restricted Project
qiucf added a comment to D71287: [PowerPC] Use fcti[dw] instructions in additional cases.

As I see, this patch tries to extend use of fcti* instructions into subtargets without direct-move. If so, this looks reasonable, but needs change/rebase since D81537 did refactor in this part conflicting with this.

Tue, Dec 29, 7:30 PM · Restricted Project

Mon, Dec 28

qiucf updated the diff for D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.

Rename findConversionLibcall.

Mon, Dec 28, 6:45 PM · Restricted Project
qiucf added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Mon, Dec 28, 1:12 AM · Restricted Project
qiucf updated the diff for D93377: [Clang] Add __ibm128 type to represent ppc_fp128.

Address comments and add tests

Mon, Dec 28, 1:12 AM · Restricted Project

Dec 22 2020

qiucf requested review of D93676: [UpdateTestChecks] Fix PowerPC RE to support AIX assembly.
Dec 22 2020, 1:38 AM · Restricted Project

Dec 21 2020

qiucf updated the diff for D92815: [PowerPC] [Clang] Enable float128 feature on Altivec targets.

Align with Altivec targets.

Dec 21 2020, 9:15 PM

Dec 17 2020

qiucf added a comment to D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.

Gentle ping

Dec 17 2020, 9:35 PM · Restricted Project

Dec 16 2020

qiucf added a reviewer for D90349: [DAGCombiner] Improve shift by select of constant: Restricted Project.
Dec 16 2020, 11:40 PM · Restricted Project
qiucf added a comment to D91053: [PowerPC] Lump the constants to save one addis for each constant access.

If there is only one constant, we will have one extra load with this patch. But the load could be optimized by linker if it merges the TOC. It is not easy inside compiler to handle it as ISEL is done basing on per BB, and we don't know if there are other constants until other BBs are selected. Any thoughts ?

Dec 16 2020, 10:52 PM · Restricted Project
qiucf edited reviewers for D92156: [PowerPC] Add support for "tlbiel" with two arguments, added: steven.zhang; removed: qshanz.
Dec 16 2020, 10:29 PM · Restricted Project
qiucf added a comment to D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad.

D91675 has PowerPC only changes to make the f128 calls get emitted. If you change the frontend in a target independent way as proposed here, won't that make the frontend and backend not match for targets like X86?

Dec 16 2020, 1:25 AM · Restricted Project
qiucf updated the diff for D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad.
  • Diff based on pre-commit
  • Restrict to PPC64
Dec 16 2020, 1:23 AM · Restricted Project
qiucf committed rGf141d1afc506: [NFC] Pre-commit test for long-double builtins (authored by qiucf).
[NFC] Pre-commit test for long-double builtins
Dec 16 2020, 1:21 AM

Dec 15 2020

qiucf requested review of D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Dec 15 2020, 11:54 PM · Restricted Project

Dec 14 2020

qiucf committed rG38b444219869: [NFC] [Legalizer] Use common method for expanding fp-to-int operands (authored by qiucf).
[NFC] [Legalizer] Use common method for expanding fp-to-int operands
Dec 14 2020, 6:46 PM
qiucf closed D92481: [NFC] [Legalizer] Use common method for expanding fp-to-int operands.
Dec 14 2020, 6:46 PM · Restricted Project

Dec 11 2020

qiucf added a comment to D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad.

I don't think I understand the whole picture here. Why would only builtins get mutated? Does a call to "modf" still call "modf"? But builtin_modf will call modf128? Is there a corresponding patch to the runtime libcalls table in the backend? With -ffast-math builtin_sinl becomes llvm.sin.f128 and the backend will emit a call to sinl if ISD::SIN isn't legal.

Dec 11 2020, 1:20 AM · Restricted Project

Dec 8 2020

qiucf added inline comments to D92815: [PowerPC] [Clang] Enable float128 feature on Altivec targets.
Dec 8 2020, 7:43 PM

Dec 7 2020

qiucf committed rG92160b23f5e0: [NFC] [PowerPC] Move i1-to-fp tests and use script (authored by qiucf).
[NFC] [PowerPC] Move i1-to-fp tests and use script
Dec 7 2020, 11:22 PM
qiucf committed rG5e85a2ba1645: [PowerPC] Implement intrinsic for DARN instruction (authored by qiucf).
[PowerPC] Implement intrinsic for DARN instruction
Dec 7 2020, 10:14 PM
qiucf closed D92465: [PowerPC] Implement intrinsic for DARN instruction.
Dec 7 2020, 10:13 PM · Restricted Project, Restricted Project
qiucf requested review of D92815: [PowerPC] [Clang] Enable float128 feature on Altivec targets.
Dec 7 2020, 9:54 PM
qiucf added a comment to D92465: [PowerPC] Implement intrinsic for DARN instruction.

LGTM.

Dec 7 2020, 6:19 PM · Restricted Project, Restricted Project
qiucf committed rG6bf29dbb1541: [PowerPC] [Clang] Enable float128 feature on P9 by default (authored by qiucf).
[PowerPC] [Clang] Enable float128 feature on P9 by default
Dec 7 2020, 2:39 AM
qiucf closed D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default.
Dec 7 2020, 2:38 AM · Restricted Project
qiucf added a comment to D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default.

Ping..

Dec 7 2020, 12:34 AM · Restricted Project

Dec 6 2020

qiucf committed rGefdd4630507e: [PowerPC] Fix chain for i1-to-fp operation (authored by qiucf).
[PowerPC] Fix chain for i1-to-fp operation
Dec 6 2020, 6:43 PM
qiucf closed D92365: [PowerPC] Fix chain for i1-to-fp operation.
Dec 6 2020, 6:42 PM · Restricted Project
qiucf added inline comments to D92365: [PowerPC] Fix chain for i1-to-fp operation.
Dec 6 2020, 6:33 PM · Restricted Project
qiucf accepted D91675: [PowerPC][FP128] Fix the incorrect signature for math library call.

LGTM. Thanks for the fix.

Dec 6 2020, 6:27 PM · Restricted Project

Dec 3 2020

qiucf committed rG9378a366b2b2: [NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen (authored by qiucf).
[NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen
Dec 3 2020, 7:30 PM
qiucf closed D92544: [NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen.
Dec 3 2020, 7:30 PM · Restricted Project
qiucf added a comment to D92544: [NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen.

Thanks!

Dec 3 2020, 7:29 PM · Restricted Project
qiucf added a comment to D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad.

Any comments...? I don't have knowledge if there's any plan about implementing *f128 math functions on X86 libcs. But as I see so far, *l doesn't work well on fp128. Keeping this target independent currently seems reasonable to me.

Dec 3 2020, 7:27 PM · Restricted Project

Dec 2 2020

qiucf updated the diff for D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.

Update comments and call findConversionLibcall outside assert.

Dec 2 2020, 11:37 PM · Restricted Project
qiucf added inline comments to D92278: [Clang] Don't adjust align for IBM extended double type.
Dec 2 2020, 11:16 PM · Restricted Project
qiucf added reviewers for D92544: [NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen: MaskRay, hubert.reinterpretcast.
Dec 2 2020, 11:13 PM · Restricted Project
qiucf requested review of D92544: [NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen.
Dec 2 2020, 11:13 PM · Restricted Project
qiucf added inline comments to D92278: [Clang] Don't adjust align for IBM extended double type.
Dec 2 2020, 6:54 PM · Restricted Project
qiucf committed rG222da77a82d1: [NFC] [Clang] Move ppc64le f128 vaargs OpenMP test (authored by qiucf).
[NFC] [Clang] Move ppc64le f128 vaargs OpenMP test
Dec 2 2020, 6:53 PM
qiucf updated the diff for D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.

Split the common methods stuff into another revision. Rebase this upon D92481.

Dec 2 2020, 6:55 AM · Restricted Project
qiucf requested review of D92481: [NFC] [Legalizer] Use common method for expanding fp-to-int operands.
Dec 2 2020, 6:55 AM · Restricted Project
qiucf updated the diff for D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.

Fix type bug

Dec 2 2020, 3:41 AM · Restricted Project
qiucf requested review of D92473: [Legalizer] Promote result type in expanding FP_TO_XINT.
Dec 2 2020, 3:40 AM · Restricted Project
qiucf planned changes to D71983: [PowerPC] Set the SideEffects of branch & call instructions from 1 to 0.
Dec 2 2020, 1:17 AM · Restricted Project
qiucf committed rGffa2dce59070: [PowerPC] Fix FLT_ROUNDS_ on little endian (authored by qiucf).
[PowerPC] Fix FLT_ROUNDS_ on little endian
Dec 2 2020, 1:17 AM
qiucf closed D91845: [PowerPC] Fix FLT_ROUNDS_ on little endian.
Dec 2 2020, 1:17 AM · Restricted Project
qiucf added a comment to D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types.

The regression should be fixed in rG3fca6a7844b5

Dec 2 2020, 1:05 AM · Restricted Project
qiucf committed rG3fca6a7844b5: [Clang] Don't adjust align for IBM extended double (authored by qiucf).
[Clang] Don't adjust align for IBM extended double
Dec 2 2020, 1:05 AM
qiucf closed D92278: [Clang] Don't adjust align for IBM extended double type.
Dec 2 2020, 1:05 AM · Restricted Project
qiucf updated the diff for D91845: [PowerPC] Fix FLT_ROUNDS_ on little endian.

Address comments

Dec 2 2020, 12:02 AM · Restricted Project

Dec 1 2020

qiucf requested review of D92465: [PowerPC] Implement intrinsic for DARN instruction.
Dec 1 2020, 11:47 PM · Restricted Project, Restricted Project
qiucf updated the diff for D92278: [Clang] Don't adjust align for IBM extended double type.

Address comments

  • Update comment to refer to ABI
  • Add test case for OpenMP host & target mismatch
Dec 1 2020, 9:03 PM · Restricted Project
qiucf added a reviewer for D92445: [PowerPC] Enable OpenMP for powerpcle target. [5/5]: nemanjai.
Dec 1 2020, 6:53 PM · Restricted Project, Restricted Project, Restricted Project

Nov 30 2020

qiucf requested review of D92365: [PowerPC] Fix chain for i1-to-fp operation.
Nov 30 2020, 10:24 PM · Restricted Project
qiucf added a comment to D92329: [PowerPC][Clang] Remove QPX support.

Another small place also needs remove? (but not related to clang)

Nov 30 2020, 8:44 AM · Restricted Project, Restricted Project
qiucf added a comment to D88044: [llvm-exegesis][PowerPC] Add more register classes.

Thanks for the patch! I think code added is quite clear since most of them already exist as framework in implementation of other platforms. We can continue to support more about exegesis on PowerPC in later patches.

Nov 30 2020, 8:36 AM · Restricted Project
qiucf accepted D92067: [PowerPC] Promote the i1 to i64 for SINT_TO_FP/FP_TO_SINT.

LGTM. Thanks for fixing this.

Nov 30 2020, 1:31 AM · Restricted Project

Nov 29 2020

qiucf updated the diff for D92278: [Clang] Don't adjust align for IBM extended double type.

use getFloatTypeSemantics

Nov 29 2020, 10:57 PM · Restricted Project
qiucf requested review of D92278: [Clang] Don't adjust align for IBM extended double type.
Nov 29 2020, 10:13 AM · Restricted Project

Nov 26 2020

qiucf added a comment to D91331: Expand the fp_to_int/int_to_fp/fp_round/fp_extend as libcall for fp128.

Besides, I found a strange thing:
In PPCTargetLowering::LowerFP_TO_INT, we will return original op if the input type is fp128, which means in some subtarget , fp128's fptoint is legal and have corresponding instructions.
But what you are going to do is to do a hack and expand it to libcall at the beginning of legalizeOp(...). It seems there is a conflict here.

Nov 26 2020, 10:19 PM · Restricted Project
qiucf added a comment to D92083: [PowerPC] Lower the SETCC/SELECT_CC as libcall for fp128 with Power9 vector disabled.

Thanks for the work! I thought code to 'unfold' SELECT_CC and BR_CC should exist in generic code..

Nov 26 2020, 6:22 PM · Restricted Project
qiucf added a comment to D92067: [PowerPC] Promote the i1 to i64 for SINT_TO_FP/FP_TO_SINT.

After applying this patch, I enumerated signed/unsigned conversion between i1~i128 and f32/f64/f128/ppcf128, only ppcf128-i1 still crashes:

Nov 26 2020, 1:03 AM · Restricted Project

Nov 25 2020

qiucf added inline comments to D91845: [PowerPC] Fix FLT_ROUNDS_ on little endian.
Nov 25 2020, 10:39 PM · Restricted Project
qiucf updated the diff for D91845: [PowerPC] Fix FLT_ROUNDS_ on little endian.

Use bitcast-truncate

Nov 25 2020, 10:39 PM · Restricted Project
qiucf added a comment to D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad.

gcc calls the *l version with -mlong-double-128 on x86. Should we match gcc here?

Nov 25 2020, 7:31 PM · Restricted Project