I'm identical to @ecnelises .
User Details
- User Since
- Mar 3 2019, 9:30 PM (98 w, 4 d)
Yesterday
Mon, Jan 18
Sun, Jan 17
Fri, Jan 15
Thu, Jan 14
Wed, Jan 13
Ping..
Tue, Jan 12
Mon, Jan 11
Rebase after rG6175fcf01f17e0bd1155aaaba977b9baa88ee61d and rG7200d2cf0891ef56607fd0336029b33bd4097eed
This looks like an NFC change?
Sun, Jan 10
Assert target type is simple
Fri, Jan 8
Thu, Jan 7
Maybe better to add some comments before each section? Like D78132 or X86ISelLowering.
Tue, Jan 5
Mon, Jan 4
Tue, Dec 29
Update with tests
As I see, this patch tries to extend use of fcti* instructions into subtargets without direct-move. If so, this looks reasonable, but needs change/rebase since D81537 did refactor in this part conflicting with this.
Mon, Dec 28
Rename findConversionLibcall.
Address comments and add tests
Dec 22 2020
Dec 21 2020
Align with Altivec targets.
Dec 17 2020
Gentle ping
Dec 16 2020
If there is only one constant, we will have one extra load with this patch. But the load could be optimized by linker if it merges the TOC. It is not easy inside compiler to handle it as ISEL is done basing on per BB, and we don't know if there are other constants until other BBs are selected. Any thoughts ?
- Diff based on pre-commit
- Restrict to PPC64
Dec 15 2020
Dec 14 2020
Dec 11 2020
Dec 8 2020
Dec 7 2020
Ping..
Dec 6 2020
LGTM. Thanks for the fix.
Dec 3 2020
Thanks!
Any comments...? I don't have knowledge if there's any plan about implementing *f128 math functions on X86 libcs. But as I see so far, *l doesn't work well on fp128. Keeping this target independent currently seems reasonable to me.
Dec 2 2020
Update comments and call findConversionLibcall outside assert.
Split the common methods stuff into another revision. Rebase this upon D92481.
Fix type bug
The regression should be fixed in rG3fca6a7844b5
Address comments
Dec 1 2020
Address comments
- Update comment to refer to ABI
- Add test case for OpenMP host & target mismatch
Nov 30 2020
Another small place also needs remove? (but not related to clang)
Thanks for the patch! I think code added is quite clear since most of them already exist as framework in implementation of other platforms. We can continue to support more about exegesis on PowerPC in later patches.
LGTM. Thanks for fixing this.
Nov 29 2020
use getFloatTypeSemantics
Nov 26 2020
Thanks for the work! I thought code to 'unfold' SELECT_CC and BR_CC should exist in generic code..
After applying this patch, I enumerated signed/unsigned conversion between i1~i128 and f32/f64/f128/ppcf128, only ppcf128-i1 still crashes:
Nov 25 2020
Use bitcast-truncate