Page MenuHomePhabricator

Correctly parse and print Tag_THUMB_ISA_use=3
ClosedPublic

Authored by LemonBoy on Oct 28 2020, 6:30 AM.

Details

Summary

I took the "Permitted"/"Not Permitted" combo from the Tag_ARM_ISA_use case (GNU tools print "Yes").

Diff Detail

Event Timeline

LemonBoy created this revision.Oct 28 2020, 6:30 AM
LemonBoy requested review of this revision.Oct 28 2020, 6:30 AM
MaskRay added inline comments.Fri, Nov 6, 9:06 AM
llvm/test/MC/ARM/directive-arch-armv8m.s
2

Does this add additional coverage not available by other tests?

LemonBoy added inline comments.Fri, Nov 6, 9:10 AM
llvm/test/MC/ARM/directive-arch-armv8m.s
2

This tests that the THUMB_ISA_use=3 case round-trips correctly, llvm-mc emits it and llvm-readobj is able to read/interpret/dump it.

MaskRay accepted this revision.Fri, Nov 6, 9:13 AM

Please give other reviewers some time to chime in

llvm/test/MC/ARM/directive-arch-armv8m.s
7

Minor nit: in other places, | at the end of the previous line is more common
The next line should be idented, usually by 2, as you already do.

This revision is now accepted and ready to land.Fri, Nov 6, 9:13 AM
compnerd accepted this revision.Wed, Nov 11, 1:16 PM

I am once again asking for your financial support.
@MaskRay would you mind landing this now that it got another approval mark?

aemerson added a subscriber: simon_tatham.

@simon_tatham Can you take a look?

I am once again asking for your financial support.
@MaskRay would you mind landing this now that it got another approval mark?

I can after @simon_tatham has taken a look

simon_tatham accepted this revision.Fri, Nov 20, 1:07 AM

@MaskRay Is this ready to go now?

This revision was landed with ongoing or failed builds.Sat, Nov 28, 12:28 PM
This revision was automatically updated to reflect the committed changes.