Page MenuHomePhabricator

compnerd (Saleem Abdulrasool)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2012, 11:41 PM (411 w, 3 h)

Recent Activity

Wed, Oct 21

compnerd added a comment to D88582: Bitcode: add some convenience helpers for streaming bitcode.

Ping

Wed, Oct 21, 8:54 AM · Restricted Project
compnerd added inline comments to D89420: [lld-macho][easy] Fix segment max protection.
Wed, Oct 21, 8:53 AM · Restricted Project
compnerd added a comment to D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version.

Is there a reason to not use the existing -mlinker-version= option and expanding that beyond just Darwin targets? I feel like having the same option would be much nicer.

I agree with @compnerd that it seems better to reuse this if possible. I wasn't around back then, but I have to assume it was named generically in order to enable that.

-mlinker-version is currently a macOS option. We could reuse it but that would be confusing: when -fuse-ld=lld is specified, does it specify the lld version? (No)

Maybe it should?

Wed, Oct 21, 8:52 AM · Restricted Project, Restricted Project

Tue, Oct 20

compnerd added a comment to D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version.

Is there a reason to not use the existing -mlinker-version= option and expanding that beyond just Darwin targets? I feel like having the same option would be much nicer.

Tue, Oct 20, 11:11 AM · Restricted Project, Restricted Project

Mon, Oct 19

compnerd accepted D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets..

Thanks for doing this!

Mon, Oct 19, 9:59 PM · Restricted Project
compnerd accepted D89762: Check LLVM_TOOLCHAIN_UTILITIES to allow utilities to be included in the toolchain.
Mon, Oct 19, 9:54 PM · Restricted Project
compnerd added inline comments to D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets..
Mon, Oct 19, 1:36 PM · Restricted Project
compnerd added inline comments to D89622: [COFF][ARM] Fix CodeView for Windows on 32bit ARM targets..
Mon, Oct 19, 9:59 AM · Restricted Project
compnerd accepted D89357: [llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools.

I know that many people find these tools useful, but they are meant as testing tools. Marking them as utilities seems reasonable.

Mon, Oct 19, 9:48 AM · Restricted Project

Fri, Oct 16

compnerd added a comment to D88859: APINotes: add APINotesYAMLCompiler.

Thanks for the feedback!

Fri, Oct 16, 8:30 AM · Restricted Project

Thu, Oct 15

compnerd committed rG273c299d5d64: [PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting (authored by vsk).
[PM/CC1] Add -f[no-]split-cold-code CC1 option to toggle splitting
Thu, Oct 15, 4:15 PM
compnerd closed D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting.
Thu, Oct 15, 4:15 PM · Restricted Project, Restricted Project
compnerd updated the diff for D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting.

Passes locally now

Thu, Oct 15, 11:21 AM · Restricted Project, Restricted Project
compnerd added a comment to D88582: Bitcode: add some convenience helpers for streaming bitcode.

Ping

Thu, Oct 15, 8:51 AM · Restricted Project
compnerd added a comment to D88859: APINotes: add APINotesYAMLCompiler.

Ping

Thu, Oct 15, 8:50 AM · Restricted Project
compnerd added a comment to D89285: [lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB.

Given that Darwin has fully moved to DWARF at this point, why STABS?

Thu, Oct 15, 8:50 AM · Restricted Project
compnerd added inline comments to D89420: [lld-macho][easy] Fix segment max protection.
Thu, Oct 15, 8:47 AM · Restricted Project
compnerd accepted D89418: [lld-macho] Implement LC_UUID.
Thu, Oct 15, 8:45 AM · Restricted Project

Tue, Oct 13

compnerd updated the diff for D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting.

Rebase; there are a 4 more test failures to go through

Tue, Oct 13, 3:52 PM · Restricted Project, Restricted Project
compnerd commandeered D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting.
Tue, Oct 13, 3:50 PM · Restricted Project, Restricted Project
compnerd abandoned D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O.

Sure, I think I can do that instead. Thanks for pointing me to that!

Tue, Oct 13, 11:10 AM · Restricted Project, Restricted Project

Mon, Oct 12

compnerd accepted D89231: [libunwind] [SEH] Don't interact with foreign exceptions.

Personally, I think that switch is nicer for the ExceptionCode check, but thats not your doing nor a real concern.

Mon, Oct 12, 8:31 AM · Restricted Project, Restricted Project

Sat, Oct 10

compnerd added a comment to D89177: [cmake] Add support for multiple distributions.

I've not taken a thorough look at the changes, but I am definitely in favour of this change (conceptually).

Sat, Oct 10, 12:16 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Oct 9

compnerd committed rG5d74c4351175: DirectoryWatcher: add an implementation for Windows (authored by compnerd).
DirectoryWatcher: add an implementation for Windows
Fri, Oct 9, 1:57 PM
compnerd closed D88666: DirectoryWatcher: add an implementation for Windows.
Fri, Oct 9, 1:56 PM · Restricted Project
compnerd updated the diff for D88666: DirectoryWatcher: add an implementation for Windows.

Remove unnecessary include, fix an incorrect wait (verified that unit tests now pass!)

Fri, Oct 9, 1:28 PM · Restricted Project
compnerd added inline comments to D88666: DirectoryWatcher: add an implementation for Windows.
Fri, Oct 9, 1:26 PM · Restricted Project

Thu, Oct 8

compnerd updated the diff for D88666: DirectoryWatcher: add an implementation for Windows.

address feedback

Thu, Oct 8, 4:43 PM · Restricted Project
compnerd added inline comments to D88666: DirectoryWatcher: add an implementation for Windows.
Thu, Oct 8, 4:42 PM · Restricted Project
compnerd requested review of D89078: Add `-f[no-]split-cold-code` toggling outlining & enable in -O.
Thu, Oct 8, 4:21 PM · Restricted Project, Restricted Project
compnerd added inline comments to D88666: DirectoryWatcher: add an implementation for Windows.
Thu, Oct 8, 3:14 PM · Restricted Project
compnerd added a reviewer for D88582: Bitcode: add some convenience helpers for streaming bitcode: eli.friedman.
Thu, Oct 8, 10:57 AM · Restricted Project

Wed, Oct 7

compnerd accepted D86828: [windows-itanium] make dllimport/export handling closer to MS behavior.

This seems pretty reasonable to me, it just makes the DLL storage handling more similar to Microsoft's which is what the Windows Itanium target is intending to do.

Wed, Oct 7, 11:10 AM · Restricted Project
compnerd added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

The reason that I added the overlapped event was specifically for the cancellation and overlooked the fact that it will be used by the kernel side as well, thanks for catching that!

Wed, Oct 7, 11:08 AM · Restricted Project

Mon, Oct 5

compnerd requested review of D88859: APINotes: add APINotesYAMLCompiler.
Mon, Oct 5, 3:52 PM · Restricted Project
compnerd committed rG85d506400081: docs: add documentation describing API Notes (authored by compnerd).
docs: add documentation describing API Notes
Mon, Oct 5, 11:30 AM
compnerd closed D88446: docs: add documentation describing API Notes.
Mon, Oct 5, 11:30 AM · Restricted Project

Sun, Oct 4

compnerd updated the diff for D88666: DirectoryWatcher: add an implementation for Windows.

Address feedback

Sun, Oct 4, 8:11 PM · Restricted Project
compnerd added inline comments to D88666: DirectoryWatcher: add an implementation for Windows.
Sun, Oct 4, 8:05 PM · Restricted Project
compnerd added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

There already is testing coverage for this - I just missed the CMake changes.

Sun, Oct 4, 7:59 PM · Restricted Project

Fri, Oct 2

compnerd updated the diff for D88446: docs: add documentation describing API Notes.

Address feedback from @rsmith

Fri, Oct 2, 3:47 PM · Restricted Project
compnerd added inline comments to D88446: docs: add documentation describing API Notes.
Fri, Oct 2, 3:46 PM · Restricted Project
compnerd updated the diff for D88446: docs: add documentation describing API Notes.

Update text based on feedback.

Fri, Oct 2, 8:37 AM · Restricted Project
compnerd added inline comments to D88446: docs: add documentation describing API Notes.
Fri, Oct 2, 8:31 AM · Restricted Project

Thu, Oct 1

compnerd added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

@aaron.ballman - I completely agree with you about the testing. The interfaces are tested via https://github.com/llvm/llvm-project/blob/master/clang/unittests/DirectoryWatcher/CMakeLists.txt, which now that I look at again, seems to need an additional case for system name.

Thu, Oct 1, 10:08 AM · Restricted Project
compnerd added inline comments to D88666: DirectoryWatcher: add an implementation for Windows.
Thu, Oct 1, 10:05 AM · Restricted Project
compnerd added inline comments to D88666: DirectoryWatcher: add an implementation for Windows.
Thu, Oct 1, 10:04 AM · Restricted Project
compnerd updated subscribers of D88666: DirectoryWatcher: add an implementation for Windows.
Thu, Oct 1, 9:42 AM · Restricted Project
compnerd requested review of D88666: DirectoryWatcher: add an implementation for Windows.
Thu, Oct 1, 8:51 AM · Restricted Project
compnerd added inline comments to D88446: docs: add documentation describing API Notes.
Thu, Oct 1, 8:30 AM · Restricted Project

Wed, Sep 30

compnerd updated subscribers of D88582: Bitcode: add some convenience helpers for streaming bitcode.
Wed, Sep 30, 8:36 AM · Restricted Project
compnerd requested review of D88582: Bitcode: add some convenience helpers for streaming bitcode.
Wed, Sep 30, 8:36 AM · Restricted Project
compnerd added inline comments to D88458: [CMake] Cache compiler-rt library results.
Wed, Sep 30, 8:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Sep 29

compnerd added a comment to D88458: [CMake] Cache compiler-rt library results.

If we require LLVM for any of the projects, perhaps we should hoist the HandleCompilerRT.cmake into LLVM and avoid having to maintain the copy everywhere.

Tue, Sep 29, 3:43 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Sep 28

compnerd added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Mon, Sep 28, 4:02 PM
compnerd requested review of D88446: docs: add documentation describing API Notes.
Mon, Sep 28, 1:47 PM · Restricted Project

Sep 25 2020

compnerd committed rG58cdbf518b6e: Sema: add support for `__attribute__((__swift_private__))` (authored by compnerd).
Sema: add support for `__attribute__((__swift_private__))`
Sep 25 2020, 3:42 PM
compnerd closed D87720: Sema: add support for `__attribute__((__swift_private__))`.
Sep 25 2020, 3:42 PM · Restricted Project
compnerd added a reviewer for D88189: [libc++abi] Add an option to avoid demangling in terminate.: ldionne.
Sep 25 2020, 10:09 AM · Restricted Project
compnerd committed rG76eb163259c4: Sema: remove unnecessary parameter for SwiftName handling (NFCI) (authored by compnerd).
Sema: remove unnecessary parameter for SwiftName handling (NFCI)
Sep 25 2020, 10:02 AM
compnerd closed D88263: Sema: remove unnecessary parameter for SwiftName handling (NFCI).
Sep 25 2020, 10:01 AM · Restricted Project

Sep 24 2020

compnerd accepted D88268: [lld-macho] Ignore a few more undocumented flags.
Sep 24 2020, 3:45 PM · Restricted Project
compnerd accepted D87960: [lld-macho] Always include custom syslibroot when running tests.

lld changes seem unrelated (include changes, whitespace); LGTM with the copyright header for lit.cfg

Sep 24 2020, 3:44 PM · Restricted Project
compnerd requested review of D88263: Sema: remove unnecessary parameter for SwiftName handling (NFCI).
Sep 24 2020, 2:53 PM · Restricted Project
compnerd updated the diff for D87720: Sema: add support for `__attribute__((__swift_private__))`.
  • address all feedback, add more test cases
Sep 24 2020, 2:29 PM · Restricted Project
compnerd added inline comments to D87720: Sema: add support for `__attribute__((__swift_private__))`.
Sep 24 2020, 2:28 PM · Restricted Project
compnerd updated the diff for D87720: Sema: add support for `__attribute__((__swift_private__))`.

add more tests to cover the confusing case of attribute merge handling

Sep 24 2020, 12:55 PM · Restricted Project
compnerd committed rGd34c8c70aae2: Basic: add an extra newline for sphinx (NFC) (authored by compnerd).
Basic: add an extra newline for sphinx (NFC)
Sep 24 2020, 11:51 AM
compnerd updated the diff for D87720: Sema: add support for `__attribute__((__swift_private__))`.
Sep 24 2020, 11:48 AM · Restricted Project
compnerd added inline comments to D87720: Sema: add support for `__attribute__((__swift_private__))`.
Sep 24 2020, 11:47 AM · Restricted Project
compnerd committed rG296d8832a3b5: Sema: add support for `__attribute__((__swift_newtype__))` (authored by compnerd).
Sema: add support for `__attribute__((__swift_newtype__))`
Sep 24 2020, 8:41 AM
compnerd closed D87652: Sema: add support for `__attribute__((__swift_newtype__))`.
Sep 24 2020, 8:41 AM · Restricted Project

Sep 23 2020

compnerd committed rG92d42b32a9b7: Utility: ignore OS version on non-Darwin targets in `ArchSpec` (authored by compnerd).
Utility: ignore OS version on non-Darwin targets in `ArchSpec`
Sep 23 2020, 6:21 PM
compnerd closed D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`.
Sep 23 2020, 6:21 PM · Restricted Project
compnerd added a comment to D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`.

Correct, this is just upstreaming the original ArchSpec change that we found on Swift.

Sep 23 2020, 2:15 PM · Restricted Project
compnerd requested changes to D87960: [lld-macho] Always include custom syslibroot when running tests.

Emphatic +1 to @smeenai's comment. This really should be done via lit substitutions.

Sep 23 2020, 2:03 PM · Restricted Project
compnerd requested review of D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`.
Sep 23 2020, 2:01 PM · Restricted Project
compnerd updated the diff for D87652: Sema: add support for `__attribute__((__swift_newtype__))`.
Sep 23 2020, 9:01 AM · Restricted Project
compnerd added inline comments to D87652: Sema: add support for `__attribute__((__swift_newtype__))`.
Sep 23 2020, 8:13 AM · Restricted Project

Sep 22 2020

compnerd updated the diff for D87652: Sema: add support for `__attribute__((__swift_newtype__))`.

Update for feedback from @aaron.ballman
The ParseAttrCommonArgs refactoring still needs to be looked at, but this should address the feedback, and doesn't need to be predicated on the refactoring.

Sep 22 2020, 3:06 PM · Restricted Project
compnerd accepted D87880: [libunwind] Combine dl_iterate_phdr codepaths for DWARF and EHABI.
Sep 22 2020, 9:33 AM · Restricted Project, Restricted Project
compnerd accepted D87881: [libunwind] Optimize dl_iterate_phdr's findUnwindSectionsByPhdr.
Sep 22 2020, 9:26 AM · Restricted Project, Restricted Project
compnerd committed rG9bb5ecf1f760: Sema: introduce `__attribute__((__swift_name__))` (authored by compnerd).
Sema: introduce `__attribute__((__swift_name__))`
Sep 22 2020, 8:41 AM
compnerd closed D87534: Sema: introduce `__attribute__((__swift_name__))`.
Sep 22 2020, 8:40 AM · Restricted Project

Sep 21 2020

compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Sep 21 2020, 3:01 PM · Restricted Project

Sep 17 2020

compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.

Address feedback

Sep 17 2020, 9:52 AM · Restricted Project
compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Sep 17 2020, 9:30 AM · Restricted Project

Sep 16 2020

compnerd accepted D87803: [lld-macho] Ignore `-mllvm` and its argument.
Sep 16 2020, 4:33 PM · Restricted Project
compnerd accepted D87750: [libunwind][DWARF] Fix end of .eh_frame calculation.

Thanks!

Sep 16 2020, 4:32 PM · Restricted Project, Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.
Sep 16 2020, 4:20 PM · Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.

Change diagnostics for conflicting swift_name, add a test case

Sep 16 2020, 4:18 PM · Restricted Project
compnerd updated subscribers of D87652: Sema: add support for `__attribute__((__swift_newtype__))`.
Sep 16 2020, 2:38 PM · Restricted Project
compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Sep 16 2020, 1:47 PM · Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.

Address everything but warning

Sep 16 2020, 12:04 PM · Restricted Project
compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Sep 16 2020, 12:02 PM · Restricted Project
compnerd committed rG77a01d9498a7: Sema: add support for `__attribute__((__swift_bridge__))` (authored by compnerd).
Sema: add support for `__attribute__((__swift_bridge__))`
Sep 16 2020, 10:56 AM
compnerd closed D87532: Sema: add support for `__attribute__((__swift_bridge__))`.
Sep 16 2020, 10:56 AM · Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.

Address feedback from @aaron.ballman

Sep 16 2020, 9:29 AM · Restricted Project
compnerd added inline comments to D87534: Sema: introduce `__attribute__((__swift_name__))`.
Sep 16 2020, 8:43 AM · Restricted Project
compnerd requested changes to D87750: [libunwind][DWARF] Fix end of .eh_frame calculation.

I think that tracking the segment length should be okay. It’s a total overhead of 8 bytes, which is only allocated once, however, the naming here is egregiously bad. This is the segment length and not the DSO length nor the DSO mapped length (which may actually be larger or smaller based on the load segment layout).

Sep 16 2020, 7:46 AM · Restricted Project, Restricted Project