The sea was angry that day, my friends - like an old man trying to send back soup in a deli.
- User Since
- Sep 9 2013, 3:45 AM (367 w, 3 d)
Maybe try to modify the existing G_XOR to be a G_AND instead of creating a new instruction?
Wed, Sep 23
I've decided to use custom legalization for this particular case in D88191, abandoning this change but I might revive it in another form later.
Tue, Sep 22
On further investigation I'm not sure this is the best way forward.
Mon, Sep 21
Fri, Sep 18
Thu, Sep 17
Wed, Sep 16
Add a test for ANDSWrs?
Tue, Sep 15
Mon, Sep 14
Fri, Sep 11
Thu, Sep 10
Wed, Sep 9
Nice clean up, LGTM.
Tue, Sep 8
Sat, Sep 5
Fri, Sep 4
I remember you mention that the change to CallLowering approach to this issue resulted in worse perf or code size. That does seem odd to me since we should be just aping SDAG, so even if we had some regressions we shouldn't be worse overall.
Thu, Sep 3
I don't have any strong feelings about this. I agree with Sanjay that correctness is more important but it would be good to have some tests that show what we're now failing to optimize.
Wed, Sep 2
Tue, Sep 1
Thanks, it seems the test doesn't work without asserts enabled. I've re-committed it fixed in 520ab710fb6f9829b4e70fda1dcc91ed4f614d0a
Did you commit this?
Mon, Aug 31
Rebase and move getICmpTrueVal() from an earlier patch to this one.
Simplify and refactor code with FP case.
Fri, Aug 28
Actually I'm going to abandon this. I think later CodeGen passes can eliminate these and make better decisions about it.
computeNumSignBits() does not mean that the value was sign extended. It only returns you the number of top-most bits that are known to be the same. As a result, this also ends up matching G_ZEXTLOAD which is a bug I hit in an earlier attempt at this.
Thu, Aug 27
Add support for vectors.
Why isn't this caught in InstCombine?
Wed, Aug 26
Great, thanks for doing this.
Aug 25 2020
That snippet is just returning if there was no debug info at all, there's a ! in the if condition.