Page MenuHomePhabricator

simon_tatham (Simon Tatham)
Compiler Engineer (Arm)

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2017, 1:23 AM (177 w, 3 d)

Recent Activity

Wed, Dec 2

simon_tatham added a comment to D92470: [ARM] Common inverse constant predicates to VPNOT.

Should there be a range limit somewhere in this logic, beyond just 'in the same basic block'? I worry slightly that if there's a very long basic block with two completely separate predicated sections, and they happen to reuse the same constant, then it might not be a win to do this change. Something along the lines of

Wed, Dec 2, 4:11 AM · Restricted Project

Tue, Dec 1

simon_tatham accepted D92235: [ARM] Turn pred_cast(xor(x, -1)) into xor(pred_cast(x), -1).
Tue, Dec 1, 1:49 AM · Restricted Project

Mon, Nov 30

simon_tatham added inline comments to D92235: [ARM] Turn pred_cast(xor(x, -1)) into xor(pred_cast(x), -1).
Mon, Nov 30, 2:35 AM · Restricted Project

Fri, Nov 27

simon_tatham accepted D92213: [ARM] PREDICATE_CAST demanded bits.
Fri, Nov 27, 1:33 AM · Restricted Project

Fri, Nov 20

simon_tatham accepted D90305: Correctly parse and print Tag_THUMB_ISA_use=3.
Fri, Nov 20, 1:07 AM · Restricted Project

Thu, Nov 19

simon_tatham added inline comments to D91773: [AArch64] Add SubtargetFeatures for v8.7-A options.
Thu, Nov 19, 3:19 AM · Restricted Project

Oct 16 2020

simon_tatham committed rGbcb7b8770620: [libcxxabi] Fix printf formats in a test. (authored by simon_tatham).
[libcxxabi] Fix printf formats in a test.
Oct 16 2020, 6:00 AM
simon_tatham closed D89547: [libcxxabi] Fix printf formats in a test..
Oct 16 2020, 6:00 AM · Restricted Project
simon_tatham added a comment to D89545: [libcxx] Fix printf formats in two tests..

Thanks for the quick review – sorry I wasn't on the ball enough to fold D89547 into this one too...

Oct 16 2020, 5:57 AM · Restricted Project
simon_tatham requested review of D89547: [libcxxabi] Fix printf formats in a test..
Oct 16 2020, 5:57 AM · Restricted Project
simon_tatham committed rG4d60467f99a0: [libcxx] Fix printf formats in two tests. (authored by simon_tatham).
[libcxx] Fix printf formats in two tests.
Oct 16 2020, 5:48 AM
simon_tatham closed D89545: [libcxx] Fix printf formats in two tests..
Oct 16 2020, 5:47 AM · Restricted Project
simon_tatham requested review of D89545: [libcxx] Fix printf formats in two tests..
Oct 16 2020, 5:43 AM · Restricted Project

Oct 14 2020

simon_tatham added a comment to D88806: [SCEV] Model ptrtoint(SCEVUnknown) cast not as unknown, but as zext/trunc/self of SCEVUnknown.

Thanks for the quick response!

Oct 14 2020, 6:18 AM · Restricted Project
simon_tatham added a comment to D88806: [SCEV] Model ptrtoint(SCEVUnknown) cast not as unknown, but as zext/trunc/self of SCEVUnknown.

Hi @lebedev.ri , it looks as if this commit is causing an assertion failure compiling the following example code.

void bar(void), baz(unsigned);
Oct 14 2020, 2:59 AM · Restricted Project

Sep 3 2020

simon_tatham accepted D86702: [ARM] Fold predicate_cast(load) into vldr p0.
Sep 3 2020, 1:54 AM · Restricted Project

Aug 7 2020

simon_tatham committed rG1d782942500b: [Sema][BFloat] Forbid arithmetic on vectors of bfloat. (authored by simon_tatham).
[Sema][BFloat] Forbid arithmetic on vectors of bfloat.
Aug 7 2020, 3:27 AM
simon_tatham closed D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat..
Aug 7 2020, 3:27 AM · Restricted Project

Aug 6 2020

simon_tatham added a comment to D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat..

This discussion seems to have wound down. I'll land this patch tomorrow on the strength of @LukeGeeson's review, unless you have strong objections, @jfb?

Aug 6 2020, 2:18 AM · Restricted Project

Aug 3 2020

simon_tatham committed rGed0e4c70c99d: [clang][ARM] Add name-mangling test for direct __fp16 arguments. (authored by simon_tatham).
[clang][ARM] Add name-mangling test for direct __fp16 arguments.
Aug 3 2020, 5:31 AM
simon_tatham closed D85010: [clang][ARM] Add name-mangling test for direct __fp16 arguments..
Aug 3 2020, 5:31 AM · Restricted Project
simon_tatham added a comment to D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat..
In D85009#2187643, @jfb wrote:

Language-wise I think https://wg21.link/p1467 is where C++ is going, and C is taking a similar approach.

Aug 3 2020, 2:02 AM · Restricted Project

Jul 31 2020

simon_tatham added a comment to D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat..
In D85009#2187621, @jfb wrote:

You mean: only aarch64 backend supports lowering bfloat16 vectors at the moment?

Jul 31 2020, 9:23 AM · Restricted Project
simon_tatham added a comment to D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat..
In D85009#2187549, @jfb wrote:

Is that true of all vector bfloat implementations? It seems like arithmetic on these types is something implementations would likely support.

Jul 31 2020, 9:06 AM · Restricted Project
simon_tatham requested review of D85010: [clang][ARM] Add name-mangling test for direct __fp16 arguments..
Jul 31 2020, 1:33 AM · Restricted Project
simon_tatham requested review of D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat..
Jul 31 2020, 1:27 AM · Restricted Project

Jul 20 2020

simon_tatham accepted D84102: [ARM] Add predicated mla reduction patterns.
Jul 20 2020, 6:11 AM · Restricted Project
simon_tatham accepted D84101: [ARM] Add predicated add reduction patterns.
Jul 20 2020, 5:29 AM · Restricted Project
simon_tatham added inline comments to D84102: [ARM] Add predicated mla reduction patterns.
Jul 20 2020, 5:20 AM · Restricted Project

Jul 14 2020

simon_tatham committed rG86d362f48928: [utils] New script `check_ninja_deps.py` (authored by simon_tatham).
[utils] New script `check_ninja_deps.py`
Jul 14 2020, 6:54 AM
simon_tatham closed D83032: [utils] New script `check_ninja_deps.py`.
Jul 14 2020, 6:54 AM · Restricted Project
simon_tatham added inline comments to D83032: [utils] New script `check_ninja_deps.py`.
Jul 14 2020, 6:22 AM · Restricted Project
simon_tatham accepted D83566: [ARM] CSEL generation.
Jul 14 2020, 1:53 AM · Restricted Project

Jul 3 2020

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

@jdoerfert , @clementval : over in D83032 is a polished-up version of the script I used to check where the missing deps needed to go. Might be useful for the next problem of this kind. But I'm not sure who to get to review it; perhaps one of you might look at it?

Jul 3 2020, 1:35 AM · Restricted Project, Restricted Project

Jul 2 2020

simon_tatham created D83032: [utils] New script `check_ninja_deps.py`.
Jul 2 2020, 4:15 AM · Restricted Project
simon_tatham committed rG9e6f19fd8390: Fix missing build dependency on omp_gen. (authored by simon_tatham).
Fix missing build dependency on omp_gen.
Jul 2 2020, 1:34 AM
simon_tatham closed D82659: Fix missing build dependency on omp_gen..
Jul 2 2020, 1:34 AM · Restricted Project, Restricted Project

Jul 1 2020

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

LGTM. So later the DEPENDS omp_gen that are in clang subdirectories could be removed right?

Jul 1 2020, 8:42 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

[facepalm] Thank you. I carefully wrote a revised description, but forgot to upload it to this issue.

Jul 1 2020, 8:42 AM · Restricted Project, Restricted Project
simon_tatham updated the summary of D82659: Fix missing build dependency on omp_gen..
Jul 1 2020, 8:42 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D82659: Fix missing build dependency on omp_gen..

Here's a completely different patch, which adds all the missing dependencies on OMP.h.inc in the clang subdirectory in one go.

Jul 1 2020, 3:44 AM · Restricted Project, Restricted Project

Jun 30 2020

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

Cannot you just add a depends for your failing case?

Jun 30 2020, 9:12 AM · Restricted Project, Restricted Project
simon_tatham reopened D82659: Fix missing build dependency on omp_gen..

Unfortunately, I had to revert this because it caused a buildbot failure: rG39ea5d74b283d5a42f34b856d22bfaf806a1c907

Jun 30 2020, 5:23 AM · Restricted Project, Restricted Project
simon_tatham added a reverting change for rGed4328c60730: Fix missing build dependency on omp_gen.: rG39ea5d74b283: Revert "Fix missing build dependency on omp_gen.".
Jun 30 2020, 2:08 AM
simon_tatham committed rG39ea5d74b283: Revert "Fix missing build dependency on omp_gen." (authored by simon_tatham).
Revert "Fix missing build dependency on omp_gen."
Jun 30 2020, 2:08 AM
simon_tatham committed rGed4328c60730: Fix missing build dependency on omp_gen. (authored by simon_tatham).
Fix missing build dependency on omp_gen.
Jun 30 2020, 1:03 AM
simon_tatham closed D82659: Fix missing build dependency on omp_gen..
Jun 30 2020, 1:02 AM · Restricted Project, Restricted Project

Jun 29 2020

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

@clementval , are you happy for me to commit this patch?

Jun 29 2020, 6:58 AM · Restricted Project, Restricted Project

Jun 26 2020

simon_tatham added a comment to D82659: Fix missing build dependency on omp_gen..

I wondered about that. I think it may well mean some of those DEPENDS can be removed, but I'm not sure how to be certain of it :-)

Jun 26 2020, 8:44 AM · Restricted Project, Restricted Project
simon_tatham created D82659: Fix missing build dependency on omp_gen..
Jun 26 2020, 8:10 AM · Restricted Project, Restricted Project
simon_tatham committed rG41eb63929183: Fix implicit include dependencies on SmallVector.h. (authored by simon_tatham).
Fix implicit include dependencies on SmallVector.h.
Jun 26 2020, 5:58 AM

Jun 24 2020

simon_tatham accepted D81339: [ARM] MVE VCVT lowering for f16->f32 extends.
Jun 24 2020, 9:09 AM · Restricted Project
simon_tatham committed rGb769eb02b526: [ARM][BFloat] Legalize bf16 type even without fullfp16. (authored by simon_tatham).
[ARM][BFloat] Legalize bf16 type even without fullfp16.
Jun 24 2020, 2:08 AM
simon_tatham closed D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Jun 24 2020, 2:08 AM · Restricted Project
simon_tatham accepted D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

LGTM. Thanks for the fixes.

Jun 24 2020, 1:34 AM · Restricted Project

Jun 23 2020

simon_tatham added inline comments to D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Jun 23 2020, 9:37 AM · Restricted Project
simon_tatham updated the diff for D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..

Updated for @dmgreen's review suggestions, which both seem to work as far as I can see.

Jun 23 2020, 9:04 AM · Restricted Project
simon_tatham added inline comments to D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Jun 23 2020, 9:04 AM · Restricted Project
simon_tatham added a comment to D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..

It isn't unused – there are still some isel patterns using it, which I haven't touched in this commit.

Jun 23 2020, 8:31 AM · Restricted Project
simon_tatham added inline comments to D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Jun 23 2020, 7:25 AM · Restricted Project
simon_tatham updated subscribers of D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..

(Sorry @labrinea – removing you as a reviewer was an unintentional side effect of a bad arc command.)

Jun 23 2020, 7:25 AM · Restricted Project
simon_tatham added a reviewer for D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16.: labrinea.
Jun 23 2020, 7:25 AM · Restricted Project
simon_tatham updated the diff for D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..

New version addressing review comments.

Jun 23 2020, 7:25 AM · Restricted Project
simon_tatham created D82372: [ARM][BFloat] Legalize bf16 type even without fullfp16..
Jun 23 2020, 5:49 AM · Restricted Project
simon_tatham added a comment to D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

OK, fair enough. In that case, please correct my nitpicks and I'll approve the revised patch.

Jun 23 2020, 2:36 AM · Restricted Project

Jun 22 2020

simon_tatham added a comment to D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

for ARMv7 we only disallowed this pair, and this change removes that restriction. So now, all of them are allowed...

Jun 22 2020, 6:24 AM · Restricted Project
simon_tatham added a comment to D59733: ARM: Allow cp10/cp11 coprocessor register access with a warning.

I've made a couple of nitpicks to the patch, but my more general question is: if we think that this pair of coprocessors should be changed from "reject completely" to "accept with a warning", why not all of them? What argument applies to CP10 and CP11 that doesn't apply to all the others, apart from the immediate short-term argument of "this is the one that's currently causing somebody a problem"?

Jun 22 2020, 2:38 AM · Restricted Project

Jun 17 2020

simon_tatham added inline comments to D80865: [TableGen] defm in a loop is not final (bug fix).
Jun 17 2020, 1:34 AM · Restricted Project

Jun 15 2020

simon_tatham added inline comments to D80865: [TableGen] defm in a loop is not final (bug fix).
Jun 15 2020, 6:28 AM · Restricted Project

May 28 2020

simon_tatham added inline comments to D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen.
May 28 2020, 7:02 AM · Restricted Project, Restricted Project

May 5 2020

simon_tatham accepted D79402: [ARM] Correct the type on a predicate cast.
May 5 2020, 3:11 AM · Restricted Project

Apr 21 2020

simon_tatham accepted D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 21 2020, 8:04 AM · Restricted Project
simon_tatham added inline comments to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.
Apr 21 2020, 6:26 AM · Restricted Project

Apr 20 2020

simon_tatham added a comment to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.

I see. In that case I suppose the simplest thing to do is just to explain that in the commit message, along the lines of "D77872 has already added the MC representations of the instructions so that they can be used in code gen; this patch fills in the details needed to make assembly parsing work, and adds tests for asm and disasm'.

Apr 20 2020, 4:16 AM · Restricted Project
simon_tatham added a comment to D77874: [AArch32] Armv8.6a Matrix Mul Assembly Parser Support.

The important part of this patch seems to be missing! It says it's adding AArch32 assembly parsing for some new instructions, but I don't see any new Tablegen work that adds the instructions. New mnemonics are added to a couple of exclusion lists in ARMAsmParser, but there's no code in here that makes the mnemonics actually exist in the first place, or that says what their operands should be or what their encodings are – just that small C++ tweak and a load of tests. Where's the rest of it?

Apr 20 2020, 1:02 AM · Restricted Project

Apr 7 2020

simon_tatham committed rGaab9e9de4d99: [Support,Windows] Tolerate failure of CryptGenRandom (authored by simon_tatham).
[Support,Windows] Tolerate failure of CryptGenRandom
Apr 7 2020, 1:36 AM
simon_tatham closed D77553: [Support,Windows] Tolerate failure of CryptGenRandom.
Apr 7 2020, 1:36 AM · Restricted Project
simon_tatham added inline comments to D77553: [Support,Windows] Tolerate failure of CryptGenRandom.
Apr 7 2020, 1:35 AM · Restricted Project

Apr 6 2020

simon_tatham created D77553: [Support,Windows] Tolerate failure of CryptGenRandom.
Apr 6 2020, 8:06 AM · Restricted Project

Apr 1 2020

simon_tatham added a comment to D77202: [Target][ARM] Fold or(A, B) more aggressively for I1 Vectors.

I have no thoughts on the patch itself, but the commit message looks quite alarming out of context. Perhaps it should mention that you're doing this specifically for i1 and vectors of i1, and not for bitwise OR of ordinary integers?

Apr 1 2020, 2:50 AM · Restricted Project

Mar 27 2020

simon_tatham accepted D76927: [ARM,CDE] Improve CDE intrinsics testing.
Mar 27 2020, 8:45 AM · Restricted Project
simon_tatham accepted D76910: [ARM] Make remaining MVE instruction predictable.
Mar 27 2020, 5:24 AM · Restricted Project
simon_tatham added a comment to D76910: [ARM] Make remaining MVE instruction predictable.

Are we talking about CONSTRAINED_UNPREDICTABLE here?

Mar 27 2020, 4:17 AM · Restricted Project
simon_tatham added a comment to D76910: [ARM] Make remaining MVE instruction predictable.

Do you understand why all those test outputs have changed as a side effect of this?

Mar 27 2020, 3:10 AM · Restricted Project

Mar 26 2020

simon_tatham committed rG6a946993d519: Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on. (authored by simon_tatham).
Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on.
Mar 26 2020, 2:08 AM
simon_tatham closed D76760: Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on..
Mar 26 2020, 2:08 AM · Restricted Project

Mar 25 2020

simon_tatham accepted D76610: [ARM,CDE] Implement predicated Q-register CDE intrinsics.
Mar 25 2020, 8:04 AM · Restricted Project
simon_tatham committed rG8f1651ccead1: [ARM,MVE] Add missing tests for vqdmlash intrinsics. (authored by simon_tatham).
[ARM,MVE] Add missing tests for vqdmlash intrinsics.
Mar 25 2020, 3:13 AM
simon_tatham closed D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics..
Mar 25 2020, 3:13 AM · Restricted Project
simon_tatham created D76760: Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on..
Mar 25 2020, 3:13 AM · Restricted Project

Mar 24 2020

simon_tatham created D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics..
Mar 24 2020, 10:12 AM · Restricted Project
simon_tatham committed rGf282b6ab23a0: [ReleaseNotes,ARM] MVE intrinsics are all implemented! (authored by simon_tatham).
[ReleaseNotes,ARM] MVE intrinsics are all implemented!
Mar 24 2020, 4:48 AM
simon_tatham closed D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.
Mar 24 2020, 4:48 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.

Added an entry to the Clang release notes as well.

Mar 24 2020, 3:12 AM · Restricted Project, Restricted Project

Mar 23 2020

simon_tatham accepted D76511: [ARM] Don't split trunc stores that can be better handled as VMOVN.
Mar 23 2020, 2:43 AM · Restricted Project
simon_tatham accepted D76139: [Target][ARM] Change VPTMaskValues to the correct encoding.

LGTM, with only one tiny remaining nitpick.

Mar 23 2020, 2:43 AM · Restricted Project

Mar 20 2020

simon_tatham created D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.
Mar 20 2020, 10:17 AM · Restricted Project, Restricted Project
simon_tatham committed rG45a9945b9ea9: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family. (authored by simon_tatham).
[ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.
Mar 20 2020, 9:11 AM
simon_tatham committed rG1adfa4c99169: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family. (authored by simon_tatham).
[ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family.
Mar 20 2020, 9:11 AM
simon_tatham closed D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family..
Mar 20 2020, 9:11 AM · Restricted Project