Page MenuHomePhabricator

rengolin (Renato Golin)
Toolchain Engineer

Projects

User does not belong to any projects.

User Details

User Since
Oct 19 2012, 12:57 AM (431 w, 5 d)

Recent Activity

Today

rengolin added a comment to D95386: Fix namespace for MLIR Async Runtime.

@ezhulenev I think I can see what the fix should be. Does the check-mlir cover this example? Or is there additional testing I should do?

Wed, Jan 27, 3:37 AM · Restricted Project

Yesterday

rengolin added a comment to D95386: Fix namespace for MLIR Async Runtime.

This is the error:

Tue, Jan 26, 2:53 AM · Restricted Project

Mon, Jan 25

rengolin added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

anymore comments or LGTM?

Mon, Jan 25, 2:39 AM · Restricted Project

Sun, Jan 24

rengolin accepted D95315: [CODE_OWNERS][M68k] (Patch 0/8) Add code owner for the M68k target.
Sun, Jan 24, 11:37 AM · Restricted Project

Fri, Jan 22

rengolin added a comment to D94451: Proposal for adding Bazel build configuration in-tree with peripheral support.

Overall, I think this is great. It answers all questions I've seen posed on the RFCs and is well aligned with the tiers policy, in text and intent.

Fri, Jan 22, 1:59 AM

Wed, Jan 20

rengolin added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

Yes, a first batch of patches to reach the point that it can generate first ALU asm codegen. In all, I propose following patches to construct the first batch.

https://reviews.llvm.org/D93798
https://reviews.llvm.org/D94007
https://reviews.llvm.org/D95029
https://reviews.llvm.org/D95030

Wed, Jan 20, 6:31 AM · Restricted Project

Tue, Jan 19

rengolin added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

Hi Zixuan,

Tue, Jan 19, 3:49 AM · Restricted Project
rengolin added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

The plan is for the entire patch series to be accepted before any are pushed.

Tue, Jan 19, 3:44 AM · Restricted Project

Sat, Jan 16

rengolin added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

Absolutely. I agree this problem should be solve before graduate from experimental target. I will create these bugs soon

Sat, Jan 16, 5:22 AM · Restricted Project

Fri, Jan 15

rengolin accepted D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

That sounds reasonable (but +1 to @RKSimon 's comment about reviewing all this "special sauce" complexity before graduating from experimental)

Fri, Jan 15, 1:58 PM · Restricted Project
rengolin added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

Yeah my concern is not about m68k doing weird things, it's about the code that's added in the target-independent places to support m68k that I am most concerned with, as it affects every target regardless of whether m68k is enabled.

Fri, Jan 15, 9:30 AM · Restricted Project

Wed, Jan 13

rengolin added reviewers for D94557: [ARM] Fixed incorrect lowering when using GNUEABI (libgcc) and 16bit floats: compnerd, peter.smith.
Wed, Jan 13, 9:41 AM · Restricted Project
rengolin added a comment to D94451: Proposal for adding Bazel build configuration in-tree with peripheral support.

If this pitch is accepted, then what are the next steps required in order for bazel or another build system to be added to tree? For example, can they automatically be added if they meet the support policy requirements or does there need to be some kind of community ack for? I think the pitch needs to be more clear about what this process is.

Wed, Jan 13, 4:07 AM
rengolin added a comment to D94557: [ARM] Fixed incorrect lowering when using GNUEABI (libgcc) and 16bit floats.

Also, please use diff -U9999 as documented: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Wed, Jan 13, 2:03 AM · Restricted Project

Wed, Jan 6

rengolin added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

Why would refactoring TSFlags into a int-ptr union just for M68k be better than adding the CodeBeads functionality just for M68k?

Wed, Jan 6, 3:32 AM · Restricted Project

Tue, Jan 5

rengolin added a comment to D92748: [VE][compiler-rt] Add VE as a target of crt.

Thank you for the response. Your description is correct. That is what I tried to describe. Thanks.

Tue, Jan 5, 1:39 AM · Restricted Project, Restricted Project
rengolin added a comment to D92748: [VE][compiler-rt] Add VE as a target of crt.

@compnerd , I have a question. I'm thinking that you might misunderstand my explanations. VE is almost merged. I can compile llvm-project using already upstreamed llvm/clang. Now, in order to continue the upstreaming, I need crtbegin.o and crtend.o in compiler-rt. It is a reason why I submit this patch. Didn't you misunderstand the situation? Thanks!

Tue, Jan 5, 1:25 AM · Restricted Project, Restricted Project

Thu, Dec 31

rengolin added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

I think it's not worthwhile to spend too much time to discuss this open topic. Let's come back to review this and following patches, please. Thank you! I can make few diff files based on this one.

Thu, Dec 31, 6:36 AM · Restricted Project

Wed, Dec 30

rengolin added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

I think it's early-refactoring issue. We should assume the current patch is good in current codebase context, or we will re-review many times.

Wed, Dec 30, 5:31 AM · Restricted Project

Tue, Dec 29

rengolin added a comment to D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter.

I don't think too many patches on the fly is good to upstream because they influence each other and need change on the way of review.

Tue, Dec 29, 3:40 AM · Restricted Project

Dec 21 2020

rengolin added inline comments to D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.
Dec 21 2020, 1:02 PM · Restricted Project
rengolin accepted D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.

LGTM, thanks!

Dec 21 2020, 1:01 PM · Restricted Project

Dec 18 2020

rengolin accepted D88392: [M68k] (Patch 6/8) IR Tests.

This LGTM now, thanks!

Dec 18 2020, 4:08 AM · Restricted Project
rengolin accepted D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.

LGTM too, thanks!

Dec 18 2020, 3:54 AM · Restricted Project

Dec 17 2020

rengolin added inline comments to D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.
Dec 17 2020, 3:21 AM · Restricted Project

Dec 16 2020

rengolin added a comment to D93372: [CSKY 3/n] Add bare-bones C-SKY MCTargetDesc.

Looks like a standard mock implementation, basic infrastructure. I don't see anything wrong with it but I've also been far from this area for too long, so I'll let other people review it properly and approve.

Dec 16 2020, 4:36 AM · Restricted Project

Dec 10 2020

rengolin accepted D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.

LGTM too, thanks!

Dec 10 2020, 3:49 AM · Restricted Project
rengolin added a comment to D88386: [MIR][M68K] (Patch 2/8): Changes on Target-independent MIR part.

This looks good to me but I'll let other people review again and approve. Thanks!

Dec 10 2020, 3:46 AM · Restricted Project
rengolin added a comment to D88391: [M68k] (Patch 5/8) Target lowering.

@craig.topper are you happy with the changes?

Dec 10 2020, 3:44 AM · Restricted Project

Dec 9 2020

rengolin added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

Does anyone have any more comments? Otherwise I think we can provisionally accept this.

Dec 9 2020, 4:31 AM · Restricted Project
rengolin added a comment to D88391: [M68k] (Patch 5/8) Target lowering.

Hmm, I am just curious about that whether GlobalISEL is mature enough to use as default instruction selection method without implementing SelectionDAG. As a newer backend, I really would like to drop legacy stuff at start if it works.

Dec 9 2020, 4:28 AM · Restricted Project

Dec 4 2020

rengolin added inline comments to D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.
Dec 4 2020, 3:09 PM · Restricted Project

Dec 2 2020

rengolin added a comment to D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.

Thanks for the changes. This looks good to me but I'll let others check again and approve.

Dec 2 2020, 4:04 AM · Restricted Project

Nov 30 2020

rengolin accepted D89180: [CSKY 2/n] Add basic tablegen infra for CSKY.

I can't possibly comment on the ISA implementation, but this looks like a standard table-gen set of files to me. They also don't affect anything else outside of CSKY, so LGTM.

Nov 30 2020, 5:55 AM · Restricted Project

Nov 19 2020

rengolin added a comment to D87981: [X86] AMX programming model..

You should at least get @craig.topper's feedback, given this is a significant change in the x86 backend.

Nov 19 2020, 3:52 AM · Restricted Project, Restricted Project

Nov 18 2020

rengolin added a comment to D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.

Oh, from the discussion on mailing list I thought this is a requirement.

Nov 18 2020, 3:30 AM · Restricted Project
rengolin added inline comments to D88386: [MIR][M68K] (Patch 2/8): Changes on Target-independent MIR part.
Nov 18 2020, 3:19 AM · Restricted Project

Nov 17 2020

rengolin added a comment to D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.

Is it worth trying to avoid adding/deleting the *Dummy* files in the patch series? @rengolin any thoughts ?

Nov 17 2020, 5:40 AM · Restricted Project
rengolin added inline comments to D88391: [M68k] (Patch 5/8) Target lowering.
Nov 17 2020, 5:36 AM · Restricted Project
rengolin added inline comments to D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.
Nov 17 2020, 3:35 AM · Restricted Project
rengolin added inline comments to D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.
Nov 17 2020, 3:31 AM · Restricted Project
rengolin added a comment to D88392: [M68k] (Patch 6/8) IR Tests.

Nice set of tests, well separated, not a lot of pattern-match on the FileCheck side, which is good, asm and object emission.

Nov 17 2020, 3:27 AM · Restricted Project
rengolin added a comment to D88391: [M68k] (Patch 5/8) Target lowering.

I only had a very quick overview and this looks fine.

Nov 17 2020, 3:23 AM · Restricted Project
rengolin added a comment to D88390: [M68k] (Patch 4/8) MC layer and object file support.

A few nits, but this is looking good.

Nov 17 2020, 3:12 AM · Restricted Project
rengolin added inline comments to D88386: [MIR][M68K] (Patch 2/8): Changes on Target-independent MIR part.
Nov 17 2020, 2:58 AM · Restricted Project

Nov 13 2020

rengolin accepted D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..

Hi @fpetrogalli, the document is so dense that it took me a while to check the macros and I was still wrong.

Nov 13 2020, 2:02 AM · Restricted Project

Nov 11 2020

rengolin committed rG6fd9e59e1b3a: [mlir] Fix exports in mlir_async_runtime (authored by Paul Lietar <paul@lietar.net>).
[mlir] Fix exports in mlir_async_runtime
Nov 11 2020, 6:12 AM
rengolin closed D91196: [mlir] Fix exports in mlir_async_runtime..
Nov 11 2020, 6:11 AM · Restricted Project

Nov 10 2020

rengolin added reviewers for D91196: [mlir] Fix exports in mlir_async_runtime.: antiagainst, ezhulenev, mehdi_amini.
Nov 10 2020, 11:46 AM · Restricted Project
rengolin committed rG3073cbd2d4c2: [docs] link new support policy from developer policy (authored by rengolin).
[docs] link new support policy from developer policy
Nov 10 2020, 11:41 AM
rengolin closed D91013: [docs] link new support policy from developer policy.
Nov 10 2020, 11:41 AM · Restricted Project
rengolin updated the diff for D91013: [docs] link new support policy from developer policy.

It's looking a bit redundant to me, but I wanted to make sure we have the link on all three sections in case people are given a link (or navigate from the table-of contents) and don't see the sections above.

Nov 10 2020, 4:06 AM · Restricted Project

Nov 7 2020

rengolin requested review of D91013: [docs] link new support policy from developer policy.
Nov 7 2020, 1:19 PM · Restricted Project
rengolin closed D90761: [docs] Adding a Support Policy.

Sorry, forgot the review text on the commit message:
Closed by 25ba6b2bcd1

Nov 7 2020, 1:17 PM · Restricted Project
rengolin committed rG25ba6b2bcd1e: [docs] Adding a Support Policy (authored by rengolin).
[docs] Adding a Support Policy
Nov 7 2020, 1:06 PM
rengolin added a comment to D90761: [docs] Adding a Support Policy.

Thanks Chris! Will do.

Nov 7 2020, 12:50 PM · Restricted Project
rengolin updated the diff for D90761: [docs] Adding a Support Policy.
Nov 7 2020, 3:25 AM · Restricted Project
rengolin added a comment to D90761: [docs] Adding a Support Policy.

LGTM from me on the principle, I didn't get into detailed wordsmith. Overall I would have been more concise and lay down the general principle rather than trying to prescribe this level of details (like the "Reinstatement" section for example), I believe that's also more in line with how we've been operating / documenting things in the past, but I don't really mind it either.
I suspect we can incrementally fix/improve anything as we go as well.

Nov 7 2020, 2:55 AM · Restricted Project
rengolin updated the diff for D90761: [docs] Adding a Support Policy.
  • Include a short phrase on inclusion policy, as requested.
  • Fixed some typos
Nov 7 2020, 2:50 AM · Restricted Project
rengolin added inline comments to D90761: [docs] Adding a Support Policy.
Nov 7 2020, 2:49 AM · Restricted Project

Nov 6 2020

rengolin accepted D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`..

Simple and straightforward, with documentation! :)

Nov 6 2020, 9:57 AM · Restricted Project
rengolin accepted D90950: [AArch64]Add memory op cost model for SVE.

Nice change, simpler to read and easier to get right. LGTM, thanks!

Nov 6 2020, 8:40 AM · Restricted Project
rengolin added a comment to D90761: [docs] Adding a Support Policy.

Sorry, s/George/Geoffrey/. :S

Nov 6 2020, 2:43 AM · Restricted Project
rengolin updated the diff for D90761: [docs] Adding a Support Policy.
  • Adding inclusion policy section
  • Reword phrase in deprecation policy
Nov 6 2020, 2:41 AM · Restricted Project
rengolin added a comment to D90761: [docs] Adding a Support Policy.

Overall LGTM, with some wording nits. One thing I think is missing is guidance for how a peripheral component gets added. Experimental targets already have their own documentation, and my impression is that editor bindings are just a matter of sending a patch (which seems reasonable to me). What about something like:

To add a new peripheral component not covered under an existing policy, send an RFC to the appropriate dev list proposing its addition and explaining how it will meet the support requirements listed here.

Nov 6 2020, 2:41 AM · Restricted Project

Nov 5 2020

rengolin updated the diff for D90761: [docs] Adding a Support Policy.

Rewriting some confusing paragraphs.

Nov 5 2020, 10:07 AM · Restricted Project
rengolin added inline comments to D90761: [docs] Adding a Support Policy.
Nov 5 2020, 10:06 AM · Restricted Project
rengolin added inline comments to D90761: [docs] Adding a Support Policy.
Nov 5 2020, 9:52 AM · Restricted Project
rengolin updated the diff for D90761: [docs] Adding a Support Policy.

Updating simple suggestions / fixups.

Nov 5 2020, 9:51 AM · Restricted Project

Nov 4 2020

rengolin updated the diff for D90761: [docs] Adding a Support Policy.
  • Adding page link to "Getting Involved" page.
  • Fixing some formatting errors (Sphinx reports no warnings on my box).
Nov 4 2020, 9:10 AM · Restricted Project
rengolin updated the diff for D90761: [docs] Adding a Support Policy.
Nov 4 2020, 8:43 AM · Restricted Project
rengolin added inline comments to D90761: [docs] Adding a Support Policy.
Nov 4 2020, 8:42 AM · Restricted Project
rengolin updated the diff for D90761: [docs] Adding a Support Policy.
Nov 4 2020, 5:48 AM · Restricted Project
rengolin added a reviewer for D90761: [docs] Adding a Support Policy: reames.
Nov 4 2020, 5:43 AM · Restricted Project
rengolin requested review of D90761: [docs] Adding a Support Policy.
Nov 4 2020, 5:43 AM · Restricted Project

Nov 2 2020

rengolin added a comment to D89824: Add a LLDB buildbot builder for FreeBSD .

The change looks good to me but @gkistanova usually handles buildbot operations, so I don't want to approve before she has time to look at it.

Nov 2 2020, 7:37 AM

Oct 29 2020

rengolin added a comment to D89824: Add a LLDB buildbot builder for FreeBSD .

W00t! FreeBSD FTW!

Oct 29 2020, 9:07 AM

Oct 28 2020

rengolin accepted D89995: Make the post-commit review expectations more explicit with respect to revert.

Accepting again. I particularly like @gribozavr2's suggestion. LGTM, thanks!

Oct 28 2020, 3:11 PM · Restricted Project

Oct 27 2020

rengolin added a comment to D83088: Introduce CfgTraits abstraction.

I have read all of the comments in this review and have looked at all the other pending reviews because of this and I still see strong disagreement on the design and implementation.

Oct 27 2020, 6:05 AM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2020

rengolin added a comment to D89995: Make the post-commit review expectations more explicit with respect to revert.

Not everybody is necessarily aware of a 4 year old email thread;

Oct 26 2020, 11:08 AM · Restricted Project
rengolin added a comment to D89995: Make the post-commit review expectations more explicit with respect to revert.

Considering that you are doing this in response to D83088, I think we have pre-existing evidence that this isn't workable as-is.

Oct 26 2020, 3:01 AM · Restricted Project
rengolin added inline comments to D89995: Make the post-commit review expectations more explicit with respect to revert.
Oct 26 2020, 2:47 AM · Restricted Project

Oct 25 2020

rengolin updated subscribers of D89995: Make the post-commit review expectations more explicit with respect to revert.

I don't want to "take sides" and I'm only looking at this review from what it is and my own experience in the community. But looking at D83088, I see a somewhat problematic review.

Oct 25 2020, 4:21 AM · Restricted Project

Oct 24 2020

rengolin added inline comments to D89995: Make the post-commit review expectations more explicit with respect to revert.
Oct 24 2020, 1:42 PM · Restricted Project

Oct 23 2020

rengolin accepted D89995: Make the post-commit review expectations more explicit with respect to revert.

This is a great policy, thanks @silvas and @mehdi_amini.

Oct 23 2020, 1:57 AM · Restricted Project

Oct 16 2020

rengolin committed rGf0f3d1b1817a: Revert "Fix Windows llvm-objdump tests" (authored by rengolin).
Revert "Fix Windows llvm-objdump tests"
Oct 16 2020, 1:51 PM
rengolin added a comment to D85024: [llvm-objdump] Implement --prefix option.

@MaskRay you seem to have fixed partially, and @thakis solution is better than what I did. To avoid a similar clash, I'll revert my change and if it breaks again, you can fix it directly.

Oct 16 2020, 1:49 PM · Restricted Project
rengolin committed rG66506eeb37b2: Fix Windows llvm-objdump tests (authored by rengolin).
Fix Windows llvm-objdump tests
Oct 16 2020, 1:28 PM
rengolin committed rGe95f9a23fad5: [llvm-objdump] Implement --prefix option (authored by tinti).
[llvm-objdump] Implement --prefix option
Oct 16 2020, 9:51 AM
rengolin closed D85024: [llvm-objdump] Implement --prefix option.
Oct 16 2020, 9:51 AM · Restricted Project
rengolin accepted D85024: [llvm-objdump] Implement --prefix option.

@MaskRay ping?

Oct 16 2020, 6:32 AM · Restricted Project

Oct 8 2020

rengolin added a comment to D85024: [llvm-objdump] Implement --prefix option.

@MaskRay are you happy with the latest changes? If so, please change your review. Thanks!

Oct 8 2020, 8:49 AM · Restricted Project

Oct 1 2020

rengolin added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

Interesting...the patch I updated yesterday had gone through clang-format. And I didn't see any lint warning here on Phabricator. Maybe I should run again.

Oct 1 2020, 11:00 PM · Restricted Project
rengolin added a reviewer for D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions: craig.topper.

Adding @craig.topper as the owner of the x86 back-end, to check the implementation of the CodeBeads concept. I have mainly worked with RISC back-ends, so it's not my area. Craig, please feel free to add whoever you think is best to review this.

Oct 1 2020, 1:33 AM · Restricted Project
rengolin added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

There are plenty of lint checks that need addressing. Some are false positives and those are obvious cases, but the rest should be followed.

Oct 1 2020, 1:30 AM · Restricted Project

Sep 25 2020

rengolin added a comment to D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.

No problems, feel free to close, thanks!

Sep 25 2020, 6:37 AM
rengolin added inline comments to D88154: Initial support for vectorization using Libmvec (GLIBC vector math library)..
Sep 25 2020, 1:47 AM · Restricted Project, Restricted Project
rengolin added a reviewer for D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).: fpetrogalli.
Sep 25 2020, 1:43 AM · Restricted Project, Restricted Project

Sep 23 2020

rengolin committed rG577adda54f07: [Support/Path] Add path::is_absolute_gnu (authored by tinti).
[Support/Path] Add path::is_absolute_gnu
Sep 23 2020, 10:03 AM
rengolin closed D87667: [Support/Path] Add path::is_absolute_gnu.
Sep 23 2020, 10:03 AM · Restricted Project