Page MenuHomePhabricator

[CodeGen] Do not call `emitGlobalConstantLargeInt` for constant requires 8 bytes to store
ClosedPublic

Authored by atanasyan on Sep 24 2020, 2:20 PM.

Details

Summary

This is a fix for PR47630. The regression is caused by the D78011. After this change the code starts to call the emitGlobalConstantLargeInt even for constants which requires eight bytes to store.

Diff Detail

Event Timeline

atanasyan created this revision.Sep 24 2020, 2:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2020, 2:20 PM
atanasyan requested review of this revision.Sep 24 2020, 2:20 PM
LemonBoy accepted this revision.Sep 24 2020, 2:25 PM

LGTM, I typo'ed the comparison operator when I removed the switch. Sorry about that.

This revision is now accepted and ready to land.Sep 24 2020, 2:25 PM