♟ arsenm

Needs some test to stress different alignment scenarios. Also need some with these globals used in some weird constant initializers.

Do we really need HasModifiers if breaking this down to src modifiers and omod?

GlobalISel: Do not set observer of MachineIRBuilder in LegalizerHelper

AMDGPU: Remove wrapper only call limitation

Fix amdgpu_gfx handling

Do we do the equivalent combine in the DAG path? I don't recognize this one

In D94429#2492683, @Flakebi wrote:

Also stop passing them for amdgpu_gfx, since the DAG path seems to skip these. I'm unclear on what amdgpu_gfx's expectations are.

As far as I understand, the “special inputs” are arguments relevant for HSA only and depending on EnableFixedFunctionABI they are added in the beginning or end of arguments.
So, passSpecialInputs should be guarded by “is HSA” instead of “is not amdgpu_gfx”?

I would expect this in the post legalizer combiner, and going directly from i64 is a bit weird. What does the post-legalized MIR look like for this?

Needs a dedicated parse/roundtrip test in test/CodeGen/MIR

In D93755#2486281, @simoll wrote:

This is one of those patches that has the potential to linger on without review for 1Y+ .. let me know if there is anything i can do to get this reviewed, as it really helps with bringing good vector architecture (long SIMD) support to LLVM. Thanks.

GlobalISel: Fail legalization on narrowing extload below memory size

Fix missing half of patch

GlobalISel: Add combine for G_UREM by power of 2

CodeGen: Refactor regallocator command line and target selection

This is ignoring the alignments of the variables. This needs some tests to stress padding edge cases, and also probably should try sorting to minimizing padding.

Is this still needed?

AMDGPU/GlobalISel: Start cleaning up calling convention lowering

Removing the wrapper check seems to work fine: D94187

In D93451#2481972, @ruiling wrote:

Now that most features of CloneModule() are tested by the unit-test. Is there any specific reason to prefer lit-test over unit-test?

AMDGPU/GlobalISel: Update fdiv lowering for denormal/ulp interaction

I think we're missing a test that needs sret inserted and also has additional arguments

In D94150#2481556, @foad wrote:

Seems pretty obvious. Is it well defined which intrinsics are "legacy"? E.g. is it documented anywhere, or do we ever generate warnings for them or anything like that?

AMDGPU/GlobalISel: Add baseline IR tests for fdiv

AMDGPU: Explicitly use SelectionDAG in legacy intrinsic tests

Is a lit test possible?

arsenm (Matt Arsenault)
User

Projects

User Details

Recent Activity
View All

Today

Fri, Jan 15

Thu, Jan 14

Wed, Jan 13

Tue, Jan 12

Mon, Jan 11

Fri, Jan 8

Thu, Jan 7

Wed, Jan 6

Tue, Jan 5

arsenm (Matt Arsenault)User