Page MenuHomePhabricator

arsenm (Matt Arsenault)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 5 2012, 4:53 PM (423 w, 4 d)

Recent Activity

Today

arsenm requested review of D94914: RegAlloc: Fix assert if all registers in class reserved.
Mon, Jan 18, 7:01 AM · Restricted Project

Fri, Jan 15

arsenm added inline comments to D94768: [AMDGPU] Implement mir parseCustomPseudoSourceValue.
Fri, Jan 15, 5:22 PM · Restricted Project
arsenm requested review of D94823: AMDGPU: Add occupancy to serialized MachineFunctionInfo.
Fri, Jan 15, 1:35 PM · Restricted Project
arsenm added inline comments to D94648: [amdgpu] Implement lower function LDS pass.
Fri, Jan 15, 11:53 AM · Restricted Project
arsenm added inline comments to D94585: [IndirectFunctions] Skip propagating attributes to address taken functions.
Fri, Jan 15, 11:27 AM · Restricted Project
arsenm added a comment to D94648: [amdgpu] Implement lower function LDS pass.

Needs some test to stress different alignment scenarios. Also need some with these globals used in some weird constant initializers.

Fri, Jan 15, 10:41 AM · Restricted Project
arsenm accepted D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.

Do we really need HasModifiers if breaking this down to src modifiers and omod?

Fri, Jan 15, 10:20 AM · Restricted Project

Thu, Jan 14

arsenm added inline comments to D94645: [AMDGPU] Fix llvm.amdgcn.init.exec and frame materialization.
Thu, Jan 14, 8:19 AM · Restricted Project

Wed, Jan 13

arsenm added inline comments to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Wed, Jan 13, 9:34 AM · Restricted Project, Restricted Project
arsenm committed rGd55d592a921f: GlobalISel: Do not set observer of MachineIRBuilder in LegalizerHelper (authored by arsenm).
GlobalISel: Do not set observer of MachineIRBuilder in LegalizerHelper
Wed, Jan 13, 7:45 AM
arsenm closed D86226: GlobalISel: Do not set observer of MachineIRBuilder in LegalizerHelper.

d55d592a921f1cd6a922bff0000f6662f8722d9c

Wed, Jan 13, 7:44 AM · Restricted Project
arsenm added inline comments to D94153: [AMDGPU][Inliner] Remove amdgpu-inline and add new TTI inline hooks.
Wed, Jan 13, 6:47 AM · Restricted Project
arsenm added inline comments to D94585: [IndirectFunctions] Skip propagating attributes to address taken functions.
Wed, Jan 13, 6:17 AM · Restricted Project

Tue, Jan 12

arsenm requested review of D94578: AArch64/GlobalISel: Factor out parametersInCSRMatch.
Tue, Jan 12, 7:12 PM · Restricted Project
arsenm closed D94187: AMDGPU: Remove wrapper only call limitation.

3d397091591fca4aa16153bba22f031218bee47d

Tue, Jan 12, 4:01 PM · Restricted Project
arsenm accepted D94556: [NFC] Disallow unused prefixes under MC/AMDGPU.
Tue, Jan 12, 3:06 PM · Restricted Project
arsenm accepted D94553: [NFC] Disallow unused prefixes in MC/AMDGPU.
Tue, Jan 12, 2:30 PM · Restricted Project
arsenm committed rG3d397091591f: AMDGPU: Remove wrapper only call limitation (authored by arsenm).
AMDGPU: Remove wrapper only call limitation
Tue, Jan 12, 2:13 PM
arsenm planned changes to D94204: GlobalISel: Handle G_BUILD_VECTOR in isKnownToBeAPowerOfTwo.
Tue, Jan 12, 1:11 PM · Restricted Project
arsenm added a comment to D93144: RegisterCoalescer: Fix not setting undef on coalesced subregister uses.

ping

Tue, Jan 12, 12:09 PM · Restricted Project
arsenm added a comment to D93064: RegisterCoalescer: Prune undef subranges from copy pairs in loops.

ping

Tue, Jan 12, 12:09 PM · Restricted Project
arsenm abandoned D89582: clang/AMDGPU: Apply workgroup related attributes to all functions.
Tue, Jan 12, 12:09 PM
arsenm added inline comments to D88667: [GlobalISel] Change asserting conditions when initializing call site info.
Tue, Jan 12, 12:08 PM · Restricted Project, debug-info
arsenm updated the diff for D94429: AMDGPU: Move handling of allocation of fixed ABI inputs.

Fix amdgpu_gfx handling

Tue, Jan 12, 12:02 PM · Restricted Project
arsenm added inline comments to D94429: AMDGPU: Move handling of allocation of fixed ABI inputs.
Tue, Jan 12, 11:38 AM · Restricted Project
arsenm added inline comments to D94437: [AArch64][GlobalISel] Add support for FCONSTANT of FP128 type.
Tue, Jan 12, 11:10 AM · Restricted Project
arsenm added a comment to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

Do we do the equivalent combine in the DAG path? I don't recognize this one

Tue, Jan 12, 10:56 AM · Restricted Project, Restricted Project
arsenm added inline comments to D93983: RegAllocFast: Do not free later early-clobbered registers..
Tue, Jan 12, 9:50 AM · Restricted Project
arsenm added inline comments to D94429: AMDGPU: Move handling of allocation of fixed ABI inputs.
Tue, Jan 12, 9:38 AM · Restricted Project
arsenm added a comment to D94429: AMDGPU: Move handling of allocation of fixed ABI inputs.

Also stop passing them for amdgpu_gfx, since the DAG path seems to skip these. I'm unclear on what amdgpu_gfx's expectations are.

As far as I understand, the “special inputs” are arguments relevant for HSA only and depending on EnableFixedFunctionABI they are added in the beginning or end of arguments.
So, passSpecialInputs should be guarded by “is HSA” instead of “is not amdgpu_gfx”?

Tue, Jan 12, 5:56 AM · Restricted Project

Mon, Jan 11

arsenm accepted D94344: [CodeGen] Try to make the print of memory operand alignment a little more user friendly..
Mon, Jan 11, 7:02 PM · Restricted Project
arsenm accepted D86618: [AMDGPU][GlobalISel] Remove some duplicate RUN lines.
Mon, Jan 11, 7:00 PM · Restricted Project
arsenm added a comment to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..

I would expect this in the post legalizer combiner, and going directly from i64 is a bit weird. What does the post-legalized MIR look like for this?

Mon, Jan 11, 2:22 PM · Restricted Project, Restricted Project
arsenm added inline comments to D94437: [AArch64][GlobalISel] Add support for FCONSTANT of FP128 type.
Mon, Jan 11, 11:16 AM · Restricted Project
arsenm requested review of D94429: AMDGPU: Move handling of allocation of fixed ABI inputs.
Mon, Jan 11, 9:27 AM · Restricted Project

Fri, Jan 8

arsenm accepted D94348: [MIPatternMatch] Add matcher for G_PTR_ADD.
Fri, Jan 8, 3:37 PM · Restricted Project
arsenm added a comment to D94344: [CodeGen] Try to make the print of memory operand alignment a little more user friendly..

Needs a dedicated parse/roundtrip test in test/CodeGen/MIR

Fri, Jan 8, 3:21 PM · Restricted Project
arsenm accepted D94245: [NFC] Disallow unused prefixes in CodeGen/AMDGPU.
Fri, Jan 8, 9:47 AM · Restricted Project
arsenm added inline comments to D91516: [AMDGPU] Support for device scope shared variables.
Fri, Jan 8, 7:37 AM · Restricted Project
arsenm added a comment to D93755: [VE][isel] Map EVT vectors to vector registers..

This is one of those patches that has the potential to linger on without review for 1Y+ .. let me know if there is anything i can do to get this reviewed, as it really helps with bringing good vector architecture (long SIMD) support to LLVM. Thanks.

Fri, Jan 8, 6:18 AM · Restricted Project, Restricted Project
arsenm accepted D91064: [MachineBasicBlock] Fix update of live intervals in splitAt.
Fri, Jan 8, 6:12 AM · Restricted Project
arsenm added inline comments to D88777: [AMDGPU] Add SI_EARLY_TERMINATE_SCC0 for early terminating shader.
Fri, Jan 8, 6:08 AM · Restricted Project

Thu, Jan 7

arsenm added inline comments to D55333: VirtRegMap: Preserve LiveDebugVariables.
Thu, Jan 7, 4:32 PM · Restricted Project
arsenm added inline comments to D94204: GlobalISel: Handle G_BUILD_VECTOR in isKnownToBeAPowerOfTwo.
Thu, Jan 7, 3:41 PM · Restricted Project
arsenm closed D94152: GlobalISel: Fail legalization on narrowing extload below memory size.

2cbbc6e87c4b565a54c9bb85e34d464acb608f16

Thu, Jan 7, 2:40 PM · Restricted Project
arsenm committed rG2cbbc6e87c4b: GlobalISel: Fail legalization on narrowing extload below memory size (authored by arsenm).
GlobalISel: Fail legalization on narrowing extload below memory size
Thu, Jan 7, 2:40 PM
arsenm updated the diff for D94204: GlobalISel: Handle G_BUILD_VECTOR in isKnownToBeAPowerOfTwo.

Fix missing half of patch

Thu, Jan 7, 2:06 PM · Restricted Project
arsenm committed rG1f9b6ef91ffd: GlobalISel: Add combine for G_UREM by power of 2 (authored by arsenm).
GlobalISel: Add combine for G_UREM by power of 2
Thu, Jan 7, 1:37 PM
arsenm closed D94203: GlobalISel: Add combine for G_UREM by power of 2.

1f9b6ef91ffd8ea487aa083d146c7568e7243457

Thu, Jan 7, 1:36 PM · Restricted Project
arsenm added inline comments to D94203: GlobalISel: Add combine for G_UREM by power of 2.
Thu, Jan 7, 1:36 PM · Restricted Project
arsenm accepted D94254: Fix gcc5 build failure (NFC).
Thu, Jan 7, 12:01 PM · Restricted Project
arsenm added inline comments to D94245: [NFC] Disallow unused prefixes in CodeGen/AMDGPU.
Thu, Jan 7, 10:41 AM · Restricted Project
arsenm committed rGc9122ddef521: CodeGen: Refactor regallocator command line and target selection (authored by arsenm).
CodeGen: Refactor regallocator command line and target selection
Thu, Jan 7, 10:14 AM
arsenm closed D93739: CodeGen: Refactor regallocator command line and target selection.

c9122ddef5213fbdd2d82c473a74e1742010f62f

Thu, Jan 7, 10:14 AM · Restricted Project
arsenm accepted D94236: [NFC] Removed unused prefixes from CodeGen/AMDGPU.
Thu, Jan 7, 9:41 AM · Restricted Project
arsenm added a comment to D91516: [AMDGPU] Support for device scope shared variables.

This is ignoring the alignments of the variables. This needs some tests to stress padding edge cases, and also probably should try sorting to minimizing padding.

Thu, Jan 7, 9:27 AM · Restricted Project
arsenm accepted D93451: [Cloning] Copy metadata of global declarations.
Thu, Jan 7, 7:41 AM · Restricted Project
arsenm added a comment to D86618: [AMDGPU][GlobalISel] Remove some duplicate RUN lines.

Is this still needed?

Thu, Jan 7, 7:39 AM · Restricted Project
arsenm closed D93337: AMDGPU/GlobalISel: Start cleaning up calling convention lowering.

6b7d5a928f5e0d5321b641909f84cb238e8194b8

Thu, Jan 7, 7:37 AM · Restricted Project
arsenm committed rG6b7d5a928f5e: AMDGPU/GlobalISel: Start cleaning up calling convention lowering (authored by arsenm).
AMDGPU/GlobalISel: Start cleaning up calling convention lowering
Thu, Jan 7, 7:37 AM
arsenm accepted D94184: [NFC] Removed unused prefixes in CodeGen/AMDGPU.
Thu, Jan 7, 7:21 AM · Restricted Project
arsenm added inline comments to D94203: GlobalISel: Add combine for G_UREM by power of 2.
Thu, Jan 7, 6:05 AM · Restricted Project
arsenm added inline comments to D94203: GlobalISel: Add combine for G_UREM by power of 2.
Thu, Jan 7, 6:05 AM · Restricted Project
arsenm accepted D94156: AMDGPU/GlobalISel: Enable sret demotion.
Thu, Jan 7, 6:04 AM · Restricted Project

Wed, Jan 6

arsenm requested review of D94204: GlobalISel: Handle G_BUILD_VECTOR in isKnownToBeAPowerOfTwo.
Wed, Jan 6, 4:28 PM · Restricted Project
arsenm requested review of D94203: GlobalISel: Add combine for G_UREM by power of 2.
Wed, Jan 6, 4:28 PM · Restricted Project
arsenm added inline comments to D93337: AMDGPU/GlobalISel: Start cleaning up calling convention lowering.
Wed, Jan 6, 1:24 PM · Restricted Project
arsenm added a comment to D94153: [AMDGPU][Inliner] Remove amdgpu-inline and add new TTI inline hooks.

Removing the wrapper check seems to work fine: D94187

Wed, Jan 6, 12:28 PM · Restricted Project
arsenm requested review of D94187: AMDGPU: Remove wrapper only call limitation.
Wed, Jan 6, 12:27 PM · Restricted Project
arsenm added inline comments to D94153: [AMDGPU][Inliner] Remove amdgpu-inline and add new TTI inline hooks.
Wed, Jan 6, 10:43 AM · Restricted Project
arsenm added a comment to D93451: [Cloning] Copy metadata of global declarations.

Now that most features of CloneModule() are tested by the unit-test. Is there any specific reason to prefer lit-test over unit-test?

Wed, Jan 6, 10:35 AM · Restricted Project
arsenm added inline comments to D94153: [AMDGPU][Inliner] Remove amdgpu-inline and add new TTI inline hooks.
Wed, Jan 6, 10:28 AM · Restricted Project
arsenm accepted D94181: [NFC] Removed unused prefixes in CodeGen/AMDGPU.
Wed, Jan 6, 9:38 AM · Restricted Project
arsenm committed rGab3a3f543b18: AMDGPU/GlobalISel: Update fdiv lowering for denormal/ulp interaction (authored by arsenm).
AMDGPU/GlobalISel: Update fdiv lowering for denormal/ulp interaction
Wed, Jan 6, 9:32 AM
arsenm closed D94145: AMDGPU/GlobalISel: Update fdiv lowering for denormal/ulp interaction.

ab3a3f543b18d36cec98faa9ca2a68cc9a6ecc65

Wed, Jan 6, 9:32 AM · Restricted Project
arsenm updated subscribers of D94153: [AMDGPU][Inliner] Remove amdgpu-inline and add new TTI inline hooks.
Wed, Jan 6, 9:31 AM · Restricted Project
arsenm accepted D94151: [NFC] Removed unused prefixes from CodeGen/AMDGPU.
Wed, Jan 6, 9:02 AM · Restricted Project
arsenm added a comment to D94156: AMDGPU/GlobalISel: Enable sret demotion.

I think we're missing a test that needs sret inserted and also has additional arguments

Wed, Jan 6, 8:49 AM · Restricted Project
arsenm added inline comments to D94153: [AMDGPU][Inliner] Remove amdgpu-inline and add new TTI inline hooks.
Wed, Jan 6, 8:43 AM · Restricted Project
arsenm closed D94150: AMDGPU: Explicitly use SelectionDAG in legacy intrinsic tests.

136f49891953ce232be2f4a8bc98e83bb2cd6462

Wed, Jan 6, 8:38 AM · Restricted Project
arsenm added a comment to D94150: AMDGPU: Explicitly use SelectionDAG in legacy intrinsic tests.

Seems pretty obvious. Is it well defined which intrinsics are "legacy"? E.g. is it documented anywhere, or do we ever generate warnings for them or anything like that?

Wed, Jan 6, 8:37 AM · Restricted Project
arsenm committed rG0a3cf7f4762e: AMDGPU/GlobalISel: Add baseline IR tests for fdiv (authored by arsenm).
AMDGPU/GlobalISel: Add baseline IR tests for fdiv
Wed, Jan 6, 8:37 AM
arsenm committed rG136f49891953: AMDGPU: Explicitly use SelectionDAG in legacy intrinsic tests (authored by arsenm).
AMDGPU: Explicitly use SelectionDAG in legacy intrinsic tests
Wed, Jan 6, 8:37 AM
arsenm closed D94146: AMDGPU/GlobalISel: Add baseline IR tests for fdiv.

0a3cf7f4762e5608750a8f6b3fa4a6efcba66c27

Wed, Jan 6, 8:37 AM · Restricted Project
arsenm added inline comments to D94146: AMDGPU/GlobalISel: Add baseline IR tests for fdiv.
Wed, Jan 6, 8:34 AM · Restricted Project

Tue, Jan 5

arsenm requested review of D94152: GlobalISel: Fail legalization on narrowing extload below memory size.
Tue, Jan 5, 8:26 PM · Restricted Project
arsenm accepted D94147: [NFC] Removed unused prefixes in CodeGen/AMDGPU.
Tue, Jan 5, 7:54 PM · Restricted Project
arsenm requested review of D94150: AMDGPU: Explicitly use SelectionDAG in legacy intrinsic tests.
Tue, Jan 5, 7:44 PM · Restricted Project
arsenm added a comment to D93451: [Cloning] Copy metadata of global declarations.

Is a lit test possible?

Tue, Jan 5, 7:39 PM · Restricted Project
arsenm requested review of D94146: AMDGPU/GlobalISel: Add baseline IR tests for fdiv.
Tue, Jan 5, 7:15 PM · Restricted Project
arsenm requested review of D94145: AMDGPU/GlobalISel: Update fdiv lowering for denormal/ulp interaction.
Tue, Jan 5, 7:12 PM · Restricted Project
arsenm accepted D94124: [NFC] Removed unused prefixes in test/CodeGen/AMDGPU.
Tue, Jan 5, 3:14 PM · Restricted Project
arsenm accepted D94121: [NFC] Removed unused prefixes in test/CodeGen/AMDGPU.
Tue, Jan 5, 2:31 PM · Restricted Project
arsenm accepted D94107: AMDGPU: Annotate amdgpu.noclobber for global loads only.
Tue, Jan 5, 1:23 PM · Restricted Project
arsenm accepted D94114: [NFC] Removed unused prefixes in CodeGen/AMDGPU.
Tue, Jan 5, 1:16 PM · Restricted Project
arsenm added inline comments to D91244: [GlobalISel] Add missing operand update when copy is required.
Tue, Jan 5, 1:16 PM · Restricted Project
arsenm added inline comments to D93983: RegAllocFast: Do not free later early-clobbered registers..
Tue, Jan 5, 11:10 AM · Restricted Project
arsenm added inline comments to D93708: [AMDGPU] Add a new Clamp Pattern to the GlobalISel Path..
Tue, Jan 5, 10:10 AM · Restricted Project, Restricted Project
arsenm closed D93742: GlobalISel: Add isKnownToBeAPowerOfTwo helper function.

a427f15d6070fd50457c553a097e031139b40886

Tue, Jan 5, 10:00 AM · Restricted Project
arsenm accepted D94099: [NFC] Removed unused prefixes in CodeGen/AMDGPU/GlobalISel.
Tue, Jan 5, 9:59 AM · Restricted Project