Page MenuHomePhabricator

morehouse (Matt Morehouse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:27 PM (173 w, 6 d)

Recent Activity

Fri, Oct 23

morehouse accepted D85928: [libFuzzer] Added -print_full_coverage flag..
Fri, Oct 23, 3:53 PM · Restricted Project, Restricted Project

Mon, Oct 19

morehouse accepted D89199: Release pages to OS when setting 0 label.
Mon, Oct 19, 3:21 PM · Restricted Project
morehouse accepted D89662: Set Huge Page mode on shadow regions based on no_huge_pages_for_shadow.

LGTM, thanks!

Mon, Oct 19, 1:36 PM · Restricted Project
morehouse requested changes to D89662: Set Huge Page mode on shadow regions based on no_huge_pages_for_shadow.
Mon, Oct 19, 12:06 PM · Restricted Project
morehouse accepted D89662: Set Huge Page mode on shadow regions based on no_huge_pages_for_shadow.
Mon, Oct 19, 12:02 PM · Restricted Project

Mon, Oct 12

morehouse added inline comments to D89199: Release pages to OS when setting 0 label.
Mon, Oct 12, 10:57 AM · Restricted Project
morehouse added inline comments to D87754: [Lsan] Use fp registers to search for pointers.
Mon, Oct 12, 8:26 AM · Restricted Project

Tue, Oct 6

morehouse added a comment to D88755: Replace shadow space zero-out by madvise at mmap.

FYI I believe linux updates the rss count only on every 40th-or-so change to the page tables.
We have a test somewhere that runs a single page mmap-munmap in a loop for a while before taking a measurement.

Tue, Oct 6, 1:32 PM · Restricted Project
morehouse accepted D88755: Replace shadow space zero-out by madvise at mmap.
Tue, Oct 6, 1:23 PM · Restricted Project
morehouse added inline comments to D88755: Replace shadow space zero-out by madvise at mmap.
Tue, Oct 6, 12:50 PM · Restricted Project
morehouse added inline comments to D88755: Replace shadow space zero-out by madvise at mmap.
Tue, Oct 6, 9:58 AM · Restricted Project

Mon, Oct 5

morehouse added a comment to D88755: Replace shadow space zero-out by madvise at mmap.

I agree with @eugenis that the madvise call is more beneficial as a special case for large sizes in dfsan_set_label.

Mon, Oct 5, 5:30 PM · Restricted Project
morehouse added a comment to D88755: Replace shadow space zero-out by madvise at mmap.

Sure, madvise has overhead. Check SetShadow in MSan and FastPoisonShadow in ASan.

I'm confused - I don't see allocator replacement in dfsan. How does it handle the situation where deallocated memory that contains some labelled data is reused for a new allocation - the labels must be cleared somehow, right?

Mon, Oct 5, 5:03 PM · Restricted Project
morehouse added inline comments to D88755: Replace shadow space zero-out by madvise at mmap.
Mon, Oct 5, 8:34 AM · Restricted Project

Fri, Oct 2

morehouse accepted D88763: [fuzzer] Remove unused variable.

LGTM

Fri, Oct 2, 4:30 PM · Restricted Project
morehouse added a comment to D88755: Replace shadow space zero-out by madvise at mmap.

We can't remove the mmap interceptors completely, since munmap doesn't always precede mmap.

Fri, Oct 2, 2:26 PM · Restricted Project
morehouse accepted D88686: Release the shadow memory used by the mmap range at munmap.
Fri, Oct 2, 1:05 PM · Restricted Project
morehouse added inline comments to D88686: Release the shadow memory used by the mmap range at munmap.
Fri, Oct 2, 8:58 AM · Restricted Project

Thu, Oct 1

morehouse added inline comments to D88686: Release the shadow memory used by the mmap range at munmap.
Thu, Oct 1, 3:35 PM · Restricted Project
morehouse added a comment to D88686: Release the shadow memory used by the mmap range at munmap.

Can we add a test that ensures RSS doesn't increase after a mmap + munmap pair?

Thu, Oct 1, 11:20 AM · Restricted Project

Sep 22 2020

morehouse added a comment to D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.

The revert did not fix the PPC bots. I suspect there is some kind of resource issue from the logs:

Sep 22 2020, 1:35 PM · Restricted Project
morehouse added a comment to D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.

Thanks for looking. Indeed, it looks like an issue with the disk being full on the bot.

Sep 22 2020, 9:32 AM · Restricted Project
morehouse committed rG4c23cf3ca0e0: [sanitizer_common] Add debug print to sysmsg.c (authored by morehouse).
[sanitizer_common] Add debug print to sysmsg.c
Sep 22 2020, 9:10 AM

Sep 21 2020

morehouse added a comment to D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.

This change appears to trigger an assertion failure in sysmsg.c on the PPC bot: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/26845/steps/ninja%20check%

Sep 21 2020, 5:58 PM · Restricted Project

Sep 18 2020

morehouse committed rG23bab1eb43d3: [DFSan] Add strpbrk wrapper. (authored by morehouse).
[DFSan] Add strpbrk wrapper.
Sep 18 2020, 8:54 AM
morehouse closed D87849: [DFSan] Add strpbrk wrapper..
Sep 18 2020, 8:54 AM · Restricted Project
morehouse updated the diff for D87849: [DFSan] Add strpbrk wrapper..
  • Simplify ternary.
Sep 18 2020, 8:43 AM · Restricted Project
morehouse accepted D87897: [msan][asan] Add runtime flag intercept_strcmp.

LGTM

Sep 18 2020, 8:23 AM · Restricted Project

Sep 17 2020

morehouse requested review of D87849: [DFSan] Add strpbrk wrapper..
Sep 17 2020, 12:22 PM · Restricted Project
morehouse committed rG50dd545b00ed: [DFSan] Add bcmp wrapper. (authored by morehouse).
[DFSan] Add bcmp wrapper.
Sep 17 2020, 9:24 AM
morehouse closed D87801: [DFSan] Add bcmp wrapper..
Sep 17 2020, 9:24 AM · Restricted Project
morehouse accepted D87754: [Lsan] Use fp registers to search for pointers.

LGTM

Sep 17 2020, 9:10 AM · Restricted Project
morehouse updated the diff for D87801: [DFSan] Add bcmp wrapper..
  • Restructure bcmp and memcmp wrapper to please check_custom_wrappers.sh
Sep 17 2020, 9:04 AM · Restricted Project
morehouse reopened D87801: [DFSan] Add bcmp wrapper..
Sep 17 2020, 9:03 AM · Restricted Project
morehouse added a reverting change for rG559f91981253: [DFSan] Add bcmp wrapper.: rGdf017fd906bb: Revert "[DFSan] Add bcmp wrapper.".
Sep 17 2020, 8:44 AM
morehouse committed rGdf017fd906bb: Revert "[DFSan] Add bcmp wrapper." (authored by morehouse).
Revert "[DFSan] Add bcmp wrapper."
Sep 17 2020, 8:44 AM
morehouse added a reverting change for D87801: [DFSan] Add bcmp wrapper.: rGdf017fd906bb: Revert "[DFSan] Add bcmp wrapper.".
Sep 17 2020, 8:44 AM · Restricted Project
morehouse committed rG559f91981253: [DFSan] Add bcmp wrapper. (authored by morehouse).
[DFSan] Add bcmp wrapper.
Sep 17 2020, 8:23 AM
morehouse closed D87801: [DFSan] Add bcmp wrapper..
Sep 17 2020, 8:23 AM · Restricted Project

Sep 16 2020

morehouse added inline comments to D87754: [Lsan] Use fp registers to search for pointers.
Sep 16 2020, 6:13 PM · Restricted Project
morehouse requested review of D87801: [DFSan] Add bcmp wrapper..
Sep 16 2020, 3:38 PM · Restricted Project
morehouse committed rGf3c2e0bcee64: [libFuzzer] Enable entropic by default. (authored by morehouse).
[libFuzzer] Enable entropic by default.
Sep 16 2020, 10:45 AM
morehouse closed D87476: [libFuzzer] Enable entropic by default..
Sep 16 2020, 10:45 AM · Restricted Project
morehouse added a comment to D87754: [Lsan] Use fp registers to search for pointers.

LGTM once we have a test.

Sep 16 2020, 10:23 AM · Restricted Project
morehouse accepted D87747: [NFC][LSAN] Change SuspendedThreadsList interface.

LGTM. Was this causing any issues, or is this just a refactor?

Sep 16 2020, 9:39 AM · Restricted Project
morehouse committed rG66df98945e08: [libfuzzer] Reduce default verbosity when printing large mutation sequences (authored by mhlakhani).
[libfuzzer] Reduce default verbosity when printing large mutation sequences
Sep 16 2020, 9:24 AM
morehouse closed D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.
Sep 16 2020, 9:24 AM · Restricted Project
morehouse accepted D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

Test looks good, thanks for figuring out the regex stuff.

Sep 16 2020, 9:19 AM · Restricted Project

Sep 15 2020

morehouse added inline comments to D87552: [Asan] Fix false leak report.
Sep 15 2020, 5:12 PM · Restricted Project
morehouse added inline comments to D87552: [Asan] Fix false leak report.
Sep 15 2020, 4:19 PM · Restricted Project
morehouse added inline comments to D87552: [Asan] Fix false leak report.
Sep 15 2020, 3:23 PM · Restricted Project
morehouse added inline comments to D87552: [Asan] Fix false leak report.
Sep 15 2020, 3:14 PM · Restricted Project
morehouse added inline comments to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.
Sep 15 2020, 9:48 AM · Restricted Project

Sep 14 2020

morehouse added inline comments to D85928: [libFuzzer] Added -print_full_coverage flag..
Sep 14 2020, 6:11 PM · Restricted Project, Restricted Project
morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

I'd like to keep the test, but we can separate it into its own file and use UNSUPPORTED or REQUIRES to avoid running on systems that don't have the tools we need.

Sep 14 2020, 5:46 PM · Restricted Project
morehouse accepted D87647: [NFC][Asan] Remove chunk pointer from metadata.

LGTM

Sep 14 2020, 5:37 PM · Restricted Project
morehouse accepted D87646: [Asan] Cleanup kAllocBegMagic setup.
Sep 14 2020, 5:31 PM · Restricted Project
morehouse accepted D87645: [NFC][Asan] Reorder bitfields.

LGTM

Sep 14 2020, 4:57 PM · Restricted Project
morehouse accepted D87644: [NFC][Asan] Remove from_memalign and rz_log.

LGTM

Sep 14 2020, 4:55 PM · Restricted Project
morehouse accepted D87643: [NFC][Asan] Don't use MetaData for size.
Sep 14 2020, 4:47 PM · Restricted Project
morehouse accepted D87642: [Asan] Accept __lsan_ignore_object for redzone pointer.

LGTM

Sep 14 2020, 4:23 PM · Restricted Project
morehouse accepted D87552: [Asan] Fix false leak report.
Sep 14 2020, 9:32 AM · Restricted Project

Sep 11 2020

morehouse committed rG2df6efedef5c: [DFSan] Re-enable event_callbacks test. (authored by morehouse).
[DFSan] Re-enable event_callbacks test.
Sep 11 2020, 9:15 AM
morehouse updated the diff for D87476: [libFuzzer] Enable entropic by default..
  • Update focus_function doc string.
  • Increase runs for keep-seed and uniform crossover tests.
Sep 11 2020, 8:40 AM · Restricted Project

Sep 10 2020

morehouse added a comment to D87476: [libFuzzer] Enable entropic by default..

@dokyungs Any idea why enabling entropic causes the KeepSeed tests to fail?

Sep 10 2020, 12:29 PM · Restricted Project
morehouse added inline comments to D87476: [libFuzzer] Enable entropic by default..
Sep 10 2020, 12:02 PM · Restricted Project
morehouse requested review of D87476: [libFuzzer] Enable entropic by default..
Sep 10 2020, 11:44 AM · Restricted Project
morehouse accepted D87217: [Asan] Fix __asan_update_allocation_context.

LGTM

Sep 10 2020, 8:16 AM · Restricted Project

Sep 9 2020

morehouse added inline comments to D87217: [Asan] Fix __asan_update_allocation_context.
Sep 9 2020, 4:47 PM · Restricted Project
morehouse resigned from D87359: [Asan] Don't use allocator Metadata.
Sep 9 2020, 4:24 PM · Restricted Project
morehouse accepted D87135: [Asan] Return nullptr for invalid chunks.

LGTM

Sep 9 2020, 2:03 PM · Restricted Project

Sep 8 2020

morehouse accepted D86560: [libFuzzer] Add a command-line option for tracing mutation of corpus inputs in the dot graph format..

This is a great patch, thank you DK!

Sep 8 2020, 5:18 PM · Restricted Project
morehouse added inline comments to D87135: [Asan] Return nullptr for invalid chunks.
Sep 8 2020, 4:53 PM · Restricted Project
morehouse accepted D86931: [Asan] Don't crash if metadata is not initialized.

Please update the commit message.

Sep 8 2020, 1:11 PM · Restricted Project
morehouse accepted D86933: [NFC][Asan] Remove Debug code.

LGTM

Sep 8 2020, 8:50 AM · Restricted Project

Sep 3 2020

morehouse committed rG711b9806547b: [fuzzer] Create user provided fuzzer writeable directories when requested if… (authored by morehouse).
[fuzzer] Create user provided fuzzer writeable directories when requested if…
Sep 3 2020, 8:33 AM
morehouse closed D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.
Sep 3 2020, 8:32 AM · Restricted Project
morehouse accepted D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.

LGTM

Sep 3 2020, 7:56 AM · Restricted Project

Sep 2 2020

morehouse accepted D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..

LGTM

Sep 2 2020, 5:54 PM · Restricted Project
morehouse added a comment to D85928: [libFuzzer] Added -print_full_coverage flag..

I'll take a look once the diff is fixed and Max's current comments are addressed.

Sep 2 2020, 5:33 PM · Restricted Project, Restricted Project
morehouse accepted D86954: [libFuzzer] Evenly select inputs to cross over with from the corpus regardless of the input's coverage..

Please make sure the harbormaster test passes before landing.

Sep 2 2020, 5:28 PM · Restricted Project
morehouse added inline comments to D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..
Sep 2 2020, 5:25 PM · Restricted Project
morehouse accepted D86577: [libFuzzer] Add an option to keep initial seed inputs around..

LGTM

Sep 2 2020, 5:20 PM · Restricted Project
morehouse added inline comments to D86931: [Asan] Don't crash if metadata is not initialized.
Sep 2 2020, 5:16 PM · Restricted Project
morehouse added a comment to D86922: [Asan] Don't use MetaData for size.

This patch changes how the allocator works, so I don't think it qualifies as NFC.

Sep 2 2020, 4:53 PM · Restricted Project
morehouse accepted D86919: [NFC][Asan] Set AP32::kMetadataSize to 0.

LGTM

Sep 2 2020, 4:02 PM · Restricted Project
morehouse accepted D86917: [Asan] Cleanup atomic usage in allocator.
Sep 2 2020, 3:58 PM · Restricted Project
morehouse added inline comments to D86577: [libFuzzer] Add an option to keep initial seed inputs around..
Sep 2 2020, 2:40 PM · Restricted Project
morehouse added inline comments to D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..
Sep 2 2020, 1:12 PM · Restricted Project

Sep 1 2020

morehouse committed rG49dda4e58aeb: [libFuzzer] Break dependency on common_interface_defs.h (authored by morehouse).
[libFuzzer] Break dependency on common_interface_defs.h
Sep 1 2020, 3:35 PM
morehouse closed D86981: [libFuzzer] Break dependency on common_interface_defs.h.
Sep 1 2020, 3:35 PM · Restricted Project
morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

The libFuzzer tests automatically run on harbormaster when you update the patch, but that's often a different environment than the bots.

Sep 1 2020, 3:33 PM · Restricted Project
morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

I do have access to that bot, but the log is gone already. Sorry.

Sep 1 2020, 3:28 PM · Restricted Project
morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

The log from the darwin bot has:

+ : 'RUN: at line 18'
+ grep NEW /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/tools/clang/runtime/compiler-rt-bins/test/fuzzer/X86_64DefaultDarwinConfig/Output/fuzzer-custommutator.test.tmp-mutate-verbose-log
+ grep '.\{1024\}'
grep: invalid repetition count(s)

So at least one issue seems to be from different grep feature support on different machines.

Sep 1 2020, 2:54 PM · Restricted Project
morehouse requested review of D86981: [libFuzzer] Break dependency on common_interface_defs.h.
Sep 1 2020, 2:42 PM · Restricted Project
morehouse reopened D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

Had to revert due to multiple buildbot failures:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/38581/steps/check-fuzzer/logs/stdio
http://green.lab.llvm.org/green//job/clang-stage1-RA/14180/consoleFull#-1417328700a1ca8a51-895e-46c6-af87-ce24fa4cd561

Sep 1 2020, 12:51 PM · Restricted Project
morehouse added a reverting change for rG2665425908e0: [libfuzzer] Reduce default verbosity when printing large mutation sequences: rG7139736261e0: Revert "[libfuzzer] Reduce default verbosity when printing large mutation….
Sep 1 2020, 12:50 PM
morehouse committed rG7139736261e0: Revert "[libfuzzer] Reduce default verbosity when printing large mutation… (authored by morehouse).
Revert "[libfuzzer] Reduce default verbosity when printing large mutation…
Sep 1 2020, 12:50 PM
morehouse added a reverting change for D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences: rG7139736261e0: Revert "[libfuzzer] Reduce default verbosity when printing large mutation….
Sep 1 2020, 12:50 PM · Restricted Project
morehouse reopened D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.
Sep 1 2020, 12:07 PM · Restricted Project