Page MenuHomePhabricator

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (230 w, 2 d)

Recent Activity

Yesterday

vitalybuka added a reverting change for rG5fd49911db54: [NFC][StackSafety] Add index test: rG6d9b3cb2fb5f: Revert "[NFC][StackSafety] Add index test".
Sat, Aug 8, 9:27 PM
vitalybuka committed rG6d9b3cb2fb5f: Revert "[NFC][StackSafety] Add index test" (authored by vitalybuka).
Revert "[NFC][StackSafety] Add index test"
Sat, Aug 8, 9:27 PM
vitalybuka committed rG5fd49911db54: [NFC][StackSafety] Add index test (authored by vitalybuka).
[NFC][StackSafety] Add index test
Sat, Aug 8, 7:12 PM
vitalybuka committed rGb317321545aa: [NFC][StackSafety] noinline in alias tests (authored by vitalybuka).
[NFC][StackSafety] noinline in alias tests
Sat, Aug 8, 6:22 PM

Fri, Aug 7

vitalybuka committed rG648228bcc33c: [NFC][StackSafety] Fix statistics (authored by vitalybuka).
[NFC][StackSafety] Fix statistics
Fri, Aug 7, 4:19 PM
vitalybuka added a reverting change for rG0b2616a8045c: [StackSafety] Skip ambiguous lifetime analysis: rG7547508b7ae0: Revert "[StackSafety] Skip ambiguous lifetime analysis".
Fri, Aug 7, 2:03 PM
vitalybuka committed rG7547508b7ae0: Revert "[StackSafety] Skip ambiguous lifetime analysis" (authored by vitalybuka).
Revert "[StackSafety] Skip ambiguous lifetime analysis"
Fri, Aug 7, 2:03 PM
vitalybuka added a reverting change for D84630: [StackSafety] Skip ambiguous lifetime analysis: rG7547508b7ae0: Revert "[StackSafety] Skip ambiguous lifetime analysis".
Fri, Aug 7, 2:03 PM · Restricted Project
vitalybuka committed rG7d4996033bc5: [StackSafety,NFC] Add Stats counters (authored by vitalybuka).
[StackSafety,NFC] Add Stats counters
Fri, Aug 7, 2:03 PM
vitalybuka reopened D84630: [StackSafety] Skip ambiguous lifetime analysis.
Fri, Aug 7, 2:00 PM · Restricted Project

Thu, Aug 6

vitalybuka committed rG7fb9de2c6f57: [StackSafety,NFC] Fix tests in debug (authored by vitalybuka).
[StackSafety,NFC] Fix tests in debug
Thu, Aug 6, 8:47 PM
vitalybuka committed rG39cbcbe1b1e5: [StackSafety,NFC] Add more tests (authored by vitalybuka).
[StackSafety,NFC] Add more tests
Thu, Aug 6, 7:52 PM
vitalybuka committed rGd97636196af1: [StackSafety,NFC] Sort llvm-lto2 resolutions in tests (authored by vitalybuka).
[StackSafety,NFC] Sort llvm-lto2 resolutions in tests
Thu, Aug 6, 7:49 PM
vitalybuka committed rG58b95c9b2bb7: [StackSafety,NFC] Add debug counters (authored by vitalybuka).
[StackSafety,NFC] Add debug counters
Thu, Aug 6, 7:24 PM
vitalybuka committed rG92dcf12b2f20: [StackSafety,NFC] Use CHECK-EMPTY in tests (authored by vitalybuka).
[StackSafety,NFC] Use CHECK-EMPTY in tests
Thu, Aug 6, 7:21 PM
vitalybuka committed rGfaeeed6f5245: [LLParser,NFC] Simplify forward GV refs update (authored by vitalybuka).
[LLParser,NFC] Simplify forward GV refs update
Thu, Aug 6, 7:19 PM
vitalybuka closed D85238: [LLParser,NFC] Simplify forward GV refs update.
Thu, Aug 6, 7:19 PM · Restricted Project
vitalybuka updated the summary of D85238: [LLParser,NFC] Simplify forward GV refs update.
Thu, Aug 6, 7:15 PM · Restricted Project
vitalybuka added reviewers for D84906: [NFC] Use GetUnderlyingObjects in findAllocaForValue: lebedev.ri, efriedma, spatel.
Thu, Aug 6, 7:13 PM · Restricted Project
vitalybuka committed rG0b2616a8045c: [StackSafety] Skip ambiguous lifetime analysis (authored by vitalybuka).
[StackSafety] Skip ambiguous lifetime analysis
Thu, Aug 6, 7:10 PM
vitalybuka closed D84630: [StackSafety] Skip ambiguous lifetime analysis.
Thu, Aug 6, 7:10 PM · Restricted Project
vitalybuka committed rG5c6d9b2bbfaf: [LTO,NFC] Skip generateParamAccessSummary when empty (authored by vitalybuka).
[LTO,NFC] Skip generateParamAccessSummary when empty
Thu, Aug 6, 7:01 PM
vitalybuka closed D85182: [LTO,NFC] Skip generateParamAccessSummary when empty.
Thu, Aug 6, 7:01 PM · Restricted Project
vitalybuka updated the diff for D85182: [LTO,NFC] Skip generateParamAccessSummary when empty.

remove if (!HasParamAccess)

Thu, Aug 6, 6:52 PM · Restricted Project
vitalybuka added a comment to D85238: [LLParser,NFC] Simplify forward GV refs update.

That certainly looks cleaner, can't recall why I wrote it the original way. But why does this depend on D85182? I must be missing something.

Thu, Aug 6, 5:02 PM · Restricted Project
vitalybuka added inline comments to D84961: [MSAN RT] Use __sanitizer::mem_is_zero in __msan_test_shadow.
Thu, Aug 6, 4:03 PM · Restricted Project
vitalybuka accepted D85350: [msan] Support %ms in scanf..
Thu, Aug 6, 1:42 PM · Restricted Project

Tue, Aug 4

vitalybuka updated the diff for D85269: [StackSafety] Use ValueInfo in ParamAccess::Call.

remove commented text

Tue, Aug 4, 6:58 PM · Restricted Project
vitalybuka requested review of D85269: [StackSafety] Use ValueInfo in ParamAccess::Call.
Tue, Aug 4, 6:52 PM · Restricted Project
vitalybuka committed rGfe74f731e702: [StackSafety,NFC] Add combined index test (authored by vitalybuka).
[StackSafety,NFC] Add combined index test
Tue, Aug 4, 6:32 PM
vitalybuka committed rG03a822f7a676: [StackSafety,NFC] Add combined index test (authored by vitalybuka).
[StackSafety,NFC] Add combined index test
Tue, Aug 4, 5:41 PM
vitalybuka requested review of D85238: [LLParser,NFC] Simplify forward GV refs update.
Tue, Aug 4, 12:18 PM · Restricted Project
vitalybuka requested review of D85182: [LTO,NFC] Skip generateParamAccessSummary when empty.
Tue, Aug 4, 1:01 AM · Restricted Project

Mon, Aug 3

vitalybuka added a comment to D81242: [StackSafety] Run ThinLTO.

Is the stack safety analysis meant to be always on with ThinLTO?

During compilation most of the time it should be off.
However during linking I assume that most build FS->paramAccesses() is empty, so no hash lookup is expected. So I assume empty looks should be cheap:

for (auto &GVS : Index) {
    for (auto &GV : GVS.second.SummaryList) {
}}

As it paramAccesses suppose to be non-empty for MTE builds for now, so if it's not empty on internal build, then the bug it likely around why it's not empty there.
Can you send me email with internal build details?

Will do

Mon, Aug 3, 12:42 AM · Restricted Project, Restricted Project

Sun, Aug 2

vitalybuka committed rG08cf49658c1d: [StackSafety, NFC] Don't insert empty objects into the map (authored by vitalybuka).
[StackSafety, NFC] Don't insert empty objects into the map
Sun, Aug 2, 1:59 PM

Sat, Aug 1

vitalybuka accepted D84945: [compiler-rt] Normalize some in/out doxygen parameter in interface headers. NFC..
Sat, Aug 1, 12:56 AM · Restricted Project
vitalybuka accepted D85061: [msan] Respect no_huge_pages_for_shadow..
Sat, Aug 1, 12:49 AM · Restricted Project

Fri, Jul 31

vitalybuka added a comment to D81242: [StackSafety] Run ThinLTO.

Is the stack safety analysis meant to be always on with ThinLTO?

During compilation most of the time it should be off.
However during linking I assume that most build FS->paramAccesses() is empty, so no hash lookup is expected. So I assume empty looks should be cheep:

Fri, Jul 31, 3:57 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D81242: [StackSafety] Run ThinLTO.

I just noticed that generateParamAccessSummary is taking a bit over 5% of the ThinLTO thin link step in an internal build (and will soon be more than 5% as I found another analysis that is hogging compile time that I'm going to work on fixing). This is currently the second hottest analysis in the thin link. Is the stack safety analysis meant to be always on with ThinLTO?

I have a theory on what is causing it to incur so much overhead, see below.

Fri, Jul 31, 3:41 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D84906: [NFC] Use GetUnderlyingObjects in findAllocaForValue.
Fri, Jul 31, 4:00 AM · Restricted Project
vitalybuka added inline comments to D84906: [NFC] Use GetUnderlyingObjects in findAllocaForValue.
Fri, Jul 31, 3:15 AM · Restricted Project
vitalybuka committed rGb0eb40ca3998: [NFC] Remove unused GetUnderlyingObject paramenter (authored by vitalybuka).
[NFC] Remove unused GetUnderlyingObject paramenter
Fri, Jul 31, 2:10 AM
vitalybuka closed D84621: [NFC] Remove unused GetUnderlyingObject paramenter.
Fri, Jul 31, 2:10 AM · Restricted Project

Thu, Jul 30

vitalybuka updated the diff for D84621: [NFC] Remove unused GetUnderlyingObject paramenter.

rebase

Thu, Jul 30, 9:22 PM · Restricted Project
vitalybuka committed rG89051ebacea7: [NFC] GetUnderlyingObject -> getUnderlyingObject (authored by vitalybuka).
[NFC] GetUnderlyingObject -> getUnderlyingObject
Thu, Jul 30, 9:08 PM
vitalybuka committed rGb256cb88a716: [ValueTracking] Remove AllocaForValue parameter (authored by vitalybuka).
[ValueTracking] Remove AllocaForValue parameter
Thu, Jul 30, 6:49 PM
vitalybuka closed D84617: [ValueTracking] Remove AllocaForValue parameter.
Thu, Jul 30, 6:48 PM · Restricted Project
vitalybuka committed rG61cab352e377: [NFC] Move findAllocaForValue into ValueTracking.h (authored by vitalybuka).
[NFC] Move findAllocaForValue into ValueTracking.h
Thu, Jul 30, 6:23 PM
vitalybuka closed D84616: [NFC] Move findAllocaForValue into ValueTracking.h.
Thu, Jul 30, 6:23 PM · Restricted Project

Wed, Jul 29

vitalybuka added inline comments to D84630: [StackSafety] Skip ambiguous lifetime analysis.
Wed, Jul 29, 7:56 PM · Restricted Project
vitalybuka updated the diff for D84630: [StackSafety] Skip ambiguous lifetime analysis.

fixed typo

Wed, Jul 29, 7:56 PM · Restricted Project
vitalybuka requested review of D84906: [NFC] Use GetUnderlyingObjects in findAllocaForValue.
Wed, Jul 29, 7:50 PM · Restricted Project

Tue, Jul 28

vitalybuka accepted D84510: [msan] Compile the libatomic.c test with a C compiler.
Tue, Jul 28, 7:46 PM · Restricted Project
vitalybuka accepted D84819: Add more debug code for https://github.com/google/sanitizers/issues/1193 (getting desperate, not being able to reproduce it for a few months, but the users are seeing it).
Tue, Jul 28, 7:13 PM · Restricted Project
vitalybuka added inline comments to D84511: Fix update_cc_test_checks.py --llvm-bin after D78478.
Tue, Jul 28, 4:59 PM · Restricted Project, Restricted Project
vitalybuka accepted D84511: Fix update_cc_test_checks.py --llvm-bin after D78478.
Tue, Jul 28, 4:57 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D84511: Fix update_cc_test_checks.py --llvm-bin after D78478.

LGTM as it fixes update_cc_test_checks.py

Tue, Jul 28, 4:57 PM · Restricted Project, Restricted Project
vitalybuka accepted D84371: [DFSan] Add efficient fast16labels instrumentation mode..

LGTM either way

Tue, Jul 28, 1:13 AM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D84466: [CompilerRT] Don't pass global compile test flags in non-standalone build.
Tue, Jul 28, 12:54 AM · Restricted Project
vitalybuka accepted D84559: [compiler-rt][cmake] Don't pass --version-script to Illumos ld.

feel free to move suggested changes into a separate patch

Tue, Jul 28, 12:15 AM · Restricted Project
vitalybuka added inline comments to D84559: [compiler-rt][cmake] Don't pass --version-script to Illumos ld.
Tue, Jul 28, 12:14 AM · Restricted Project
vitalybuka accepted D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

Could you please move it one dir up with suggested changes?

Tue, Jul 28, 12:06 AM · Restricted Project

Mon, Jul 27

vitalybuka added inline comments to D84509: Fix qsort() interceptor for FreeBSD.
Mon, Jul 27, 6:28 PM · Restricted Project
vitalybuka added inline comments to D84650: [asan][tsan] Mark tests failing with debug checks as XFAIL.
Mon, Jul 27, 6:18 PM · Restricted Project
vitalybuka accepted D84650: [asan][tsan] Mark tests failing with debug checks as XFAIL.
Mon, Jul 27, 6:16 PM · Restricted Project
vitalybuka accepted D84687: [NewPM][Sancov] Pin RUN lines with -sancov to legacy PM.
Mon, Jul 27, 5:44 PM · Restricted Project
Herald added a project to D84630: [StackSafety] Skip ambiguous lifetime analysis: Restricted Project.
Mon, Jul 27, 3:24 AM · Restricted Project

Sun, Jul 26

Herald added a project to D84621: [NFC] Remove unused GetUnderlyingObject paramenter: Restricted Project.
Sun, Jul 26, 11:37 PM · Restricted Project
Herald added a project to D84617: [ValueTracking] Remove AllocaForValue parameter: Restricted Project.
Sun, Jul 26, 10:37 PM · Restricted Project
Herald added a project to D84616: [NFC] Move findAllocaForValue into ValueTracking.h: Restricted Project.
Sun, Jul 26, 10:36 PM · Restricted Project

Thu, Jul 23

vitalybuka added inline comments to D84371: [DFSan] Add efficient fast16labels instrumentation mode..
Thu, Jul 23, 8:50 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D84425: [libFuzzer] Expose fuzzer::FuzzerDriver().

BTW. Have anyone considered to change/configure arcanist to not to insert them in the first place?

Thu, Jul 23, 2:33 PM · Restricted Project
vitalybuka accepted D84446: [MSAN] Allow inserting array checks.

LGTM with clang-format

Thu, Jul 23, 2:28 PM · Restricted Project
vitalybuka added inline comments to D84446: [MSAN] Allow inserting array checks.
Thu, Jul 23, 12:38 PM · Restricted Project
vitalybuka accepted D84454: scudo: Remove some boilerplate from the combined allocator tests. NFCI..
Thu, Jul 23, 12:15 PM · Restricted Project

Wed, Jul 22

vitalybuka accepted D82680: MSAN: Allow emitting checks for struct types.
Wed, Jul 22, 8:38 PM · Restricted Project
vitalybuka added inline comments to D84361: scudo: Interleave odd and even tags for adjacent blocks..
Wed, Jul 22, 8:03 PM · Restricted Project
vitalybuka accepted D84351: [MSAN] Never allow checking calls to __sanitizer_unaligned_{load,store}.
Wed, Jul 22, 7:24 PM · Restricted Project
vitalybuka added inline comments to D84371: [DFSan] Add efficient fast16labels instrumentation mode..
Wed, Jul 22, 7:15 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka committed rG952fdb6b434e: [sanitizer,NFC] InternalAlloc cleanup (authored by vitalybuka).
[sanitizer,NFC] InternalAlloc cleanup
Wed, Jul 22, 3:08 AM

Sat, Jul 18

vitalybuka committed rG1fe0705cb17a: [sanitizer] Disable test on incompatible platforms (authored by vitalybuka).
[sanitizer] Disable test on incompatible platforms
Sat, Jul 18, 2:23 AM

Fri, Jul 17

vitalybuka committed rGc12f11184682: Corrected __libfuzzer_is_present symbol inclusion for MSVC x86 32-bit (authored by vitalybuka).
Corrected __libfuzzer_is_present symbol inclusion for MSVC x86 32-bit
Fri, Jul 17, 6:30 PM
vitalybuka closed D83594: Corrected __libfuzzer_is_present symbol inclusion for MSVC x86 32-bit.
Fri, Jul 17, 6:30 PM · Restricted Project
vitalybuka accepted D83921: [NewPM][ASan] Make ASan tests work under NPM.
Fri, Jul 17, 5:46 PM · Restricted Project
vitalybuka committed rG1bbed69059d5: [sanitizer] Another attempt to fix protoent test (authored by vitalybuka).
[sanitizer] Another attempt to fix protoent test
Fri, Jul 17, 5:31 PM
vitalybuka added inline comments to D83921: [NewPM][ASan] Make ASan tests work under NPM.
Fri, Jul 17, 1:22 PM · Restricted Project
vitalybuka committed rGe412cc402e84: [asan] Dedup MemToShadowSize (authored by vitalybuka).
[asan] Dedup MemToShadowSize
Fri, Jul 17, 2:40 AM
vitalybuka closed D84004: [compiler-rt][asan] Define MemToShadowSize for sparc64.
Fri, Jul 17, 2:38 AM · Restricted Project
vitalybuka accepted D84004: [compiler-rt][asan] Define MemToShadowSize for sparc64.
Fri, Jul 17, 2:37 AM · Restricted Project
vitalybuka reopened D84004: [compiler-rt][asan] Define MemToShadowSize for sparc64.
Fri, Jul 17, 2:37 AM · Restricted Project
vitalybuka committed rG650baf22e69f: [msan] Fix strxfrm test (authored by vitalybuka).
[msan] Fix strxfrm test
Fri, Jul 17, 2:22 AM
vitalybuka committed rG02c74907e06d: [lsan] Fix SyntaxWarning: "is" with a literal (authored by vitalybuka).
[lsan] Fix SyntaxWarning: "is" with a literal
Fri, Jul 17, 2:21 AM
vitalybuka committed rG05fe0697903a: [gwp-asan] Fix check-all with LIT_FILTER (authored by vitalybuka).
[gwp-asan] Fix check-all with LIT_FILTER
Fri, Jul 17, 2:21 AM
vitalybuka added a reverting change for D83719: [compiler-rt][MSAN][test] Update buffersize for UTF-8 to C convert: rG650baf22e69f: [msan] Fix strxfrm test.
Fri, Jul 17, 2:21 AM · Restricted Project
vitalybuka committed rG40a073eac1bb: [sanitizer] Fix protoent without network (authored by vitalybuka).
[sanitizer] Fix protoent without network
Fri, Jul 17, 2:21 AM
vitalybuka accepted D83361: [LLVM] Add libatomic load/store functions to TargetLibraryInfo.
Fri, Jul 17, 12:22 AM · Restricted Project
vitalybuka accepted D82411: sanitizers: Implement sig{and,or}set interceptors.
Fri, Jul 17, 12:21 AM · Restricted Project
vitalybuka committed rGdbf39e54f648: [sanitizer] Revert accidentally committed file (authored by vitalybuka).
[sanitizer] Revert accidentally committed file
Fri, Jul 17, 12:09 AM
vitalybuka committed rG1cb8cc1fd1b9: [profile] Enabled test on windows (authored by vitalybuka).
[profile] Enabled test on windows
Fri, Jul 17, 12:06 AM

Thu, Jul 16

vitalybuka added a comment to D83967: [profile] Move __llvm_profile_raw_version into a separate file.

I've disabled the test https://reviews.llvm.org/rGb128f719a4c826e8f723eaa9b42b607c81f563a5
Please could you take a look and fix it or add comment explaining why it can't be done?

Thu, Jul 16, 7:50 PM · Restricted Project