Page MenuHomePhabricator
People vitalybuka

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (274 w, 2 d)

Recent Activity
View All

Yesterday

vitalybuka added inline comments to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.
Fri, Jun 11, 6:58 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.
In D104165#2814817, @stephan.yichao.zhao wrote:
In D104165#2814790, @vitalybuka wrote:

why __sanitizer_print_stack_trace is not enough?

We wanted to record stack traces to some databases for post-process. This is similar to the request of printing dfsan origin traces to a buffer.

Fri, Jun 11, 6:56 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.

why __sanitizer_print_stack_trace is not enough?

Fri, Jun 11, 6:21 PM · Restricted Project, Restricted Project
vitalybuka abandoned D102980: [scudo] Always MAP_NORESERVE in to release pages.
Fri, Jun 11, 3:12 PM · Restricted Project
vitalybuka abandoned D102979: [scudo] Use MAP_NORESERVE to release pages.
Fri, Jun 11, 3:12 PM · Restricted Project
vitalybuka added a comment to D103726: [scudo] Enabled MTE before the first allocator.

ping

Fri, Jun 11, 3:12 PM · Restricted Project
vitalybuka accepted D104146: [sanitizer] Replace -mllvm -asan-use-after-return in compile-rt tests with -fsanitize-address-use-after-return (NFC).
Fri, Jun 11, 3:11 PM · Restricted Project
vitalybuka added a comment to D104154: [sanitizer] Replace calls to __asan_get_current_fake_stack with -fsanitize-address-use-after-return=never in tests. (NFC).

I'd prefer we just update __asan_get_current_fake_stack()

Fri, Jun 11, 3:10 PM · Restricted Project
vitalybuka added inline comments to D104155: Add documentation for -fsanitize-address-use-after-return..
Fri, Jun 11, 3:09 PM · Restricted Project
vitalybuka accepted D104152: [sanitizer] Remove numeric values from -asan-use-after-return flag. (NFC).
Fri, Jun 11, 3:02 PM · Restricted Project
vitalybuka added inline comments to D102470: sanitizer_common/symbolizer: fix crashes during exit.
Fri, Jun 11, 12:33 AM · Restricted Project
vitalybuka committed rGf3f904563ec9: [lldb] Fix leak in test (authored by vitalybuka).
[lldb] Fix leak in test
Fri, Jun 11, 12:21 AM
vitalybuka closed D104091: [lldb] Fix leak in test.
Fri, Jun 11, 12:20 AM · Restricted Project
vitalybuka updated the diff for D104091: [lldb] Fix leak in test.

::Terminate

Fri, Jun 11, 12:04 AM · Restricted Project
vitalybuka retitled D104091: [lldb] Fix leak in test from [NFC][lldb] Fix leak in test to [lldb] Fix leak in test.
Fri, Jun 11, 12:03 AM · Restricted Project

Thu, Jun 10

vitalybuka accepted D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct.

I see comment on the D104091

Thu, Jun 10, 11:50 PM · Restricted Project
vitalybuka added inline comments to D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct.
Thu, Jun 10, 11:47 PM · Restricted Project
vitalybuka added inline comments to D102470: sanitizer_common/symbolizer: fix crashes during exit.
Thu, Jun 10, 11:45 PM · Restricted Project
vitalybuka added inline comments to D102470: sanitizer_common/symbolizer: fix crashes during exit.
Thu, Jun 10, 11:42 PM · Restricted Project
vitalybuka accepted D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang..

LGTM with some nits and if you extract FunctionStackPoisoner::initializeCallbacks into a separate patch

Thu, Jun 10, 10:43 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D104091: [lldb] Fix leak in test.
Thu, Jun 10, 6:48 PM · Restricted Project
vitalybuka retitled D104091: [lldb] Fix leak in test from [NFC] Fix leak in test to [NFC][lldb] Fix leak in test.
Thu, Jun 10, 6:47 PM · Restricted Project
vitalybuka requested review of D104091: [lldb] Fix leak in test.
Thu, Jun 10, 6:43 PM · Restricted Project

Wed, Jun 9

vitalybuka accepted D103965: Cleanup for final comment on https://reviews.llvm.org/D103304.

Thanks!

Wed, Jun 9, 1:37 PM · Restricted Project
vitalybuka accepted D102901: [HWASan] Add basic stack tagging support for LAM..
Wed, Jun 9, 1:17 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 8

vitalybuka added inline comments to D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..
Tue, Jun 8, 4:51 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..
Tue, Jun 8, 4:50 PM · Restricted Project, Restricted Project
vitalybuka accepted D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file.
Tue, Jun 8, 10:26 AM · Restricted Project
vitalybuka accepted D103841: [llvm][hwasan] Decouple use of the TLS global for getting the shadow base and using the frame record feature .
Tue, Jun 8, 10:19 AM · Restricted Project, Restricted Project
vitalybuka accepted D102475: Prevent introduction of a dependency of libasan.a on libstdc++.
Tue, Jun 8, 10:04 AM · Restricted Project
vitalybuka accepted D103578: [scudo] Add Scudo support for Trusty OS.

LGTM but upstream testing could be very helpful for those who change code without TrustyOS setup

Tue, Jun 8, 10:03 AM · Restricted Project
vitalybuka accepted D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..

Thanks. LGTM with some nits.

Tue, Jun 8, 9:50 AM · Restricted Project, Restricted Project

Mon, Jun 7

vitalybuka added a comment to rG98a7563261ff: [scudo] Mark ARM64 as supported platform.

Sorry, this thread slipped from me. I assume it's already resolved?

Mon, Jun 7, 9:04 PM
vitalybuka added a comment to rGc9ae3c5e1079: [openmp] Disable tests flaky on Debian.

For this reason I filed https://bugs.llvm.org/show_bug.cgi?id=45397
It's not helpful if it's spamming committers of unrelated changes. I don't
remember but it was probably broken for some time, otherwise I would
probably try to bisect.

Mon, Jun 7, 9:01 PM
vitalybuka added a comment to D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps.
In D103845#2804441, @pcc wrote:

This isn't how the output looks on Android. Are you sure this isn't a Fuchsia-specific bug in the output formatting?

Mon, Jun 7, 8:25 PM · Restricted Project
vitalybuka accepted D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps.
Mon, Jun 7, 7:09 PM · Restricted Project
vitalybuka committed rGb41b76b303cd: [NFC][scudo] Print errno of fork failure (authored by vitalybuka).
[NFC][scudo] Print errno of fork failure
Mon, Jun 7, 6:59 PM
vitalybuka committed rG11539edf52d5: [NFC][LSAN] Limit the number of concurrent threads is the test (authored by vitalybuka).
[NFC][LSAN] Limit the number of concurrent threads is the test
Mon, Jun 7, 5:39 PM
vitalybuka closed D102218: [NFC][LSAN] Limit the number of concurrent threads is the test.
Mon, Jun 7, 5:39 PM · Restricted Project
vitalybuka reopened D102218: [NFC][LSAN] Limit the number of concurrent threads is the test.
Mon, Jun 7, 4:22 PM · Restricted Project
vitalybuka added a comment to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

I am fine with up to 10 :)

Mon, Jun 7, 12:45 PM · Restricted Project
vitalybuka added a comment to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

I looked up all calls to this function and we use this function once per thread, I don't see a point in this caching
Following should be enough and solve symbols issues.

Mon, Jun 7, 12:40 PM · Restricted Project
vitalybuka added a comment to D100645: Sanitizer built against glibc 2.34 doesn't work.
Mon, Jun 7, 12:39 PM · Restricted Project
vitalybuka added a comment to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.
In D102475#2803426, @jakubjelinek wrote:

The reason why the previous change was done is because it is no longer a constant on Linux with recent glibc (2.34 to be released later this year). But it is still constant for older glibcs, or on non-Linux.

Mon, Jun 7, 11:30 AM · Restricted Project
vitalybuka updated subscribers of D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

This patch introduce https://lab.llvm.org/buildbot/#/builders/85/builds/4886

Mon, Jun 7, 11:27 AM · Restricted Project
vitalybuka added inline comments to D103578: [scudo] Add Scudo support for Trusty OS.
Mon, Jun 7, 11:20 AM · Restricted Project
vitalybuka added inline comments to D103578: [scudo] Add Scudo support for Trusty OS.
Mon, Jun 7, 11:19 AM · Restricted Project
vitalybuka added inline comments to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.
Mon, Jun 7, 11:14 AM · Restricted Project
vitalybuka added inline comments to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.
Mon, Jun 7, 11:13 AM · Restricted Project
vitalybuka requested changes to D102475: Prevent introduction of a dependency of libasan.a on libstdc++.
Mon, Jun 7, 11:11 AM · Restricted Project
vitalybuka added a comment to D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..
In D103304#2800789, @kda wrote:

Regarding below, I had this previously: https://reviews.llvm.org/differential/changeset/?ref=2601358

Correct, at that time I thought we are doing WEAK asan_use_after_return_mode, for which new fictions are not needed.
Sorry, we'd save some time if I asked to drop asan_use_after_return_mode instead.
If you are going to recover that one I'd recommencement Flagless -> Always to be consistent with naming?

Mon, Jun 7, 11:04 AM · Restricted Project, Restricted Project
vitalybuka accepted D102475: Prevent introduction of a dependency of libasan.a on libstdc++.

LGTM

Mon, Jun 7, 10:53 AM · Restricted Project

Sat, Jun 5

vitalybuka added a reverting change for rG927688a4cd9d: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|…: rGe3258b0894be: Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=….
Sat, Jun 5, 12:40 AM
vitalybuka committed rGe3258b0894be: Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=… (authored by vitalybuka).
Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=…
Sat, Jun 5, 12:40 AM
vitalybuka reopened D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..
Sat, Jun 5, 12:40 AM · Restricted Project, Restricted Project
vitalybuka added a reverting change for D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always).: rGe3258b0894be: Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=….
Sat, Jun 5, 12:40 AM · Restricted Project, Restricted Project
vitalybuka committed rG927688a4cd9d: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|… (authored by kda).
Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|…
Sat, Jun 5, 12:26 AM
vitalybuka closed D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..
Sat, Jun 5, 12:26 AM · Restricted Project, Restricted Project
vitalybuka accepted D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..

Oh, I missed

Yes, it was a problem on my end, all good now.

Sat, Jun 5, 12:18 AM · Restricted Project, Restricted Project
vitalybuka updated the diff for D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..

rebase

Sat, Jun 5, 12:16 AM · Restricted Project, Restricted Project
vitalybuka added a reverting change for rG00542932fe13: [gn build] manually port 60e5243e593e (weak asan symbol): rGc2f2c1b32c9c: Revert "[gn build] manually port 60e5243e593e (weak asan symbol)".
Sat, Jun 5, 12:03 AM
vitalybuka committed rGc2f2c1b32c9c: Revert "[gn build] manually port 60e5243e593e (weak asan symbol)" (authored by vitalybuka).
Revert "[gn build] manually port 60e5243e593e (weak asan symbol)"
Sat, Jun 5, 12:03 AM

Fri, Jun 4

vitalybuka requested changes to D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..

I looked at Lazy approach and it's simpler then I thought. Asan already contains all needed pieces.
Considering that we have not idea how to handle Windows and Darwin we should do that in this patch.

Fri, Jun 4, 11:56 PM · Restricted Project, Restricted Project
vitalybuka committed rG5b0e50550c0b: [NFC][asan] Split fake_stack() into two funcions (authored by vitalybuka).
[NFC][asan] Split fake_stack() into two funcions
Fri, Jun 4, 11:29 PM
vitalybuka committed rG64b1cbca1978: [NFC][asan] Fix include order (authored by vitalybuka).
[NFC][asan] Fix include order
Fri, Jun 4, 11:29 PM
vitalybuka committed rG6f122d96f728: [NFC][memprof] FIx delete[] usage in test (authored by vitalybuka).
[NFC][memprof] FIx delete[] usage in test
Fri, Jun 4, 11:17 PM
vitalybuka committed rG585b9679ad75: [NFC][asan] format ThreadStackContainsAddress (authored by vitalybuka).
[NFC][asan] format ThreadStackContainsAddress
Fri, Jun 4, 11:17 PM
vitalybuka committed rG4a9111879339: [NFC][memprof] Compile *.c tests as C (authored by vitalybuka).
[NFC][memprof] Compile *.c tests as C
Fri, Jun 4, 11:17 PM
vitalybuka updated the diff for D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..

Upload the last reverted version

Fri, Jun 4, 8:23 PM · Restricted Project, Restricted Project
vitalybuka reopened D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always)..
Fri, Jun 4, 8:20 PM · Restricted Project, Restricted Project
vitalybuka added a reverting change for rG60e5243e593e: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|…: rGd8a4a2cb9321: Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=….
Fri, Jun 4, 8:20 PM
vitalybuka added a reverting change for rG26b3ea224e77: fix SANITIZE_WINDOWS pragma for https://reviews.llvm.: rGd8a4a2cb9321: Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=….
Fri, Jun 4, 8:20 PM
vitalybuka added a reverting change for rG17600ec32a6f: remove windows tests for -asan_use-after-return=always (as this is currently…: rGd8a4a2cb9321: Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=….
Fri, Jun 4, 8:20 PM
vitalybuka added a reverting change for D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always).: rGd8a4a2cb9321: Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=….
Fri, Jun 4, 8:20 PM · Restricted Project, Restricted Project
vitalybuka committed rGd8a4a2cb9321: Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=… (authored by vitalybuka).
Revert "Update and improve compiler-rt tests for -mllvm -asan_use_after_return=…
Fri, Jun 4, 8:20 PM
vitalybuka accepted D103731: [lsan] Bump the thread limit from 1<<13 to 1<<22.
Fri, Jun 4, 7:57 PM · Restricted Project
vitalybuka updated the diff for D103726: [scudo] Enabled MTE before the first allocator.

MemoryTaggingConfig

Fri, Jun 4, 7:52 PM · Restricted Project
vitalybuka committed rG9ff982dbbdd4: [NFC][scudo] Fix sign-compare warning in test (authored by vitalybuka).
[NFC][scudo] Fix sign-compare warning in test
Fri, Jun 4, 7:34 PM
vitalybuka committed rG57ba22629641: [NFC][scudo] Convert to TYPED more ScudoCombinedTest (authored by vitalybuka).
[NFC][scudo] Convert to TYPED more ScudoCombinedTest
Fri, Jun 4, 7:34 PM
vitalybuka committed rG70b29213eb34: [scudo] Remove ScopedString::Length (authored by vitalybuka).
[scudo] Remove ScopedString::Length
Fri, Jun 4, 6:29 PM
vitalybuka closed D103725: [scudo] Remove ScopedString::Length.
Fri, Jun 4, 6:29 PM · Restricted Project
vitalybuka committed rGdf87aeb82682: [Scudo] Improve ScopedString constructor (authored by vitalybuka).
[Scudo] Improve ScopedString constructor
Fri, Jun 4, 6:29 PM
vitalybuka closed D103718: [Scudo] Improve ScopedString constructor.
Fri, Jun 4, 6:28 PM · Restricted Project
vitalybuka retitled D103718: [Scudo] Improve ScopedString constructor from [Scudo] Fix ScopedString constructor after D103641 to [Scudo] Improve ScopedString constructor.
Fri, Jun 4, 6:28 PM · Restricted Project
vitalybuka committed rGb850798f11d3: [NFC][scudo] Fix sign-compare warning in test (authored by vitalybuka).
[NFC][scudo] Fix sign-compare warning in test
Fri, Jun 4, 6:24 PM
vitalybuka requested review of D103726: [scudo] Enabled MTE before the first allocator.
Fri, Jun 4, 4:45 PM · Restricted Project
vitalybuka added a comment to D103718: [Scudo] Improve ScopedString constructor.
In D103718#2800231, @cryptoad wrote:

Was it the DCHECK issues I fixed with https://reviews.llvm.org/D103716 or something else?

I stated that as a fix for DCHECK, but then I noticed that you already landed the fix.
However then I noticed .data() on just created string is still kind of not nice even if it has no DCHECK there.

Fri, Jun 4, 4:41 PM · Restricted Project
vitalybuka added a comment to D103718: [Scudo] Improve ScopedString constructor.

Please stamp this one to avoid conflicts with D103725

Fri, Jun 4, 4:14 PM · Restricted Project
vitalybuka updated the diff for D103725: [scudo] Remove ScopedString::Length.

Fix CHECK

Fri, Jun 4, 4:07 PM · Restricted Project
vitalybuka requested review of D103725: [scudo] Remove ScopedString::Length.
Fri, Jun 4, 3:58 PM · Restricted Project
vitalybuka abandoned D103721: [NFC][scudo] Make formatString return uptr.
Fri, Jun 4, 3:42 PM · Restricted Project
vitalybuka requested review of D103721: [NFC][scudo] Make formatString return uptr.
Fri, Jun 4, 2:48 PM · Restricted Project
vitalybuka updated the diff for D103718: [Scudo] Improve ScopedString constructor.

undo accidental change

Fri, Jun 4, 2:19 PM · Restricted Project
vitalybuka requested review of D103718: [Scudo] Improve ScopedString constructor.
Fri, Jun 4, 2:18 PM · Restricted Project
vitalybuka committed rG1e6d13532535: [scudo] Untag pointer in iterateOverChunks (authored by vitalybuka).
[scudo] Untag pointer in iterateOverChunks
Fri, Jun 4, 12:45 PM
vitalybuka closed D103496: [scudo] Untag pointer in iterateOverChunks.
Fri, Jun 4, 12:45 PM · Restricted Project
vitalybuka updated the diff for D103496: [scudo] Untag pointer in iterateOverChunks.

undo accidental line move

Fri, Jun 4, 12:42 PM · Restricted Project
vitalybuka committed rG07c92b2e9581: [scudo] Add memtag_test (authored by vitalybuka).
[scudo] Add memtag_test
Fri, Jun 4, 12:39 PM
vitalybuka committed rG39f928ed01fd: [scudo] Remove disableMemoryTagChecksTestOnly (authored by vitalybuka).
[scudo] Remove disableMemoryTagChecksTestOnly
Fri, Jun 4, 12:39 PM
vitalybuka closed D103074: [scudo] Add memtag_test.
Fri, Jun 4, 12:38 PM · Restricted Project