Page MenuHomePhabricator

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (253 w, 2 d)

Recent Activity

Thu, Jan 7

vitalybuka accepted D94209: Introduce `UnIgnoreObjectLocked` functions.

Still please do not submit if D94210 does not need it.

Thu, Jan 7, 4:49 PM · Restricted Project
vitalybuka added inline comments to D94210: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Thu, Jan 7, 4:46 PM · Restricted Project

Wed, Jan 6

vitalybuka added inline comments to D94210: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Wed, Jan 6, 6:29 PM · Restricted Project
vitalybuka added inline comments to D94209: Introduce `UnIgnoreObjectLocked` functions.
Wed, Jan 6, 6:20 PM · Restricted Project
vitalybuka added a comment to D94207: [NFC] Refactor `IgnoreObjectLocked`.

Please remove and let compiler decide.
ALWAYS_INLINE may confuse future readers

Wed, Jan 6, 6:18 PM · Restricted Project
vitalybuka added inline comments to D94210: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..
Wed, Jan 6, 6:12 PM · Restricted Project
vitalybuka accepted D94207: [NFC] Refactor `IgnoreObjectLocked`.
Wed, Jan 6, 5:43 PM · Restricted Project
vitalybuka added inline comments to D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
Wed, Jan 6, 5:36 PM · Restricted Project
vitalybuka added inline comments to D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
Wed, Jan 6, 3:03 PM · Restricted Project

Sat, Jan 2

vitalybuka added a comment to D92936: [Sema] Fix deleted function problem in implicitly movable test.

Something is not initialized tihttp://lab.llvm.org:8011/#/builders/74/builds/1834/steps/9/logs/stdio

Sat, Jan 2, 4:26 PM · Restricted Project

Wed, Dec 30

vitalybuka accepted D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Wed, Dec 30, 9:12 PM · Restricted Project, Restricted Project
vitalybuka committed rG9a0237011b7e: [lsan] Ignore inderect leaks referenced by suppressed blocks (authored by vitalybuka).
[lsan] Ignore inderect leaks referenced by suppressed blocks
Wed, Dec 30, 7:12 PM
vitalybuka closed D93884: [lsan] Ignore inderect leaks referenced by suppressed blocks.
Wed, Dec 30, 7:12 PM · Restricted Project
vitalybuka accepted D93386: [compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33.x86_64+i686.
Wed, Dec 30, 12:45 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Wed, Dec 30, 12:44 PM · Restricted Project, Restricted Project

Tue, Dec 29

vitalybuka updated the diff for D93884: [lsan] Ignore inderect leaks referenced by suppressed blocks.

avoid function local static

Tue, Dec 29, 5:38 PM · Restricted Project
vitalybuka committed rG9b25b8068df3: [NFC][lsan] Extract PrintResults function (authored by vitalybuka).
[NFC][lsan] Extract PrintResults function
Tue, Dec 29, 5:29 PM
vitalybuka committed rG9a5261efd755: [lsan] Parse suppressions just before leak reporting (authored by vitalybuka).
[lsan] Parse suppressions just before leak reporting
Tue, Dec 29, 5:29 PM
vitalybuka added inline comments to D93884: [lsan] Ignore inderect leaks referenced by suppressed blocks.
Tue, Dec 29, 3:33 PM · Restricted Project
vitalybuka updated the diff for D93884: [lsan] Ignore inderect leaks referenced by suppressed blocks.

update

Tue, Dec 29, 3:33 PM · Restricted Project
vitalybuka added inline comments to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Tue, Dec 29, 2:29 PM · Restricted Project, Restricted Project
vitalybuka accepted D93921: [CMake][tsan] Remove --sysroot=..
Tue, Dec 29, 2:14 PM · Restricted Project
vitalybuka requested changes to D92521: [tsan] Fix build failure with _FORTIFY_SOURCE.

I assume it's not needed after D93877

Tue, Dec 29, 2:07 PM · Restricted Project
vitalybuka committed rG3c0d36f977d9: [NFC][lsan] Add nested leak in test (authored by vitalybuka).
[NFC][lsan] Add nested leak in test
Tue, Dec 29, 2:03 PM
vitalybuka committed rGababeca34b3f: [NFC][sanitizer] Add SortAndDedup function (authored by vitalybuka).
[NFC][sanitizer] Add SortAndDedup function
Tue, Dec 29, 2:02 PM
vitalybuka committed rG4e74480e0234: [NFC][sanitizer] Simplify InternalLowerBound (authored by vitalybuka).
[NFC][sanitizer] Simplify InternalLowerBound
Tue, Dec 29, 2:02 PM
vitalybuka committed rG673b12e76ff7: [tsan] Remove stdlib.h from dd_interceptors.cpp (authored by vitalybuka).
[tsan] Remove stdlib.h from dd_interceptors.cpp
Tue, Dec 29, 2:01 PM
vitalybuka closed D93877: [tsan] Remove stdlib.h from dd_interceptors.cpp.
Tue, Dec 29, 2:01 PM · Restricted Project
vitalybuka added inline comments to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Tue, Dec 29, 1:55 PM · Restricted Project, Restricted Project

Mon, Dec 28

vitalybuka added a comment to D93386: [compiler-rt] [Sanitizers] Extend ThreadDescriptorSize() for glibc-2.32-2.fc33.x86_64+i686.

We have TEST(SanitizerLinux, ThreadDescriptorSize)
Do you know if it fails on your boxes?

Mon, Dec 28, 11:52 PM · Restricted Project, Restricted Project
vitalybuka requested review of D93884: [lsan] Ignore inderect leaks referenced by suppressed blocks.
Mon, Dec 28, 7:54 PM · Restricted Project
vitalybuka requested review of D93877: [tsan] Remove stdlib.h from dd_interceptors.cpp.
Mon, Dec 28, 4:27 PM · Restricted Project
vitalybuka updated subscribers of D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Mon, Dec 28, 3:13 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.

Can we add #include "sanitizer_common/sanitizer_glibc_version.h" into interception_linux.h ?

Mon, Dec 28, 2:52 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Mon, Dec 28, 1:40 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.

check-asan complains like thins:

Mon, Dec 28, 1:37 PM · Restricted Project, Restricted Project
vitalybuka committed rGb4655a0815d0: [NFC][sanitizer] Remove unused typedef (authored by vitalybuka).
[NFC][sanitizer] Remove unused typedef
Mon, Dec 28, 1:32 PM
vitalybuka accepted D93866: [sanitizer-common] Delete ancient glibc TLS workaround.
Mon, Dec 28, 1:14 PM · Restricted Project
vitalybuka added a comment to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.

LGTM, I'll accept in a day or so if no other feedback

Mon, Dec 28, 1:11 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Mon, Dec 28, 1:10 PM · Restricted Project, Restricted Project

Tue, Dec 22

vitalybuka added inline comments to D93499: [sanitizers] Force pickup of new symbolizer (round #2)..
Tue, Dec 22, 8:43 PM · Restricted Project

Dec 15 2020

vitalybuka accepted D93352: [sanitizer-common] Force pickup of llvm-symbolizer from new binaries..
Dec 15 2020, 8:43 PM · Restricted Project

Dec 14 2020

vitalybuka resigned from D93070: [asan] Search for llvm-symbolizer in the executable's directory instead of only searching in PATH..

I don't have strong opinion

Dec 14 2020, 3:55 PM · Restricted Project

Dec 11 2020

vitalybuka added a comment to D93070: [asan] Search for llvm-symbolizer in the executable's directory instead of only searching in PATH..

Can we embed clang binary location when compiling the program?

Dec 11 2020, 4:36 PM · Restricted Project
vitalybuka added a comment to D93070: [asan] Search for llvm-symbolizer in the executable's directory instead of only searching in PATH..

I am not sure about this change. For the most of users it's very unlikely to have llvm-symbolizer next to the tested binary. Looks like this just simplifies few tests. I'd rather use usual approach with ASAN_OPTIONS there.

Dec 11 2020, 1:49 AM · Restricted Project

Dec 9 2020

vitalybuka accepted D92961: [DFSan] Add custom wrapper for getsockopt..
Dec 9 2020, 12:53 PM · Restricted Project
vitalybuka committed rG8d33f08844a1: [compiler-rt sanitizer] Use our own PTRACE_GETREGSET if it does not exist. (authored by jeroen.dobbelaere).
[compiler-rt sanitizer] Use our own PTRACE_GETREGSET if it does not exist.
Dec 9 2020, 1:08 AM
vitalybuka closed D91686: [compiler-rt sanitizer] Use our own PTRACE_GETREGSET if it does not exist..
Dec 9 2020, 1:08 AM · Restricted Project
vitalybuka accepted D91686: [compiler-rt sanitizer] Use our own PTRACE_GETREGSET if it does not exist..
Dec 9 2020, 12:29 AM · Restricted Project

Dec 7 2020

vitalybuka added a comment to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.

fails here http://lab.llvm.org:8011/#/builders/99/builds/1031

Dec 7 2020, 10:43 PM · Restricted Project
vitalybuka updated subscribers of D92078: [asan] Default to -asan-use-private-alias=1.

I've chatted about that with @kcc and @eugenis . It seems the problem the patch is trying to solve is less important than regressions. Even with the current state when rare false ODR reports are possible it still useful.
It would be nice with -fsanitize-address-use-odr-indicator, but someone will need to figure-out what to do with few users broken by binary size increase.

Dec 7 2020, 9:19 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D92521: [tsan] Fix build failure with _FORTIFY_SOURCE.

I was able to reproduce.

Dec 7 2020, 9:11 PM · Restricted Project
vitalybuka committed rG6e614b0c7ed3: [NFC][MSan] Round up OffsetPtr in PoisonMembers (authored by vitalybuka).
[NFC][MSan] Round up OffsetPtr in PoisonMembers
Dec 7 2020, 8:19 PM
vitalybuka closed D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers.
Dec 7 2020, 8:19 PM · Restricted Project
vitalybuka added a comment to D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers.

Don't you want to similarly align down PoisonEnd?

But if this is something that should never happen, as your comment rightly suggests, wouldn't it be better to add an assert()?
The same in the case when PoisonSize < 0 - it should never happen.

Dec 7 2020, 1:52 PM · Restricted Project
vitalybuka retitled D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers from [NFC][MSan] Round up OffsetPtr in PoisonMembersgetFieldOffset(layoutStartOffset) for current calleds is expected topoint to the first trivial field or the one which follows non-trivial.So it must be byte aligned. However this is not obvious... to [NFC][MSan] Round up OffsetPtr in PoisonMembers.
Dec 7 2020, 1:42 PM · Restricted Project
vitalybuka committed rG3e1cb0db8a79: [CodeGen][MSan] Don't use offsets of zero-sized fields (authored by vitalybuka).
[CodeGen][MSan] Don't use offsets of zero-sized fields
Dec 7 2020, 1:40 PM
vitalybuka closed D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields.
Dec 7 2020, 1:39 PM · Restricted Project
vitalybuka added a comment to D92521: [tsan] Fix build failure with _FORTIFY_SOURCE.

Can you add a test probably in sanitizer_common which reproduces the issue?

The build failure is when building compiler-rt itself, and not in the application trying to use compiler-rt. Should I just create a test mini-sanitizer with one interceptor to demonstrate the problem?

Dec 7 2020, 1:08 PM · Restricted Project

Dec 6 2020

vitalybuka requested review of D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers.
Dec 6 2020, 12:09 AM · Restricted Project

Dec 5 2020

vitalybuka requested review of D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields.
Dec 5 2020, 9:42 PM · Restricted Project
vitalybuka committed rG1f21f6d6a4ce: [NFC][CodeGen] Simplify SanitizeDtorMembers::Emit (authored by vitalybuka).
[NFC][CodeGen] Simplify SanitizeDtorMembers::Emit
Dec 5 2020, 9:20 PM
vitalybuka committed rG19e7741fef77: [TargetMachine] Set dso_local for memprof (authored by vitalybuka).
[TargetMachine] Set dso_local for memprof
Dec 5 2020, 9:11 PM
vitalybuka committed rG452eddf30bfc: [NFC][CodeGen] Add sanitize-dtor-zero-size-field test (authored by vitalybuka).
[NFC][CodeGen] Add sanitize-dtor-zero-size-field test
Dec 5 2020, 4:40 PM

Dec 4 2020

vitalybuka added inline comments to D92078: [asan] Default to -asan-use-private-alias=1.
Dec 4 2020, 12:18 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D92521: [tsan] Fix build failure with _FORTIFY_SOURCE.

Can you add a test probably in sanitizer_common which reproduces the issue?

Dec 4 2020, 11:37 AM · Restricted Project

Dec 3 2020

vitalybuka added a comment to D92519: [tsan] Use REAL macro when calling intercepted function.

It intentionally calls interceptor which will call sigaction_impl where all works is done.

Dec 3 2020, 5:33 PM · Restricted Project
vitalybuka added a reviewer for D92518: [msan] Use REAL macro when calling intercepted function: vitalybuka.
Dec 3 2020, 5:14 PM · Restricted Project
vitalybuka added a comment to D92078: [asan] Default to -asan-use-private-alias=1.

alias change is LGTM, we can try to figure-out how to roll out -fsanitize-address-use-odr-indicator

Dec 3 2020, 5:05 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D92078: [asan] Default to -asan-use-private-alias=1.

https://reviews.llvm.org/D55156
So with this patch no code increase but we lose ODR checks.
To preserve checks we need -fsanitize-address-use-odr-indicator but then binary size increase.

Dec 3 2020, 1:25 AM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2020

vitalybuka committed rG20a2b1bf6bfe: [NFC][sanitizer] Another attempt to fix test on arm (authored by vitalybuka).
[NFC][sanitizer] Another attempt to fix test on arm
Dec 2 2020, 6:36 PM
vitalybuka added a comment to D92490: [msan] Do not use 77 as exit code, instead use 1.

What is going to be the default?

Dec 2 2020, 2:01 PM · Restricted Project
vitalybuka committed rG1f3def16f6e5: [NFC][sanitizer] Fix test on 32bit platform (authored by vitalybuka).
[NFC][sanitizer] Fix test on 32bit platform
Dec 2 2020, 7:34 AM

Dec 1 2020

vitalybuka accepted D92457: [dfsan] Add test cases for struct/pair.
Dec 1 2020, 9:52 PM · Restricted Project
vitalybuka committed rG3f0c4bfc64f3: [NFC][sanitizer] Fix ppc -> powerpc64 in XFAIL (authored by vitalybuka).
[NFC][sanitizer] Fix ppc -> powerpc64 in XFAIL
Dec 1 2020, 5:58 PM
vitalybuka committed rGbdd6718bef6f: [NFC] Disable new test from D92428 on PPC TSAN (authored by vitalybuka).
[NFC] Disable new test from D92428 on PPC TSAN
Dec 1 2020, 4:54 PM
vitalybuka committed rG8a300deb3e46: [sanitizer] Make DTLS_on_tls_get_addr signal safer (authored by vitalybuka).
[sanitizer] Make DTLS_on_tls_get_addr signal safer
Dec 1 2020, 4:16 PM
vitalybuka closed D92428: [sanitizer] Make DTLS_on_tls_get_addr signal safer.
Dec 1 2020, 4:16 PM · Restricted Project
vitalybuka committed rGadfefa555333: [NFC] Extract ForEachDVT (authored by vitalybuka).
[NFC] Extract ForEachDVT
Dec 1 2020, 4:16 PM
vitalybuka added a comment to D92078: [asan] Default to -asan-use-private-alias=1.

I guess another cons was binary size increase? Would you like to run large scale testing on internal Google code?

Dec 1 2020, 4:12 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D92403: [LSan][RISCV] Enable LSan for RISCV64.
Dec 1 2020, 4:04 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D92428: [sanitizer] Make DTLS_on_tls_get_addr signal safer.

update

Dec 1 2020, 3:38 PM · Restricted Project
vitalybuka added inline comments to D92428: [sanitizer] Make DTLS_on_tls_get_addr signal safer.
Dec 1 2020, 2:14 PM · Restricted Project
vitalybuka updated the diff for D92428: [sanitizer] Make DTLS_on_tls_get_addr signal safer.

remove unneded change

Dec 1 2020, 2:11 PM · Restricted Project
vitalybuka retitled D92428: [sanitizer] Make DTLS_on_tls_get_addr signal safer from [sanitizer] Make signal safer to [sanitizer] Make DTLS_on_tls_get_addr signal safer.
Dec 1 2020, 2:04 PM · Restricted Project
vitalybuka requested review of D92428: [sanitizer] Make DTLS_on_tls_get_addr signal safer.
Dec 1 2020, 2:03 PM · Restricted Project

Nov 26 2020

vitalybuka added a comment to D71126: Adding PoisonValue for representing poison value explicitly in IR.

74536==WARNING: MemorySanitizer: use-of-uninitialized-value

#0 0x7c7b3ed in llvm::Value::setValueName(llvm::StringMapEntry<llvm::Value*>*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/Value.cpp:281:3
#1 0x7c78ec6 in destroyValueName /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/Value.cpp:143:3
#2 0x7c78ec6 in llvm::Value::~Value() /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/Value.cpp:104:3
#3 0x7b389e6 in operator() /b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1/memory:2122:5
#4 0x7b389e6 in reset /b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1/memory:2383:7
#5 0x7b389e6 in ~unique_ptr /b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1/memory:2337:19
#6 0x7b389e6 in destroyAll /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/DenseMap.h:368:25
#7 0x7b389e6 in llvm::DenseMap<llvm::Type*, std::__1::unique_ptr<llvm::PoisonValue, std::__1::default_delete<llvm::PoisonValue> >, llvm::DenseMapInfo<llvm::Type*>, llvm::detail::DenseMapPair<llvm::Type*, std::__1::unique_ptr<llvm::PoisonValue, std::__1::default_delete<llvm::PoisonValue> > > >::~DenseMap() /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/DenseMap.h:754:11
#8 0x7b2f91d in llvm::LLVMContextImpl::~LLVMContextImpl() /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LLVMContextImpl.cpp:125:1
#9 0x7b19cff in llvm::LLVMContext::~LLVMContext() /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LLVMContext.cpp:94:31
#10 0x2561bb6 in main /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llc/llc.cpp:366:1
#11 0x7f93b5e3309a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2409a)
#12 0x24e0df9 in _start (/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc+0x24e0df9)
Nov 26 2020, 12:04 AM · Restricted Project

Nov 20 2020

vitalybuka added a comment to D91808: [llvm-zorg] Exit early (skip tests) if builds failed.

bb93d57ac0d2ecbaaf56dae6268b9e4e1bf32199
19b0dd23e09d1fa902550af206a03b019131bc65

Nov 20 2020, 1:49 PM
vitalybuka committed rG3b947cc8ce08: [msan] unpoison_file from fclose and fflash (authored by vitalybuka).
[msan] unpoison_file from fclose and fflash
Nov 20 2020, 1:09 PM
vitalybuka closed D91858: [msan] unpoison_file from fclose and fflash.
Nov 20 2020, 1:09 PM · Restricted Project
vitalybuka updated the summary of D91858: [msan] unpoison_file from fclose and fflash.
Nov 20 2020, 3:56 AM · Restricted Project
vitalybuka updated the diff for D91858: [msan] unpoison_file from fclose and fflash.

format

Nov 20 2020, 3:54 AM · Restricted Project
vitalybuka requested review of D91858: [msan] unpoison_file from fclose and fflash.
Nov 20 2020, 3:53 AM · Restricted Project

Nov 19 2020

vitalybuka added a comment to D91605: [sanitizers] Implement GetTls on Solaris.

Other than file issue, compiler-rt part is LGTM
leaving the rest to @MaskRay

Nov 19 2020, 5:09 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D91808: [llvm-zorg] Exit early (skip tests) if builds failed.

LGTM either way

Nov 19 2020, 3:40 PM

Nov 18 2020

vitalybuka accepted D91765: [sanitizer_common] Add facility to get the full report path.
Nov 18 2020, 11:40 PM · Restricted Project
vitalybuka accepted D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9.

LGTM with some FIXME explaining that it needs investigation in future

Nov 18 2020, 11:37 PM · Restricted Project
vitalybuka added inline comments to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
Nov 18 2020, 11:32 PM · Restricted Project
vitalybuka accepted D91768: [MemProf] Add interface to dump profile.
Nov 18 2020, 11:18 PM · Restricted Project
vitalybuka accepted D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.
Nov 18 2020, 11:15 PM · Restricted Project