Page MenuHomePhabricator

djtodoro (Djordje Todorovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2017, 6:53 AM (161 w, 5 d)

Recent Activity

Yesterday

djtodoro added a comment to D93939: [elf-core] Improve reading memory from core file.

(@labath Sorry for late response, I've been away from keyboard for some time.)

Mon, Jan 18, 7:54 AM · Restricted Project
djtodoro committed rG2040c1110b66: [CSInfo][MIPS] Update CSInfo in delay slot filler (authored by djtodoro).
[CSInfo][MIPS] Update CSInfo in delay slot filler
Mon, Jan 18, 6:31 AM
djtodoro closed D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.
Mon, Jan 18, 6:30 AM · Restricted Project, debug-info
djtodoro accepted D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.
Mon, Jan 18, 3:19 AM · Restricted Project, debug-info
djtodoro added a comment to D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.

some comments inline, lgtm otherwise

Mon, Jan 18, 12:16 AM · Restricted Project, debug-info

Wed, Dec 30

djtodoro updated the summary of D93939: [elf-core] Improve reading memory from core file.
Wed, Dec 30, 1:38 AM · Restricted Project
djtodoro requested review of D93939: [elf-core] Improve reading memory from core file.
Wed, Dec 30, 1:36 AM · Restricted Project

Dec 15 2020

djtodoro added a comment to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.

Ping. :)

Dec 15 2020, 12:05 AM · debug-info, Restricted Project
djtodoro added a comment to D91595: [Debugify] Support checking Machine IR debug info.

Hi @xiangzhangllvm, please wait for @vsk to approve as well, since he is author of the original debugify IR patch and he is very involved in the area.
Thanks a lot for your patience and work.

Dec 15 2020, 12:03 AM · Restricted Project

Dec 11 2020

djtodoro added inline comments to D88592: [DebugInfo] Emit DBG_VALUE_LIST from ISel.
Dec 11 2020, 1:20 AM · Restricted Project, debug-info
djtodoro added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Thanks!! So, this should be the most important one :) I would really like to see some measurements (e.g. llvm-locstats) before/after this patch.
Have you tried building llvm-project itself with this?

So far I've tested this with the benchmarks from the llvm test suite (specifically the CTMark projects, since we're looking for compilation metrics only). I'll post a more complete set of stats soon, but the summary is that there is a small increase in compile time for most projects; <1% or outright negligible in most cases. In terms of locstats, the change looks to add a modest 1-2% increase in overall variable coverage for most projects, although a notable exception is tramp3d-v4 which saw variable coverage change from 53%=>66% - a fairly substantial improvement.

I'm optimistic about further improvements to the locstats following from this work; the current patch doesn't update any of the existing salvaging in Instruction Selection to support variadic locations (they require some specific changes which aren't complicated but require a separate patch), and also enable some new salvaging opportunities in Instruction Selection and the loop passes (such as Loop Strength Reduce).

Dec 11 2020, 1:13 AM · Restricted Project, debug-info
djtodoro added inline comments to D88589: [DebugInfo] Handle dbg.values with multiple variable location operands in ISel.
Dec 11 2020, 1:09 AM · debug-info, Restricted Project

Dec 10 2020

djtodoro added a comment to D86812: [DebugInstrRef][1/3] Track PHI values through register allocation.

LGTM, some nits inline. Thanks.

Dec 10 2020, 2:28 AM · Restricted Project

Dec 9 2020

djtodoro accepted D90046: [LiveDebugValues] Handle spill locations with a fixed and scalable component..

lgtm, thanks!

Dec 9 2020, 7:11 AM · Restricted Project
djtodoro committed rG163c223161b8: [Debuginfo] [CSInfo] Do not create CSInfo for undef arguments (authored by djtodoro).
[Debuginfo] [CSInfo] Do not create CSInfo for undef arguments
Dec 9 2020, 3:56 AM
djtodoro closed D92471: [CSInfo] Do not create CSInfo for undef arguments.
Dec 9 2020, 3:56 AM · debug-info, Restricted Project

Dec 7 2020

djtodoro added a comment to D90046: [LiveDebugValues] Handle spill locations with a fixed and scalable component..

Thanks for addressing the comments.

Dec 7 2020, 6:16 AM · Restricted Project
djtodoro accepted D92471: [CSInfo] Do not create CSInfo for undef arguments.

lgtm, but please keep just one test case, since it is enough (as @dstenb suggested)

Dec 7 2020, 3:26 AM · debug-info, Restricted Project

Dec 3 2020

djtodoro added inline comments to D90046: [LiveDebugValues] Handle spill locations with a fixed and scalable component..
Dec 3 2020, 7:37 AM · Restricted Project

Dec 2 2020

djtodoro added a comment to D92471: [CSInfo] Do not create CSInfo for undef arguments.

I think it would be preferable if we could do this in a target independent place, so that downstream targets, and upstream targets that do not yet support call sites, do not have to care about this.

Can we do this in collectCallSiteParameters by looking at the call instruction's undef uses?

Something like this:

@@ -787,6 +787,15 @@ static void collectCallSiteParameters(const MachineInstr *CallMI,
     (void)InsertedReg;
   }
 
+  for (auto &MO : CallMI->uses()) {
+    if (!MO.isReg() || !MO.isUndef())
+      continue;
+    auto It = ForwardedRegWorklist.find(MO.getReg());
+    if (It == ForwardedRegWorklist.end())
+      continue;
+    ForwardedRegWorklist.erase(It);
+  }
+
Dec 2 2020, 8:12 AM · debug-info, Restricted Project
djtodoro added a comment to D92471: [CSInfo] Do not create CSInfo for undef arguments.

This makes sense to me. The call site info represents info about param value transferring, so if the value was undef, we have "nothing to transfer".

Dec 2 2020, 4:36 AM · debug-info, Restricted Project

Nov 29 2020

djtodoro added inline comments to D90418: [debuginfo] Vectorizing a loop doesn't terminate all vectorized variable locations.
Nov 29 2020, 11:41 PM · debug-info, Restricted Project

Nov 27 2020

djtodoro updated the diff for D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.
  • Use the entry values for local vars as well
Nov 27 2020, 7:15 AM · Restricted Project, debug-info
djtodoro updated the diff for D87233: [POC][DebugInfo] Use entry values within IR.
  • Support old metadata
  • Fix testcases
Nov 27 2020, 7:14 AM · Restricted Project, debug-info

Nov 26 2020

djtodoro accepted D91595: [Debugify] Support checking Machine IR debug info.

(please leave some time (a few days) to other reviewers to take a look)

Nov 26 2020, 6:46 AM · Restricted Project

Nov 25 2020

djtodoro added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 25 2020, 11:50 PM · Restricted Project
djtodoro added a comment to D91595: [Debugify] Support checking Machine IR debug info.

Thanks for addressing the comments! We are almost there.

Nov 25 2020, 1:13 AM · Restricted Project

Nov 23 2020

djtodoro added a comment to D91595: [Debugify] Support checking Machine IR debug info.

Nice! (few nits inline)

Nov 23 2020, 11:50 PM · Restricted Project
djtodoro added a comment to D91595: [Debugify] Support checking Machine IR debug info.

Thanks!

Nov 23 2020, 5:31 AM · Restricted Project

Nov 20 2020

djtodoro added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 20 2020, 12:53 AM · Restricted Project

Nov 19 2020

djtodoro added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 19 2020, 5:59 AM · Restricted Project
djtodoro added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Thanks!! So, this should be the most important one :) I would really like to see some measurements (e.g. llvm-locstats) before/after this patch.
Have you tried building llvm-project itself with this?

Nov 19 2020, 1:47 AM · Restricted Project, debug-info

Nov 18 2020

djtodoro added inline comments to D91595: [Debugify] Support checking Machine IR debug info.
Nov 18 2020, 1:48 AM · Restricted Project

Nov 17 2020

djtodoro edited reviewers for D91595: [Debugify] Support checking Machine IR debug info, added: dsanders; removed: dsanders11.
Nov 17 2020, 3:49 AM · Restricted Project
djtodoro added reviewers for D91595: [Debugify] Support checking Machine IR debug info: dsanders11, vsk.
Nov 17 2020, 3:48 AM · Restricted Project
djtodoro added a comment to D91595: [Debugify] Support checking Machine IR debug info.

Thanks for doing this! (some initial comments inline)

Nov 17 2020, 3:47 AM · Restricted Project

Nov 13 2020

djtodoro committed rG22fd38d5080e: [NFC][IntrRefLDV] Remove dead code from transferSpillOrRestoreInst() (authored by djtodoro).
[NFC][IntrRefLDV] Remove dead code from transferSpillOrRestoreInst()
Nov 13 2020, 7:54 AM
djtodoro closed D90852: [NFC][IntrRefLDV] Remove dead code from transferSpillOrRestoreInst().
Nov 13 2020, 7:54 AM · debug-info, Restricted Project
djtodoro added a comment to D90852: [NFC][IntrRefLDV] Remove dead code from transferSpillOrRestoreInst().

OK, IMPO we can go with removing it completely from the source.

Nov 13 2020, 7:27 AM · debug-info, Restricted Project
djtodoro added inline comments to D84115: [Debuginfo][Codegen] (2/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..
Nov 13 2020, 6:39 AM · Restricted Project, debug-info
djtodoro added inline comments to D84115: [Debuginfo][Codegen] (2/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..
Nov 13 2020, 4:15 AM · Restricted Project, debug-info

Nov 12 2020

djtodoro added inline comments to D84118: [Debuginfo][Salvaging] (5/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..
Nov 12 2020, 2:43 AM · debug-info, Restricted Project
djtodoro added inline comments to D84118: [Debuginfo][Salvaging] (5/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..
Nov 12 2020, 2:32 AM · debug-info, Restricted Project

Nov 5 2020

djtodoro requested review of D90852: [NFC][IntrRefLDV] Remove dead code from transferSpillOrRestoreInst().
Nov 5 2020, 7:20 AM · debug-info, Restricted Project

Nov 3 2020

djtodoro accepted D89337: [DebugInfo][Docs] Document MIR language debug-info constructs.
Nov 3 2020, 1:51 AM · Restricted Project

Oct 29 2020

djtodoro accepted D90433: [dwarfdump] Recognize __apple sections as debug info sections.

lgtm, thanks.

Oct 29 2020, 3:46 PM · Restricted Project
djtodoro added inline comments to D88405: [LiveDebugValues][InstrRef][1/2] Try harder to recover clobbered variable locations.
Oct 29 2020, 12:24 AM · Restricted Project

Oct 28 2020

djtodoro accepted D88405: [LiveDebugValues][InstrRef][1/2] Try harder to recover clobbered variable locations.

Super nit inline.

Oct 28 2020, 8:39 AM · Restricted Project
djtodoro committed rG6384378582b4: [NFC][IntrRefLDV] Improve the Value printing (authored by djtodoro).
[NFC][IntrRefLDV] Improve the Value printing
Oct 28 2020, 7:39 AM
djtodoro closed D90309: [NFC][IntrRefLDV] Improve the Value printing.
Oct 28 2020, 7:39 AM · debug-info, Restricted Project
djtodoro added a comment to D90309: [NFC][IntrRefLDV] Improve the Value printing.

@jmorse Thanks. :)

Oct 28 2020, 7:36 AM · debug-info, Restricted Project
djtodoro requested review of D90309: [NFC][IntrRefLDV] Improve the Value printing.
Oct 28 2020, 7:24 AM · debug-info, Restricted Project
djtodoro accepted D88406: [LiveDebugValues][InstrRef][2/2] Emit entry value variable locations.

LGTM; Please remove "Entry values" from the top-level comment TODO list.

Oct 28 2020, 5:00 AM · Restricted Project

Oct 27 2020

djtodoro accepted D90243: [NFC] [LLParser] Renaming LLParser routines to satisfy LLVM coding style.

It was huge. Thanks.

Oct 27 2020, 9:20 AM · Restricted Project, debug-info
djtodoro added inline comments to D88406: [LiveDebugValues][InstrRef][2/2] Emit entry value variable locations.
Oct 27 2020, 6:29 AM · Restricted Project
djtodoro added inline comments to D88406: [LiveDebugValues][InstrRef][2/2] Emit entry value variable locations.
Oct 27 2020, 6:05 AM · Restricted Project
djtodoro committed rGcca049ad2b30: [NFC][IntrRefLDV] Some code clean up (authored by djtodoro).
[NFC][IntrRefLDV] Some code clean up
Oct 27 2020, 5:32 AM
djtodoro closed D90155: [NFC][IntrRefLDV] Some code clean up.
Oct 27 2020, 5:32 AM · debug-info, Restricted Project

Oct 26 2020

djtodoro requested review of D90155: [NFC][IntrRefLDV] Some code clean up.
Oct 26 2020, 7:08 AM · debug-info, Restricted Project
djtodoro committed rGa64b2c93662d: [NFC][InstrRefLDV] Fix a typo (authored by djtodoro).
[NFC][InstrRefLDV] Fix a typo
Oct 26 2020, 4:05 AM

Oct 23 2020

djtodoro added inline comments to D88898: [DebugInfo][InstrRef][4/4] Support using DBG_INSTR_REF through all* backend passes.
Oct 23 2020, 3:52 AM · Restricted Project

Oct 22 2020

djtodoro accepted D89941: [DebugInfo] Clear subreg in setDebugValueUndef().

This looks reasonable to me.

Oct 22 2020, 5:16 AM · Restricted Project, debug-info

Oct 19 2020

djtodoro added a comment to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.

@StephenTozer Thanks for your comments. I'll address them and refactor the patch a bit, as soon as I catch some time to address some issues with the first patch from the stack.

Oct 19 2020, 6:13 AM · Restricted Project, debug-info
djtodoro added inline comments to D89337: [DebugInfo][Docs] Document MIR language debug-info constructs.
Oct 19 2020, 12:32 AM · Restricted Project

Oct 16 2020

djtodoro requested review of D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.
Oct 16 2020, 12:02 AM · Restricted Project, debug-info

Oct 15 2020

djtodoro added inline comments to D82678: [CGP] Set debug locations when optimizing phi types.
Oct 15 2020, 2:46 AM · debug-info, Restricted Project

Oct 13 2020

djtodoro added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 13 2020, 12:05 AM · debug-info, Restricted Project

Oct 12 2020

djtodoro added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 12 2020, 11:53 PM · debug-info, Restricted Project
djtodoro added a comment to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.

Some nits included.

Oct 12 2020, 11:49 PM · debug-info, Restricted Project

Oct 11 2020

djtodoro added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 11 2020, 11:34 PM · debug-info, Restricted Project

Oct 9 2020

djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

If I understand this correctly, the new {EntryValue, EntryExpr} operands do, if EntryExpr is not undef, specify a location that is identical to the dbg.value's current {Value, Expr} operands, but with DW_OP_LLVM_entry_value implicitly being applied to EntryValue before EntryExpr. Is that correct?

Yes, that is correct.

If so, just throwing out some questions (sorry in case I have overlooked the answers for this in the implementation):

  • I assume that we are only interested in EntryValue operands that are Argument values? Should the verifier catch that? Or is there some case where it could anything else than an Argument?

I think we should extend the Verifier with some kind of support for this. Not sure at the moment how we are going to handle this:

fn(%param) {
...
}

isa<Argument>(%param) ==>true
isa<Argument>(%param.something) ==> false (something could be `addr`)

Actually, I extended the Verifier locally, and I am catching some cases during the replaceAllUsesWith() where the entry value needs to be handled differently, e.g.:

llvm.dbg.value(%p1, !var_p1, !DIExpr(), %p1, !DIExpr()) becomes llvm.dbg.value(i32 0, !var_p1, !DIExpr(), i32 0, !DIExpr())

but we want the entry value to be an undef in this situation, so I am wondering whether we need a new representation of the entry-value, something like MetadataAsEntryValue, so we can invalidate such nodes in an efficent way.

  • What should happen in cases where the dbg.values Value operand already is an Argument? Do we need to specify that value in the EntryValue operand also to ensure that entry values can be emitted?

We should, since the Argument (from some point) can start depending on different entry value, please consider this case:

void fn (int p1, int p2) {
   ...
   p1 = p2;
}

And the intrinsics would be:

llvm.dbg.value(%p1, !var_p1, !DIExpr(), %p1, !DIExpr())
llvm.dbg.value(%p2, !var_p1, !DIExpr(), %p2, !DIExpr())

!var_p2, sorry for my mistake

....
llvm.dbg.value(%p1, !var_p1, !DIExpr(), %p2, !DIExpr()) <=== p1 is an argument, but it depends on different entry value
Oct 9 2020, 10:01 AM · Restricted Project, debug-info
djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

If I understand this correctly, the new {EntryValue, EntryExpr} operands do, if EntryExpr is not undef, specify a location that is identical to the dbg.value's current {Value, Expr} operands, but with DW_OP_LLVM_entry_value implicitly being applied to EntryValue before EntryExpr. Is that correct?

Yes, that is correct.

Oct 9 2020, 1:50 AM · Restricted Project, debug-info

Oct 8 2020

djtodoro added inline comments to D88667: [GlobalISel] Change asserting conditions when initializing call site info.
Oct 8 2020, 7:54 AM · Restricted Project, debug-info

Oct 6 2020

djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

TODO: Handle Function Inlining

Oct 6 2020, 7:53 AM · Restricted Project, debug-info
djtodoro updated the diff for D87233: [POC][DebugInfo] Use entry values within IR.
  • Use VMContext instead of InsertBB->getParent()->getContext()
Oct 6 2020, 7:21 AM · Restricted Project, debug-info
djtodoro added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Oct 6 2020, 7:10 AM · Restricted Project, debug-info
djtodoro updated the diff for D87233: [POC][DebugInfo] Use entry values within IR.
  • Avoid null metadata within the new llvm.dbg.value()
Oct 6 2020, 6:49 AM · Restricted Project, debug-info
djtodoro accepted D88593: [DebugInfo] Add tests for ISel handling of variadic debug values.
Oct 6 2020, 12:47 AM · Restricted Project, debug-info

Oct 5 2020

djtodoro added a comment to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.

This needs to be tested more (so it is not for the final commit (yet)). I believe this triggers some asserts, but (at least) we are covering the cases we want.

Oct 5 2020, 5:43 AM · Restricted Project, debug-info
djtodoro updated the diff for D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.
  • Use 2 extra arguments from llvm.dbg.value()
  • Handle modified params
Oct 5 2020, 5:36 AM · Restricted Project, debug-info
djtodoro requested review of D87233: [POC][DebugInfo] Use entry values within IR.
Oct 5 2020, 5:32 AM · Restricted Project, debug-info
djtodoro updated the diff for D87233: [POC][DebugInfo] Use entry values within IR.
  • Extend the llvm.dbg.value() with 2 operands by describing Entry Value
Oct 5 2020, 5:31 AM · Restricted Project, debug-info
djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

I am about to post new set of patches addressing this problem. We are back to the initial idea that refers to extending the llvm.dbg.value() to hold info about the entry Value. We need to do that, since the current approach (by relying on the method that uses the DILocalVariable*) couldn't detect variable modifications (in an efficient way). Another advantage we are getting with this new approach is that we can handle local variables as well, if it can be expressed in terms of an entry value such as:

void fn (int param) {
 ...
 int local = param + 2;
 ...
Oct 5 2020, 5:25 AM · Restricted Project, debug-info

Oct 1 2020

djtodoro added a reviewer for D88667: [GlobalISel] Change asserting conditions when initializing call site info: arsenm.
Oct 1 2020, 9:31 AM · Restricted Project, debug-info
djtodoro updated the diff for D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
  • Return the names
Oct 1 2020, 3:37 AM · debug-info, Restricted Project
djtodoro added inline comments to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.
Oct 1 2020, 2:27 AM · Restricted Project, debug-info
djtodoro added inline comments to D88406: [LiveDebugValues][InstrRef][2/2] Emit entry value variable locations.
Oct 1 2020, 2:15 AM · Restricted Project

Sep 30 2020

djtodoro added inline comments to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.
Sep 30 2020, 12:30 AM · Restricted Project, debug-info
djtodoro added a comment to D88232: [DebugInfo] Handle multiple variable location operands in IR.

mostly lgtm, some initinal comments inline, thanks!

Sep 30 2020, 12:21 AM · debug-info, Restricted Project

Sep 29 2020

djtodoro added a comment to D88406: [LiveDebugValues][InstrRef][2/2] Emit entry value variable locations.

Thanks a lot for such a nice explanation! I've got it (at least for this example)!

Sep 29 2020, 9:31 AM · Restricted Project
djtodoro added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Sep 29 2020, 7:46 AM · debug-info, Restricted Project

Sep 28 2020

djtodoro added a comment to D88406: [LiveDebugValues][InstrRef][2/2] Emit entry value variable locations.

Hi @jmorse, cool, nice improvement! It turns out that this value-based value tracking pass makes it simple as well as effective!

Sep 28 2020, 5:39 AM · Restricted Project
djtodoro updated the diff for D82547: [VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option.

-Rebasing

Sep 28 2020, 4:51 AM · Restricted Project, Restricted Project, debug-info
djtodoro updated the diff for D82546: [VerifyDIPreserve][OriginalDIMode] Export the report into JSON file.

-Rebasing

Sep 28 2020, 4:51 AM · Restricted Project, debug-info
djtodoro updated the diff for D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.

-Addressing the latest comments
-Rebasing

Sep 28 2020, 4:49 AM · debug-info, Restricted Project

Sep 25 2020

djtodoro added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Sep 25 2020, 7:56 AM · debug-info, Restricted Project
djtodoro added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Sep 25 2020, 7:14 AM · debug-info, Restricted Project
djtodoro added inline comments to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
Sep 25 2020, 2:57 AM · debug-info, Restricted Project
djtodoro planned changes to D87233: [POC][DebugInfo] Use entry values within IR.

@StephenTozer @dstenb Thanks for your comments! I'll try to change the approach (by putting some extra context), so we might end up changing this one (a bit).

Sep 25 2020, 12:36 AM · Restricted Project, debug-info

Sep 24 2020

djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover variables values.
Sep 24 2020, 1:41 AM · Restricted Project, debug-info