Page MenuHomePhabricator

djtodoro (Djordje Todorovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2017, 6:53 AM (145 w, 43 m)

Recent Activity

Today

djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Thu, Sep 24, 1:41 AM · Restricted Project, debug-info

Yesterday

djtodoro planned changes to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 8:35 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 8:34 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 4:44 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 3:56 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 3:54 AM · Restricted Project, debug-info
djtodoro updated the diff for D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
  • addressing comment
Wed, Sep 23, 3:00 AM · Restricted Project, debug-info
djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 23, 2:56 AM · Restricted Project, debug-info
djtodoro updated the diff for D87233: [POC][DebugInfo] Use entry values within IR.
  • addressing comments
Wed, Sep 23, 2:26 AM · Restricted Project, debug-info
djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

Sorry for a piecemeal review from my part!

No problem, the tempo works for me. :) Thanks!

Wed, Sep 23, 2:22 AM · Restricted Project, debug-info

Tue, Sep 22

djtodoro added inline comments to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Tue, Sep 22, 10:18 AM · Restricted Project, debug-info
djtodoro updated the diff for D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
  • Rebase
Tue, Sep 22, 6:53 AM · Restricted Project, debug-info
djtodoro updated the diff for D87233: [POC][DebugInfo] Use entry values within IR.
  • Update the algorithm for finding the entry values
  • Improve the tests
Tue, Sep 22, 6:52 AM · Restricted Project, debug-info
djtodoro added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Tue, Sep 22, 6:49 AM · Restricted Project, debug-info

Mon, Sep 21

djtodoro added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Mon, Sep 21, 5:57 AM · Restricted Project, debug-info
djtodoro updated the diff for D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
  • addressing comments
  • refactoring
  • fixing tests
  • adding RegState::Debug to the Reg from the dbg_value
Mon, Sep 21, 1:42 AM · Restricted Project, debug-info
djtodoro added a comment to D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.

@aprantl thanks for your comments.

Mon, Sep 21, 1:38 AM · Restricted Project, debug-info
djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

@dstenb Please let me know if this looks OK to you now.

Mon, Sep 21, 1:37 AM · Restricted Project, debug-info

Fri, Sep 18

djtodoro requested changes to D87902: [GlobalISel] Fix enumeration of entry basic blocks when using GlobalISel.

Please investigate the test failures.
($ make check-all)

Fri, Sep 18, 7:03 AM · debug-info, Restricted Project
djtodoro added inline comments to D87903: [CSInfo][GlobalISel] CallSiteInfo support when using GlobalISel.
Fri, Sep 18, 6:54 AM · debug-info, Restricted Project
djtodoro added a reviewer for D87903: [CSInfo][GlobalISel] CallSiteInfo support when using GlobalISel: arsenm.
Fri, Sep 18, 6:54 AM · debug-info, Restricted Project
djtodoro added a comment to D87902: [GlobalISel] Fix enumeration of entry basic blocks when using GlobalISel.

LGTM, thanks. The motivation is D87903?

Fri, Sep 18, 6:52 AM · debug-info, Restricted Project
djtodoro added a reviewer for D87902: [GlobalISel] Fix enumeration of entry basic blocks when using GlobalISel: arsenm.
Fri, Sep 18, 6:50 AM · debug-info, Restricted Project

Thu, Sep 17

djtodoro retitled D82547: [VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option from [Debugify] Expose debugify (original mode) as CC1 option to [VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option.
Thu, Sep 17, 5:30 AM · Restricted Project, Restricted Project, debug-info
djtodoro updated the diff for D82547: [VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option.
  • Rebasing
Thu, Sep 17, 5:28 AM · Restricted Project, Restricted Project, debug-info
djtodoro updated the diff for D82546: [VerifyDIPreserve][OriginalDIMode] Export the report into JSON file.
  • Rebasing
  • Refactoring
Thu, Sep 17, 5:26 AM · Restricted Project, debug-info
djtodoro retitled D82546: [VerifyDIPreserve][OriginalDIMode] Export the report into JSON file from [Debugify][OriginalMode] Export the report into JSON file to [VerifyDIPreserve][OriginalDIMode] Export the report into JSON file.
Thu, Sep 17, 5:25 AM · Restricted Project, debug-info
djtodoro updated the diff for D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
  • Addressing comments
  • Refactoring
  • Rename debugify passes into more general name (in order to support original debug info check) - VerifyDIPreserve
  • Rename the options
  • Fix the test cases
  • Update the docs
  • Rebasing
Thu, Sep 17, 5:23 AM · debug-info, Restricted Project
djtodoro added a comment to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.

@aprantl @vsk Thanks a lot for the reviews!

Thu, Sep 17, 4:05 AM · debug-info, Restricted Project

Fri, Sep 11

djtodoro abandoned D85111: [NOT FOR COMMIT] Avoid entry_val ops with callee clobbered regs in call_value.

will make right fix for this (coming soon)

Fri, Sep 11, 12:10 AM · Restricted Project, debug-info

Thu, Sep 10

djtodoro updated the summary of D87233: [POC][DebugInfo] Use entry values within IR.
Thu, Sep 10, 4:23 AM · Restricted Project, debug-info
djtodoro updated the summary of D87233: [POC][DebugInfo] Use entry values within IR.
Thu, Sep 10, 4:22 AM · Restricted Project, debug-info
djtodoro updated the diff for D87233: [POC][DebugInfo] Use entry values within IR.
  • Test new expression
Thu, Sep 10, 4:19 AM · Restricted Project, debug-info
djtodoro added inline comments to D87233: [POC][DebugInfo] Use entry values within IR.
Thu, Sep 10, 4:18 AM · Restricted Project, debug-info

Wed, Sep 9

djtodoro requested review of D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values.
Wed, Sep 9, 2:55 AM · Restricted Project, debug-info
djtodoro updated the diff for D87233: [POC][DebugInfo] Use entry values within IR.

-Split into 2 parts
-Remove unused parts

Wed, Sep 9, 2:51 AM · Restricted Project, debug-info
djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

@dstenb Thanks a lot for your comments! I will split this into two patches.

Wed, Sep 9, 2:48 AM · Restricted Project, debug-info

Mon, Sep 7

djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

(test.c was listed within llvm/test/DebugInfo/X86/entry-values-for-isel-invalidated-nodes.ll)
Looks like LLDB has a problem with parsing "complex" expression with DW_OP_entry_value:

Mon, Sep 7, 6:59 AM · Restricted Project, debug-info
djtodoro added a comment to D87233: [POC][DebugInfo] Use entry values within IR.

This is actually ISel phase, but we still consider SSA, so this should be the latest point we are able to use the findEntryValue() in the pipeline.

Mon, Sep 7, 6:47 AM · Restricted Project, debug-info
djtodoro requested review of D87233: [POC][DebugInfo] Use entry values within IR.
Mon, Sep 7, 6:45 AM · Restricted Project, debug-info

Tue, Sep 1

djtodoro added a reviewer for D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info: dsanders.
Tue, Sep 1, 12:20 AM · debug-info, Restricted Project
djtodoro added a comment to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.

@dblaikie Thanks for your comment!

Tue, Sep 1, 12:19 AM · debug-info, Restricted Project

Mon, Aug 31

djtodoro added a comment to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.

Ping :)

Mon, Aug 31, 11:46 PM · debug-info, Restricted Project

Wed, Aug 26

djtodoro accepted D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4).

LGTM, thanks.

Wed, Aug 26, 11:56 PM · debug-info, Restricted Project

Aug 25 2020

djtodoro added a comment to D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

Please close the revision as well.

Aug 25 2020, 1:46 AM · Restricted Project, debug-info

Aug 24 2020

djtodoro accepted D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations.

nit included, otherwise lgtm, thanks!

Aug 24 2020, 2:31 AM · debug-info, Restricted Project, Restricted Project
djtodoro added inline comments to D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4).
Aug 24 2020, 2:25 AM · debug-info, Restricted Project
djtodoro added a comment to D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics.

@Orlando Thanks for doing this!

Aug 24 2020, 1:49 AM · Restricted Project, debug-info

Aug 7 2020

djtodoro added inline comments to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.
Aug 7 2020, 12:23 PM · Restricted Project
djtodoro added inline comments to D85012: [NOT FOR COMMIT(yet)] [deadargelim] Use entry values for unused args.
Aug 7 2020, 1:52 AM · Restricted Project, debug-info
djtodoro added inline comments to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.
Aug 7 2020, 1:34 AM · Restricted Project

Aug 6 2020

djtodoro added inline comments to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.
Aug 6 2020, 12:06 AM · Restricted Project

Aug 5 2020

djtodoro added a comment to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.

According to the --show-section-sizes output, the .debug_loc has been increased?

Thanks for reviewing this! Yea that's one of the drawback(Added FIXME for the same).

When you say "this causes loc list emission even at -O0" could you be more precise? Does the debug_info actually use a location list somewhere? If so, where, if not - does debug_loc contain an unused location list? Does it contain no location lists, but gets emitted (though empty) when it'd otherwise not be emitted at all?

+1 for this question(s).

Aug 5 2020, 12:47 AM · Restricted Project
djtodoro added inline comments to D85012: [NOT FOR COMMIT(yet)] [deadargelim] Use entry values for unused args.
Aug 5 2020, 12:21 AM · Restricted Project, debug-info

Aug 4 2020

djtodoro added a comment to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.

According to the --show-section-sizes output, the .debug_loc has been increased?

Aug 4 2020, 8:13 AM · Restricted Project
djtodoro added a comment to D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.

From the [0], I've understood that this should affect debug build only (-g + -O0) ?

Aug 4 2020, 7:00 AM · Restricted Project

Aug 3 2020

djtodoro added inline comments to D85012: [NOT FOR COMMIT(yet)] [deadargelim] Use entry values for unused args.
Aug 3 2020, 11:48 PM · Restricted Project, debug-info
djtodoro updated the summary of D85111: [NOT FOR COMMIT] Avoid entry_val ops with callee clobbered regs in call_value.
Aug 3 2020, 1:27 AM · Restricted Project, debug-info
djtodoro requested review of D85111: [NOT FOR COMMIT] Avoid entry_val ops with callee clobbered regs in call_value.
Aug 3 2020, 1:27 AM · Restricted Project, debug-info
djtodoro committed rG4fdc4d892b98: [NFC] [MIR] Document the reg state flags (authored by djtodoro).
[NFC] [MIR] Document the reg state flags
Aug 3 2020, 12:04 AM
djtodoro closed D84634: [NFC] [MIR] Document the reg state flags.
Aug 3 2020, 12:03 AM · Restricted Project

Jul 31 2020

djtodoro requested review of D85012: [NOT FOR COMMIT(yet)] [deadargelim] Use entry values for unused args.
Jul 31 2020, 2:41 AM · Restricted Project, debug-info

Jul 28 2020

djtodoro added a comment to D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.

@StephenTozer Thanks for addressing the comments! Can you please share with us if you have any measurements with the respect to build time increase (e.g. on clang build itself) with this patch? I think that this patch is the only one from the stack that could give us potential performance issues.

Jul 28 2020, 12:24 AM · Restricted Project, debug-info
djtodoro added inline comments to D83054: [LiveDebugValues] 4/4 Initial test changes for InstrRef LiveDebugValues.
Jul 28 2020, 12:14 AM · debug-info, Restricted Project
djtodoro updated the diff for D84634: [NFC] [MIR] Document the reg state flags.
  • additional formatting
Jul 28 2020, 12:12 AM · Restricted Project

Jul 27 2020

djtodoro updated the diff for D84634: [NFC] [MIR] Document the reg state flags.
  • refactor the comments
Jul 27 2020, 11:28 PM · Restricted Project
djtodoro added inline comments to D84634: [NFC] [MIR] Document the reg state flags.
Jul 27 2020, 11:27 PM · Restricted Project
djtodoro created D84634: [NFC] [MIR] Document the reg state flags.
Jul 27 2020, 3:58 AM · Restricted Project
djtodoro added a comment to D84479: [X86] Detect if EFLAGs is live across XBEGIN pseudo instruction. Add it as livein to the basic blocks created when expanding the pseudo.

@craig.topper Thanks for addressing the comments, lgtm now.

Jul 27 2020, 1:07 AM · Restricted Project
djtodoro added a comment to D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.

Hi @vsk, is this in better shape now? :)

Jul 27 2020, 1:03 AM · debug-info, Restricted Project

Jul 24 2020

djtodoro added inline comments to D84479: [X86] Detect if EFLAGs is live across XBEGIN pseudo instruction. Add it as livein to the basic blocks created when expanding the pseudo.
Jul 24 2020, 10:58 AM · Restricted Project
djtodoro added a comment to D84479: [X86] Detect if EFLAGs is live across XBEGIN pseudo instruction. Add it as livein to the basic blocks created when expanding the pseudo.

@craig.topper Thanks for fixing this!

Jul 24 2020, 10:06 AM · Restricted Project
djtodoro committed rG6371a0a00edb: [DWARF][EntryValues] Emit GNU extensions in the case of DWARF 4 + SCE (authored by djtodoro).
[DWARF][EntryValues] Emit GNU extensions in the case of DWARF 4 + SCE
Jul 24 2020, 5:34 AM
djtodoro closed D83463: [DWARF][EntryValues] Emit GNU extensions in the case of DWARF 4 + SCE.
Jul 24 2020, 5:34 AM · Restricted Project, debug-info
djtodoro committed rGcbb3571b0df5: [DWARF] Avoid entry_values production for SCE (authored by djtodoro).
[DWARF] Avoid entry_values production for SCE
Jul 24 2020, 4:34 AM
djtodoro closed D83462: [DWARF] Avoid entry_values production for SCE.
Jul 24 2020, 4:34 AM · Restricted Project, debug-info

Jul 21 2020

djtodoro committed rG30b015dbe9cc: [NFC][Debugify] Rename OptCustomPassManager into DebugifyCustomPassManager (authored by djtodoro).
[NFC][Debugify] Rename OptCustomPassManager into DebugifyCustomPassManager
Jul 21 2020, 3:16 AM
djtodoro closed D83391: [NFC][Debugify] Rename OptCustomPassManager into DebugifyCustomPassManager.
Jul 21 2020, 3:16 AM · Restricted Project, debug-info
djtodoro added inline comments to D83047: [LiveDebugValues] 2/4 Add instruction-referencing LiveDebugValues implementation.
Jul 21 2020, 3:02 AM · debug-info, Restricted Project
djtodoro added inline comments to D83047: [LiveDebugValues] 2/4 Add instruction-referencing LiveDebugValues implementation.
Jul 21 2020, 2:56 AM · debug-info, Restricted Project

Jul 20 2020

djtodoro added a comment to D83391: [NFC][Debugify] Rename OptCustomPassManager into DebugifyCustomPassManager.

@vsk Thanks!

Jul 20 2020, 11:26 PM · Restricted Project, debug-info
djtodoro updated the summary of D83391: [NFC][Debugify] Rename OptCustomPassManager into DebugifyCustomPassManager.
Jul 20 2020, 11:26 PM · Restricted Project, debug-info
djtodoro added a comment to D83462: [DWARF] Avoid entry_values production for SCE.

Any additional comment on this? :)

Jul 20 2020, 1:14 AM · Restricted Project, debug-info
djtodoro added inline comments to D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.
Jul 20 2020, 1:13 AM · Restricted Project, debug-info

Jul 16 2020

djtodoro added a comment to D83890: [DebugInfo] Process DBG_VALUE_LIST in LiveDebugValues.

Thanks for doing this!

Jul 16 2020, 2:34 AM · Restricted Project, debug-info

Jul 15 2020

djtodoro added a comment to D83047: [LiveDebugValues] 2/4 Add instruction-referencing LiveDebugValues implementation.

On the topic of entry values, I believe the value based tracking should make identifying entry values trivial -- all entry value numbers will be identifiable (as a ValueIDNum) with "BlockNo=0" and "InstNo="0", indicating a value defined before the first instruction of the first block. Ideally, the logic would be after machine-value-numbers and variable-values are propagated, when final locations are picked, and would look like this:

  • This variables value is an entry value (BlockNo=0,InstNo=0),
  • That value isn't available in any machine location right now
  • I will emit a DBG_VALUE containing a DW_OP_LLVM_entry_value expression.

My initial impression went in that direction. The implementation of the callee side of the entry values feature (production of the DW_OP_entry_values) within GCC Value Tracking System was trivial as well. I think this new implementation of LLVM LDV will give us more freedom to use entry-values even for modified parameters, if we can express the modification in terms of its entry value (i.e. param = param + 2 ==> DW_OP_plus (DW_OP_entry_value (param), 2)).

Jul 15 2020, 1:32 AM · debug-info, Restricted Project
djtodoro updated the diff for D83462: [DWARF] Avoid entry_values production for SCE.
  • Improve the test
Jul 15 2020, 1:23 AM · Restricted Project, debug-info
djtodoro added inline comments to D83462: [DWARF] Avoid entry_values production for SCE.
Jul 15 2020, 1:12 AM · Restricted Project, debug-info

Jul 14 2020

djtodoro updated the diff for D82547: [VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option.
  • Rebase
Jul 14 2020, 4:31 AM · Restricted Project, Restricted Project, debug-info
djtodoro updated the diff for D82546: [VerifyDIPreserve][OriginalDIMode] Export the report into JSON file.
  • Rebase
Jul 14 2020, 4:30 AM · Restricted Project, debug-info
djtodoro updated the diff for D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info.
  • Rebase
  • TODO: Consider another name for mode. 'original' might be too sharp.
Jul 14 2020, 4:30 AM · debug-info, Restricted Project
djtodoro updated the diff for D83391: [NFC][Debugify] Rename OptCustomPassManager into DebugifyCustomPassManager.
  • Move the def of DebugifyCustomPassManager into the Debugify.h
Jul 14 2020, 4:27 AM · Restricted Project, debug-info
djtodoro added inline comments to D83391: [NFC][Debugify] Rename OptCustomPassManager into DebugifyCustomPassManager.
Jul 14 2020, 4:15 AM · Restricted Project, debug-info
djtodoro updated the diff for D83462: [DWARF] Avoid entry_values production for SCE.
  • Update the comment around ShouldEmitDebugEntryValues()
Jul 14 2020, 12:40 AM · Restricted Project, debug-info

Jul 13 2020

djtodoro updated the summary of D83462: [DWARF] Avoid entry_values production for SCE.
Jul 13 2020, 11:55 PM · Restricted Project, debug-info
djtodoro committed rG1af8c93bab4b: [deadargelim] Attach dbg info to the insert/extractvalue instructions (authored by djtodoro).
[deadargelim] Attach dbg info to the insert/extractvalue instructions
Jul 13 2020, 11:53 PM
djtodoro added a comment to D81939: [deadargelim] Attach dbg info to the insert/extractvalue instructions.

Thanks!

Jul 13 2020, 11:52 PM · debug-info, Restricted Project
djtodoro closed D81939: [deadargelim] Attach dbg info to the insert/extractvalue instructions.
Jul 13 2020, 11:52 PM · debug-info, Restricted Project
djtodoro added inline comments to D83047: [LiveDebugValues] 2/4 Add instruction-referencing LiveDebugValues implementation.
Jul 13 2020, 4:15 AM · debug-info, Restricted Project

Jul 10 2020

djtodoro added inline comments to D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values.
Jul 10 2020, 5:08 AM · Restricted Project, debug-info