Page MenuHomePhabricator

[MLIR] Move TestDialect to ::test namespace
AcceptedPublic

Authored by stephenneuendorffer on Sep 24 2020, 11:54 AM.

Details

Reviewers
mehdi_amini
Summary

This patch is currently broken because many parts of the TableGen
generated files assume they exist in the ::mlir namespace.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2020, 11:54 AM
stephenneuendorffer requested review of this revision.Sep 24 2020, 11:54 AM
mehdi_amini accepted this revision.Sep 24 2020, 9:06 PM

LGTM on the principle, whenever you get it to work :)

This revision is now accepted and ready to land.Sep 24 2020, 9:06 PM
mehdi_amini added inline comments.Sep 24 2020, 9:18 PM
mlir/test/lib/Dialect/Test/TestDialect.cpp
22

River mentioned to me that a good tradeoff would be to keep the using namespace mlir; but move it after the point where we include all the TableGen generated stuff.

That way all the manually written code in this file does not need to be clobbered with mlir:: everywhere.

mlir/test/lib/Dialect/Test/TestDialect.cpp
22

Agreed, I'm more concerned about the tablegen'd stuff being broken right now.