- User Since
- Dec 24 2019, 5:47 AM (32 w, 3 d)
Cool, thanks for the contribution!
Wed, Aug 5
Tue, Aug 4
Awesome, great to see that you are interested in bring up the OpenCL conversion path! :)
This looks awesome! Sorry about the delay... LGTM; just a few nits. I see River has comments so would be good to get his consent too.
LGTM for SPIR-V side.
Tue, Jul 28
Sat, Jul 25
Fri, Jul 24
Thu, Jul 23
Awesome! Can we also support (de)serialization for this?
Wed, Jul 22
Mon, Jul 20
Thu, Jul 16
Wed, Jul 15
This is awesome doc! Thanks George!
Mon, Jul 13
Looks to me #include <optional> is not really needed. Removed it via https://github.com/llvm/llvm-project/commit/9cafbf8f66c9596d8b31293830d8892db0837745.
FYI: this breaks MLIR's buildbot https://buildkite.com/mlir/mlir-core/builds/6347#749c8761-2489-490e-bde9-edc50ea9207c
Thu, Jul 9
@NathanielMcVicar Oh BTW, please certainly feel free to ignore my previous suggestion if it didn't make sense. I don't manage the CIs myself so I can be way off there. And really appreciate your help in reporting the issue and try out patches!
Thanks @ergawy for bearing with all the pain to make this work. I can understand how much additional effort it is to set up a VM for iterating on this. And really appreciate your contribution here.
Feel free to submit after fixing the above issue.
Jul 7 2020
Nice! I believe you can land it by yourself now. So I won't spoil the fun here and will let you do it by yourself. :) Please make sure to follow https://llvm.org/docs/Phabricator.html#committing-a-change.
Rename variables too
Fix accidentially removed code
Address comments: renamed class and file and add comments
Jul 6 2020
This is now changed to use inheritance as suggested by River. Let me know if this is okay now.
Jul 2 2020
Hey @ergawy, I reverted this in https://reviews.llvm.org/D83075. This causes a VS2017 MSVC internal compiler bug: http://lab.llvm.org:8011/builders/mlir-windows/builds/4147/steps/build-unified-tree/logs/stdio. I don't know the exact reason; maybe due to the templating or decltype? Might want to cherry-pick the original patch and then modify it to avoid using those "advanced" features to give it a try.
This is just for trying out whether it's causing the compiler internal error seen in http://lab.llvm.org:8011/builders/mlir-windows/builds/4145/steps/build-unified-tree/logs/stdio.