Page MenuHomePhabricator

antiagainst (Lei Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 24 2019, 5:47 AM (32 w, 3 d)

Recent Activity

Yesterday

antiagainst accepted D85196: [mlir][spirv] Add correct handling of Kernel and Addresses capabilities.

Cool, thanks for the contribution!

Thu, Aug 6, 2:29 PM · Restricted Project
antiagainst accepted D85461: [mlir][SPIR-V] Fix wrongly placed Rationale section..
Thu, Aug 6, 11:50 AM · Restricted Project

Wed, Aug 5

antiagainst committed rG0d03b3901d38: [mlir][StandardToSPIRV] Use spv.UMod for index re-calculation (authored by antiagainst).
[mlir][StandardToSPIRV] Use spv.UMod for index re-calculation
Wed, Aug 5, 11:52 AM
antiagainst closed D83714: [mlir][StandardToSPIRV] Use spv.UMod for index re-calculation.
Wed, Aug 5, 11:52 AM · Restricted Project
antiagainst added inline comments to D83714: [mlir][StandardToSPIRV] Use spv.UMod for index re-calculation.
Wed, Aug 5, 11:47 AM · Restricted Project
antiagainst committed rG48378a32af54: [spirv] Fix bitwidth emulation for Workgroup storage class (authored by antiagainst).
[spirv] Fix bitwidth emulation for Workgroup storage class
Wed, Aug 5, 11:44 AM
antiagainst closed D85308: [spirv] Fix bitwidth emulation for Workgroup storage class.
Wed, Aug 5, 11:44 AM · Restricted Project
antiagainst updated the diff for D85308: [spirv] Fix bitwidth emulation for Workgroup storage class.

Update

Wed, Aug 5, 7:18 AM · Restricted Project
antiagainst requested review of D85308: [spirv] Fix bitwidth emulation for Workgroup storage class.
Wed, Aug 5, 7:12 AM · Restricted Project

Tue, Aug 4

antiagainst accepted D84734: [MLIR][SPIRVToLLVM] Updated documentation for SPIR-V to LLVM conversion.
Tue, Aug 4, 3:32 PM · Restricted Project
antiagainst requested changes to D85196: [mlir][spirv] Add correct handling of Kernel and Addresses capabilities.

Awesome, great to see that you are interested in bring up the OpenCL conversion path! :)

Tue, Aug 4, 3:22 PM · Restricted Project
antiagainst accepted D84107: Add indented raw_ostream class.

This looks awesome! Sorry about the delay... LGTM; just a few nits. I see River has comments so would be good to get his consent too.

Tue, Aug 4, 1:09 PM · Restricted Project
antiagainst accepted D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733.

LGTM for SPIR-V side.

Tue, Aug 4, 12:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Jul 28

antiagainst requested changes to D84734: [MLIR][SPIRVToLLVM] Updated documentation for SPIR-V to LLVM conversion.

Nice!

Tue, Jul 28, 6:44 PM · Restricted Project
antiagainst requested changes to D84626: [MLIR][SPIRVToLLVM] Conversion for global and addressof.
Tue, Jul 28, 6:38 PM · Restricted Project
antiagainst accepted D84175: [MLIR][SPIRV] Control attributes parsing/printing for loop and selection.
Tue, Jul 28, 6:31 PM · Restricted Project
antiagainst accepted D84739: [MLIR][SPIRVToLLVM] Added support of volatile and nontemporal memory access in load/store.
Tue, Jul 28, 5:53 PM · Restricted Project
antiagainst accepted D84731: [MLIR][SPIRV] Added storage class constraint on global variable.
Tue, Jul 28, 5:51 PM · Restricted Project
antiagainst accepted D84661: [MLIR][SPIRVToLLVM] Conversion of GLSL ops to LLVM intrinsics.
Tue, Jul 28, 5:50 PM · Restricted Project
antiagainst accepted D84633: [MLIR][SPIRVToLLVM] Conversion for inverse sqrt and tanh.
Tue, Jul 28, 5:49 PM · Restricted Project
antiagainst accepted D84627: [MLIR][SPIRVToLLVM] Conversion patterns for GLSL ops.
Tue, Jul 28, 4:07 PM · Restricted Project
antiagainst accepted D84657: [MLIR][SPIRVToLLVM] Branch weights support for BranchConditional conversion.
Tue, Jul 28, 4:06 PM · Restricted Project

Sat, Jul 25

GitHub <noreply@github.com> committed rZORG7e51df689871: Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into… (authored by antiagainst).
Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into…
Sat, Jul 25, 6:52 PM

Fri, Jul 24

GitHub <noreply@github.com> committed rZORG18c017b1164d: Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into… (authored by antiagainst).
Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into…
Fri, Jul 24, 2:58 AM

Thu, Jul 23

antiagainst accepted D84236: [MLIR][SPIRVToLLVM] Conversion of load and store SPIR-V ops.
Thu, Jul 23, 4:25 PM · Restricted Project
antiagainst accepted D84196: [MLIR][SPIRV] Updated documentation for variableOp.
Thu, Jul 23, 4:15 PM · Restricted Project
antiagainst requested changes to D84175: [MLIR][SPIRV] Control attributes parsing/printing for loop and selection.

Awesome! Can we also support (de)serialization for this?

Thu, Jul 23, 4:14 PM · Restricted Project
GitHub <noreply@github.com> committed rZORG445a216a1472: Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into… (authored by antiagainst).
Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into…
Thu, Jul 23, 7:52 AM

Wed, Jul 22

GitHub <noreply@github.com> committed rZORG31975020fcf2: Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into… (authored by antiagainst).
Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into…
Wed, Jul 22, 7:35 PM
GitHub <noreply@github.com> committed rZORG84463a9bc1d0: Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into… (authored by antiagainst).
Merge 706905e1515bfa6d00221e1313a2b505d689e8d4 into…
Wed, Jul 22, 7:18 AM
antiagainst committed rZORG706905e1515b: Set up Vulkan compute in mlir-nvidia docker (authored by antiagainst).
Set up Vulkan compute in mlir-nvidia docker
Wed, Jul 22, 7:18 AM
GitHub <noreply@github.com> committed rZORGbfb0880b554f: Merge d6c3b7e43ff2dd9e5323f748ffbb4415200db97f into… (authored by antiagainst).
Merge d6c3b7e43ff2dd9e5323f748ffbb4415200db97f into…
Wed, Jul 22, 7:16 AM
antiagainst committed rZORGd6c3b7e43ff2: Set up Vulkan compute in mlir-nvidia docker and enable Vulkan tests (authored by antiagainst).
Set up Vulkan compute in mlir-nvidia docker and enable Vulkan tests
Wed, Jul 22, 7:16 AM

Mon, Jul 20

antiagainst accepted D84184: [mlir][SPIR-V] Adding rationale for not using memref descriptors.
Mon, Jul 20, 9:16 PM · Restricted Project
antiagainst accepted D83860: [MLIR][LLVMDialect] SelectionOp conversion pattern.
Mon, Jul 20, 6:29 AM · Restricted Project
antiagainst accepted D83784: [MLIR][SPIRVToLLVM] Conversion of SPIR-V branch ops.
Mon, Jul 20, 6:10 AM · Restricted Project

Thu, Jul 16

antiagainst accepted D83322: [MLIR][SPIRVToLLVM] Documentation for SPIR-V to LLVM conversion.

Awesome!

Thu, Jul 16, 3:06 PM · Restricted Project
antiagainst committed rG2dd9e43579b3: [spirv] Use owning module ref to avoid leaks and fix ASAN tests (authored by antiagainst).
[spirv] Use owning module ref to avoid leaks and fix ASAN tests
Thu, Jul 16, 2:31 PM
antiagainst closed D83982: [spirv] Use owning module ref to avoid leaks and fix ASAN tests.
Thu, Jul 16, 2:31 PM · Restricted Project
antiagainst added reviewers for D83982: [spirv] Use owning module ref to avoid leaks and fix ASAN tests: mehdi_amini, rriddle.
Thu, Jul 16, 1:10 PM · Restricted Project
Herald added a project to D83982: [spirv] Use owning module ref to avoid leaks and fix ASAN tests: Restricted Project.
Thu, Jul 16, 1:09 PM · Restricted Project

Wed, Jul 15

antiagainst requested changes to D83322: [MLIR][SPIRVToLLVM] Documentation for SPIR-V to LLVM conversion.

This is awesome doc! Thanks George!

Wed, Jul 15, 8:47 AM · Restricted Project

Mon, Jul 13

antiagainst added inline comments to D83679: [mlir][StandardToSPIRV] Fix conversion for signed remainder.
Mon, Jul 13, 1:24 PM · Restricted Project
Herald added a project to D83714: [mlir][StandardToSPIRV] Use spv.UMod for index re-calculation: Restricted Project.
Mon, Jul 13, 1:23 PM · Restricted Project
antiagainst committed rG4ba45a778a13: [mlir][StandardToSPIRV] Fix conversion for signed remainder (authored by antiagainst).
[mlir][StandardToSPIRV] Fix conversion for signed remainder
Mon, Jul 13, 1:19 PM
antiagainst closed D83679: [mlir][StandardToSPIRV] Fix conversion for signed remainder.
Mon, Jul 13, 1:19 PM · Restricted Project
antiagainst added inline comments to D83679: [mlir][StandardToSPIRV] Fix conversion for signed remainder.
Mon, Jul 13, 1:15 PM · Restricted Project
antiagainst updated the diff for D83679: [mlir][StandardToSPIRV] Fix conversion for signed remainder.

Address comments

Mon, Jul 13, 1:14 PM · Restricted Project
antiagainst added a comment to rGfb7ef0bb0b9c: [ORC] Generalize emit re-entry, stub, etc. APIs for working addr != link addr..

Looks to me #include <optional> is not really needed. Removed it via https://github.com/llvm/llvm-project/commit/9cafbf8f66c9596d8b31293830d8892db0837745.

Mon, Jul 13, 11:44 AM
antiagainst committed rG9cafbf8f66c9: [NFC] Remove unused header include (authored by antiagainst).
[NFC] Remove unused header include
Mon, Jul 13, 11:44 AM
antiagainst closed D83706: [NFC] Remove unused header include.
Mon, Jul 13, 11:44 AM · Restricted Project
Herald added a project to D83706: [NFC] Remove unused header include: Restricted Project.
Mon, Jul 13, 11:41 AM · Restricted Project
antiagainst added a comment to rGfb7ef0bb0b9c: [ORC] Generalize emit re-entry, stub, etc. APIs for working addr != link addr..

FYI: this breaks MLIR's buildbot https://buildkite.com/mlir/mlir-core/builds/6347#749c8761-2489-490e-bde9-edc50ea9207c

Mon, Jul 13, 11:38 AM
antiagainst added a reviewer for D83679: [mlir][StandardToSPIRV] Fix conversion for signed remainder: ThomasRaoux.
Mon, Jul 13, 6:25 AM · Restricted Project
antiagainst added a reviewer for D83679: [mlir][StandardToSPIRV] Fix conversion for signed remainder: hanchung.
Mon, Jul 13, 6:23 AM · Restricted Project
Herald added a project to D83679: [mlir][StandardToSPIRV] Fix conversion for signed remainder: Restricted Project.
Mon, Jul 13, 6:23 AM · Restricted Project

Thu, Jul 9

antiagainst added a comment to D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

@NathanielMcVicar Oh BTW, please certainly feel free to ignore my previous suggestion if it didn't make sense. I don't manage the CIs myself so I can be way off there. And really appreciate your help in reporting the issue and try out patches!

Thu, Jul 9, 6:20 PM · Restricted Project
antiagainst committed rG3847a6ae759e: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory. (authored by ergawy).
[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.
Thu, Jul 9, 5:24 PM
antiagainst closed D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
Thu, Jul 9, 5:24 PM · Restricted Project
antiagainst accepted D83241: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

Thanks @ergawy for bearing with all the pain to make this work. I can understand how much additional effort it is to set up a VM for iterating on this. And really appreciate your contribution here.

Thu, Jul 9, 4:08 PM · Restricted Project
antiagainst accepted D83285: [MLIR][SPIRVToLLVM] SPIR-V types size in bytes function.
Thu, Jul 9, 5:59 AM · Restricted Project
antiagainst accepted D83403: [MLIR][SPIRVToLLVM] Conversion of SPIR-V struct type without offset.

Feel free to submit after fixing the above issue.

Thu, Jul 9, 5:57 AM · Restricted Project
antiagainst requested changes to D83403: [MLIR][SPIRVToLLVM] Conversion of SPIR-V struct type without offset.
Thu, Jul 9, 5:56 AM · Restricted Project
antiagainst accepted D83399: [MLIR][SPIRVToLLVM] Conversion of SPIR-V array, runtime array, and pointer types.
Thu, Jul 9, 5:53 AM · Restricted Project

Jul 7 2020

antiagainst requested changes to D82945: [MLIR][SPIRVToLLVM] Conversion of SPIR-V array, runtime array, pointer and struct types to LLVM dialect..
Jul 7 2020, 7:21 PM · Restricted Project
antiagainst accepted D83291: [MLIR][SPIRVToLLVM] Miscellaneous ops conversion: select, fmul and undef.
Jul 7 2020, 6:50 PM · Restricted Project
antiagainst requested changes to D83285: [MLIR][SPIRVToLLVM] SPIR-V types size in bytes function.
Jul 7 2020, 6:47 PM · Restricted Project
antiagainst committed rG34c485201507: [mlir][spirv] Add MatrixTimesMatrix operation (authored by Hazem).
[mlir][spirv] Add MatrixTimesMatrix operation
Jul 7 2020, 6:38 PM
antiagainst closed D82671: [mlir][spirv] Add MatrixTimesMatrix operation.
Jul 7 2020, 6:38 PM · Restricted Project
antiagainst accepted D82640: [MLIR][SPIRVToLLVM] Implementation of spv.BitFieldSExtract and spv.BitFieldUExtract patterns.

Nice! I believe you can land it by yourself now. So I won't spoil the fun here and will let you do it by yourself. :) Please make sure to follow https://llvm.org/docs/Phabricator.html#committing-a-change.

Jul 7 2020, 6:38 PM · Restricted Project
antiagainst accepted D82671: [mlir][spirv] Add MatrixTimesMatrix operation.

Cool!

Jul 7 2020, 6:32 PM · Restricted Project
antiagainst committed rGb80508703fd7: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership (authored by antiagainst).
[mlir][spirv] Introduce OwningSPIRVModuleRef for ownership
Jul 7 2020, 5:33 AM
antiagainst closed D81652: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership.
Jul 7 2020, 5:32 AM · Restricted Project
antiagainst updated the diff for D81652: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership.

Rename variables too

Jul 7 2020, 5:28 AM · Restricted Project
antiagainst updated the diff for D81652: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership.

Fix accidentially removed code

Jul 7 2020, 5:21 AM · Restricted Project
antiagainst updated the diff for D81652: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership.

Address comments: renamed class and file and add comments

Jul 7 2020, 5:18 AM · Restricted Project

Jul 6 2020

antiagainst added a comment to D81652: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership.

This is now changed to use inheritance as suggested by River. Let me know if this is okay now.

Jul 6 2020, 6:56 PM · Restricted Project
antiagainst updated the diff for D81652: [mlir][spirv] Introduce OwningSPIRVModuleRef for ownership.

Address comments

Jul 6 2020, 6:50 PM · Restricted Project

Jul 2 2020

antiagainst added a comment to D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

Hey @ergawy, I reverted this in https://reviews.llvm.org/D83075. This causes a VS2017 MSVC internal compiler bug: http://lab.llvm.org:8011/builders/mlir-windows/builds/4147/steps/build-unified-tree/logs/stdio. I don't know the exact reason; maybe due to the templating or decltype? Might want to cherry-pick the original patch and then modify it to avoid using those "advanced" features to give it a try.

Jul 2 2020, 2:03 PM · Restricted Project
antiagainst committed rG08679af900c6: Revert "[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory." (authored by antiagainst).
Revert "[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory."
Jul 2 2020, 1:31 PM
antiagainst added a reverting change for rGef2f46e1f6a6: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.: rG08679af900c6: Revert "[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.".
Jul 2 2020, 1:31 PM
antiagainst closed D83075: Revert "[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.".
Jul 2 2020, 1:31 PM · Restricted Project
antiagainst added a reverting change for rGef2f46e1f6a6: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.: D83075: Revert "[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.".
Jul 2 2020, 12:58 PM
antiagainst updated the summary of D83075: Revert "[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.".
Jul 2 2020, 12:57 PM · Restricted Project
antiagainst created D83075: Revert "[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.".
Jul 2 2020, 12:57 PM · Restricted Project
antiagainst added a comment to D83075: Revert "[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.".

This is just for trying out whether it's causing the compiler internal error seen in http://lab.llvm.org:8011/builders/mlir-windows/builds/4145/steps/build-unified-tree/logs/stdio.

Jul 2 2020, 12:57 PM · Restricted Project
antiagainst committed rG1cfaaf645528: [MLIR][SPIRVToLLVM] Convert spv.constant scalars and vectors (authored by georgemitenkov).
[MLIR][SPIRVToLLVM] Convert spv.constant scalars and vectors
Jul 2 2020, 11:53 AM
antiagainst closed D82936: [MLIR][SPIRVToLLVM] Added spv.constant conversion pattern for scalar and vector types.
Jul 2 2020, 11:53 AM · Restricted Project
antiagainst requested changes to D82945: [MLIR][SPIRVToLLVM] Conversion of SPIR-V array, runtime array, pointer and struct types to LLVM dialect..
Jul 2 2020, 11:51 AM · Restricted Project
antiagainst accepted D82936: [MLIR][SPIRVToLLVM] Added spv.constant conversion pattern for scalar and vector types.
Jul 2 2020, 11:51 AM · Restricted Project
antiagainst added inline comments to D82671: [mlir][spirv] Add MatrixTimesMatrix operation.
Jul 2 2020, 11:19 AM · Restricted Project
antiagainst committed rGef2f46e1f6a6: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory. (authored by ergawy).
[MLIR][SPIRV] Support two memory access attributes in OpCopyMemory.
Jul 2 2020, 10:48 AM
antiagainst closed D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..
Jul 2 2020, 10:48 AM · Restricted Project
antiagainst added a comment to D82710: [MLIR][SPIRV] Support two memory access attributes in OpCopyMemory..

It seems that I still don't have commit access. Just to be sure that I didn't do anything wrong. Here what I tried:
1 - I squashed all the commits in my local dev branch into one. Also in the commit messages cleaned up the unnecessary Arcanist tags except for Differential Revision: ...
2 - Rebased on top of master.
3 - Changed the active branch to master.
4 - Cherry picked the squashed commit from step 1.
5 - Tried to: git push.

What I get is:

remote: Permission to llvm/llvm-project.git denied to KareemErgawy.
fatal: unable to access 'https://github.com/llvm/llvm-project.git/': The requested URL returned error: 403
Jul 2 2020, 10:47 AM · Restricted Project
antiagainst committed rG8119a374bc3a: [MLIR][SPIRVToLLVM] SPIR-V function call conversion pattern (authored by georgemitenkov).
[MLIR][SPIRVToLLVM] SPIR-V function call conversion pattern
Jul 2 2020, 9:44 AM
antiagainst closed D83030: [MLIR][SPIRVToLLVM] SPIR-V function call conversion pattern.
Jul 2 2020, 9:43 AM · Restricted Project
antiagainst committed rG03fe7eb16fa2: [MLIR][SPIRVToLLVM] Implementation of spv.BitFieldInsert pattern (authored by georgemitenkov).
[MLIR][SPIRVToLLVM] Implementation of spv.BitFieldInsert pattern
Jul 2 2020, 9:43 AM
antiagainst closed D82639: [MLIR][SPIRVToLLVM] Implementation of spv.BitFieldInsert pattern.
Jul 2 2020, 9:43 AM · Restricted Project
antiagainst accepted D83030: [MLIR][SPIRVToLLVM] SPIR-V function call conversion pattern.
Jul 2 2020, 9:42 AM · Restricted Project
antiagainst requested changes to D82640: [MLIR][SPIRVToLLVM] Implementation of spv.BitFieldSExtract and spv.BitFieldUExtract patterns.
Jul 2 2020, 9:42 AM · Restricted Project