Page MenuHomePhabricator

[clangd] Actually parse Index section of the YAML file.
ClosedPublic

Authored by adamcz on Tue, Sep 15, 11:15 AM.

Details

Summary

This fixes a bug in dbf486c0de92c76df77c1a1f815cf16533ecbb3a, which
introduced the Index section of the config, but did not register the
parse method, so it didn't work in a YAML file (but did in a test).

Diff Detail

Event Timeline

adamcz created this revision.Tue, Sep 15, 11:15 AM
adamcz requested review of this revision.Tue, Sep 15, 11:15 AM

oh shoot, thanks for catching this. i'll leave the stamp to sam, just came here to remind that this needs to be cherry-picked into release branch :/

sammccall accepted this revision.Wed, Sep 16, 12:27 AM
sammccall added a subscriber: hans.

Argh, sorry. I think this might be too late to get into 11 - we're in the "soon=final" stage and maybe any changes at all cause logistical problems? :-(

@hans to confirm - this is a feature that was meant to be in the 11 release (and was implemented and tested) but the flag to enable it wasn't wired up.

This revision is now accepted and ready to land.Wed, Sep 16, 12:27 AM
hans added a comment.Wed, Sep 16, 2:22 AM

Argh, sorry. I think this might be too late to get into 11 - we're in the "soon=final" stage and maybe any changes at all cause logistical problems? :-(

@hans to confirm - this is a feature that was meant to be in the 11 release (and was implemented and tested) but the flag to enable it wasn't wired up.

Okay, I'll cherry-pick it once it lands.

This revision was landed with ongoing or failed builds.Wed, Sep 16, 4:12 AM
This revision was automatically updated to reflect the committed changes.