Page MenuHomePhabricator

adamcz (Adam Czachorowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 19 2020, 5:57 AM (56 w, 18 h)

Recent Activity

Fri, Apr 9

adamcz committed rG3b4936ba2905: [clangd] Add --check-lines to restrict --check to specific lines (authored by adamcz).
[clangd] Add --check-lines to restrict --check to specific lines
Fri, Apr 9, 4:54 AM
adamcz closed D98970: [clangd] Add --check-range to restrict --check to specific lines.
Fri, Apr 9, 4:53 AM · Restricted Project

Tue, Apr 6

adamcz added inline comments to D98970: [clangd] Add --check-range to restrict --check to specific lines.
Tue, Apr 6, 9:34 AM · Restricted Project
adamcz added inline comments to D98970: [clangd] Add --check-range to restrict --check to specific lines.
Tue, Apr 6, 9:05 AM · Restricted Project
adamcz updated the diff for D98970: [clangd] Add --check-range to restrict --check to specific lines.

addressed review comments + rebase to latest version

Tue, Apr 6, 9:05 AM · Restricted Project

Fri, Mar 19

adamcz added a reviewer for D98970: [clangd] Add --check-range to restrict --check to specific lines: sammccall.

This has been annoying me for a while ;-)

Fri, Mar 19, 11:01 AM · Restricted Project
adamcz requested review of D98970: [clangd] Add --check-range to restrict --check to specific lines.
Fri, Mar 19, 10:59 AM · Restricted Project

Mar 9 2021

adamcz committed rG4e1c487004a2: [clang] Fix crash when creating deduction guide. (authored by adamcz).
[clang] Fix crash when creating deduction guide.
Mar 9 2021, 8:02 AM
adamcz closed D97965: [clang] Fix crash when creating deduction guide..
Mar 9 2021, 8:02 AM · Restricted Project
adamcz added inline comments to D97965: [clang] Fix crash when creating deduction guide..
Mar 9 2021, 7:41 AM · Restricted Project
adamcz updated the diff for D97965: [clang] Fix crash when creating deduction guide..

expanded a comment

Mar 9 2021, 7:41 AM · Restricted Project

Mar 4 2021

adamcz added a reviewer for D97965: [clang] Fix crash when creating deduction guide.: hokein.
Mar 4 2021, 9:27 AM · Restricted Project
adamcz updated the diff for D97965: [clang] Fix crash when creating deduction guide..

format

Mar 4 2021, 9:15 AM · Restricted Project
adamcz requested review of D97965: [clang] Fix crash when creating deduction guide..
Mar 4 2021, 9:14 AM · Restricted Project

Jan 25 2021

adamcz committed rG00054382b95a: [clangd] Fix a crash when indexing invalid ObjC method declaration (authored by adamcz).
[clangd] Fix a crash when indexing invalid ObjC method declaration
Jan 25 2021, 6:56 AM
adamcz closed D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.
Jan 25 2021, 6:55 AM · Restricted Project
adamcz committed rGd462aa5a619a: [clang] Fix a nullptr dereference bug on invalid code (authored by adamcz).
[clang] Fix a nullptr dereference bug on invalid code
Jan 25 2021, 6:03 AM
adamcz closed D95145: [clang] Fix a nullptr dereference bug on invalid code.
Jan 25 2021, 6:02 AM · Restricted Project

Jan 22 2021

adamcz added a comment to D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.

The crash happens while indexing the file, not during code completion. The code completion tests generally specify a cursor position, but in this case it is not relevant and could confuse the reader. This seemed like a logical place for indexing bug, in the spirit of using minimal repro case (i.e. you don't need to trigger code completion at all)

Jan 22 2021, 10:14 AM · Restricted Project
adamcz added a comment to D95145: [clang] Fix a nullptr dereference bug on invalid code.

PTAL

Jan 22 2021, 8:35 AM · Restricted Project
adamcz updated the diff for D95145: [clang] Fix a nullptr dereference bug on invalid code.

addressed review comments

Jan 22 2021, 8:35 AM · Restricted Project
adamcz added inline comments to D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.
Jan 22 2021, 8:03 AM · Restricted Project
adamcz updated the diff for D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.

addressed review comments

Jan 22 2021, 8:03 AM · Restricted Project
adamcz added inline comments to D95145: [clang] Fix a nullptr dereference bug on invalid code.
Jan 22 2021, 6:13 AM · Restricted Project

Jan 21 2021

adamcz requested review of D95145: [clang] Fix a nullptr dereference bug on invalid code.
Jan 21 2021, 9:05 AM · Restricted Project

Jan 19 2021

adamcz accepted D94927: [clangd] Use ASTSignals in Heuristics CC Ranking..
Jan 19 2021, 7:17 AM · Restricted Project
adamcz committed rGa6f9077b16da: [clang] Check for nullptr when instantiating late attrs (authored by adamcz).
[clang] Check for nullptr when instantiating late attrs
Jan 19 2021, 4:53 AM
adamcz closed D94933: [clang] Check for nullptr when instantiating late attrs.
Jan 19 2021, 4:53 AM · Restricted Project

Jan 18 2021

adamcz requested review of D94933: [clang] Check for nullptr when instantiating late attrs.
Jan 18 2021, 2:19 PM · Restricted Project
adamcz committed rG196cc96f9a64: [clang] Allow LifetimeExtendedTemporary to have no access specifier (authored by adamcz).
[clang] Allow LifetimeExtendedTemporary to have no access specifier
Jan 18 2021, 10:30 AM
adamcz closed D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier.
Jan 18 2021, 10:29 AM · Restricted Project
adamcz requested review of D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration.
Jan 18 2021, 9:19 AM · Restricted Project
adamcz accepted D94473: [clangd] Use AST-based signals in CodeCompletion..
Jan 18 2021, 8:30 AM · Restricted Project
adamcz added inline comments to D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier.
Jan 18 2021, 8:12 AM · Restricted Project

Jan 15 2021

adamcz requested review of D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier.
Jan 15 2021, 9:42 AM · Restricted Project
adamcz committed rGc77c3d1d18cd: [clangd] Set correct CWD when using compile_flags.txt (authored by adamcz).
[clangd] Set correct CWD when using compile_flags.txt
Jan 15 2021, 5:32 AM
adamcz closed D94699: [clangd] Set correct CWD when using compile_flags.txt.
Jan 15 2021, 5:32 AM · Restricted Project
adamcz committed rGaeaeb9e6bdc9: [clangd] Make ExpandAutoType not available on template params. (authored by adamcz).
[clangd] Make ExpandAutoType not available on template params.
Jan 15 2021, 5:26 AM
adamcz closed D94719: [clangd] Make ExpandAutoType not available on template params..
Jan 15 2021, 5:26 AM · Restricted Project
adamcz added inline comments to D94473: [clangd] Use AST-based signals in CodeCompletion..
Jan 15 2021, 5:17 AM · Restricted Project
adamcz accepted D94697: [clangd] Update CC Ranking model with better sampling..
Jan 15 2021, 4:33 AM · Restricted Project

Jan 14 2021

adamcz edited reviewers for D94699: [clangd] Set correct CWD when using compile_flags.txt, added: kadircet; removed: sammccall.
Jan 14 2021, 1:45 PM · Restricted Project
adamcz requested review of D94719: [clangd] Make ExpandAutoType not available on template params..
Jan 14 2021, 1:44 PM · Restricted Project
adamcz committed rGa71877edfbb7: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base. (authored by adamcz).
[clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base.
Jan 14 2021, 12:28 PM
adamcz closed D94704: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base..
Jan 14 2021, 12:28 PM · Restricted Project
adamcz requested review of D94704: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base..
Jan 14 2021, 11:58 AM · Restricted Project
adamcz added a reviewer for D94699: [clangd] Set correct CWD when using compile_flags.txt: sammccall.
Jan 14 2021, 9:23 AM · Restricted Project
adamcz requested review of D94699: [clangd] Set correct CWD when using compile_flags.txt.
Jan 14 2021, 9:22 AM · Restricted Project

Jan 13 2021

adamcz accepted D94424: [clangd] Make AST-based signals available to runWithPreamble..
Jan 13 2021, 10:32 AM · Restricted Project

Jan 12 2021

adamcz added inline comments to D94424: [clangd] Make AST-based signals available to runWithPreamble..
Jan 12 2021, 8:15 AM · Restricted Project

Jan 10 2021

adamcz accepted D94359: [clangd] Remove ScratchFS from tests.

Thanks, that's better than my hacky workaround!

Jan 10 2021, 1:01 PM · Restricted Project

Jan 8 2021

adamcz added a reviewer for D94321: [clangd] Prevent tests from failing when /tmp/compile_flags.txt exists: hokein.
Jan 8 2021, 10:17 AM · Restricted Project
adamcz requested review of D94321: [clangd] Prevent tests from failing when /tmp/compile_flags.txt exists.
Jan 8 2021, 10:16 AM · Restricted Project
adamcz committed rG2e1bb7940a4d: [clangd] Add missing "override" to fix the build. (authored by adamcz).
[clangd] Add missing "override" to fix the build.
Jan 8 2021, 8:26 AM
adamcz closed D94314: [clangd] Add missing "override" to fix the build..
Jan 8 2021, 8:26 AM · Restricted Project
adamcz added a reviewer for D94314: [clangd] Add missing "override" to fix the build.: kadircet.
Jan 8 2021, 8:22 AM · Restricted Project
adamcz requested review of D94314: [clangd] Add missing "override" to fix the build..
Jan 8 2021, 8:21 AM · Restricted Project
adamcz committed rGd4af86581e80: [clangd] Fix type printing in the presence of qualifiers (authored by adamcz).
[clangd] Fix type printing in the presence of qualifiers
Jan 8 2021, 8:06 AM
adamcz closed D94259: [clangd] Fix type printing in the presence of qualifiers.
Jan 8 2021, 8:06 AM · Restricted Project
adamcz updated the diff for D94259: [clangd] Fix type printing in the presence of qualifiers.

s/NS/DC

Jan 8 2021, 7:52 AM · Restricted Project
adamcz updated the diff for D94259: [clangd] Fix type printing in the presence of qualifiers.

final review comments

Jan 8 2021, 7:42 AM · Restricted Project
adamcz added a comment to D94259: [clangd] Fix type printing in the presence of qualifiers.

Thanks!

Jan 8 2021, 5:47 AM · Restricted Project
adamcz updated the diff for D94259: [clangd] Fix type printing in the presence of qualifiers.

Addressed review comment

Jan 8 2021, 5:46 AM · Restricted Project

Jan 7 2021

adamcz added a reviewer for D94259: [clangd] Fix type printing in the presence of qualifiers: kadircet.
Jan 7 2021, 12:52 PM · Restricted Project
adamcz requested review of D94259: [clangd] Fix type printing in the presence of qualifiers.
Jan 7 2021, 12:51 PM · Restricted Project

Dec 28 2020

adamcz committed rG0999408aea79: [clangd] Add error handling (elog) in code completion. (authored by adamcz).
[clangd] Add error handling (elog) in code completion.
Dec 28 2020, 6:24 AM
adamcz closed D93220: [clangd] Add error handling (elog) in code completion..
Dec 28 2020, 6:23 AM · Restricted Project

Dec 16 2020

adamcz added inline comments to D93220: [clangd] Add error handling (elog) in code completion..
Dec 16 2020, 7:15 AM · Restricted Project
adamcz updated the diff for D93220: [clangd] Add error handling (elog) in code completion..

address comments

Dec 16 2020, 7:13 AM · Restricted Project
adamcz accepted D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt.
Dec 16 2020, 6:35 AM · Restricted Project

Dec 15 2020

adamcz added inline comments to D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt.
Dec 15 2020, 9:30 AM · Restricted Project

Dec 14 2020

adamcz added a reviewer for D93220: [clangd] Add error handling (elog) in code completion.: sammccall.
Dec 14 2020, 8:08 AM · Restricted Project
adamcz requested review of D93220: [clangd] Add error handling (elog) in code completion..
Dec 14 2020, 8:07 AM · Restricted Project

Dec 9 2020

adamcz committed rG5934a79196b9: [clangd] Split tweak tests into one file per tweak. (authored by adamcz).
[clangd] Split tweak tests into one file per tweak.
Dec 9 2020, 8:19 AM
adamcz closed D92939: [clangd] Split tweak tests into one file per tweak..
Dec 9 2020, 8:19 AM · Restricted Project
adamcz updated the diff for D92939: [clangd] Split tweak tests into one file per tweak..

rebase

Dec 9 2020, 8:12 AM · Restricted Project
adamcz updated the diff for D92939: [clangd] Split tweak tests into one file per tweak..

Removed unused incldues and usings

Dec 9 2020, 8:06 AM · Restricted Project
adamcz added a reviewer for D92939: [clangd] Split tweak tests into one file per tweak.: sammccall.
Dec 9 2020, 7:26 AM · Restricted Project
adamcz updated the diff for D92939: [clangd] Split tweak tests into one file per tweak..

sorted CMake file

Dec 9 2020, 7:26 AM · Restricted Project
adamcz requested review of D92939: [clangd] Split tweak tests into one file per tweak..
Dec 9 2020, 7:24 AM · Restricted Project

Dec 8 2020

adamcz committed rG3c5bed734f9e: [clangd] ExpandAutoType: Do not offer code action on lambdas. (authored by adamcz).
[clangd] ExpandAutoType: Do not offer code action on lambdas.
Dec 8 2020, 11:08 AM
adamcz closed D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas..
Dec 8 2020, 11:08 AM · Restricted Project
adamcz added a comment to D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas..

Also added some "const" to make clang-tidy happy

Dec 8 2020, 10:54 AM · Restricted Project
adamcz updated the diff for D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas..

addressed review comments

Dec 8 2020, 10:54 AM · Restricted Project
adamcz added a reviewer for D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas.: sammccall.
Dec 8 2020, 8:18 AM · Restricted Project
adamcz requested review of D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas..
Dec 8 2020, 7:36 AM · Restricted Project
adamcz committed rGf6b205dae163: [clangd] ExtractFunction: disable on regions that sometimes, but not always… (authored by adamcz).
[clangd] ExtractFunction: disable on regions that sometimes, but not always…
Dec 8 2020, 6:57 AM
adamcz closed D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return..
Dec 8 2020, 6:56 AM · Restricted Project

Dec 7 2020

adamcz added a comment to D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return..

Thanks!

Dec 7 2020, 10:52 AM · Restricted Project
adamcz updated the diff for D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return..

addressed review comments

Dec 7 2020, 10:51 AM · Restricted Project

Dec 3 2020

adamcz committed rGc282b7de5a5d: [clangd] AddUsing: Fix a crash on ElaboratedTypes without NestedNameSpecfiiers. (authored by adamcz).
[clangd] AddUsing: Fix a crash on ElaboratedTypes without NestedNameSpecfiiers.
Dec 3 2020, 11:30 AM
adamcz closed D92579: [clangd] AddUsing: Fix a crash on ElaboratedTypes without NestedNameSpecfiiers..
Dec 3 2020, 11:30 AM · Restricted Project
adamcz added a reviewer for D92579: [clangd] AddUsing: Fix a crash on ElaboratedTypes without NestedNameSpecfiiers.: hokein.
Dec 3 2020, 9:11 AM · Restricted Project
adamcz requested review of D92579: [clangd] AddUsing: Fix a crash on ElaboratedTypes without NestedNameSpecfiiers..
Dec 3 2020, 9:10 AM · Restricted Project
adamcz committed rG517828a31b0d: [clangd] Bundle code completion items when the include paths differ, but… (authored by adamcz).
[clangd] Bundle code completion items when the include paths differ, but…
Dec 3 2020, 7:34 AM
adamcz closed D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file..
Dec 3 2020, 7:34 AM · Restricted Project
adamcz accepted D92573: [clang] Add a C++17 deduction guide testcase..

Thanks, adding this test is a very good idea.

Dec 3 2020, 7:20 AM · Restricted Project

Dec 2 2020

adamcz added a reviewer for D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file.: usaxena95.
Dec 2 2020, 10:04 AM · Restricted Project
adamcz updated the diff for D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file..

-bracket

Dec 2 2020, 10:03 AM · Restricted Project
adamcz requested review of D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file..
Dec 2 2020, 10:02 AM · Restricted Project