Page MenuHomePhabricator

usaxena95 (Utkarsh Saxena)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2018, 2:16 AM (125 w, 2 d)

Recent Activity

Tue, Jan 19

usaxena95 committed rG17846ed5af4a: [clangd] Use ASTSignals in Heuristics CC Ranking. (authored by usaxena95).
[clangd] Use ASTSignals in Heuristics CC Ranking.
Tue, Jan 19, 10:49 AM
usaxena95 closed D94927: [clangd] Use ASTSignals in Heuristics CC Ranking..
Tue, Jan 19, 10:49 AM · Restricted Project
usaxena95 updated the diff for D94927: [clangd] Use ASTSignals in Heuristics CC Ranking..

Added a comment about the calculation.

Tue, Jan 19, 10:06 AM · Restricted Project
usaxena95 committed rG8bf7116d50bf: [clangd] Index local classes, virtual and overriding methods. (authored by usaxena95).
[clangd] Index local classes, virtual and overriding methods.
Tue, Jan 19, 7:19 AM
usaxena95 closed D94785: [clangd] Index local classes, virtual and overriding methods..
Tue, Jan 19, 7:19 AM · Restricted Project
usaxena95 updated the summary of D94785: [clangd] Index local classes, virtual and overriding methods..
Tue, Jan 19, 7:14 AM · Restricted Project
usaxena95 added a comment to D94785: [clangd] Index local classes, virtual and overriding methods..

if you don't mind, could you rerun the benchmark (we have a behavior changes from original version, I guess it won't not change significantly)? and update the data in the description before landing.

Tue, Jan 19, 6:39 AM · Restricted Project
usaxena95 updated the summary of D94785: [clangd] Index local classes, virtual and overriding methods..
Tue, Jan 19, 6:38 AM · Restricted Project
usaxena95 updated the diff for D94785: [clangd] Index local classes, virtual and overriding methods..

Updated index tests's input files.

Tue, Jan 19, 4:30 AM · Restricted Project
usaxena95 updated the diff for D94785: [clangd] Index local classes, virtual and overriding methods..

Index all member functions instead of only polymorphic functions.

Tue, Jan 19, 4:26 AM · Restricted Project
usaxena95 added a comment to D94785: [clangd] Index local classes, virtual and overriding methods..

I think we'd better bump the index version, even though this is not a breaking change, but we will collect more data. Not bumping the index version may lead to a half-completed state of the index (e.g. only newly-changed files will get completed index data in background index).

Tue, Jan 19, 4:25 AM · Restricted Project

Mon, Jan 18

usaxena95 added a reviewer for D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.: adamcz.
Mon, Jan 18, 12:04 PM · Restricted Project
usaxena95 requested review of D94927: [clangd] Use ASTSignals in Heuristics CC Ranking..
Mon, Jan 18, 12:03 PM · Restricted Project
usaxena95 committed rG275716d6db79: [clangd] Derive new signals in CC from ASTSignals. (authored by usaxena95).
[clangd] Derive new signals in CC from ASTSignals.
Mon, Jan 18, 8:39 AM
usaxena95 closed D94473: [clangd] Use AST-based signals in CodeCompletion..
Mon, Jan 18, 8:38 AM · Restricted Project
usaxena95 updated the diff for D94785: [clangd] Index local classes, virtual and overriding methods..

Addressed comments. Left a todo to fix the bug in RefContainers later.

Mon, Jan 18, 5:46 AM · Restricted Project
usaxena95 updated the diff for D94473: [clangd] Use AST-based signals in CodeCompletion..

Addressed comments.

Mon, Jan 18, 2:42 AM · Restricted Project

Sun, Jan 17

usaxena95 committed rG9abbc050974f: [clangd] Use !empty() instead of size()>0 (authored by usaxena95).
[clangd] Use !empty() instead of size()>0
Sun, Jan 17, 6:29 AM
usaxena95 committed rG0f9908a7c9c5: [clangd] Use empty() instead of size()>0 (authored by usaxena95).
[clangd] Use empty() instead of size()>0
Sun, Jan 17, 6:21 AM

Fri, Jan 15

usaxena95 added a comment to D94785: [clangd] Index local classes, virtual and overriding methods..

My only question is does this try and index lambdas, under the hood they are declared as a CXXRecordDecl, defined in function scope?

Fri, Jan 15, 10:26 AM · Restricted Project
usaxena95 updated the diff for D94785: [clangd] Index local classes, virtual and overriding methods..

Added tests for not indexing lambdas.

Fri, Jan 15, 10:23 AM · Restricted Project
usaxena95 committed rGd5047d762f39: [clangd] Update CC Ranking model with better sampling. (authored by usaxena95).
[clangd] Update CC Ranking model with better sampling.
Fri, Jan 15, 9:14 AM
usaxena95 closed D94697: [clangd] Update CC Ranking model with better sampling..
Fri, Jan 15, 9:14 AM · Restricted Project
usaxena95 updated the diff for D94697: [clangd] Update CC Ranking model with better sampling..

Addressed comments.

Fri, Jan 15, 8:52 AM · Restricted Project
usaxena95 updated the summary of D94785: [clangd] Index local classes, virtual and overriding methods..
Fri, Jan 15, 8:42 AM · Restricted Project
usaxena95 updated the summary of D94785: [clangd] Index local classes, virtual and overriding methods..
Fri, Jan 15, 8:41 AM · Restricted Project
usaxena95 requested review of D94785: [clangd] Index local classes, virtual and overriding methods..
Fri, Jan 15, 8:23 AM · Restricted Project

Thu, Jan 14

usaxena95 added a reviewer for D94473: [clangd] Use AST-based signals in CodeCompletion.: adamcz.
Thu, Jan 14, 11:08 PM · Restricted Project
usaxena95 updated the diff for D94473: [clangd] Use AST-based signals in CodeCompletion..

Rebase.

Thu, Jan 14, 11:02 PM · Restricted Project
usaxena95 committed rG8b09cf7956d8: [clangd] Trivial: Documentation fix in ASTSignals. (authored by usaxena95).
[clangd] Trivial: Documentation fix in ASTSignals.
Thu, Jan 14, 9:40 AM
usaxena95 committed rG2f395b7092bd: [clangd] Make AST-based signals available to runWithPreamble. (authored by usaxena95).
[clangd] Make AST-based signals available to runWithPreamble.
Thu, Jan 14, 9:35 AM
usaxena95 closed D94424: [clangd] Make AST-based signals available to runWithPreamble..
Thu, Jan 14, 9:35 AM · Restricted Project
usaxena95 updated the diff for D94424: [clangd] Make AST-based signals available to runWithPreamble..

Added newline at end of new file.

Thu, Jan 14, 9:31 AM · Restricted Project
usaxena95 updated the diff for D94424: [clangd] Make AST-based signals available to runWithPreamble..

Addressed comments. Ready for landing.

Thu, Jan 14, 9:27 AM · Restricted Project
usaxena95 updated the summary of D94697: [clangd] Update CC Ranking model with better sampling..
Thu, Jan 14, 9:07 AM · Restricted Project
usaxena95 requested review of D94697: [clangd] Update CC Ranking model with better sampling..
Thu, Jan 14, 9:06 AM · Restricted Project
usaxena95 updated the diff for D94424: [clangd] Make AST-based signals available to runWithPreamble..

Removed unused headers.

Thu, Jan 14, 8:25 AM · Restricted Project
usaxena95 added inline comments to D94424: [clangd] Make AST-based signals available to runWithPreamble..
Thu, Jan 14, 8:19 AM · Restricted Project
usaxena95 updated the diff for D94424: [clangd] Make AST-based signals available to runWithPreamble..

Addressed comments.

Thu, Jan 14, 8:19 AM · Restricted Project

Wed, Jan 13

usaxena95 committed rGa4f386688239: [clangd] Remove "decision-forest-base" experimental flag. (authored by usaxena95).
[clangd] Remove "decision-forest-base" experimental flag.
Wed, Jan 13, 8:56 AM
usaxena95 closed D94513: [clangd] Remove "decision-forest-base" experimental flag..
Wed, Jan 13, 8:55 AM · Restricted Project
usaxena95 added inline comments to D94424: [clangd] Make AST-based signals available to runWithPreamble..
Wed, Jan 13, 6:30 AM · Restricted Project
usaxena95 updated the diff for D94424: [clangd] Make AST-based signals available to runWithPreamble..

Addressed comments.

Wed, Jan 13, 6:30 AM · Restricted Project

Tue, Jan 12

usaxena95 requested review of D94513: [clangd] Remove "decision-forest-base" experimental flag..
Tue, Jan 12, 9:31 AM · Restricted Project
usaxena95 updated the diff for D94473: [clangd] Use AST-based signals in CodeCompletion..

Edge cases fix.

Tue, Jan 12, 6:01 AM · Restricted Project
usaxena95 requested review of D94473: [clangd] Use AST-based signals in CodeCompletion..
Tue, Jan 12, 1:25 AM · Restricted Project

Mon, Jan 11

usaxena95 accepted D94390: [clangd] Extend find-refs to include overrides..

LG. Thanks!

Mon, Jan 11, 11:36 AM · Restricted Project
usaxena95 updated the diff for D94424: [clangd] Make AST-based signals available to runWithPreamble..

Documentation change.

Mon, Jan 11, 9:27 AM · Restricted Project
usaxena95 updated the summary of D94424: [clangd] Make AST-based signals available to runWithPreamble..
Mon, Jan 11, 9:27 AM · Restricted Project
usaxena95 added reviewers for D94424: [clangd] Make AST-based signals available to runWithPreamble.: sammccall, adamcz.
Mon, Jan 11, 9:26 AM · Restricted Project
usaxena95 requested review of D94424: [clangd] Make AST-based signals available to runWithPreamble..
Mon, Jan 11, 9:06 AM · Restricted Project
usaxena95 accepted D94393: [clangd] Add metrics for go-to-implementation..

LG. Thanks.

Mon, Jan 11, 1:13 AM · Restricted Project

Fri, Jan 8

usaxena95 accepted D92749: [clangd] go-to-implementation on a base class jumps to all subclasses..

LGTM. Thanks!

Fri, Jan 8, 2:30 AM · Restricted Project

Dec 10 2020

usaxena95 accepted D92299: [clangd] Go-to-definition on pure virtual method decls jumps to all overrides..

LG. Thanks.

Dec 10 2020, 9:59 AM · Restricted Project
usaxena95 committed rG4ce242a163c3: [clangd] Find relations in Dex exploration tool. (authored by usaxena95).
[clangd] Find relations in Dex exploration tool.
Dec 10 2020, 7:54 AM
usaxena95 closed D93029: [clangd] Find relations in Dex exploration tool..
Dec 10 2020, 7:54 AM · Restricted Project
usaxena95 updated the diff for D93029: [clangd] Find relations in Dex exploration tool..

Addressed comments. Ready to land.

Dec 10 2020, 7:47 AM · Restricted Project
usaxena95 updated the diff for D93029: [clangd] Find relations in Dex exploration tool..

Update error message.

Dec 10 2020, 5:28 AM · Restricted Project
usaxena95 requested review of D93029: [clangd] Find relations in Dex exploration tool..
Dec 10 2020, 5:27 AM · Restricted Project

Dec 7 2020

usaxena95 added inline comments to D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return..
Dec 7 2020, 12:49 AM · Restricted Project

Dec 5 2020

usaxena95 accepted D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return..
Dec 5 2020, 4:29 AM · Restricted Project
usaxena95 accepted D92640: Add ability to load a FixedCompilationDatabase from a buffer..

Thanks.

Dec 5 2020, 1:19 AM · Restricted Project

Dec 4 2020

usaxena95 accepted D92646: [Tooling] JSONCompilationDatabase::loadFromBuffer retains the buffer, copy it..
Dec 4 2020, 10:10 AM · Restricted Project
usaxena95 added inline comments to D92640: Add ability to load a FixedCompilationDatabase from a buffer..
Dec 4 2020, 8:19 AM · Restricted Project

Dec 2 2020

usaxena95 accepted D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file..
Dec 2 2020, 10:57 PM · Restricted Project

Nov 23 2020

usaxena95 committed rGb31486ad9717: [clangd] textDocument/implementation (LSP layer) (authored by usaxena95).
[clangd] textDocument/implementation (LSP layer)
Nov 23 2020, 4:59 AM
usaxena95 closed D91721: [clangd] textDocument/implementation (LSP layer).
Nov 23 2020, 4:58 AM · Restricted Project
usaxena95 updated the diff for D91721: [clangd] textDocument/implementation (LSP layer).

Addressed comments.

Nov 23 2020, 12:31 AM · Restricted Project
usaxena95 added a comment to D91721: [clangd] textDocument/implementation (LSP layer).

Looks like the patch is based on the old revision (pre-merging tests are failing), I assume you have fixed the failure tests last week?

Nov 23 2020, 12:30 AM · Restricted Project

Nov 18 2020

usaxena95 added a reverting change for rG0016ab6f3632: Revert "[clangd] Implement textDocument/implementation (Xref layer)": rG130da802ff6e: Revert "Revert "[clangd] Implement textDocument/implementation (Xref layer)"".
Nov 18 2020, 10:11 AM
usaxena95 committed rG130da802ff6e: Revert "Revert "[clangd] Implement textDocument/implementation (Xref layer)"" (authored by usaxena95).
Revert "Revert "[clangd] Implement textDocument/implementation (Xref layer)""
Nov 18 2020, 10:11 AM
usaxena95 added a reverting change for rG43243208fa6f: [clangd] Implement textDocument/implementation (Xref layer): rG0016ab6f3632: Revert "[clangd] Implement textDocument/implementation (Xref layer)".
Nov 18 2020, 9:06 AM
usaxena95 committed rG0016ab6f3632: Revert "[clangd] Implement textDocument/implementation (Xref layer)" (authored by usaxena95).
Revert "[clangd] Implement textDocument/implementation (Xref layer)"
Nov 18 2020, 9:06 AM
usaxena95 added a reverting change for D91702: [clangd] Implement textDocument/implementation (Xref layer): rG0016ab6f3632: Revert "[clangd] Implement textDocument/implementation (Xref layer)".
Nov 18 2020, 9:06 AM · Restricted Project
usaxena95 added a comment to D91702: [clangd] Implement textDocument/implementation (Xref layer).

I will revert this commit and investigate. Sorry for the trouble.

Nov 18 2020, 9:06 AM · Restricted Project
usaxena95 added a comment to D91702: [clangd] Implement textDocument/implementation (Xref layer).

This was reviewed in https://reviews.llvm.org/D91626
Somehow phabricator attached the commit to this old patch.
I tried to address the failures. Are you seeing failures at the HEAD ?

Nov 18 2020, 8:54 AM · Restricted Project
usaxena95 added a reviewer for D91721: [clangd] textDocument/implementation (LSP layer): hokein.
Nov 18 2020, 8:45 AM · Restricted Project
usaxena95 requested review of D91721: [clangd] textDocument/implementation (LSP layer).
Nov 18 2020, 8:41 AM · Restricted Project
usaxena95 closed D91626: [clangd] Implement textDocument/implementation (Xref layer).
Nov 18 2020, 8:32 AM · Restricted Project
usaxena95 committed rG43243208fa6f: [clangd] Implement textDocument/implementation (Xref layer) (authored by usaxena95).
[clangd] Implement textDocument/implementation (Xref layer)
Nov 18 2020, 8:16 AM
usaxena95 closed D91702: [clangd] Implement textDocument/implementation (Xref layer).
Nov 18 2020, 8:16 AM · Restricted Project
usaxena95 retitled D91626: [clangd] Implement textDocument/implementation (Xref layer) from [clangd] Implement textDocument/implementation. to [clangd] Implement textDocument/implementation (Xref layer).
Nov 18 2020, 8:05 AM · Restricted Project
usaxena95 updated the diff for D91626: [clangd] Implement textDocument/implementation (Xref layer).

Addressed comments.

Nov 18 2020, 8:03 AM · Restricted Project
usaxena95 removed a project from D91702: [clangd] Implement textDocument/implementation (Xref layer): Restricted Project.
Nov 18 2020, 8:02 AM · Restricted Project
usaxena95 updated the diff for D91702: [clangd] Implement textDocument/implementation (Xref layer).

Addressed comments.

Nov 18 2020, 8:02 AM · Restricted Project
usaxena95 updated the diff for D91626: [clangd] Implement textDocument/implementation (Xref layer).

Added test for no implementation for concrete methods.

Nov 18 2020, 6:02 AM · Restricted Project
usaxena95 added inline comments to D91626: [clangd] Implement textDocument/implementation (Xref layer).
Nov 18 2020, 5:56 AM · Restricted Project
usaxena95 updated the diff for D91626: [clangd] Implement textDocument/implementation (Xref layer).

Addressed comments.

Nov 18 2020, 5:56 AM · Restricted Project
usaxena95 abandoned D91702: [clangd] Implement textDocument/implementation (Xref layer).
Nov 18 2020, 5:55 AM · Restricted Project
usaxena95 requested review of D91702: [clangd] Implement textDocument/implementation (Xref layer).
Nov 18 2020, 5:54 AM · Restricted Project

Nov 17 2020

usaxena95 committed rG4bc085f5b3ed: [clangd] Add OverridenBy Relation to index. (authored by usaxena95).
[clangd] Add OverridenBy Relation to index.
Nov 17 2020, 10:11 PM
usaxena95 closed D91610: [clangd] Add OverriddenBy Relation to index..
Nov 17 2020, 10:11 PM · Restricted Project
usaxena95 updated the diff for D91610: [clangd] Add OverriddenBy Relation to index..

Addressed final comments. Ready to land.

Nov 17 2020, 9:58 PM · Restricted Project
usaxena95 updated the diff for D91626: [clangd] Implement textDocument/implementation (Xref layer).

Remove unintended change.

Nov 17 2020, 9:52 PM · Restricted Project
usaxena95 updated the diff for D91626: [clangd] Implement textDocument/implementation (Xref layer).

Addressed final comments. Ready to land.

Nov 17 2020, 9:50 PM · Restricted Project
usaxena95 updated the diff for D91626: [clangd] Implement textDocument/implementation (Xref layer).

Minor fixes.

Nov 17 2020, 9:46 AM · Restricted Project
usaxena95 updated the summary of D91626: [clangd] Implement textDocument/implementation (Xref layer).
Nov 17 2020, 9:29 AM · Restricted Project
usaxena95 updated the diff for D91626: [clangd] Implement textDocument/implementation (Xref layer).

Refactor.

Nov 17 2020, 9:18 AM · Restricted Project
usaxena95 updated the diff for D91626: [clangd] Implement textDocument/implementation (Xref layer).

Typo fix.

Nov 17 2020, 8:34 AM · Restricted Project
usaxena95 updated the diff for D91610: [clangd] Add OverriddenBy Relation to index..

Typo fix.

Nov 17 2020, 8:06 AM · Restricted Project