Page MenuHomePhabricator

usaxena95 (Utkarsh Saxena)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2018, 2:16 AM (108 w, 1 d)

Recent Activity

Yesterday

usaxena95 closed D79500: [clangd] Refactor code completion signal's utility properties..

Closed with commit 158af0d3d165c0382a6a291e81ffecf0b18ffe77

Wed, Sep 23, 7:20 AM · Restricted Project
usaxena95 committed rG158af0d3d165: [clangd] Refactor code completion signal's utility properties. (authored by usaxena95).
[clangd] Refactor code completion signal's utility properties.
Wed, Sep 23, 7:15 AM
usaxena95 updated the summary of D79500: [clangd] Refactor code completion signal's utility properties..
Wed, Sep 23, 7:10 AM · Restricted Project
usaxena95 added inline comments to D79500: [clangd] Refactor code completion signal's utility properties..
Wed, Sep 23, 5:42 AM · Restricted Project
usaxena95 updated the diff for D79500: [clangd] Refactor code completion signal's utility properties..

Addressed comments.

Wed, Sep 23, 5:41 AM · Restricted Project

Tue, Sep 22

usaxena95 updated usaxena95.
Tue, Sep 22, 9:09 AM
usaxena95 updated the summary of D88071: [clangd] Add a trained DecisionForest for code completion..
Tue, Sep 22, 8:59 AM · Restricted Project

Mon, Sep 21

usaxena95 requested review of D88071: [clangd] Add a trained DecisionForest for code completion..
Mon, Sep 21, 11:12 PM · Restricted Project

Sat, Sep 19

usaxena95 added a reverting change for rG549e55b3d563: Temporarily Revert "[clangd] Add Random Forest runtime for code completion.": rG985deba9319b: Revert "Temporarily Revert "[clangd] Add Random Forest runtime for code….
Sat, Sep 19, 2:21 AM
usaxena95 committed rG985deba9319b: Revert "Temporarily Revert "[clangd] Add Random Forest runtime for code… (authored by usaxena95).
Revert "Temporarily Revert "[clangd] Add Random Forest runtime for code…
Sat, Sep 19, 2:21 AM
usaxena95 updated the summary of D83814: [clangd] Add Random Forest runtime for code completion..
Sat, Sep 19, 12:37 AM · Restricted Project

Fri, Sep 18

usaxena95 committed rG9b6765e784b3: [clangd] Add Random Forest runtime for code completion. (authored by usaxena95).
[clangd] Add Random Forest runtime for code completion.
Fri, Sep 18, 10:27 AM
usaxena95 closed D83814: [clangd] Add Random Forest runtime for code completion..
Fri, Sep 18, 10:27 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Fixed output_dir cmake variable. Clean build succeeds now.
Ready to land.

Fri, Sep 18, 9:36 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Removed generated (for review) files.

Fri, Sep 18, 9:04 AM · Restricted Project
usaxena95 added inline comments to D83814: [clangd] Add Random Forest runtime for code completion..
Fri, Sep 18, 12:52 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Addressed comments.

Fri, Sep 18, 12:52 AM · Restricted Project

Wed, Sep 16

usaxena95 added inline comments to D83814: [clangd] Add Random Forest runtime for code completion..
Wed, Sep 16, 4:57 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Addressed comments.

Wed, Sep 16, 4:57 AM · Restricted Project

Tue, Sep 15

usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Fixed namespace ending.

Tue, Sep 15, 7:21 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Fixed namespace.

Tue, Sep 15, 12:15 AM · Restricted Project

Fri, Sep 11

usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Added README.md for the code completion model.

Fri, Sep 11, 7:01 AM · Restricted Project

Thu, Sep 10

usaxena95 added a comment to D83814: [clangd] Add Random Forest runtime for code completion..

Do you guys intend to open-source also the training part of the model pipeline ?

Open sourcing the training part (both dataset generation and using an open sourced DecisionForest based framework for training) has been on our radar. Although gathering capacity for this task has been difficult lately.

Thu, Sep 10, 11:08 AM · Restricted Project
usaxena95 added inline comments to D83814: [clangd] Add Random Forest runtime for code completion..
Thu, Sep 10, 10:37 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Addressed comments.

Thu, Sep 10, 10:28 AM · Restricted Project

Tue, Sep 8

usaxena95 added a reviewer for D83814: [clangd] Add Random Forest runtime for code completion.: adamcz.
Tue, Sep 8, 5:01 AM · Restricted Project

Jul 24 2020

usaxena95 updated the summary of D83814: [clangd] Add Random Forest runtime for code completion..
Jul 24 2020, 7:23 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Better formatting in generated files.

Jul 24 2020, 7:12 AM · Restricted Project
usaxena95 added a reviewer for D83814: [clangd] Add Random Forest runtime for code completion.: sammccall.
Jul 24 2020, 7:11 AM · Restricted Project
usaxena95 updated the diff for D83814: [clangd] Add Random Forest runtime for code completion..

Addressed offline comments.

Jul 24 2020, 4:56 AM · Restricted Project

Jul 22 2020

usaxena95 added a comment to D83814: [clangd] Add Random Forest runtime for code completion..

The features refers to the code completion signals in https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/Quality.h
These signals are currently used to map the code completion candidates to a relevance score using hand-coded heuristics.
We intend to replace the heuristics with a Decision forest model. This patch introduces a dummy model and corresponding runtime that will be used to inference this model.

Jul 22 2020, 3:07 AM · Restricted Project

Jul 15 2020

usaxena95 updated the summary of D83814: [clangd] Add Random Forest runtime for code completion..
Jul 15 2020, 9:10 AM · Restricted Project
usaxena95 updated the summary of D83814: [clangd] Add Random Forest runtime for code completion..
Jul 15 2020, 9:09 AM · Restricted Project
usaxena95 updated the summary of D83814: [clangd] Add Random Forest runtime for code completion..
Jul 15 2020, 1:58 AM · Restricted Project

Jul 14 2020

Herald added a project to D83814: [clangd] Add Random Forest runtime for code completion.: Restricted Project.
Jul 14 2020, 2:32 PM · Restricted Project

May 8 2020

usaxena95 updated the diff for D79500: [clangd] Refactor code completion signal's utility properties..
  • Added DerivedSignals struct containing all the derived signals.
  • Added NameMatchesContext and proximtiy signals to this struct.
  • We need to call computeDerivedSignals() before calling evaluate() if we set non-concrete utilites (e.g. ContextWords and Name).
  • This is logically equivalent to the previous version (both when the utilites are explicitly set and when the default signals are used).
  • The utilites are not marked as null in computeDerivedSignals. This is due to 2 reasons:
    • Current scoring function checks whether ScopeProximityMatch is set or not to decide whether to multiply with scopeProxitiyScore. Possible solutions:
      • Have scopeProxitiyScore as a derived signal itself.
      • Or have a different derived signal HasScopeProximityMatch.
    • Having these utilities available for debug purposes is great. We can try to compute other derived signals (e.g. ContextMatchesName) and test out it's value without even adding them concretely to clangd. Once their value is justified, we can add it to Quality/Relevance signals.
May 8 2020, 3:43 AM · Restricted Project

May 6 2020

usaxena95 created D79500: [clangd] Refactor code completion signal's utility properties..
May 6 2020, 9:40 AM · Restricted Project

Mar 25 2020

usaxena95 accepted D76741: [clangd] Support multiple cursors in selectionRange..

Thanks. LG.

Mar 25 2020, 6:27 AM · Restricted Project
usaxena95 added a comment to D76741: [clangd] Support multiple cursors in selectionRange..

Mostly looks good. Few nits. Thanks.

Mar 25 2020, 3:13 AM · Restricted Project

Mar 5 2020

usaxena95 committed rGe397a0a5c3c0: [clangd] Add instrumentation mode in clangd for metrics collection. (authored by usaxena95).
[clangd] Add instrumentation mode in clangd for metrics collection.
Mar 5 2020, 3:52 AM
usaxena95 closed D75603: [clangd] Add instrumentation mode in clangd for metrics collection..
Mar 5 2020, 3:51 AM · Restricted Project
usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Passed score as a float as an explicit argument of the callback.

Mar 5 2020, 3:51 AM · Restricted Project
usaxena95 added inline comments to D75603: [clangd] Add instrumentation mode in clangd for metrics collection..
Mar 5 2020, 3:18 AM · Restricted Project
usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Addressed comments.

  • Populated score in CodeCompletion before invoking the callback.
  • Tested that CodeCompletion is scored
  • Updated comment for callback.
Mar 5 2020, 3:18 AM · Restricted Project

Mar 4 2020

usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Remove ununsed import.

Mar 4 2020, 10:39 AM · Restricted Project
usaxena95 added inline comments to D75603: [clangd] Add instrumentation mode in clangd for metrics collection..
Mar 4 2020, 10:39 AM · Restricted Project
usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Changed to invoke callback on all code completion items.

Mar 4 2020, 10:38 AM · Restricted Project
usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Addressed linter issues.

Mar 4 2020, 6:11 AM · Restricted Project
usaxena95 created D75603: [clangd] Add instrumentation mode in clangd for metrics collection..
Mar 4 2020, 5:39 AM · Restricted Project

Feb 20 2020

usaxena95 committed rGcb54c13c217b: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp (authored by usaxena95).
[clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp
Feb 20 2020, 8:30 AM
usaxena95 closed D74906: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp.
Feb 20 2020, 8:30 AM · Restricted Project
usaxena95 created D74906: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp.
Feb 20 2020, 8:21 AM · Restricted Project

Feb 11 2020

usaxena95 accepted D74305: [clangd] Expose completion range in code completion results (C++ API).

Thanks. LG.

Feb 11 2020, 4:58 AM · Restricted Project

Jan 16 2020

usaxena95 accepted D72777: [clangd] Dont display `<unknown>` kinds in hover board.
Jan 16 2020, 2:35 AM · Restricted Project

Jan 13 2020

usaxena95 committed rG734aa1d133f2: [clangd] Publish xref for macros from Index and AST. (authored by usaxena95).
[clangd] Publish xref for macros from Index and AST.
Jan 13 2020, 2:12 AM
usaxena95 closed D72395: [clangd] Publish xref for macros from Index and AST..
Jan 13 2020, 2:12 AM · Restricted Project
usaxena95 added inline comments to D72395: [clangd] Publish xref for macros from Index and AST..
Jan 13 2020, 1:57 AM · Restricted Project
usaxena95 updated the diff for D72395: [clangd] Publish xref for macros from Index and AST..

Removed repeated check from the test.

Jan 13 2020, 1:57 AM · Restricted Project

Jan 8 2020

usaxena95 added inline comments to D72395: [clangd] Publish xref for macros from Index and AST..
Jan 8 2020, 7:59 AM · Restricted Project
usaxena95 updated the diff for D72395: [clangd] Publish xref for macros from Index and AST..

Addressed comments.

Jan 8 2020, 7:50 AM · Restricted Project
usaxena95 created D72395: [clangd] Publish xref for macros from Index and AST..
Jan 8 2020, 5:23 AM · Restricted Project

Jan 7 2020

usaxena95 committed rG583ba07884ed: [clangd] Add xref for macros to FileIndex. (authored by usaxena95).
[clangd] Add xref for macros to FileIndex.
Jan 7 2020, 11:38 PM
usaxena95 closed D71406: [clangd] Add xref for macros to FileIndex..
Jan 7 2020, 11:38 PM · Restricted Project
usaxena95 updated the summary of D71406: [clangd] Add xref for macros to FileIndex..
Jan 7 2020, 11:29 PM · Restricted Project
usaxena95 updated the diff for D71406: [clangd] Add xref for macros to FileIndex..

Added tests.

Jan 7 2020, 9:46 AM · Restricted Project
usaxena95 updated the diff for D71406: [clangd] Add xref for macros to FileIndex..

Removed extra tests.

Jan 7 2020, 6:00 AM · Restricted Project
usaxena95 added inline comments to D71406: [clangd] Add xref for macros to FileIndex..
Jan 7 2020, 2:55 AM · Restricted Project
usaxena95 updated the diff for D71406: [clangd] Add xref for macros to FileIndex..

Addressed comments.

Jan 7 2020, 2:55 AM · Restricted Project

Jan 3 2020

usaxena95 added inline comments to D71406: [clangd] Add xref for macros to FileIndex..
Jan 3 2020, 5:57 AM · Restricted Project
usaxena95 updated the diff for D71406: [clangd] Add xref for macros to FileIndex..

Added another version of handleMacroOccurence to handle MacroReferences from main file.

Jan 3 2020, 5:57 AM · Restricted Project

Dec 12 2019

usaxena95 created D71406: [clangd] Add xref for macros to FileIndex..
Dec 12 2019, 3:20 AM · Restricted Project

Dec 4 2019

usaxena95 closed D70008: [clangd] Store xref for Macros in ParsedAST..
Dec 4 2019, 7:38 PM · Restricted Project
usaxena95 committed rG9347655a2754: [clangd] Add xref for macro to static index. (authored by usaxena95).
[clangd] Add xref for macro to static index.
Dec 4 2019, 7:29 PM
usaxena95 closed D70489: [clangd] Add xref for macro to static index..
Dec 4 2019, 7:29 PM · Restricted Project
usaxena95 updated the summary of D70489: [clangd] Add xref for macro to static index..
Dec 4 2019, 7:29 PM · Restricted Project
usaxena95 updated the summary of D70489: [clangd] Add xref for macro to static index..
Dec 4 2019, 7:19 PM · Restricted Project
usaxena95 added a comment to D70489: [clangd] Add xref for macro to static index..

Updated benchmarks:
Before this patch

Loaded Dex from static-index.idx with estimated memory usage 354410880 bytes
  - number of symbols: 462463
  - number of refs: 6361763
  - numnber of relations: 20322

After this patch
Num refs increases by 5.7%
Disk increase: 2.5%

Loaded Dex from with-macro-xref.idx with estimated memory usage 363390426 bytes
  - number of symbols: 462482
  - number of refs: 6727051
  - numnber of relations: 20325
Dec 4 2019, 7:19 PM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.

Dec 4 2019, 6:51 PM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Removed unintended space.

Dec 4 2019, 6:53 AM · Restricted Project
usaxena95 added inline comments to D70489: [clangd] Add xref for macro to static index..
Dec 4 2019, 6:53 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.

Dec 4 2019, 6:53 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.

Dec 4 2019, 3:48 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Explicitly turn off CollectMacro in test.

Dec 4 2019, 3:48 AM · Restricted Project

Dec 3 2019

usaxena95 updated the summary of D70489: [clangd] Add xref for macro to static index..
Dec 3 2019, 2:39 AM · Restricted Project
usaxena95 added a comment to D70489: [clangd] Add xref for macro to static index..

Before this patch
CollectMacro is disabled by default

Loaded Dex from static-index.idx with estimated memory usage 354410880 bytes
  - number of symbols: 462463
  - number of refs: 6361763
  - numnber of relations: 20322

Before this patch
CollectMacros=true enabled in IndexerMain.cpp
Num symbols increases by 3%
Disk increase: 1.2%

Loaded Dex from no-macro-xref.idx with estimated memory usage 358596403 bytes
  - number of symbols: 476056
  - number of refs: 6361764
  - numnber of relations: 20322
Dec 3 2019, 2:29 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.
Will update the increase in size of index shortly.

Dec 3 2019, 12:15 AM · Restricted Project
usaxena95 added inline comments to D70489: [clangd] Add xref for macro to static index..
Dec 3 2019, 12:15 AM · Restricted Project

Dec 2 2019

usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Added correct documentation.

Dec 2 2019, 3:09 AM · Restricted Project
usaxena95 added inline comments to D70489: [clangd] Add xref for macro to static index..
Dec 2 2019, 2:50 AM · Restricted Project
usaxena95 added inline comments to D70489: [clangd] Add xref for macro to static index..
Dec 2 2019, 1:56 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.

Dec 2 2019, 1:56 AM · Restricted Project

Nov 20 2019

usaxena95 created D70489: [clangd] Add xref for macro to static index..
Nov 20 2019, 6:23 AM · Restricted Project

Nov 18 2019

usaxena95 committed rG2054ed052f15: [clangd] Store xref for Macros in ParsedAST. (authored by usaxena95).
[clangd] Store xref for Macros in ParsedAST.
Nov 18 2019, 7:51 AM
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Addressed comments.

Nov 18 2019, 6:58 AM · Restricted Project
usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 18 2019, 6:58 AM · Restricted Project

Nov 15 2019

usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Minor change: Resued variable.

Nov 15 2019, 6:49 AM · Restricted Project
usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 15 2019, 6:22 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Modified tests for better error messages.

Nov 15 2019, 6:22 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Uploading latest patch

Nov 15 2019, 3:09 AM · Restricted Project

Nov 14 2019

usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 14 2019, 7:12 AM · Restricted Project