Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (152 w, 5 d)

Recent Activity

Fri, Jan 15

kadircet added inline comments to D94606: [clangd] Move DirBasedCDB broadcasting onto its own thread..
Fri, Jan 15, 3:47 AM · Restricted Project
kadircet added a comment to D94753: [clangd] exclude symbols from document outline which do not originate from the main file.

btw, do you have commit access or should i land this for you ? (if so please provide your email)

Fri, Jan 15, 2:28 AM · Restricted Project
kadircet requested review of D94755: [clangd] Fix division by zero when computing scores.
Fri, Jan 15, 2:15 AM · Restricted Project
kadircet accepted D94603: [clangd] Allow CDBs to have background work to block on..
Fri, Jan 15, 1:18 AM · Restricted Project
kadircet accepted D94753: [clangd] exclude symbols from document outline which do not originate from the main file.

thanks for the fix, a small comment about testing though.

Fri, Jan 15, 1:16 AM · Restricted Project

Wed, Jan 13

kadircet accepted D94503: [clangd] Explicitly avoid background-indexing the same file twice..

thank, as discussed offline this looks like the right thing to do before the branch cut. we might re-evaluate our decision around re-indexing on cmd changes and canonicalization one day ...

Wed, Jan 13, 12:34 AM · Restricted Project

Tue, Jan 12

kadircet added a comment to D94477: [clangd] Add main file macros into the main-file index..

Ah this is really unfortunate :( In theory we already know which slabs belong to main file while updating the index for the preamble, as we shard them per file. But it is really inconvenient layering wise to transfer that slab from updatePreamble to updateMain in parsing callbacks :/
Another layer to fix the issue would be to somehow make main file parsing, re-parse those macro definitions through replay mechanism or preamble patching, but these might have unwanted consequences as we would see a re-definition of the macro now. Also they are considerably hard :/

Tue, Jan 12, 2:38 AM · Restricted Project
kadircet added a comment to D93873: [clangd] Cache preambles of closed files.
  1. a *persistent* cache so closing+reopening clangd loses less state. (This is complicated because only the PCH is easily serializable, the rest of the PreambleData struct isn't)
  2. building caches of preambles while background-indexing (this would be great for modules but is probably way too big for whole preambles)
  3. reusing the "wrong" preamble initially when you open a new file, to give some basic functionality (using existing preamble patching logic, just in a more aggressive scenario)
  4. having the disk-based storage unlink the file preemptively, to eliminate any chance of leaking the *.pch
Tue, Jan 12, 12:43 AM · Restricted Project

Sun, Jan 10

kadircet added a comment to D94382: [clangd] Avoid recursion in TargetFinder::add().

oh and also thanks a lot for all the investigation and fix of the issue!

Sun, Jan 10, 10:55 PM · Restricted Project
kadircet added inline comments to D94382: [clangd] Avoid recursion in TargetFinder::add().
Sun, Jan 10, 10:54 PM · Restricted Project
kadircet added inline comments to D94359: [clangd] Remove ScratchFS from tests.
Sun, Jan 10, 10:33 PM · Restricted Project

Fri, Jan 8

kadircet added inline comments to D94259: [clangd] Fix type printing in the presence of qualifiers.
Fri, Jan 8, 7:44 AM · Restricted Project
kadircet accepted D94259: [clangd] Fix type printing in the presence of qualifiers.

Thanks, LGTM!

Fri, Jan 8, 7:18 AM · Restricted Project
kadircet added a comment to D94293: [clangd] automatically index STL.

How does this approach work with differing language standards. For example with an old implementation designed for c++14, string_view header won't exist. If the implementation is designed to work with c++17, including that header in c++14 mode will probably be ifdef... Error.

Fri, Jan 8, 5:17 AM · Restricted Project
kadircet added inline comments to D94259: [clangd] Fix type printing in the presence of qualifiers.
Fri, Jan 8, 5:07 AM · Restricted Project
kadircet accepted D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC.
Fri, Jan 8, 4:26 AM
kadircet added a comment to D94293: [clangd] automatically index STL.

(not sure if you were looking for comments yet, but i was just passing by and it was a small-ish patch, so couldn't resist :D)

Fri, Jan 8, 4:17 AM · Restricted Project

Thu, Jan 7

kadircet accepted D94222: [clangd] Add server capability advertising hot-reloading of CDBs..
Thu, Jan 7, 3:59 AM · Restricted Project

Tue, Jan 5

kadircet added a comment to D93354: [clang-tidy] Make clang-format and include-order-check coherent again.

i thought clang-format was also putting angled includes and "OtherHeaders" into same category, by looking at:

Tue, Jan 5, 9:34 AM · Restricted Project

Dec 9 2020

kadircet added a comment to D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt.

this mostly LGTM. there are some changes to the existing behavior; like discovery order and not looking for other plugins under build/, but they seem like non-harmful changes to me.

Dec 9 2020, 7:40 AM · Restricted Project
kadircet accepted D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC.

thanks, lgtm!

Dec 9 2020, 1:37 AM · Restricted Project
kadircet added inline comments to D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file..
Dec 9 2020, 1:16 AM · Restricted Project

Dec 1 2020

kadircet requested changes to D92041: [clangd] Add hover info for `this` expr.

One last point, is it worth including cv qualifications in the hover info?

Dec 1 2020, 9:18 AM · Restricted Project, Restricted Project
kadircet added inline comments to D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC.
Dec 1 2020, 6:20 AM · Restricted Project
kadircet committed rGe98d3be11c29: [clang] Enable code completion of designated initializers in Compound Literal… (authored by kadircet).
[clang] Enable code completion of designated initializers in Compound Literal…
Dec 1 2020, 3:12 AM
kadircet closed D92370: [clang] Enable code completion of designated initializers in Compound Literal Expressions.
Dec 1 2020, 3:12 AM · Restricted Project
kadircet added a comment to D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage().

I was trying to cause the index to load in the initialization stage for D92198 but couldn't figure out where exactly the config is loaded and what could be the best place for triggering index loading.

Fair point, will have a look at that. Forcing an index load might be a nice side-effect of this patch, but I think we can find a better way to do it.

Dec 1 2020, 1:21 AM · Restricted Project
kadircet requested review of D92370: [clang] Enable code completion of designated initializers in Compound Literal Expressions.
Dec 1 2020, 1:01 AM · Restricted Project
kadircet added a comment to D92041: [clangd] Add hover info for `this` expr.

can you give me an email address to associate the commit with?

Dec 1 2020, 12:19 AM · Restricted Project, Restricted Project

Nov 27 2020

kadircet added a comment to D92041: [clangd] Add hover info for `this` expr.

Do you have commit access or should I commit this for you?

Nov 27 2020, 7:27 AM · Restricted Project, Restricted Project
kadircet added a comment to D92198: [clangd] Log remote index connectivity status.

Haven't checked the details but is there a specific reason for implementing a custom protocol rather than making use of NotifyOnStateChange (https://grpc.github.io/grpc/cpp/classgrpc_1_1_channel_interface.html) or even WaitForStateChange if we really want to block the channel creation ?

Nov 27 2020, 7:15 AM · Restricted Project

Nov 26 2020

kadircet accepted D92041: [clangd] Add hover info for `this` expr.

thanks, LGTM!

Nov 26 2020, 5:09 AM · Restricted Project, Restricted Project
kadircet added inline comments to D92157: [clangd] Add language metrics for recovery AST usage..
Nov 26 2020, 1:10 AM · Restricted Project
kadircet added inline comments to D92012: [clangd][query-driver] Extract target.
Nov 26 2020, 12:58 AM · Restricted Project
kadircet added inline comments to D92012: [clangd][query-driver] Extract target.
Nov 26 2020, 12:56 AM · Restricted Project

Nov 25 2020

kadircet added a comment to D92000: [clangd] Collect main file refs by default.

nope, as it doesn't change the serialization format. but any existing shards won't have refs from the main file, they'll accumulate over time as sources gets modified. (i don't think it is worth bumping the version to invalidate existing shards, if a user cares enough they can manually delete their cache)

Nov 25 2020, 12:07 PM · Restricted Project
kadircet added inline comments to D92041: [clangd] Add hover info for `this` expr.
Nov 25 2020, 10:45 AM · Restricted Project, Restricted Project
kadircet accepted D92107: [clangd] Fix use of system-installed GRPC after f726101b6240a6740b3c0926af759da5e7336f8a.

thanks, LGTM!

Nov 25 2020, 10:15 AM · Restricted Project
kadircet added inline comments to D92012: [clangd][query-driver] Extract target.
Nov 25 2020, 5:06 AM · Restricted Project
kadircet added a comment to D91930: [clangd] Implement textDocument/codeLens.

Thanks for the explanations. I've also had some discussions with @sammccall about this and would like to summarize them.

Nov 25 2020, 4:30 AM · Restricted Project, Restricted Project
kadircet accepted D92000: [clangd] Collect main file refs by default.

Thanks, LGTM.

Nov 25 2020, 3:59 AM · Restricted Project
kadircet accepted D92077: [clangd] Avoid type hierarchy crash on incomplete type.

Thanks, LGTM!

Nov 25 2020, 12:15 AM · Restricted Project
kadircet added inline comments to D92041: [clangd] Add hover info for `this` expr.
Nov 25 2020, 12:14 AM · Restricted Project, Restricted Project

Nov 24 2020

kadircet accepted D92053: [clangd] Addusing tweak: find insertion point after definition.

thanks, LGTM

Nov 24 2020, 1:24 PM · Restricted Project
kadircet added inline comments to D92012: [clangd][query-driver] Extract target.
Nov 24 2020, 12:21 PM · Restricted Project
kadircet added a comment to D92041: [clangd] Add hover info for `this` expr.

Thanks, this sounds like a sensible idea. I got a few suggestions for the implementation though.

Nov 24 2020, 9:37 AM · Restricted Project, Restricted Project
kadircet accepted D91966: [clangd] AddUsing: Used spelled text instead of type name..

thanks, lgtm!

Nov 24 2020, 8:45 AM · Restricted Project
kadircet committed rGf726101b6240: [clangd] Fix shared-lib builds (authored by kadircet).
[clangd] Fix shared-lib builds
Nov 24 2020, 4:05 AM
kadircet closed D91859: [clangd] Fix shared-lib builds.
Nov 24 2020, 4:05 AM · Restricted Project, Restricted Project
kadircet updated the diff for D91859: [clangd] Fix shared-lib builds.
  • Link protobuf and grpc++ publicly to generated targets
Nov 24 2020, 1:42 AM · Restricted Project, Restricted Project
kadircet accepted D92009: [clangd] Sort results of incomingCalls request by container name.

Thanks!

Nov 24 2020, 12:25 AM · Restricted Project
kadircet added a comment to D92000: [clangd] Collect main file refs by default.

NVM, found the summary https://github.com/clangd/clangd/issues/162#issuecomment-653981038

Nov 24 2020, 12:19 AM · Restricted Project
kadircet added a comment to D92000: [clangd] Collect main file refs by default.

i remember discussing this in the past, and having "negative" feelings about it. I couldn't find the discussion on the issues page tho, could you toss me the link if you can find it? (it might've been an offline discussion as well, sorry if that's the case for not dumping a summary).

Nov 24 2020, 12:17 AM · Restricted Project
kadircet added inline comments to D91122: [clangd] Call hierarchy (XRefs layer, incoming calls).
Nov 24 2020, 12:11 AM · Restricted Project

Nov 23 2020

kadircet added inline comments to D91966: [clangd] AddUsing: Used spelled text instead of type name..
Nov 23 2020, 9:33 AM · Restricted Project
kadircet added a comment to D91930: [clangd] Implement textDocument/codeLens.

Thanks a lot for working on improving clangd!

Nov 23 2020, 6:18 AM · Restricted Project, Restricted Project
kadircet added a reverting change for rG8cec8de2a4e6: [clangd] testPath's final result agrees with the passed in Style: rG61e538b15ddb: Revert "[clangd] testPath's final result agrees with the passed in Style".
Nov 23 2020, 4:13 AM
kadircet committed rG61e538b15ddb: Revert "[clangd] testPath's final result agrees with the passed in Style" (authored by kadircet).
Revert "[clangd] testPath's final result agrees with the passed in Style"
Nov 23 2020, 4:13 AM
kadircet added a reverting change for D91947: [clangd] testPath's final result agrees with the passed in Style: rG61e538b15ddb: Revert "[clangd] testPath's final result agrees with the passed in Style".
Nov 23 2020, 4:13 AM · Restricted Project
kadircet committed rG8cec8de2a4e6: [clangd] testPath's final result agrees with the passed in Style (authored by kadircet).
[clangd] testPath's final result agrees with the passed in Style
Nov 23 2020, 3:45 AM
kadircet closed D91947: [clangd] testPath's final result agrees with the passed in Style.
Nov 23 2020, 3:45 AM · Restricted Project
kadircet accepted D91122: [clangd] Call hierarchy (XRefs layer, incoming calls).

This looks great! Thanks a lot for bearing with me and doing all of this!

Nov 23 2020, 1:46 AM · Restricted Project
kadircet requested review of D91947: [clangd] testPath's final result agrees with the passed in Style.
Nov 23 2020, 1:32 AM · Restricted Project
kadircet accepted D91945: Enable retry on failed git operations.

LGTM

Nov 23 2020, 1:08 AM
kadircet committed rGfee78fb0049a: [clangd] Second attempt at fixing windows buildbots (authored by kadircet).
[clangd] Second attempt at fixing windows buildbots
Nov 23 2020, 1:07 AM
kadircet accepted D91941: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy().

thanks!

Nov 23 2020, 12:49 AM · Restricted Project
kadircet committed rG0dc2589d4a72: [clangd] Attempt at fixing ExternalIndex tests on windows (authored by kadircet).
[clangd] Attempt at fixing ExternalIndex tests on windows
Nov 23 2020, 12:16 AM

Nov 22 2020

kadircet committed rG655360096f27: [clangd] Fix use-after-free in ProjectAwareIndex tests (authored by kadircet).
[clangd] Fix use-after-free in ProjectAwareIndex tests
Nov 22 2020, 12:30 PM
kadircet committed rGcab313680703: [clangd] Use ProjectAwareIndex in ClangdMain (authored by kadircet).
[clangd] Use ProjectAwareIndex in ClangdMain
Nov 22 2020, 12:13 PM
kadircet committed rG067ffbfe6018: [clangd] Introduce ProjectAwareIndex (authored by kadircet).
[clangd] Introduce ProjectAwareIndex
Nov 22 2020, 12:13 PM
kadircet committed rGc9776c8d4ef7: [clangd] Introduce config compilation for External blocks (authored by kadircet).
[clangd] Introduce config compilation for External blocks
Nov 22 2020, 12:13 PM
kadircet committed rG359e2f988dc5: [clangd] Introduce config parsing for External blocks (authored by kadircet).
[clangd] Introduce config parsing for External blocks
Nov 22 2020, 12:13 PM
kadircet closed D91860: [clangd] Move remote-index dependency from clangDaemon to ClangdMain.
Nov 22 2020, 12:13 PM · Restricted Project
kadircet closed D90750: [clangd] Introduce ProjectAwareIndex.
Nov 22 2020, 12:13 PM · Restricted Project
kadircet closed D90749: [clangd] Introduce config compilation for External blocks.
Nov 22 2020, 12:13 PM · Restricted Project
kadircet closed D90748: [clangd] Introduce config parsing for External blocks.
Nov 22 2020, 12:13 PM · Restricted Project
kadircet added a comment to D91859: [clangd] Fix shared-lib builds.

I applied the patch locally and it fixes most of the linker errors but I'm still seeing one:

[6/393] Linking CXX executable bin/clangd-index-server
FAILED: bin/clangd-index-server
: && /usr/bin/clang++-10 -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -fuse-ld=gold     -Wl,-O3 -Wl,--gc-sections tools/clang/tools/extra/clangd/index/remote/server/CMakeFiles/clangd-index-server.dir/Server.cpp.o -o bin/clangd-index-server  -Wl,-rpath,"\$ORIGIN/../lib"  -lpthread  lib/libRemoteIndexServiceProto.so.12git  lib/libclangdRemoteMarshalling.so.12git  -lgrpc++  lib/libclangDaemon.so.12git  lib/libclangdSupport.so.12git  lib/libRemoteIndexProto.so.12git  lib/libLLVMSupport.so.12git  -Wl,-rpath-link,llvm/prod-build/lib && :
tools/clang/tools/extra/clangd/index/remote/server/CMakeFiles/clangd-index-server.dir/Server.cpp.o:Server.cpp:function llvm::detail::stream_operator_format_adapter<clang::clangd::remote::(anonymous namespace)::RemoteIndexServer::TextProto>::format(llvm::raw_ostream&, llvm::StringRef): error: undefined reference to 'google::protobuf::Message::DebugString[abi:cxx11]() const'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Nov 22 2020, 9:52 AM · Restricted Project, Restricted Project
kadircet updated the diff for D90750: [clangd] Introduce ProjectAwareIndex.
  • Address comments
Nov 22 2020, 9:11 AM · Restricted Project

Nov 21 2020

kadircet added inline comments to D91122: [clangd] Call hierarchy (XRefs layer, incoming calls).
Nov 21 2020, 5:36 AM · Restricted Project
kadircet abandoned D90751: [clangd] Use ProjectAwareIndex.

Merged with https://reviews.llvm.org/D91860

Nov 21 2020, 5:05 AM · Restricted Project
kadircet updated the diff for D91860: [clangd] Move remote-index dependency from clangDaemon to ClangdMain.
Nov 21 2020, 5:05 AM · Restricted Project
kadircet updated the diff for D91860: [clangd] Move remote-index dependency from clangDaemon to ClangdMain.
  • Address comments
Nov 21 2020, 5:02 AM · Restricted Project
kadircet accepted D91123: [clangd] Call hierarchy (ClangdServer layer).
Nov 21 2020, 2:09 AM · Restricted Project
kadircet accepted D91124: [clangd] Call hierarchy (ClangdLSPServer layer).

thanks, lgtm!

Nov 21 2020, 2:06 AM · Restricted Project
kadircet accepted D91868: [clangd] Mention when CXXThis is implicit in exposed AST..
Nov 21 2020, 1:47 AM · Restricted Project
kadircet updated subscribers of D91859: [clangd] Fix shared-lib builds.

I don't think that's how CMake works, the whole CMakeLists tree is parsed before anything is compiled, so it shouldn't race like that.

Nov 21 2020, 1:39 AM · Restricted Project, Restricted Project
kadircet updated the diff for D91859: [clangd] Fix shared-lib builds.
  • Address comments
Nov 21 2020, 1:39 AM · Restricted Project, Restricted Project

Nov 20 2020

kadircet added a comment to D91868: [clangd] Mention when CXXThis is implicit in exposed AST..

This looks like an improvement to me as well, thanks!

Nov 20 2020, 2:09 PM · Restricted Project
kadircet requested review of D91860: [clangd] Move remote-index dependency from clangDaemon to ClangdMain.
Nov 20 2020, 4:06 AM · Restricted Project
kadircet requested review of D91859: [clangd] Fix shared-lib builds.
Nov 20 2020, 4:03 AM · Restricted Project, Restricted Project
kadircet added inline comments to D91186: [clangd] Add documentation for building and testing clangd.
Nov 20 2020, 2:34 AM · Restricted Project
kadircet updated the diff for D91186: [clangd] Add documentation for building and testing clangd.
  • Mention assertions and ninja
Nov 20 2020, 2:34 AM · Restricted Project
kadircet updated the diff for D90751: [clangd] Use ProjectAwareIndex.
  • Rebase
Nov 20 2020, 1:37 AM · Restricted Project
kadircet updated the diff for D90750: [clangd] Introduce ProjectAwareIndex.
  • Internalize synchronization of indexstorage rather than using Memoize
Nov 20 2020, 12:59 AM · Restricted Project

Nov 19 2020

kadircet added inline comments to D89571: [clangd] Add textDocument/ast extension method to dump the AST.
Nov 19 2020, 11:47 PM · Restricted Project
kadircet added a comment to D90750: [clangd] Introduce ProjectAwareIndex.

ping :)

Nov 19 2020, 1:06 AM · Restricted Project
kadircet added inline comments to D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC.
Nov 19 2020, 12:22 AM

Nov 18 2020

kadircet committed rG7c2990b8af6f: [clangd] Fix data race in GoToInclude.All test (authored by kadircet).
[clangd] Fix data race in GoToInclude.All test
Nov 18 2020, 11:53 PM
kadircet accepted D91705: Fix unused variables in release build.
Nov 18 2020, 6:14 AM · Restricted Project

Nov 17 2020

kadircet added inline comments to D91610: [clangd] Add OverriddenBy Relation to index..
Nov 17 2020, 7:07 AM · Restricted Project