Page MenuHomePhabricator

kadircet (Kadir Cetinkaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 2:16 AM (129 w, 15 h)

Recent Activity

Today

kadircet requested review of D85354: [clangd] Reduce availability of extract function.
Wed, Aug 5, 1:22 PM · Restricted Project
kadircet committed rG618db6803d6c: [clangd][NFC] Delete dead code in ExtractFunction code action (authored by kadircet).
[clangd][NFC] Delete dead code in ExtractFunction code action
Wed, Aug 5, 12:15 PM
kadircet committed rGd3ac30188666: [clangd] Disable define out-of-line code action on templates (authored by kadircet).
[clangd] Disable define out-of-line code action on templates
Wed, Aug 5, 12:01 PM
kadircet closed D85310: [clangd] Disable define out-of-line code action on templates.
Wed, Aug 5, 12:01 PM · Restricted Project
kadircet added a comment to D85318: [clangd] Hide "swap if branch" tweak.

you might want this to be cherry-picked into 11 release

Wed, Aug 5, 9:27 AM · Restricted Project
kadircet accepted D85318: [clangd] Hide "swap if branch" tweak.
Wed, Aug 5, 9:26 AM · Restricted Project
kadircet added a comment to D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..

I'm not quite sure there should be no tooltip for a #define. Such tooltip is not really useful, but at the same time clangd shows tooltips for function declarations/defnitions, namespaces, variables, etc. and not showing it for macro definition will be a little bit inconsistent from my point of view.

Wed, Aug 5, 9:19 AM · Restricted Project
kadircet updated the diff for D85310: [clangd] Disable define out-of-line code action on templates.
  • Address comments
Wed, Aug 5, 9:07 AM · Restricted Project
kadircet added inline comments to D85310: [clangd] Disable define out-of-line code action on templates.
Wed, Aug 5, 9:07 AM · Restricted Project
kadircet committed rG011732852c2c: [clangd] Fix a crash in DefineInline (authored by kadircet).
[clangd] Fix a crash in DefineInline
Wed, Aug 5, 8:38 AM
kadircet closed D85291: [clangd] Fix a crash in DefineInline.
Wed, Aug 5, 8:38 AM · Restricted Project
kadircet requested review of D85310: [clangd] Disable define out-of-line code action on templates.
Wed, Aug 5, 7:22 AM · Restricted Project
kadircet requested review of D85291: [clangd] Fix a crash in DefineInline.
Wed, Aug 5, 4:34 AM · Restricted Project
kadircet added a comment to D85253: [clangd] Show correct hover tooltip for non-preamble macro definition..

Sigh, (I think) this is working for macros defined in preamble region as a side effect of preamble being loaded separately and before anything in the main file. E.g.

Wed, Aug 5, 3:27 AM · Restricted Project

Mon, Aug 3

kadircet committed rG76c3ec814dec: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes (authored by kadircet).
[clang][Tooling] Optimize addTargetAndMode in case of invalid modes
Mon, Aug 3, 5:01 AM
kadircet closed D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes.
Mon, Aug 3, 5:01 AM · Restricted Project
kadircet updated the diff for D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes.
  • Change bitwise assignment to logical operators, as bitwise operators do not have short-circuting.
Mon, Aug 3, 4:51 AM · Restricted Project
kadircet updated the diff for D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes.
  • Rename AlreadyHas to ShouldAdd (and revert the logic)
Mon, Aug 3, 2:58 AM · Restricted Project
kadircet committed rG87de54dbb6ef: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names (authored by kadircet).
[clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names
Mon, Aug 3, 2:47 AM
kadircet closed D85076: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names.
Mon, Aug 3, 2:47 AM · Restricted Project
kadircet added a comment to D84599: [clang-index] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.

I can see how this can cause problems with current implementation, but I don't think the proposed solution in here is also solving these problems.

Mon, Aug 3, 2:46 AM · Restricted Project
kadircet added inline comments to D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes.
Mon, Aug 3, 2:38 AM · Restricted Project
kadircet committed rGd76057c1fe6a: Add document outline symbols from unnamed contexts, e.g. extern "C". (authored by ilya-golovenko).
Add document outline symbols from unnamed contexts, e.g. extern "C".
Mon, Aug 3, 2:36 AM
kadircet closed D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..
Mon, Aug 3, 2:36 AM · Restricted Project
kadircet accepted D85028: [clangd] Support new/delete operator in TargetFinder..

thanks, lgtm!

Mon, Aug 3, 2:31 AM · Restricted Project

Sat, Aug 1

kadircet added a comment to D85028: [clangd] Support new/delete operator in TargetFinder..

please note that this might require special handling for go-to-def. as go-to-def only jumps to canonical decl and in operator new's case the user provided one might not be canonical, whereas the canonical one is likely builtin without a source info.

Sat, Aug 1, 10:56 AM · Restricted Project
kadircet accepted D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

let me know if i should land this for you

Sat, Aug 1, 10:19 AM · Restricted Project
kadircet requested review of D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes.
Sat, Aug 1, 10:04 AM · Restricted Project
kadircet requested review of D85076: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names.
Sat, Aug 1, 10:01 AM · Restricted Project

Fri, Jul 31

kadircet added a comment to D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

@kadircet I decided to add OnlyChildren to enum VisitKind instead of making a VisitKindSet - this helped to minimize the changes in shouldVisit(). What do you think?

Fri, Jul 31, 9:02 AM · Restricted Project
kadircet committed rG161882816540: [clang][Syntax] syntax::Arena doesnt own TokenBuffer (authored by kadircet).
[clang][Syntax] syntax::Arena doesnt own TokenBuffer
Fri, Jul 31, 2:50 AM
kadircet closed D84973: [clang][Syntax] syntax::Arena doesnt own TokenBuffer.
Fri, Jul 31, 2:50 AM · Restricted Project
kadircet accepted D84939: [clangd] Propagate remote index errors via Expected.

thanks, lgtm!

Fri, Jul 31, 2:35 AM · Restricted Project

Thu, Jul 30

kadircet requested review of D84975: [clangd][WIP] Make use of SyntaxTrees for SemanticSelection.
Thu, Jul 30, 12:45 PM · Restricted Project
kadircet requested review of D84973: [clang][Syntax] syntax::Arena doesnt own TokenBuffer.
Thu, Jul 30, 12:43 PM · Restricted Project
kadircet accepted D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol..

thanks, lgtm!

Thu, Jul 30, 7:37 AM · Restricted Project
kadircet added a comment to D84939: [clangd] Propagate remote index errors via Expected.

i think you might want to have an helper for creating stringerrors and use it in all places

Thu, Jul 30, 7:36 AM · Restricted Project
kadircet accepted D84894: [clangd] Implement Relations request for remote index.

thanks, lgtm!

Thu, Jul 30, 3:43 AM · Restricted Project
kadircet added inline comments to D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol..
Thu, Jul 30, 3:23 AM · Restricted Project
kadircet added a comment to D84894: [clangd] Implement Relations request for remote index.

thanks mostly nits, only annoying bit is usage of optionals and multi-logging but letting them be for now :D.

Thu, Jul 30, 3:06 AM · Restricted Project
kadircet added a comment to D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream..

oh and also, how did you notice the discrepancy? was it a random encounter while reading the code or did you notice a misbehaviour?

Thu, Jul 30, 2:32 AM · Restricted Project
kadircet accepted D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream..

thanks for catching this, LGTM! This might still end up traversing the whole file in non-existent cases, but I suppose that's an adventure for another day.

Thu, Jul 30, 2:31 AM · Restricted Project
kadircet added inline comments to D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol..
Thu, Jul 30, 2:10 AM · Restricted Project

Wed, Jul 29

kadircet added inline comments to D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..
Wed, Jul 29, 5:57 AM · Restricted Project

Tue, Jul 28

kadircet added a comment to D83224: [clangd] Move clang-tidy check modifications into ClangdServer.

Do you think there should be a hidden command line option to disable disabling blacklisted checks, purely to prevent hindering attempts to fix these problematic checks.

Tue, Jul 28, 7:56 AM · Restricted Project

Mon, Jul 27

kadircet accepted D84499: [clangd] Add more logs and attach tracers to remote index server routines.

thanks, LGTM apart from templated-lambdas.

Mon, Jul 27, 6:14 AM · Restricted Project
kadircet accepted D84525: [clangd] Add marshalling code for all request types.

thanks for bearing with me, LGTM!

Mon, Jul 27, 4:53 AM · Restricted Project
kadircet accepted D84513: [clangd] Collect references for externally visible main-file symbols.

thanks! numbers and the patch LGTM.

Mon, Jul 27, 4:24 AM · Restricted Project
kadircet added a comment to D84525: [clangd] Add marshalling code for all request types.

mostly LG. sorry for lots of nits, only two important bits are changing the {1} to {0} in logs, wrapping symbolid generations in llvm::cantFail and making sure Deserialized is exactly the same thing as Request in tests. feel free to ignore the rest (I should've marked them with nit hopefully, but might've missed some)

Mon, Jul 27, 4:19 AM · Restricted Project
kadircet added inline comments to D84525: [clangd] Add marshalling code for all request types.
Mon, Jul 27, 1:55 AM · Restricted Project

Sun, Jul 26

kadircet accepted D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests.

thanks LGTM!

Sun, Jul 26, 4:13 AM · Restricted Project

Fri, Jul 24

kadircet added inline comments to D84525: [clangd] Add marshalling code for all request types.
Fri, Jul 24, 8:15 AM · Restricted Project
kadircet added inline comments to D84499: [clangd] Add more logs and attach tracers to remote index server routines.
Fri, Jul 24, 7:58 AM · Restricted Project
kadircet added a comment to D84513: [clangd] Collect references for externally visible main-file symbols.

thanks, this looks good in general, but it would be nice to make sure we are not blowing the index memory and disk usage.

Fri, Jul 24, 6:00 AM · Restricted Project

Wed, Jul 22

kadircet accepted D83759: [clangd] Fixes in lit tests.

thanks, LGTM.

Wed, Jul 22, 5:55 AM · Restricted Project
kadircet added inline comments to D83759: [clangd] Fixes in lit tests.
Wed, Jul 22, 4:50 AM · Restricted Project
kadircet added inline comments to D83759: [clangd] Fixes in lit tests.
Wed, Jul 22, 4:20 AM · Restricted Project
kadircet committed rGa69f9a8584f2: [clangd] Fix Origin and MainFileOnly-ness for macros (authored by kadircet).
[clangd] Fix Origin and MainFileOnly-ness for macros
Wed, Jul 22, 2:25 AM
kadircet closed D84297: [clangd] Fix Origin and MainFileOnly-ness for macros.
Wed, Jul 22, 2:24 AM · Restricted Project
kadircet updated the diff for D84297: [clangd] Fix Origin and MainFileOnly-ness for macros.
  • Move declarations closer to use.
Wed, Jul 22, 2:24 AM · Restricted Project
kadircet added a comment to D84297: [clangd] Fix Origin and MainFileOnly-ness for macros.

the test.h in the patch description is missing a #define X.

Wed, Jul 22, 2:24 AM · Restricted Project
kadircet updated the summary of D84297: [clangd] Fix Origin and MainFileOnly-ness for macros.
Wed, Jul 22, 1:44 AM · Restricted Project
Herald added a project to D84297: [clangd] Fix Origin and MainFileOnly-ness for macros: Restricted Project.
Wed, Jul 22, 1:43 AM · Restricted Project
kadircet added a comment to D83759: [clangd] Fixes in lit tests.

Seem the problem is in -i option.
According with OSX man:
sed [-Ealn] command [file ... ]
sed [-Ealn] [-e command] [-f command_file] [-i extension] [file ...].

Seems on macOS -E is treated as an argument for -i in command like sed -i -E -e ... .

Also, seems commands like sed -i -e ... are unsafe on macOS. Such commands will create backup with name <filename>-e, but I do not have macOS to check it.
@thakis could you please verify that after tests you have extra <filename>-e files in /Users/thakis/src/llvm-project/out/gn/obj/clang-tools-extra/clangd/test/Output/background-index.test.tmp/ ?

I think we could avoid -i usage to fix this problem.

Wed, Jul 22, 1:02 AM · Restricted Project

Tue, Jul 21

kadircet accepted D83759: [clangd] Fixes in lit tests.

as i mentioned please watch out for buildbot breakages after landing this. (and again let me know if I should land this for you)

Tue, Jul 21, 7:53 AM · Restricted Project
kadircet added inline comments to D83759: [clangd] Fixes in lit tests.
Tue, Jul 21, 2:46 AM · Restricted Project
kadircet added a comment to D83759: [clangd] Fixes in lit tests.

hi, sorry for the late replay :/

Tue, Jul 21, 1:54 AM · Restricted Project

Mon, Jul 20

kadircet committed rGc911803d5df0: [clangd] Remove TokenBuffer usage in TypeHierarchy (authored by ArcsinX).
[clangd] Remove TokenBuffer usage in TypeHierarchy
Mon, Jul 20, 9:17 PM
kadircet added a reverting change for D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers: rGc911803d5df0: [clangd] Remove TokenBuffer usage in TypeHierarchy.
Mon, Jul 20, 9:17 PM · Restricted Project
kadircet closed D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.
Mon, Jul 20, 9:17 PM · Restricted Project
kadircet added inline comments to D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection.
Mon, Jul 20, 6:43 AM · Restricted Project
kadircet added a comment to D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.

just some drive-by comments.

Mon, Jul 20, 4:44 AM · Restricted Project
kadircet added inline comments to D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.
Mon, Jul 20, 4:20 AM · Restricted Project
kadircet accepted D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.

LGTM, just some improvements to the testing. also please let me know if I should land this for you.

Mon, Jul 20, 3:37 AM · Restricted Project
kadircet added a comment to D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.

ah embarrassing :/ thanks for catching this! It should've been obvious from the fact that there's a "FilePath" and a "TUPath" going on ..

Mon, Jul 20, 2:42 AM · Restricted Project

Fri, Jul 17

kadircet added inline comments to D83822: [clangd] Support config over LSP..
Fri, Jul 17, 8:10 AM · Restricted Project
kadircet accepted D84009: [Syntax] expose API for expansions overlapping a spelled token range..

thanks, LGTM! (and loved the choice of overlapping)

Fri, Jul 17, 6:52 AM · Restricted Project
kadircet added a comment to D84009: [Syntax] expose API for expansions overlapping a spelled token range..

thanks, mostly LG with a comment about some edge case. just wanna know what you think.

Fri, Jul 17, 4:32 AM · Restricted Project
kadircet accepted D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection.

LGTM, thanks!

Fri, Jul 17, 3:44 AM · Restricted Project

Thu, Jul 16

kadircet added a comment to D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor..

Yeah that makes sense, I guess it just says nothing is selected in that case?
Selecting the while is probably marginally better for that exact case, but selecting nothing seems fine to me.

@kadircet any concerns with that "regression"?

Thu, Jul 16, 4:04 AM · Restricted Project
kadircet committed rGa130cf8ae8ab: [clang] Fix printing of lambdas with capture expressions (authored by walrus).
[clang] Fix printing of lambdas with capture expressions
Thu, Jul 16, 3:50 AM
kadircet closed D83855: [clang] Fix printing of lambdas with capture expressions.
Thu, Jul 16, 3:50 AM · Restricted Project
kadircet committed rG46c921003c2c: [clangd] Always retrieve ProjectInfo from Base in OverlayCDB (authored by kadircet).
[clangd] Always retrieve ProjectInfo from Base in OverlayCDB
Thu, Jul 16, 3:38 AM
kadircet closed D83934: [clangd] Always retrieve ProjectInfo from Base in OverlayCDB.
Thu, Jul 16, 3:38 AM · Restricted Project
kadircet added a comment to D83855: [clang] Fix printing of lambdas with capture expressions.

do you have commit access? if not I am happy to land this for you.

Thu, Jul 16, 3:36 AM · Restricted Project
kadircet updated the diff for D83934: [clangd] Always retrieve ProjectInfo from Base in OverlayCDB.
  • Split comments between implementation and header, and reword.
Thu, Jul 16, 3:33 AM · Restricted Project
kadircet accepted D83855: [clang] Fix printing of lambdas with capture expressions.

thanks, lgtm!

Thu, Jul 16, 3:20 AM · Restricted Project
Herald added a project to D83934: [clangd] Always retrieve ProjectInfo from Base in OverlayCDB: Restricted Project.
Thu, Jul 16, 2:35 AM · Restricted Project

Wed, Jul 15

kadircet added inline comments to D83855: [clang] Fix printing of lambdas with capture expressions.
Wed, Jul 15, 8:26 AM · Restricted Project
kadircet added inline comments to D83855: [clang] Fix printing of lambdas with capture expressions.
Wed, Jul 15, 5:03 AM · Restricted Project
kadircet added inline comments to D83822: [clangd] Support config over LSP..
Wed, Jul 15, 3:28 AM · Restricted Project
kadircet accepted D83802: [clangd] Config: also propagate in sync (testing) mode.

thanks, lgtm.

Wed, Jul 15, 1:44 AM · Restricted Project

Tue, Jul 14

kadircet accepted D83790: [clangd] Config: on by default.
Tue, Jul 14, 10:52 AM · Restricted Project
kadircet accepted D83768: [clangd] Config: Index.Background.

let's ship it!

Tue, Jul 14, 8:43 AM · Restricted Project
kadircet added inline comments to D83768: [clangd] Config: Index.Background.
Tue, Jul 14, 8:10 AM · Restricted Project
kadircet accepted D83755: [clangd] Cache config files for 5 seconds, without revalidating with stat..

thanks, LGTM

Tue, Jul 14, 4:36 AM · Restricted Project

Mon, Jul 13

kadircet added a comment to D83536: [clangd] Index refs to main-file symbols as well.

I can do that.

Another thing we could consider, if the space increase is a concern, is to limit which references we store, e.g. to functions only (not variables or classes).

Mon, Jul 13, 12:16 AM · Restricted Project
kadircet committed rG07c4c7e7959b: [clangd] Fix tests build for GCC5 (authored by ArcsinX).
[clangd] Fix tests build for GCC5
Mon, Jul 13, 12:09 AM
kadircet closed D83548: [clangd] Fix tests build for GCC5.
Mon, Jul 13, 12:09 AM · Restricted Project

Fri, Jul 10

kadircet accepted D83546: [clangd] Fix hover crash on InitListExpr..

thanks, lgtm!

Fri, Jul 10, 6:36 AM · Restricted Project