- User Since
- Apr 18 2013, 6:48 AM (381 w, 2 d)
Fri, Aug 7
lgtm, looks like we already do this elsewhere in the file.
I don't know if anyone cares about the msan+zlib case, I just think it's important that FORCE_ON either enables zlib or raises an error. Looks like this patch ensures that.
Looks great, thanks! I put a suggestion for different wording of the note, but I'll leave it up to you to decide.
Brian: I think this is good to go, right?
Thu, Aug 6
Thanks! This looks promising.
Wed, Aug 5
In general when -ffoo is supported by clang-cl, -fno-foo should be too, so this makes sense.
Reverted in 3ab01550b632dad46f9595d74855749557ffd25c
Tue, Aug 4
From my point of view, I think it would be fine to only support rpmalloc in this patch. One aspect that Russell touched on is that if we support a bunch of options, it's not clear how well that support will be tested. Supporting only rpmalloc would also simplify the patch a little, and small incremental change is always good I think.
Fri, Jul 31
Thanks! This fixes the link error I was hitting.
Thu, Jul 30
Wed, Jul 29
Thanks! Can you add a note in docs/ReleaseNotes.rst explaining that this is expected to change in 12, what that means, what flags one should use to try it, and what problems to look out for?
Tue, Jul 28
Mon, Jul 27
Pushed to 11.x as 00ed5355e45b4d7e84366619dbbbb9df9b4aa816
Pushed to 11.x as 9dea95b78082a1d9739a60be8a40d721788e4447
Please shout if any problems come up.
Nemanja: should we cherry-pick this to the 11.x release branch, since 1fed131660b2 landed before? Are there other fixes that should also be cherry-picked?
Fri, Jul 24
Pushed to 11.x as 833f8c958601bb640ba6a25d627c1dc58dad14d2. Please let me know if there are any follow-ups.
Thu, Jul 23
In that case, I've enabled it again using add_compile_options instead of add_definitions. I've got my finger hovering over the button to revert.
Wed, Jul 22
This caused asserts in Chromium's coverage builds: https://bugs.chromium.org/p/chromium/issues/detail?id=1108352
I've reverted it in the meantime (238bbd48c5a5f84deca36e5df980241578f7c1df).