Page MenuHomePhabricator

sammccall (Sam McCall)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 26 2016, 6:53 AM (281 w, 6 d)
Roles
Administrator

Recent Activity

Today

sammccall accepted D117776: [clangd] Fail inlayHints requests on content changes.

This seems right for consistency with SemanticHighlights.

Thu, Jan 20, 8:35 AM · Restricted Project
sammccall accepted D117792: [clangd][Background] Make index validation logs verbose.
Thu, Jan 20, 8:32 AM · Restricted Project
sammccall added a comment to D116786: [clangd] Add designator inlay hints for initializer lists..

Any ideas? :-(

I've got a feeling that, this should also be annoying in the case of function calls (especially when there's only one overload)? Maybe we should just debounce the inlayhint requests (by saying contents modified to the clients)?

Thu, Jan 20, 6:11 AM · Restricted Project
sammccall added inline comments to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.
Thu, Jan 20, 2:47 AM · Restricted Project

Yesterday

sammccall added a comment to D117056: [clangd] Properly compute framework-style include spelling.

This looks good now, only blocker is dropping the change to LookupFile somehow.

Wed, Jan 19, 4:06 PM · Restricted Project, Restricted Project
sammccall added a comment to D116786: [clangd] Add designator inlay hints for initializer lists..

a drive by concern around possible flakiness of the interaction. have you checked how does it look like when the user is still forming the initializer? it might be annoying if their cursor kept jumping around while they're editing the (possibly half-formed) initializer.

Wed, Jan 19, 2:47 PM · Restricted Project
sammccall updated the diff for D116786: [clangd] Add designator inlay hints for initializer lists..

Address comments, rebase.
This category is *off* by default.

Wed, Jan 19, 2:38 PM · Restricted Project
sammccall added inline comments to D117463: [clangd] Disable expand-auto action on constrained auto..
Wed, Jan 19, 7:19 AM · Restricted Project
sammccall accepted D117475: [clangd] NFC, emit source ranges in selection debug messages..

Thanks!

Wed, Jan 19, 6:49 AM · Restricted Project

Tue, Jan 18

sammccall added a comment to D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks.

Happy to take a look at this, but is there a particular motive for optimizing this?
Looking at some profiles this appears to be something like 0.1-0.5ms in fairly complex configurations.

Tue, Jan 18, 4:55 PM · Restricted Project
sammccall added a comment to D117056: [clangd] Properly compute framework-style include spelling.

Nice!

Tue, Jan 18, 3:41 PM · Restricted Project, Restricted Project
sammccall added a comment to D117461: [clangd] IncludeCleaner: Attach "insert prgama keep" fix-it to diagnostic.

Nice!

Tue, Jan 18, 2:55 PM · Restricted Project
sammccall added inline comments to D117475: [clangd] NFC, emit source ranges in selection debug messages..
Tue, Jan 18, 2:29 PM · Restricted Project
sammccall added a comment to D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent.

@kadircet What we forgot to think about here is that this allows more semantic checks to happen at template parsing time, which affects diagnostics.

Tue, Jan 18, 1:23 PM · Restricted Project
sammccall committed rG4777eb295408: [Sema] Add test for new errors due to 09f8315bba391 (authored by sammccall).
[Sema] Add test for new errors due to 09f8315bba391
Tue, Jan 18, 1:18 PM
sammccall accepted D117549: [clangd] Sort targets before printing for tests.

Thanks!

Tue, Jan 18, 12:07 PM · Restricted Project

Mon, Jan 17

sammccall added a comment to D117268: [libc++] Install clang-tidy in docker containers.

This puts the relative path v1 on the include path (it's a fancy -I v1).
In case of compile_flags.txt, the working directory is the dir containing compile_flags.txt.
So if this is to be placed somewhere other than the parent of the v1 header directory, it will need to be some other (relative or absolute) path to that directory.

Mon, Jan 17, 10:09 AM · Restricted Project
sammccall added a reverting change for rG1093b9f2e984: Revert "[clangd] Elide even more checks in SelectionTree.": rG4dedd82cc993: Re-land [clangd] Elide even more checks in SelectionTree..
Mon, Jan 17, 6:29 AM
sammccall committed rG4dedd82cc993: Re-land [clangd] Elide even more checks in SelectionTree. (authored by sammccall).
Re-land [clangd] Elide even more checks in SelectionTree.
Mon, Jan 17, 6:29 AM
sammccall accepted D117472: [clangd] Bring back early-claim approach to fix a selection-tree regression..
Mon, Jan 17, 6:11 AM · Restricted Project
sammccall updated subscribers of D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

Ah, this seems to be coming from the buildbot configuration.

Mon, Jan 17, 5:46 AM · Restricted Project
sammccall added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

This appears to have triggered some buildbot failures:

Mon, Jan 17, 5:41 AM · Restricted Project
sammccall added a comment to D117463: [clangd] Disable expand-auto action on constrained auto..

I'm missing some context on this patch. My intuition is that constrained auto is unlikely to be used in deducible contexts, but maybe some people will like Iterator<int> auto I = foo.begin() or so...

Mon, Jan 17, 2:46 AM · Restricted Project
sammccall added a comment to D95046: [clangd] Add option to use dirty file contents when building preambles..

Sorry about letting this sit. I think this is good to go, with a naming tweak.

For the 14 cycle, it should be hidden: we may want to tweak the interactions with didSave reparsing etc, and there may be other unexpected wrinkles.

Regarding moving to config: we should do this, but there's some dumb bikeshedding of names (mostly: does this go at the top level or do we want a Parsing block or something, will other things fit in there, etc). So a hidden flag seems like the easiest thing for now.

I've been using this locally for months. The one nit i have is if you edit a header file then switch to a different file, diagnostics aren't updated until you force clangd to reparse the file (by editing it for example).

Mon, Jan 17, 2:41 AM · Restricted Project, Restricted Project
sammccall accepted D95046: [clangd] Add option to use dirty file contents when building preambles..

Sorry about letting this sit. I think this is good to go, with a naming tweak.

Mon, Jan 17, 1:28 AM · Restricted Project, Restricted Project
sammccall committed rG16949762dc6a: [docs] Clarify & update JSONCompilationDatabase docs (authored by sammccall).
[docs] Clarify & update JSONCompilationDatabase docs
Mon, Jan 17, 12:52 AM
sammccall closed D117428: [docs] Clarify & update JSONCompilationDatabase docs.
Mon, Jan 17, 12:52 AM · Restricted Project
sammccall accepted D117456: [clangd] Avoid a code completion crash.

This isn't an ideal fix but it's simple, we know the real fix is invasive, and 14 is upon us.

Mon, Jan 17, 12:47 AM · Restricted Project

Sun, Jan 16

sammccall added a comment to D117268: [libc++] Install clang-tidy in docker containers.

@sammccall Do you know whether clang-tidy can use compile_flags.txt? If it did, that could perhaps solve both this issue and also https://github.com/llvm/llvm-project/issues/45348.

Sun, Jan 16, 7:40 AM · Restricted Project
sammccall added inline comments to D117428: [docs] Clarify & update JSONCompilationDatabase docs.
Sun, Jan 16, 7:03 AM · Restricted Project
sammccall requested review of D117428: [docs] Clarify & update JSONCompilationDatabase docs.
Sun, Jan 16, 7:00 AM · Restricted Project

Fri, Jan 14

sammccall accepted D117294: [clangd] Better handling `\n` in the synthesized diagnostic message..
Fri, Jan 14, 3:43 AM · Restricted Project
sammccall committed rGbba729af3ef8: [clang-check] Adjust argument adjusters for clang-check to strip options… (authored by sammccall).
[clang-check] Adjust argument adjusters for clang-check to strip options…
Fri, Jan 14, 1:06 AM
sammccall closed D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer.
Fri, Jan 14, 1:05 AM · Restricted Project

Thu, Jan 13

sammccall accepted D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer.

Thanks, LG!

Thu, Jan 13, 10:51 PM · Restricted Project
sammccall committed rG07f9fb8b5141: [clangd] Elide even more checks in SelectionTree. (authored by sammccall).
[clangd] Elide even more checks in SelectionTree.
Thu, Jan 13, 1:28 PM
sammccall closed D117107: [clangd] Elide even more checks in SelectionTree..
Thu, Jan 13, 1:28 PM · Restricted Project
sammccall committed rG004acbb47d61: [clangd] Suppress warning about system_header pragma when editing headers (authored by sammccall).
[clangd] Suppress warning about system_header pragma when editing headers
Thu, Jan 13, 1:24 PM
sammccall closed D116925: [clangd] Suppress warning about system_header pragma when editing headers.
Thu, Jan 13, 1:24 PM · Restricted Project
sammccall committed rG71a082f72674: [clangd] Implement textDocument/typeDefinition (authored by sammccall).
[clangd] Implement textDocument/typeDefinition
Thu, Jan 13, 1:15 PM
sammccall closed D116443: [clangd] Implement textDocument/typeDefinition.
Thu, Jan 13, 1:15 PM · Restricted Project
sammccall added inline comments to D116443: [clangd] Implement textDocument/typeDefinition.
Thu, Jan 13, 1:14 PM · Restricted Project
sammccall updated the diff for D116925: [clangd] Suppress warning about system_header pragma when editing headers.

add test, fix build

Thu, Jan 13, 6:21 AM · Restricted Project
sammccall committed rGfc7a9f36a923: [clangd] Ignore cvr-qualifiers in selection. (authored by sammccall).
[clangd] Ignore cvr-qualifiers in selection.
Thu, Jan 13, 6:09 AM
sammccall closed D117185: [clangd] Ignore cvr-qualifiers in selection..
Thu, Jan 13, 6:08 AM · Restricted Project
sammccall added a comment to D117107: [clangd] Elide even more checks in SelectionTree..

PTAL

Thu, Jan 13, 5:56 AM · Restricted Project
sammccall updated the diff for D117107: [clangd] Elide even more checks in SelectionTree..

Handle EOF

Thu, Jan 13, 5:55 AM · Restricted Project
sammccall planned changes to D117107: [clangd] Elide even more checks in SelectionTree..

Thanks! You caught a serious bug, I'm digging into it.

Thu, Jan 13, 5:28 AM · Restricted Project
sammccall committed rG2b2dbe6126f8: [clangd] Selection: Prune gtest TEST()s earlier (authored by sammccall).
[clangd] Selection: Prune gtest TEST()s earlier
Thu, Jan 13, 4:59 AM
sammccall closed D116978: [clangd] Selection: Prune gtest TEST()s earlier.
Thu, Jan 13, 4:58 AM · Restricted Project
sammccall added inline comments to D116978: [clangd] Selection: Prune gtest TEST()s earlier.
Thu, Jan 13, 4:56 AM · Restricted Project
sammccall committed rG971bd6f83440: Fix build failure with MSVC in C++20 mode (authored by Godin).
Fix build failure with MSVC in C++20 mode
Thu, Jan 13, 3:55 AM
sammccall closed D116904: Fix build failure with MSVC in C++20 mode.
Thu, Jan 13, 3:55 AM · Restricted Project
sammccall added a comment to D116925: [clangd] Suppress warning about system_header pragma when editing headers.

I wasn't sure whether to suppress this in clang or clangd, wonder what you think.

I think it is fine to do it in clang. pp_pragma_once_in_main_file is a similar diag, and clang has already suppressed it.

Thu, Jan 13, 3:46 AM · Restricted Project
sammccall updated the diff for D116925: [clangd] Suppress warning about system_header pragma when editing headers.

add fixme

Thu, Jan 13, 3:44 AM · Restricted Project
sammccall committed rG54eb70886cda: [clangd] Remove --inlay-hints flag (authored by sammccall).
[clangd] Remove --inlay-hints flag
Thu, Jan 13, 1:02 AM
sammccall closed D117036: [clangd] Remove --inlay-hints flag.
Thu, Jan 13, 1:02 AM · Restricted Project
sammccall added inline comments to D117036: [clangd] Remove --inlay-hints flag.
Thu, Jan 13, 12:59 AM · Restricted Project

Wed, Jan 12

sammccall added a comment to D117036: [clangd] Remove --inlay-hints flag.

nit: I'd rename the patch to remove rather than retire.

Wed, Jan 12, 11:29 PM · Restricted Project
sammccall updated the diff for D117036: [clangd] Remove --inlay-hints flag.

rename patch

Wed, Jan 12, 11:29 PM · Restricted Project
sammccall committed rG9c9119ab364b: [clangd] Extend SymbolOrigin, stop serializing it (authored by sammccall).
[clangd] Extend SymbolOrigin, stop serializing it
Wed, Jan 12, 11:29 PM
sammccall closed D115243: [clangd] Extend SymbolOrigin, stop serializing it.
Wed, Jan 12, 11:29 PM · Restricted Project
sammccall committed rGd8716cd7d31c: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers. (authored by sammccall).
[CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.
Wed, Jan 12, 11:26 PM
sammccall closed D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers..
Wed, Jan 12, 11:25 PM · Restricted Project, Restricted Project
sammccall added inline comments to D117107: [clangd] Elide even more checks in SelectionTree..
Wed, Jan 12, 11:09 PM · Restricted Project
sammccall updated the diff for D117185: [clangd] Ignore cvr-qualifiers in selection..

Fix tests

Wed, Jan 12, 11:06 PM · Restricted Project
sammccall requested review of D117185: [clangd] Ignore cvr-qualifiers in selection..
Wed, Jan 12, 11:03 PM · Restricted Project
sammccall accepted D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm.
Wed, Jan 12, 5:58 AM · Restricted Project
sammccall requested review of D117107: [clangd] Elide even more checks in SelectionTree..
Wed, Jan 12, 5:51 AM · Restricted Project
sammccall accepted D116904: Fix build failure with MSVC in C++20 mode.

Thanks! Much nicer :-)

Wed, Jan 12, 2:27 AM · Restricted Project

Tue, Jan 11

sammccall accepted D117037: [clang][CodeComplete] Perform approximate member search in bases.
Tue, Jan 11, 10:09 AM · Restricted Project, Restricted Project
sammccall requested review of D117036: [clangd] Remove --inlay-hints flag.
Tue, Jan 11, 9:43 AM · Restricted Project
sammccall updated the diff for D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover.

Revert hover changes, only use for code complete

Tue, Jan 11, 9:37 AM · Restricted Project, Restricted Project
sammccall accepted D117009: [AST] Fix the incorrect auto-keyword loc for constrained auto type loc..
Tue, Jan 11, 8:58 AM · Restricted Project, Restricted Project
sammccall added a reviewer for D116978: [clangd] Selection: Prune gtest TEST()s earlier: hokein.
Tue, Jan 11, 8:51 AM · Restricted Project
sammccall updated the diff for D116978: [clangd] Selection: Prune gtest TEST()s earlier.

Rebase (offsetInSelFile)

Tue, Jan 11, 2:18 AM · Restricted Project
sammccall committed rG1e9b837585cc: [clangd] Save more getFileID in Selection (authored by sammccall).
[clangd] Save more getFileID in Selection
Tue, Jan 11, 2:02 AM
sammccall committed rG22ac067b2dce: [clangd] Small optimization in SelectionTree (authored by sammccall).
[clangd] Small optimization in SelectionTree
Tue, Jan 11, 1:24 AM

Mon, Jan 10

sammccall committed rG4258d68dc737: [Tooling] When transferring compile commands between files, always use '--' (authored by sammccall).
[Tooling] When transferring compile commands between files, always use '--'
Mon, Jan 10, 4:42 PM
sammccall closed D116721: [Tooling] When transferring compile commands between files, always use '--'.
Mon, Jan 10, 4:41 PM · Restricted Project, Restricted Project
sammccall updated the diff for D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover.

Fix printName

Mon, Jan 10, 4:41 PM · Restricted Project, Restricted Project
sammccall updated the diff for D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers..

Never eat malformed decl while code completing

Mon, Jan 10, 4:19 PM · Restricted Project, Restricted Project
sammccall added inline comments to D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers..
Mon, Jan 10, 4:19 PM · Restricted Project, Restricted Project
sammccall committed rGbbf234b56a82: [CodeCompletion] Complete designators for fields in anonymous structs/unions (authored by sammccall).
[CodeCompletion] Complete designators for fields in anonymous structs/unions
Mon, Jan 10, 3:59 PM
sammccall closed D116717: [CodeCompletion] Complete designators for fields in anonymous structs/unions.
Mon, Jan 10, 3:59 PM · Restricted Project
sammccall updated the diff for D116978: [clangd] Selection: Prune gtest TEST()s earlier.

Use the other end too

Mon, Jan 10, 3:15 PM · Restricted Project
sammccall requested review of D116978: [clangd] Selection: Prune gtest TEST()s earlier.
Mon, Jan 10, 3:10 PM · Restricted Project
sammccall added a comment to D116925: [clangd] Suppress warning about system_header pragma when editing headers.

I wasn't sure whether to suppress this in clang or clangd, wonder what you think.

Mon, Jan 10, 3:47 AM · Restricted Project
sammccall requested review of D116925: [clangd] Suppress warning about system_header pragma when editing headers.
Mon, Jan 10, 3:47 AM · Restricted Project
sammccall committed rG1ab13793beaf: [clangd] Include fixer for missing functions in C (authored by sammccall).
[clangd] Include fixer for missing functions in C
Mon, Jan 10, 3:17 AM
sammccall closed D115490: [clangd] Include fixer for missing functions in C.
Mon, Jan 10, 3:17 AM · Restricted Project, Restricted Project
sammccall added inline comments to D115490: [clangd] Include fixer for missing functions in C.
Mon, Jan 10, 3:17 AM · Restricted Project, Restricted Project
sammccall added a comment to D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover.

Agree that __ reserved names are ugly, but I'm not sure this is a great improvement.

I played around the patch locally, and found the new behavior being confused in some cases (mostly inconsistencies between deuglified places vs uglified places), and seems hard for readers to predict it:

Agree, but I don't think it needs to be predictable, it's enough that the output can be understood.
(e.g. I never particularly noticed *which* identifiers in stdlib were ugly, just that the thing overall was hard to read).
i.e. if we remove the underscores half the time, that seems like a win.

Mon, Jan 10, 3:10 AM · Restricted Project, Restricted Project
sammccall committed rG27ea0c4e7234: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse (authored by sammccall).
[Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse
Mon, Jan 10, 1:50 AM
sammccall committed rG16fd5c278488: [clangd] Support configuration of inlay hints. (authored by sammccall).
[clangd] Support configuration of inlay hints.
Mon, Jan 10, 1:50 AM
sammccall closed D116713: [clangd] Support configuration of inlay hints..
Mon, Jan 10, 1:49 AM · Restricted Project
sammccall closed D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse.
Mon, Jan 10, 1:49 AM · Restricted Project
sammccall accepted D116922: [AST] Use recovery-expr to preserve incomplete-type-member-access expression..
Mon, Jan 10, 1:40 AM · Restricted Project
sammccall accepted D116921: [clangd] Enable expand-auto for decltype(auto)..
Mon, Jan 10, 1:21 AM · Restricted Project
sammccall accepted D116919: [AST] Add RParen loc for decltype AutoTypeloc..
Mon, Jan 10, 1:21 AM · Restricted Project, Restricted Project