Page MenuHomePhabricator

ArcsinX (Aleksandr Platonov)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 13 2019, 11:28 AM (33 w, 5 d)

Recent Activity

Today

ArcsinX added reviewers for D85301: [clang-tidy] Fix crashes in bugprone-bad-signal-to-kill-thread check.: sammccall, kadircet, alexfh.
Wed, Aug 5, 6:45 AM · Restricted Project, Restricted Project
ArcsinX requested review of D85301: [clang-tidy] Fix crashes in bugprone-bad-signal-to-kill-thread check..
Wed, Aug 5, 6:43 AM · Restricted Project, Restricted Project

Yesterday

ArcsinX added reviewers for D85193: [clang] Do not use an invalid expression to update the initializer.: rsmith, aaron.ballman, riccibruno.
Tue, Aug 4, 4:51 AM · Restricted Project
ArcsinX requested review of D85193: [clang] Do not use an invalid expression to update the initializer..
Tue, Aug 4, 4:49 AM · Restricted Project

Thu, Jul 30

ArcsinX added a comment to D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream..

I think we should also cherry-pick this into release branch. I've filed https://bugs.llvm.org/show_bug.cgi?id=46905 for cherry-picking please update the bug
with the commit hash once you land the fix (or let me know if you don't have an account in bugzilla)

I do not have bugzilla account, so could you please do this for me?

Thu, Jul 30, 2:51 AM · Restricted Project
ArcsinX committed rG05b173466142: [clangd] findNearbyIdentifier(): fix the word search in the token stream. (authored by ArcsinX).
[clangd] findNearbyIdentifier(): fix the word search in the token stream.
Thu, Jul 30, 2:47 AM
ArcsinX closed D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream..
Thu, Jul 30, 2:47 AM · Restricted Project
ArcsinX added a comment to D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream..

oh and also, how did you notice the discrepancy? was it a random encounter while reading the code or did you notice a misbehaviour?

Thu, Jul 30, 2:38 AM · Restricted Project
ArcsinX added reviewers for D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.: sammccall, kadircet, nridge.
Thu, Jul 30, 12:43 AM · Restricted Project
ArcsinX requested review of D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream..
Thu, Jul 30, 12:41 AM · Restricted Project

Mon, Jul 27

ArcsinX committed rG90684d154516: [clangd] Collect references for externally visible main-file symbols (authored by ArcsinX).
[clangd] Collect references for externally visible main-file symbols
Mon, Jul 27, 5:36 AM
ArcsinX closed D84513: [clangd] Collect references for externally visible main-file symbols.
Mon, Jul 27, 5:36 AM · Restricted Project

Sun, Jul 26

ArcsinX added a comment to D84513: [clangd] Collect references for externally visible main-file symbols.

thanks, this looks good in general, but it would be nice to make sure we are not blowing the index memory and disk usage.

could you grab some numbers for these two before/after this patch?

Project: LLVM with clang and clang-tools-extra (~3700 records in compile_commands.json)

Sun, Jul 26, 3:49 AM · Restricted Project
ArcsinX updated the diff for D84513: [clangd] Collect references for externally visible main-file symbols.

Remove version bump

Sun, Jul 26, 3:41 AM · Restricted Project

Fri, Jul 24

ArcsinX added reviewers for D84513: [clangd] Collect references for externally visible main-file symbols: sammccall, kadircet.
Fri, Jul 24, 4:36 AM · Restricted Project
Herald added a project to D84513: [clangd] Collect references for externally visible main-file symbols: Restricted Project.
Fri, Jul 24, 4:35 AM · Restricted Project

Wed, Jul 22

ArcsinX committed rG98b56c09be00: [clangd] Fixes in lit tests (authored by ArcsinX).
[clangd] Fixes in lit tests
Wed, Jul 22, 6:01 AM
ArcsinX closed D83759: [clangd] Fixes in lit tests.
Wed, Jul 22, 6:01 AM · Restricted Project
ArcsinX added inline comments to D83759: [clangd] Fixes in lit tests.
Wed, Jul 22, 5:27 AM · Restricted Project
ArcsinX updated the diff for D83759: [clangd] Fixes in lit tests.

Get rid of -i sed option

Wed, Jul 22, 5:26 AM · Restricted Project
ArcsinX added inline comments to D83759: [clangd] Fixes in lit tests.
Wed, Jul 22, 4:37 AM · Restricted Project
ArcsinX updated the summary of D83759: [clangd] Fixes in lit tests.
Wed, Jul 22, 3:42 AM · Restricted Project
ArcsinX added a comment to D83759: [clangd] Fixes in lit tests.

I believe it's okay now on macOS.

Wed, Jul 22, 3:38 AM · Restricted Project
ArcsinX updated the diff for D83759: [clangd] Fixes in lit tests.

[macOS] Fix background-index.test failure, don't create *-e files during background-index.test

Wed, Jul 22, 3:35 AM · Restricted Project
ArcsinX reopened D83759: [clangd] Fixes in lit tests.
Wed, Jul 22, 3:25 AM · Restricted Project

Tue, Jul 21

ArcsinX added a comment to D83759: [clangd] Fixes in lit tests.

Seem the problem is in -i option.
According with OSX man:
sed [-Ealn] command [file ... ]
sed [-Ealn] [-e command] [-f command_file] [-i extension] [file ...].

Tue, Jul 21, 11:41 PM · Restricted Project
ArcsinX added a comment to D83759: [clangd] Fixes in lit tests.

Looks like this breaks tests on macOS (and probably with non-gnu greps): http://45.33.8.238/mac/17611/step_9.txt

Please take a look, and revert while you investigate if it takes a while to fix.

Tue, Jul 21, 1:40 PM · Restricted Project
ArcsinX committed rG23ff4e4f5d65: Revert "[clangd] Fixes in lit tests" (authored by ArcsinX).
Revert "[clangd] Fixes in lit tests"
Tue, Jul 21, 1:33 PM
ArcsinX added a reverting change for rGff63d6be93dc: [clangd] Fixes in lit tests: rG23ff4e4f5d65: Revert "[clangd] Fixes in lit tests".
Tue, Jul 21, 1:33 PM
ArcsinX committed rGff63d6be93dc: [clangd] Fixes in lit tests (authored by ArcsinX).
[clangd] Fixes in lit tests
Tue, Jul 21, 11:23 AM
ArcsinX closed D83759: [clangd] Fixes in lit tests.
Tue, Jul 21, 11:22 AM · Restricted Project
ArcsinX added a comment to D83759: [clangd] Fixes in lit tests.

as i mentioned please watch out for buildbot breakages after landing this. (and again let me know if I should land this for you)

Thanks for review.

Tue, Jul 21, 8:49 AM · Restricted Project
ArcsinX updated the summary of D83759: [clangd] Fixes in lit tests.
Tue, Jul 21, 4:40 AM · Restricted Project
ArcsinX updated the diff for D83759: [clangd] Fixes in lit tests.

Revert tests split; Replace '\' with '/' in background-index.test.

Tue, Jul 21, 4:37 AM · Restricted Project
ArcsinX added inline comments to D83759: [clangd] Fixes in lit tests.
Tue, Jul 21, 2:11 AM · Restricted Project

Mon, Jul 20

ArcsinX added a comment to D83759: [clangd] Fixes in lit tests.

What do you think of this patch? I'm not sure if Windows is important OS for developers, and that some of these changes might be awkward to maintain, but maybe we can enable background-index.test at least?

Mon, Jul 20, 11:45 PM · Restricted Project
ArcsinX abandoned D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor..
Mon, Jul 20, 5:59 AM · Restricted Project
ArcsinX added inline comments to D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.
Mon, Jul 20, 5:03 AM · Restricted Project
ArcsinX updated the diff for D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.

AdditionalFiles["header_in_preamble.h"] => HeaderCode

Mon, Jul 20, 4:26 AM · Restricted Project
ArcsinX added a comment to D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.

also please let me know if I should land this for you.

Yes, could you please land this for me? I do not have commit access.
Aleksandr Platonov <platonov.aleksandr@huawei.com>

Mon, Jul 20, 4:04 AM · Restricted Project
ArcsinX added inline comments to D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.
Mon, Jul 20, 4:00 AM · Restricted Project
ArcsinX updated the diff for D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.

Check source range for Parent

Mon, Jul 20, 3:58 AM · Restricted Project
ArcsinX added inline comments to D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.
Mon, Jul 20, 3:28 AM · Restricted Project
ArcsinX updated the diff for D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.

NameRange => DeclRange
Simplify TypeHierarchy.Preamble test.

Mon, Jul 20, 3:27 AM · Restricted Project
ArcsinX added reviewers for D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy: sammccall, kadircet.
Mon, Jul 20, 2:22 AM · Restricted Project
Herald added a project to D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy: Restricted Project.
Mon, Jul 20, 2:21 AM · Restricted Project
ArcsinX added a reverting change for D74850: [clangd] Migrate Lexer usages in TypeHierarchy to TokenBuffers: D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy.
Mon, Jul 20, 2:21 AM · Restricted Project

Fri, Jul 17

ArcsinX added a comment to D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor..

Tried this out in D84012/D84009. Works pretty well, and I think the API is a useful and natural addition to TokenBuffer.

For my test cases it works well, so I think this problem is fixed.
Should I abandon this revision?

Fri, Jul 17, 4:13 AM · Restricted Project
ArcsinX added a comment to D84009: [Syntax] expose API for expansions overlapping a spelled token range..

Thanks. This LGTM, but I think I don't have enough experience to accept revisions and could miss something important. So, may be @kadircet could accept it if its OK for him.

Fri, Jul 17, 4:07 AM · Restricted Project
ArcsinX added inline comments to D84009: [Syntax] expose API for expansions overlapping a spelled token range..
Fri, Jul 17, 3:45 AM · Restricted Project

Thu, Jul 16

ArcsinX added inline comments to D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor..
Thu, Jul 16, 2:02 PM · Restricted Project
ArcsinX updated the diff for D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor..

Prevent tokens selection in disabled preprocessor sections.

Thu, Jul 16, 5:20 AM · Restricted Project
ArcsinX added a comment to D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor..

Your test cases show two problems with this strategy:

  • we ignore comments and semicolons, but not preprocessor directives (or disabled preprocessor regions). I think we can fix this by asking TokenBuffer if a spelled token is part of a region that maps to no (PP-)expanded tokens.

I have tried this locally. seems it breaks SelectionTest.IncludedFile test.

Yeah that makes sense, I guess it just says nothing is selected in that case?

Yes, and test crashes at T.commonAncestor() (which is nullptr) dereference. So can we also add ASSERT_TRUE(T.commonAncestor()); into several tests?

Thu, Jul 16, 3:33 AM · Restricted Project
ArcsinX added a comment to D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor..

Your test cases show two problems with this strategy:

  • we ignore comments and semicolons, but not preprocessor directives (or disabled preprocessor regions). I think we can fix this by asking TokenBuffer if a spelled token is part of a region that maps to no (PP-)expanded tokens.

I have tried this locally. seems it breaks SelectionTest.IncludedFile test.

Thu, Jul 16, 2:28 AM · Restricted Project

Wed, Jul 15

ArcsinX added a comment to D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json.

As far as I do not have commit access, could you please commit for me?
Aleksandr Platonov <platonov.aleksandr@huawei.com>

Wed, Jul 15, 10:11 AM · Restricted Project
ArcsinX updated the summary of D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json.
Wed, Jul 15, 10:02 AM · Restricted Project
ArcsinX updated the diff for D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json.

Update comments.

Wed, Jul 15, 9:55 AM · Restricted Project
ArcsinX updated the diff for D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json.

Support only directory simlinks.

Wed, Jul 15, 6:11 AM · Restricted Project
ArcsinX added a comment to D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json.
  • don't scan for equivalences if the set of candidates exceeds some size threshold (10 or so)
  • don't scan for equivalences if the node we'd scan under is the root

After such fixes JSONCompilationDatabase::getCompileCommands() will return other results than before in some cases.

Can you elaborate on this - do you think there are reasonable cases where it will give the wrong answer?
I can certainly imagine cases where this changes behaviour, e.g. project/foo.cc is a symlink to project/bar.cc, compile_commands contains an entry for foo.cc, we query for bar.cc.
But I don't think this was ever really intended to handle arbitrary symlinks that change the names of files, and I do think this is OK to break.

If breaking project/foo.cc <=> project/bar.cc is OK, then could we also break some/path/here/foo.cc <=> some/other/path/bar.cc?

Wed, Jul 15, 1:17 AM · Restricted Project

Tue, Jul 14

ArcsinX added reviewers for D83759: [clangd] Fixes in lit tests: sammccall, kadircet.
Tue, Jul 14, 4:12 AM · Restricted Project
Herald added a project to D83759: [clangd] Fixes in lit tests: Restricted Project.
Tue, Jul 14, 4:10 AM · Restricted Project

Mon, Jul 13

ArcsinX added a comment to D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json.

IIRC the symlink checking was there because some part of the system on linux tends to give us realpaths (with CMake builds), and that leads to not finding anything if there are symlinks involved.

That was before InterpolatingCompilationDatabase introduction in https://reviews.llvm.org/D45006.
For my experience InterpolatingCompilationDatabase works pretty well for symlinks cases.

Mon, Jul 13, 2:16 AM · Restricted Project
ArcsinX added a comment to D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json.

Wow, yeah, this seems pretty bad! I'm not very familiar with this code. I'm curious, for "it tooks more than 1 second" - what OS is this on?

Windows.
I faced this problem on a huge project and it takes 7 seconds for MatchTrie.findEquivalent() to return.

Mon, Jul 13, 2:08 AM · Restricted Project

Sat, Jul 11

ArcsinX added a comment to D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json.

Also I think that FileMatchTrie introduced in https://reviews.llvm.org/D30 is not efficient solution to fight with symlinks and for most cases InterpolatingCompilationDatabase will be accurate enough. But I am not sure, is it safe to completely remove FileMatchTrie? What do you think?

Sat, Jul 11, 6:22 AM · Restricted Project
ArcsinX added reviewers for D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json: sammccall, kadircet, hokein.
Sat, Jul 11, 6:07 AM · Restricted Project
Herald added a project to D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json: Restricted Project.
Sat, Jul 11, 6:05 AM · Restricted Project

Fri, Jul 10

ArcsinX added a comment to D83548: [clangd] Fix tests build for GCC5.

As far as I do not have commit access, could you please commit for me?
Aleksandr Platonov <platonov.aleksandr@huawei.com>

Fri, Jul 10, 9:02 AM · Restricted Project
ArcsinX added reviewers for D83548: [clangd] Fix tests build for GCC5: kadircet, sammccall.
Fri, Jul 10, 5:53 AM · Restricted Project
Herald added a project to D83548: [clangd] Fix tests build for GCC5: Restricted Project.
Fri, Jul 10, 5:51 AM · Restricted Project
ArcsinX added a comment to D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor..

@kadircet Thanks for your reply.

Fri, Jul 10, 2:22 AM · Restricted Project

Thu, Jul 9

ArcsinX added a reviewer for D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.: sammccall.
Thu, Jul 9, 2:28 PM · Restricted Project
Herald added a project to D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.: Restricted Project.
Thu, Jul 9, 2:22 PM · Restricted Project

Wed, Jul 8

ArcsinX added a comment to D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.

Do you want me to commit it for you?

Yes, thank you.

Wed, Jul 8, 8:39 AM · Restricted Project
ArcsinX added a comment to D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.

Ping

Wed, Jul 8, 12:20 AM · Restricted Project

Jul 1 2020

ArcsinX added inline comments to D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.
Jul 1 2020, 7:00 AM · Restricted Project
ArcsinX updated the diff for D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.

Try conversion function only in C++.

Jul 1 2020, 7:00 AM · Restricted Project

Jun 30 2020

ArcsinX added inline comments to D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.
Jun 30 2020, 8:06 AM · Restricted Project

Jun 29 2020

ArcsinX updated the diff for D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.
Jun 29 2020, 11:04 PM · Restricted Project
ArcsinX added inline comments to D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.
Jun 29 2020, 3:18 PM · Restricted Project
ArcsinX updated the diff for D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.

Fix format

Jun 29 2020, 2:58 PM · Restricted Project
ArcsinX created D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.
Jun 29 2020, 2:12 PM · Restricted Project
ArcsinX updated the summary of D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter.
Jun 29 2020, 2:12 PM · Restricted Project