This is an archive of the discontinued LLVM Phabricator instance.

[ms] [llvm-ml] Add MASM hex float support
ClosedPublic

Authored by epastor on Sep 9 2020, 11:09 AM.

Details

Summary

Implement MASM's syntax for specifying floats in raw hexadecimal bytes.

Diff Detail

Event Timeline

epastor created this revision.Sep 9 2020, 11:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2020, 11:09 AM
epastor requested review of this revision.Sep 9 2020, 11:09 AM
thakis accepted this revision.Sep 14 2020, 10:25 AM
thakis added inline comments.
llvm/lib/MC/MCParser/MasmParser.cpp
3455

Should we at least warn about an explicit sign with a hexfloat?

This revision is now accepted and ready to land.Sep 14 2020, 10:25 AM
epastor updated this revision to Diff 291639.Sep 14 2020, 12:08 PM

Warn on explicit sign preceding MASM-style hex float (which is ignored for compatibility)

epastor added inline comments.Sep 14 2020, 12:12 PM
llvm/lib/MC/MCParser/MasmParser.cpp
3455

Warning sounds like a good idea. Added.

epastor updated this revision to Diff 294412.Sep 25 2020, 1:17 PM

Rebase on relanded parent

epastor updated this revision to Diff 295097.Sep 29 2020, 1:15 PM

Rebase on parent

This revision was automatically updated to reflect the committed changes.