Page MenuHomePhabricator

epastor (Eric Astor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 14 2019, 3:23 PM (105 w, 5 d)

Recent Activity

Sun, Jun 13

epastor committed rGf09e200b31f4: [ms] [llvm-ml] When parsing MASM, "jmp short" instructions are case insensitive (authored by epastor).
[ms] [llvm-ml] When parsing MASM, "jmp short" instructions are case insensitive
Sun, Jun 13, 3:37 PM
epastor committed rGd81c059c3ed2: [ms] [llvm-ml] Fix capitalization of the ignored CPU directives (authored by epastor).
[ms] [llvm-ml] Fix capitalization of the ignored CPU directives
Sun, Jun 13, 3:37 PM
epastor closed D104195: [ms] [llvm-ml] When parsing MASM, "jmp short" instructions are case insensitive.
Sun, Jun 13, 3:37 PM · Restricted Project
epastor closed D104206: [ms] [llvm-ml] Fix capitalization of the ignored CPU directives.
Sun, Jun 13, 3:37 PM · Restricted Project
epastor committed rG56edcbc2ad8c: Fix misspelled instruction in X86 assembly parser (authored by epastor).
Fix misspelled instruction in X86 assembly parser
Sun, Jun 13, 3:35 PM
epastor closed D104194: Fix misspelled instruction in X86 assembly parser.
Sun, Jun 13, 3:34 PM · Restricted Project
epastor requested review of D104206: [ms] [llvm-ml] Fix capitalization of the ignored CPU directives.
Sun, Jun 13, 3:31 PM · Restricted Project
epastor added a comment to D104194: Fix misspelled instruction in X86 assembly parser.

More concretely, branch instruction tests in llvm/test/MC/X86/x86-32.s can be moved outside, then you can add a test for jecxz. jexcz seems untested.

Sun, Jun 13, 3:20 PM · Restricted Project
epastor updated the diff for D104194: Fix misspelled instruction in X86 assembly parser.

Add test case

Sun, Jun 13, 3:19 PM · Restricted Project
epastor requested review of D104196: [ms] [llvm-ml] Standardize blocking of lexical substitution.
Sun, Jun 13, 8:19 AM · Restricted Project
epastor requested review of D104195: [ms] [llvm-ml] When parsing MASM, "jmp short" instructions are case insensitive.
Sun, Jun 13, 8:13 AM · Restricted Project
epastor requested review of D104194: Fix misspelled instruction in X86 assembly parser.
Sun, Jun 13, 8:05 AM · Restricted Project

Thu, Jun 10

epastor committed rGf03a3caac5e5: [ms] [llvm-ml] Warn on command-line redefinition (authored by epastor).
[ms] [llvm-ml] Warn on command-line redefinition
Thu, Jun 10, 11:21 AM
epastor closed D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Thu, Jun 10, 11:20 AM · Restricted Project
epastor updated the diff for D104008: [ms] [llvm-ml] Warn on command-line redefinition.

Dropping unnecessary implicit-check-not guard

Thu, Jun 10, 10:27 AM · Restricted Project
epastor added inline comments to D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Thu, Jun 10, 6:15 AM · Restricted Project
epastor updated the diff for D104008: [ms] [llvm-ml] Warn on command-line redefinition.

Directly check for the warning, rather than converting it to an error

Thu, Jun 10, 6:14 AM · Restricted Project
epastor committed rG00ebbedd1c92: [ms] [llvm-ml] Make variable redefinition match ML.EXE (authored by epastor).
[ms] [llvm-ml] Make variable redefinition match ML.EXE
Thu, Jun 10, 5:36 AM
epastor closed D103993: [ms] [llvm-ml] Make variable redefinition match ML.EXE.
Thu, Jun 10, 5:36 AM · Restricted Project
epastor added inline comments to D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Thu, Jun 10, 5:34 AM · Restricted Project
epastor added reviewers for D104008: [ms] [llvm-ml] Warn on command-line redefinition: thakis, rnk.
Thu, Jun 10, 5:32 AM · Restricted Project

Wed, Jun 9

epastor requested review of D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Wed, Jun 9, 9:57 PM · Restricted Project
epastor abandoned D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition.

This required a few too many changes; I'll re-upload a working variant on top of a prerequisite (D103993).

Wed, Jun 9, 9:33 PM · Restricted Project
epastor requested review of D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.
Wed, Jun 9, 9:20 PM · Restricted Project
epastor updated the diff for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Fix handling of the second (and later) field after an ORG directive

Wed, Jun 9, 9:19 PM · Restricted Project
epastor added a comment to D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

While I was working on the comments above, I discovered a problem - after improving the tests and fixing various errors, the way we were dealing with determining field offsets caused a failure on the second field after an ORG offset change. I've been working on and off to adjust the code to handle this; it requires a nontrivial rework, as Structure has to track both its Size and the offset of the next field. I'll upload that revision shortly, and I'm afraid it will require a re-review. Sorry, thakis - and I'll try to find someone else if more appropriate.

Wed, Jun 9, 9:16 PM · Restricted Project
epastor added a comment to D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Does it wrap around 32-bit in 64-bit output too?

Oddly enough: yes.

Is this relied on? Or could we error out on negative values instead?

I don't think we can prove that it isn't relied on, especially when ORG explicitly allows putting things "outside bounds", so I'd rather maintain compatibility.

Well, we don't need to prove it if we make it an error: We'll know if the diag fires. So if we make this an error first and then build lots of files with it, we'll learn if we run into it. At that point we'll know we need to make it compatible, but maybe we won't have to. Doesn't it seem better to default to less surprising behavior and only put in the compat warts once there's evidence that we need them?

Wed, Jun 9, 9:12 PM · Restricted Project
epastor added reviewers for D103993: [ms] [llvm-ml] Make variable redefinition match ML.EXE: thakis, rnk, mstorsjo.
Wed, Jun 9, 3:53 PM · Restricted Project
epastor requested review of D103993: [ms] [llvm-ml] Make variable redefinition match ML.EXE.
Wed, Jun 9, 3:52 PM · Restricted Project
epastor committed rG4b5317e937ac: [ms] [llvm-ml] Add support for INCLUDE environment variable (authored by epastor).
[ms] [llvm-ml] Add support for INCLUDE environment variable
Wed, Jun 9, 2:55 PM
epastor closed D103989: [ms] [llvm-ml] Add support for INCLUDE environment variable.
Wed, Jun 9, 2:54 PM · Restricted Project
epastor updated the diff for D103989: [ms] [llvm-ml] Add support for INCLUDE environment variable.

Fix lint

Wed, Jun 9, 2:08 PM · Restricted Project
epastor requested review of D103989: [ms] [llvm-ml] Add support for INCLUDE environment variable.
Wed, Jun 9, 1:05 PM · Restricted Project
epastor added a reverting change for rGc43f413b01b0: [ms] [llvm-ml] Add support for INCLUDE environment variable: rG68d0db0b6d56: Revert "[ms] [llvm-ml] Add support for INCLUDE environment variable".
Wed, Jun 9, 12:50 PM
epastor committed rG68d0db0b6d56: Revert "[ms] [llvm-ml] Add support for INCLUDE environment variable" (authored by epastor).
Revert "[ms] [llvm-ml] Add support for INCLUDE environment variable"
Wed, Jun 9, 12:50 PM
epastor committed rGc43f413b01b0: [ms] [llvm-ml] Add support for INCLUDE environment variable (authored by epastor).
[ms] [llvm-ml] Add support for INCLUDE environment variable
Wed, Jun 9, 12:26 PM
epastor committed rGc8d6e67d53a0: [ms] [llvm-ml] Fix parity errors in error handling for INCLUDE directive (authored by epastor).
[ms] [llvm-ml] Fix parity errors in error handling for INCLUDE directive
Wed, Jun 9, 10:35 AM
epastor closed D103980: [ms] [llvm-ml] Fix parity errors in error handling for INCLUDE directive.
Wed, Jun 9, 10:34 AM · Restricted Project
epastor requested review of D103980: [ms] [llvm-ml] Fix parity errors in error handling for INCLUDE directive.
Wed, Jun 9, 10:34 AM · Restricted Project

Tue, Jun 8

epastor committed rGdc0c3fe5f35e: [ms] [llvm-ml] Disambiguate size directives and variable declarations (authored by epastor).
[ms] [llvm-ml] Disambiguate size directives and variable declarations
Tue, Jun 8, 12:47 PM
epastor closed D103257: [ms] [llvm-ml] Disambiguate size directives and variable declarations.
Tue, Jun 8, 12:46 PM · Restricted Project
epastor requested changes to D102297: [X86] Modify LOOP*, HLT control flow attributes, add TAILJMP encoding.

Marking as Request Changes to get it off of my dashboard until the other comments get a response.

Tue, Jun 8, 11:21 AM · Restricted Project
epastor updated the diff for D103257: [ms] [llvm-ml] Disambiguate size directives and variable declarations.

Add test (confirmed to fail before this patch)

Tue, Jun 8, 10:51 AM · Restricted Project

Sat, Jun 5

epastor updated the diff for D103257: [ms] [llvm-ml] Disambiguate size directives and variable declarations.

Updating use of peekTok to account for macros & included files

Sat, Jun 5, 1:15 PM · Restricted Project
epastor updated the summary of D103257: [ms] [llvm-ml] Disambiguate size directives and variable declarations.
Sat, Jun 5, 12:42 PM · Restricted Project

Thu, May 27

epastor updated the diff for D103257: [ms] [llvm-ml] Disambiguate size directives and variable declarations.

Fix a copy/paste error

Thu, May 27, 8:12 AM · Restricted Project
epastor requested review of D103257: [ms] [llvm-ml] Disambiguate size directives and variable declarations.
Thu, May 27, 8:02 AM · Restricted Project

May 11 2021

epastor added inline comments to D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.
May 11 2021, 12:57 PM · Restricted Project

Apr 22 2021

epastor added inline comments to D100959: [AsmParser][SystemZ][z/OS] Use updated framework in AsmLexer to accept special tokens as Identifiers.
Apr 22 2021, 5:57 AM · Restricted Project

Apr 20 2021

epastor added inline comments to D100755: [llvm-rc] [3/4] Run clang to preprocess input files.
Apr 20 2021, 12:18 PM · Restricted Project, Restricted Project

Apr 19 2021

epastor added inline comments to D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
Apr 19 2021, 11:30 AM · Restricted Project

Apr 16 2021

epastor added a comment to D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition.

(this didn't have me as a reviewer, so I only saw it by coincidence)

We should also add the /WX switch :)

Apr 16 2021, 1:41 PM · Restricted Project

Apr 5 2021

epastor accepted D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
Apr 5 2021, 9:03 AM · Restricted Project
epastor added inline comments to D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
Apr 5 2021, 8:58 AM · Restricted Project

Apr 2 2021

epastor committed rG0499a9d68890: [ms] [llvm-ml] Accept /WX to signal that warnings should be fatal. (authored by epastor).
[ms] [llvm-ml] Accept /WX to signal that warnings should be fatal.
Apr 2 2021, 12:13 PM
epastor closed D92504: [ms] [llvm-ml] Accept /WX to signal that warnings should be fatal..
Apr 2 2021, 12:13 PM · Restricted Project
epastor updated the diff for D92504: [ms] [llvm-ml] Accept /WX to signal that warnings should be fatal..

Rebase to HEAD

Apr 2 2021, 11:10 AM · Restricted Project
epastor committed rG15ec0ad77ae3: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros (authored by epastor).
[ms] [llvm-ml] Fix case-sensitivity for variables and textmacros
Apr 2 2021, 11:08 AM
epastor closed D92503: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros.
Apr 2 2021, 11:08 AM · Restricted Project
epastor updated the diff for D92503: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros.

Rebase to HEAD

Apr 2 2021, 10:02 AM · Restricted Project
epastor accepted D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Apr 2 2021, 7:49 AM · Restricted Project
epastor added a comment to D98519: [M68k] Add support for Motorola literal syntax to AsmParser.

Can you add tests for this?

Apr 2 2021, 6:20 AM · Restricted Project

Apr 1 2021

epastor requested changes to D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers.
Apr 1 2021, 2:56 PM · Restricted Project

Mar 17 2021

epastor updated the diff for D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition.

Rebase on parent

Mar 17 2021, 11:21 AM · Restricted Project
epastor retitled D92504: [ms] [llvm-ml] Accept /WX to signal that warnings should be fatal. from [ms] [llvm-ml] When warnings are fatal, make sure to fail on warnings to [ms] [llvm-ml] Accept /WX to signal that warnings should be fatal..
Mar 17 2021, 11:12 AM · Restricted Project
epastor updated the diff for D92504: [ms] [llvm-ml] Accept /WX to signal that warnings should be fatal..

Revised to include fatal warning support, and test both cases

Mar 17 2021, 11:11 AM · Restricted Project
epastor updated the summary of D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.
Mar 17 2021, 10:31 AM · Restricted Project
epastor updated the diff for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Restore the explicit cast to make it easier to switch to a Warning later

Mar 17 2021, 10:29 AM · Restricted Project
epastor updated the diff for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Emit an error on negative ORG offsets, per feedback.

Mar 17 2021, 10:27 AM · Restricted Project
epastor committed rG1236dbc2fadf: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null (authored by epastor).
[ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null
Mar 17 2021, 9:19 AM
epastor closed D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.
Mar 17 2021, 9:19 AM · Restricted Project

Mar 15 2021

epastor updated the diff for D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition.

Rebase on parent

Mar 15 2021, 2:15 PM · Restricted Project
epastor updated the diff for D92504: [ms] [llvm-ml] Accept /WX to signal that warnings should be fatal..

Rebase on parent

Mar 15 2021, 2:15 PM · Restricted Project
epastor updated the diff for D92503: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros.

Rebase on HEAD

Mar 15 2021, 2:14 PM · Restricted Project
epastor added inline comments to D92503: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros.
Mar 15 2021, 2:12 PM · Restricted Project
epastor updated the diff for D92503: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros.

Improve comments to clarify the change

Mar 15 2021, 2:12 PM · Restricted Project
epastor updated the summary of D92503: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros.
Mar 15 2021, 2:08 PM · Restricted Project

Dec 15 2020

epastor added a comment to D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

CC'ing @epastor as a FYI for the assembly parser bug.

Dec 15 2020, 6:47 AM · Restricted Project

Dec 10 2020

epastor added a comment to D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Still no test, as far as I can tell. I think the suggestion below turns this into a 3-line diff (+ test).

Dec 10 2020, 7:38 AM · Restricted Project
epastor updated the diff for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Rebase on parent

Dec 10 2020, 7:37 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Fix errors in Alias/AliasArgs use, and add tests

Dec 10 2020, 7:37 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Use AliasArgs to simplify

Dec 10 2020, 7:17 AM · Restricted Project
epastor requested review of D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.
Dec 10 2020, 7:07 AM · Restricted Project
epastor added a comment to D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Does it wrap around 32-bit in 64-bit output too?

Dec 10 2020, 7:07 AM · Restricted Project

Dec 2 2020

epastor added reviewers for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives: thakis, rnk.
Dec 2 2020, 1:22 PM · Restricted Project
epastor requested review of D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.
Dec 2 2020, 1:21 PM · Restricted Project
epastor added a comment to D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition.

The test here doesn't currently warn - because test5 is already defined, and as such the line under t5: is lexed as:

def textequ <redef>
Dec 2 2020, 1:09 PM · Restricted Project
epastor requested review of D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition.
Dec 2 2020, 1:07 PM · Restricted Project
epastor added reviewers for D92504: [ms] [llvm-ml] Accept /WX to signal that warnings should be fatal.: thakis, rnk.
Dec 2 2020, 1:05 PM · Restricted Project
epastor requested review of D92504: [ms] [llvm-ml] Accept /WX to signal that warnings should be fatal..
Dec 2 2020, 1:04 PM · Restricted Project
epastor requested review of D92503: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros.
Dec 2 2020, 1:03 PM · Restricted Project

Dec 1 2020

epastor added a reviewer for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null: rnk.
Dec 1 2020, 3:06 PM · Restricted Project
epastor committed rGc64037b784ae: [ms] [llvm-ml] Support command-line defines (authored by epastor).
[ms] [llvm-ml] Support command-line defines
Dec 1 2020, 3:06 PM
epastor closed D90059: [ms] [llvm-ml] Support command-line defines.
Dec 1 2020, 3:06 PM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Dec 1 2020, 2:48 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on HEAD

Dec 1 2020, 2:48 PM · Restricted Project
epastor committed rG8fee2ee9a689: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe (authored by epastor).
[ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe
Dec 1 2020, 2:44 PM
epastor closed D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.
Dec 1 2020, 2:43 PM · Restricted Project
epastor added a comment to D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

(Just to be sure: This is ready to go and not waiting on me, right?)

Dec 1 2020, 12:26 PM · Restricted Project

Nov 30 2020

epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Update for new test files

Nov 30 2020, 1:35 PM · Restricted Project