Page MenuHomePhabricator

epastor (Eric Astor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 14 2019, 3:23 PM (75 w, 6 d)

Recent Activity

Wed, Nov 25

epastor committed rG35828b84a523: [ms] [llvm-ml] Implement the expression expansion operator (authored by epastor).
[ms] [llvm-ml] Implement the expression expansion operator
Wed, Nov 25, 1:11 PM
epastor closed D89736: [ms] [llvm-ml] Implement the expression expansion operator.
Wed, Nov 25, 1:11 PM · Restricted Project
epastor added a comment to D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Looks like there's no coverage for expanding statements that aren't the echo special case - - could you add coverage for that too? Other than that, lg!

Wed, Nov 25, 12:36 PM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Wed, Nov 25, 12:35 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Wed, Nov 25, 12:35 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Rebase on parent

Wed, Nov 25, 12:35 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Rebase on parent

Wed, Nov 25, 12:35 PM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Rebase on parent

Wed, Nov 25, 12:34 PM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Add a test case covering the lack of impact on typical statements

Wed, Nov 25, 12:29 PM · Restricted Project

Mon, Nov 23

epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Mon, Nov 23, 1:32 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Mon, Nov 23, 1:32 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Disable IgnoreCase; ml.exe and ml64.exe use case-sensitive flags

Mon, Nov 23, 1:32 PM · Restricted Project
epastor added inline comments to D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.
Mon, Nov 23, 12:22 PM · Restricted Project
epastor added inline comments to D90059: [ms] [llvm-ml] Support command-line defines.
Mon, Nov 23, 12:20 PM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Mon, Nov 23, 12:19 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Mon, Nov 23, 12:19 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Accept /c as a flag without warning; it's our current default behavior anyway

Mon, Nov 23, 12:14 PM · Restricted Project
epastor abandoned D90060: [ms] [llvm-ml] Add more documentation to unsupported options.
Mon, Nov 23, 12:10 PM · Restricted Project
epastor added a comment to D90060: [ms] [llvm-ml] Add more documentation to unsupported options.

I'd argue that we shouldn't have help texts for flags we don't support.

Mon, Nov 23, 12:10 PM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Mon, Nov 23, 12:10 PM · Restricted Project
epastor updated the diff for D90060: [ms] [llvm-ml] Add more documentation to unsupported options.

Rebase on parent

Mon, Nov 23, 12:09 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Mon, Nov 23, 12:09 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Rebase on parent

Mon, Nov 23, 12:09 PM · Restricted Project
epastor updated the diff for D89741: [ms] [llvm-ml] Allow macro function invocations in arbitrary positions.

Rebase on parent

Mon, Nov 23, 12:09 PM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Rebase on parent

Mon, Nov 23, 12:09 PM · Restricted Project
epastor added inline comments to D89736: [ms] [llvm-ml] Implement the expression expansion operator.
Mon, Nov 23, 12:08 PM · Restricted Project
epastor updated the diff for D89736: [ms] [llvm-ml] Implement the expression expansion operator.

Remove "return/else" branches to match LLVM style

Mon, Nov 23, 12:07 PM · Restricted Project
epastor committed rG1e41e22323a3: [ms] [llvm-ml] Support purging macro definitions (authored by epastor).
[ms] [llvm-ml] Support purging macro definitions
Mon, Nov 23, 12:03 PM
epastor closed D89735: [ms] [llvm-ml] Support purging macro definitions.
Mon, Nov 23, 12:03 PM · Restricted Project
epastor updated the diff for D89736: [ms] [llvm-ml] Implement the expression expansion operator.

Rebase on parent (pushed a change further up the stack)

Mon, Nov 23, 11:20 AM · Restricted Project
epastor updated the diff for D89735: [ms] [llvm-ml] Support purging macro definitions.

Rebase to HEAD

Mon, Nov 23, 11:19 AM · Restricted Project
epastor committed rG454f32e4d572: [ms] [llvm-ml] Support macro function invocations in expressions (authored by epastor).
[ms] [llvm-ml] Support macro function invocations in expressions
Mon, Nov 23, 11:17 AM
epastor closed D89734: [ms] [llvm-ml] Support macro function invocations in expressions.
Mon, Nov 23, 11:17 AM · Restricted Project

Tue, Nov 17

epastor added a comment to D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref.

LGTM for llvm-ml.

Tue, Nov 17, 7:43 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 13

epastor updated the diff for D89734: [ms] [llvm-ml] Support macro function invocations in expressions.

Fix an off-by-one error in the recently-added assert.

Fri, Nov 13, 2:08 PM · Restricted Project
epastor added a comment to D89734: [ms] [llvm-ml] Support macro function invocations in expressions.

Can we also add a test where EndStatementAtEOFStack isn't empty at end-of-file?

Fri, Nov 13, 11:07 AM · Restricted Project
epastor updated the diff for D89734: [ms] [llvm-ml] Support macro function invocations in expressions.

Add assert() that EndStatementAtEOFStack ends up empty.

Fri, Nov 13, 11:06 AM · Restricted Project

Mon, Nov 9

epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Add ifdef testing, and fix a minor StringRef vs. std::string issue.

Mon, Nov 9, 1:32 PM · Restricted Project
epastor committed rGd657f7cd30ed: [ms] [llvm-ml] Support MASM's relational operators (EQ, LT, etc.) (authored by epastor).
[ms] [llvm-ml] Support MASM's relational operators (EQ, LT, etc.)
Mon, Nov 9, 11:02 AM
epastor closed D89733: [ms] [llvm-ml] Support MASM's relational operators (EQ, LT, etc.).
Mon, Nov 9, 11:01 AM · Restricted Project
epastor committed rG3a71f5519423: [ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives (authored by epastor).
[ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives
Mon, Nov 9, 10:21 AM
epastor closed D89732: [ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives.
Mon, Nov 9, 10:21 AM · Restricted Project

Fri, Nov 6

epastor committed rG5afb36080809: [ms] [llvm-ml] Allow arbitrary strings as integer constants (authored by epastor).
[ms] [llvm-ml] Allow arbitrary strings as integer constants
Fri, Nov 6, 2:16 PM
epastor closed D90788: [ms] [llvm-ml] Allow arbitrary strings as integer constants.
Fri, Nov 6, 2:16 PM · Restricted Project

Thu, Nov 5

epastor added a comment to D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Nice!

Do tests still run after the test file renaming to .asm? llvm/test/lit.cfg.py has config.suffixes = ['.ll', '.c', '.test', '.txt', '.s', '.mir', '.yaml'] which includes .test but not .asm. I would expect that you need to edit llvm/test/tools/llvm-ml/lit.local.cfg to have config.suffixes.add('.asm,') for the tests to keep running.

Thu, Nov 5, 11:25 AM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Fix lit.local.cfg (add vs. append)

Thu, Nov 5, 11:22 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Thu, Nov 5, 10:44 AM · Restricted Project
epastor updated the diff for D90060: [ms] [llvm-ml] Add more documentation to unsupported options.

Rebase on parent

Thu, Nov 5, 10:44 AM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Thu, Nov 5, 10:44 AM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

After rebasing on parent, fix new test files for invocation style

Thu, Nov 5, 10:43 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on HEAD

Thu, Nov 5, 10:33 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on HEAD

Thu, Nov 5, 10:33 AM · Restricted Project
epastor updated the diff for D90060: [ms] [llvm-ml] Add more documentation to unsupported options.

Rebase on HEAD

Thu, Nov 5, 10:33 AM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on HEAD

Thu, Nov 5, 10:33 AM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Rebase on HEAD

Thu, Nov 5, 10:33 AM · Restricted Project
epastor updated the diff for D89741: [ms] [llvm-ml] Allow macro function invocations in arbitrary positions.

Rebase on HEAD

Thu, Nov 5, 10:33 AM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Rebase on HEAD

Thu, Nov 5, 10:33 AM · Restricted Project
epastor updated the diff for D89736: [ms] [llvm-ml] Implement the expression expansion operator.

Rebase on HEAD

Thu, Nov 5, 10:33 AM · Restricted Project
epastor updated the diff for D89735: [ms] [llvm-ml] Support purging macro definitions.

Rebase on HEAD

Thu, Nov 5, 10:32 AM · Restricted Project
epastor updated the diff for D89734: [ms] [llvm-ml] Support macro function invocations in expressions.

Rebase on HEAD

Thu, Nov 5, 10:32 AM · Restricted Project
epastor updated the diff for D89733: [ms] [llvm-ml] Support MASM's relational operators (EQ, LT, etc.).

Rebase on HEAD

Thu, Nov 5, 10:32 AM · Restricted Project
epastor updated the diff for D89732: [ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives.

Rebase to HEAD

Thu, Nov 5, 10:32 AM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Fix prefixes for LLVM-specific options, and add the .asm tests to the lit config

Thu, Nov 5, 10:28 AM · Restricted Project

Wed, Nov 4

epastor requested review of D90788: [ms] [llvm-ml] Allow arbitrary strings as integer constants.
Wed, Nov 4, 12:56 PM · Restricted Project
epastor committed rGe6cd3eff17fd: Fix -Wsign-compare issue in MasmParser.cpp (authored by epastor).
Fix -Wsign-compare issue in MasmParser.cpp
Wed, Nov 4, 12:44 PM
epastor committed rG07c4f1d10b30: [ms] [llvm-ml] Lex MASM strings, including escaping (authored by epastor).
[ms] [llvm-ml] Lex MASM strings, including escaping
Wed, Nov 4, 12:30 PM
epastor closed D89731: [ms] [llvm-ml] Lex MASM strings, including escaping.
Wed, Nov 4, 12:29 PM · Restricted Project
epastor added inline comments to D89731: [ms] [llvm-ml] Lex MASM strings, including escaping.
Wed, Nov 4, 12:25 PM · Restricted Project
epastor added inline comments to D89735: [ms] [llvm-ml] Support purging macro definitions.
Wed, Nov 4, 8:14 AM · Restricted Project
epastor updated the diff for D89735: [ms] [llvm-ml] Support purging macro definitions.

Add testing for list invocation of PURGE

Wed, Nov 4, 8:13 AM · Restricted Project
epastor committed rGbf027da04c41: [ms] [llvm-ml] Enable support for MASM-style macro procedures (authored by epastor).
[ms] [llvm-ml] Enable support for MASM-style macro procedures
Wed, Nov 4, 7:30 AM
epastor closed D89729: [ms] [llvm-ml] Enable support for MASM-style macro procedures.
Wed, Nov 4, 7:30 AM · Restricted Project
epastor added inline comments to D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM.
Wed, Nov 4, 5:38 AM · Restricted Project, Restricted Project

Tue, Nov 3

epastor added a comment to D89731: [ms] [llvm-ml] Lex MASM strings, including escaping.

Tests added; thank you!

Tue, Nov 3, 2:27 PM · Restricted Project
epastor updated the diff for D89731: [ms] [llvm-ml] Lex MASM strings, including escaping.

Add tests for quote characters in expressions, with and without escaping

Tue, Nov 3, 12:36 PM · Restricted Project
epastor updated the diff for D89731: [ms] [llvm-ml] Lex MASM strings, including escaping.

Add test for handling of single characters in expressions (even in double-quotes)

Tue, Nov 3, 12:26 PM · Restricted Project
epastor updated the diff for D89731: [ms] [llvm-ml] Lex MASM strings, including escaping.

Reduce diff, and add specific tests of new functionality

Tue, Nov 3, 12:23 PM · Restricted Project
epastor updated the diff for D89729: [ms] [llvm-ml] Enable support for MASM-style macro procedures.

Adding tests for the error cases

Tue, Nov 3, 8:06 AM · Restricted Project
epastor added inline comments to D89729: [ms] [llvm-ml] Enable support for MASM-style macro procedures.
Tue, Nov 3, 7:44 AM · Restricted Project
epastor updated the diff for D89729: [ms] [llvm-ml] Enable support for MASM-style macro procedures.

Addressing feedback

Tue, Nov 3, 7:43 AM · Restricted Project

Fri, Oct 30

epastor added inline comments to D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM.
Fri, Oct 30, 5:57 AM · Restricted Project, Restricted Project

Oct 23 2020

epastor requested review of D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.
Oct 23 2020, 10:52 AM · Restricted Project
epastor requested review of D90060: [ms] [llvm-ml] Add more documentation to unsupported options.
Oct 23 2020, 10:50 AM · Restricted Project
epastor requested review of D90059: [ms] [llvm-ml] Support command-line defines.
Oct 23 2020, 10:49 AM · Restricted Project
epastor requested review of D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.
Oct 23 2020, 10:48 AM · Restricted Project

Oct 21 2020

epastor added reviewers for D89741: [ms] [llvm-ml] Allow macro function invocations in arbitrary positions: rnk, thakis.
Oct 21 2020, 7:14 AM · Restricted Project
epastor added reviewers for D89740: [ms] [llvm-ml] Implement the statement expansion operator: thakis, rnk.
Oct 21 2020, 7:13 AM · Restricted Project
epastor added reviewers for D89736: [ms] [llvm-ml] Implement the expression expansion operator: thakis, rnk.
Oct 21 2020, 7:13 AM · Restricted Project
epastor added reviewers for D89735: [ms] [llvm-ml] Support purging macro definitions: rnk, thakis.
Oct 21 2020, 7:12 AM · Restricted Project
epastor added reviewers for D89734: [ms] [llvm-ml] Support macro function invocations in expressions: rnk, thakis.
Oct 21 2020, 7:12 AM · Restricted Project
epastor updated the diff for D89734: [ms] [llvm-ml] Support macro function invocations in expressions.

Fix case of parameter

Oct 21 2020, 7:12 AM · Restricted Project
epastor added reviewers for D89733: [ms] [llvm-ml] Support MASM's relational operators (EQ, LT, etc.): rnk, thakis.
Oct 21 2020, 7:09 AM · Restricted Project
epastor added reviewers for D89732: [ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives: rnk, thakis.
Oct 21 2020, 7:09 AM · Restricted Project
epastor updated the diff for D89732: [ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives.

Fix case of local variable

Oct 21 2020, 7:08 AM · Restricted Project
epastor added reviewers for D89731: [ms] [llvm-ml] Lex MASM strings, including escaping: rnk, thakis.
Oct 21 2020, 7:06 AM · Restricted Project
epastor added reviewers for D89729: [ms] [llvm-ml] Enable support for MASM-style macro procedures: rnk, thakis.
Oct 21 2020, 7:04 AM · Restricted Project

Oct 19 2020

epastor requested review of D89741: [ms] [llvm-ml] Allow macro function invocations in arbitrary positions.
Oct 19 2020, 2:17 PM · Restricted Project
epastor requested review of D89740: [ms] [llvm-ml] Implement the statement expansion operator.
Oct 19 2020, 2:15 PM · Restricted Project
epastor updated the diff for D89736: [ms] [llvm-ml] Implement the expression expansion operator.

Removed debug line

Oct 19 2020, 2:14 PM · Restricted Project
epastor updated the diff for D89736: [ms] [llvm-ml] Implement the expression expansion operator.

Fix missing brackets around a case block

Oct 19 2020, 2:06 PM · Restricted Project