Page MenuHomePhabricator

brad (Brad Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 20 2016, 8:58 AM (229 w, 5 d)

Recent Activity

Wed, Mar 31

brad added a reviewer for D97129: [Support] unsafe pointer arithmetic in llvm_regcomp(): chandlerc.
Wed, Mar 31, 12:33 PM · Restricted Project

Fri, Mar 26

brad added inline comments to D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs.
Fri, Mar 26, 1:18 PM · Restricted Project

Mon, Mar 22

brad added a comment to D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs.

-m32 is not supported on OpenBSD at all:

openbsd# echo | gcc -E -dM -m32 -            
:0: error: -m32 is not supported by this configuration
openbsd#
Mon, Mar 22, 9:27 AM · Restricted Project

Mar 13 2021

brad added a comment to D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs.

I do not immediately see why the other tests are failing, but at a bare minimum the following test from clang/test/Preprocessor/predefined-arch-macros.c will have to be updated..

Mar 13 2021, 4:46 PM · Restricted Project

Feb 27 2021

brad added a comment to D97129: [Support] unsafe pointer arithmetic in llvm_regcomp().

ping.

Feb 27 2021, 12:12 PM · Restricted Project

Feb 20 2021

brad committed rGb42d57a100c5: [clang][Driver][OpenBSD] libcxx also requires pthread (authored by brad).
[clang][Driver][OpenBSD] libcxx also requires pthread
Feb 20 2021, 5:53 PM
brad requested review of D97129: [Support] unsafe pointer arithmetic in llvm_regcomp().
Feb 20 2021, 3:46 PM · Restricted Project

Feb 8 2021

brad set the repository for D51206: [Sparc] Add tail call support to rG LLVM Github Monorepo.
Feb 8 2021, 6:21 PM · Restricted Project
brad committed rG45e33e8ba9e0: [SPARC] Recognize and handle the %lm(sym) operator (authored by LemonBoy).
[SPARC] Recognize and handle the %lm(sym) operator
Feb 8 2021, 4:26 PM
brad closed D77737: [SPARC] Recognize and handle the %lm(sym) operator.
Feb 8 2021, 4:25 PM · Restricted Project

Jan 25 2021

brad committed rG4b6d7fdd2079: [libcxx] random_device, for OpenBSD specify optimal entropy properties (authored by brad).
[libcxx] random_device, for OpenBSD specify optimal entropy properties
Jan 25 2021, 6:03 PM
brad closed D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.
Jan 25 2021, 6:03 PM · Restricted Project

Jan 23 2021

brad updated the diff for D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.

Updated.

Jan 23 2021, 10:17 PM · Restricted Project
brad added inline comments to D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.
Jan 23 2021, 10:17 PM · Restricted Project

Jan 22 2021

brad committed rG018984ae6833: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets (authored by kernigh).
[PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets
Jan 22 2021, 9:18 PM
brad closed D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets.
Jan 22 2021, 9:18 PM · Restricted Project

Jan 21 2021

brad updated the diff for D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.

Rebased.

Jan 21 2021, 4:57 PM · Restricted Project
brad committed rG1be2524b7d21: [libcxx] Check return value for asprintf() (authored by brad).
[libcxx] Check return value for asprintf()
Jan 21 2021, 4:43 PM
brad closed D94564: [libcxx] Check return value for asprintf().
Jan 21 2021, 4:43 PM · Restricted Project

Jan 19 2021

brad updated the diff for D94564: [libcxx] Check return value for asprintf().

Fix the comparison between signed and unsigned values.

Jan 19 2021, 9:20 PM · Restricted Project
brad added a comment to D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.

@ldionne I don't understand how a Linux specific diff would help with another operating system. I could update this after D94953 goes in and eliminate the first chunk.

Jan 19 2021, 7:37 AM · Restricted Project

Jan 16 2021

brad added a comment to D77737: [SPARC] Recognize and handle the %lm(sym) operator.

ping.

Jan 16 2021, 10:12 AM · Restricted Project

Jan 13 2021

brad updated the diff for D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.

Don't care about the removal of that one line.

Jan 13 2021, 8:47 AM · Restricted Project
brad updated the diff for D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.

Updated diff after moving header up to the top and removing the OpenBSD guard.

Jan 13 2021, 8:41 AM · Restricted Project
brad added inline comments to D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.
Jan 13 2021, 8:23 AM · Restricted Project

Jan 12 2021

brad requested review of D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties.
Jan 12 2021, 5:36 PM · Restricted Project
brad requested review of D94569: [libcxx] Wipe some more macros that do not belong in C++ forwarding headers.
Jan 12 2021, 5:28 PM · Restricted Project
brad requested review of D94564: [libcxx] Check return value for asprintf().
Jan 12 2021, 4:21 PM · Restricted Project
brad committed rG79f99ba65d96: [libcxx] Port to OpenBSD (authored by brad).
[libcxx] Port to OpenBSD
Jan 12 2021, 11:22 AM
brad closed D94205: [libcxx] Port to OpenBSD.
Jan 12 2021, 11:22 AM · Restricted Project
brad added a comment to D94205: [libcxx] Port to OpenBSD.

Sorry, I think I had started the review on my phone and forgot to pick it back up. LGTM, do you need commit access?

Jan 12 2021, 11:01 AM · Restricted Project
brad added a comment to D94205: [libcxx] Port to OpenBSD.

Anyone?

Jan 12 2021, 9:35 AM · Restricted Project

Jan 6 2021

brad requested review of D94205: [libcxx] Port to OpenBSD.
Jan 6 2021, 4:49 PM · Restricted Project

Dec 18 2020

brad added a comment to D78193: [Sparc] Fixes for the internal assembler.

@dcederman Able to see about getting this in?

Dec 18 2020, 5:34 PM · Restricted Project

Nov 21 2020

brad added a comment to D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets.

@efriedma Eli?

Nov 21 2020, 12:00 PM · Restricted Project

Oct 22 2020

brad added a comment to D78193: [Sparc] Fixes for the internal assembler.

Any chance of seeing review on this?

Oct 22 2020, 10:16 PM · Restricted Project

Oct 12 2020

brad added a comment to D87219: [ELF] Merge .openbsd.randomdata.* sections into a single .openbsd.randomdata section when linking.

I'm not really good with coming up with tests, but especially with lld. Any suggestions? Any further comments?

Oct 12 2020, 1:07 PM · Restricted Project

Oct 7 2020

brad added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

What about reverting this now that you have found this is an issue with the Sun linker?

Oct 7 2020, 11:40 PM · Restricted Project

Oct 2 2020

brad committed rG9ae95a0f8f1b: [Sparc] Remove cast that truncates immediate operands to 32 bits. (authored by brad).
[Sparc] Remove cast that truncates immediate operands to 32 bits.
Oct 2 2020, 5:15 PM
brad closed D87210: [Sparc] Remove cast that truncates immediate operands to 32 bits..
Oct 2 2020, 5:15 PM · Restricted Project

Sep 29 2020

brad committed rG6f01c53f26af: Remove further OpenBSD/sparc bits (authored by brad).
Remove further OpenBSD/sparc bits
Sep 29 2020, 7:18 PM

Sep 22 2020

brad added a comment to D87219: [ELF] Merge .openbsd.randomdata.* sections into a single .openbsd.randomdata section when linking.

I spoke to the author of the diff and asked for some feedback. He said...

Sep 22 2020, 5:17 PM · Restricted Project

Sep 19 2020

brad added a comment to D87210: [Sparc] Remove cast that truncates immediate operands to 32 bits..

@jrtc27 ??

Sep 19 2020, 4:45 PM · Restricted Project

Sep 11 2020

brad added a comment to D87210: [Sparc] Remove cast that truncates immediate operands to 32 bits..

Venkatraman?

Sep 11 2020, 3:13 PM · Restricted Project

Sep 8 2020

brad added a comment to D87210: [Sparc] Remove cast that truncates immediate operands to 32 bits..

Is this Ok or is any further testing necessary?

Sep 8 2020, 7:10 PM · Restricted Project
brad committed rG88b368a1c47b: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC… (authored by brad).
[PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC…
Sep 8 2020, 6:26 PM
brad closed D86165: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering.
Sep 8 2020, 6:25 PM · Restricted Project, Restricted Project

Sep 7 2020

brad committed rG70523ecfaca6: [Sparc] Select the UltraSPARC instruction set with the external assembler (authored by brad).
[Sparc] Select the UltraSPARC instruction set with the external assembler
Sep 7 2020, 12:18 AM

Sep 6 2020

brad requested review of D87219: [ELF] Merge .openbsd.randomdata.* sections into a single .openbsd.randomdata section when linking.
Sep 6 2020, 8:45 PM · Restricted Project
brad updated the diff for D87210: [Sparc] Remove cast that truncates immediate operands to 32 bits..

Added provided test.

Sep 6 2020, 7:19 PM · Restricted Project
brad added a reviewer for D86165: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering: jrtc27.
Sep 6 2020, 2:40 PM · Restricted Project, Restricted Project
brad requested review of D87210: [Sparc] Remove cast that truncates immediate operands to 32 bits..
Sep 6 2020, 2:18 PM · Restricted Project
brad committed rG8542dab909f8: [compiler-rt] Implement __clear_cache() on OpenBSD/arm (authored by brad).
[compiler-rt] Implement __clear_cache() on OpenBSD/arm
Sep 6 2020, 12:56 PM

Sep 1 2020

brad added a comment to D86165: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering.

Any chance of a review of the auto generated tests. Do they look appropriate?

Sep 1 2020, 3:08 PM · Restricted Project, Restricted Project
brad added inline comments to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Sep 1 2020, 1:01 PM · Restricted Project, Restricted Project

Aug 30 2020

brad retitled D86165: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering from [PowerPC] setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering to [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering.
Aug 30 2020, 3:41 PM · Restricted Project, Restricted Project
brad added reviewers for D86165: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering: hfinkel, nemanjai, saghir, amyk, steven.zhang, kbarton.
Aug 30 2020, 1:48 PM · Restricted Project, Restricted Project

Aug 29 2020

brad committed rG4fbf0636a214: Remove OpenBSD/sparc support (authored by brad).
Remove OpenBSD/sparc support
Aug 29 2020, 5:48 PM

Aug 27 2020

brad updated subscribers of D86165: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering.
Aug 27 2020, 8:15 PM · Restricted Project, Restricted Project
brad committed rGd870e3632638: [SSP] Restore setting the visibility of __guard_local to hidden for better code… (authored by brad).
[SSP] Restore setting the visibility of __guard_local to hidden for better code…
Aug 27 2020, 2:30 PM

Aug 26 2020

brad committed rGa45ccc983b51: Default to -fuse-init-array on OpenBSD. (authored by brad).
Default to -fuse-init-array on OpenBSD.
Aug 26 2020, 10:13 PM

Aug 25 2020

brad updated the diff for D86165: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering.

Nothing changed. Just want to rebuild as an unrelated Windows test was broken.

Aug 25 2020, 7:52 PM · Restricted Project, Restricted Project

Aug 24 2020

brad updated the diff for D86165: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering.

Drop the tests I had copied and modified from X86 as it looks like the existing tests are probably good enough and update the failing tests with update_llc_test_checks.py.

Aug 24 2020, 6:42 PM · Restricted Project, Restricted Project

Aug 23 2020

brad committed rGbf3577ef64c3: [clang][Driver] Implement addLibCxxIncludePaths and getCompilerRT for the… (authored by brad).
[clang][Driver] Implement addLibCxxIncludePaths and getCompilerRT for the…
Aug 23 2020, 5:46 PM
brad committed rG2b37174b9a5d: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport… (authored by brad).
[clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport…
Aug 23 2020, 5:09 PM
brad closed D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver..
Aug 23 2020, 5:08 PM · Restricted Project
brad accepted D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver..

I was wondering why we had not seen any issues like this but your followup post clarified the situation.

Aug 23 2020, 2:25 PM · Restricted Project

Aug 22 2020

brad added a comment to D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver..

Looks reasonable. I'm a little surprised I don't see this in the FreeBSD driver. What about FreeBSD, NetBSD and DragonFly?

Aug 22 2020, 10:16 PM · Restricted Project

Aug 18 2020

brad committed rGd9ff48d03817: WCharType and WIntType are always signed int on OpenBSD. (authored by brad).
WCharType and WIntType are always signed int on OpenBSD.
Aug 18 2020, 5:01 PM
brad committed rG592b8996bf9b: Hook up OpenBSD 64-bit RISC-V support (authored by brad).
Hook up OpenBSD 64-bit RISC-V support
Aug 18 2020, 4:02 PM
brad requested review of D86165: [PowerPC] Set setMaxAtomicSizeInBitsSupported appropriately for 32-bit PowerPC in PPCTargetLowering.
Aug 18 2020, 12:19 PM · Restricted Project, Restricted Project

Aug 16 2020

brad committed rG44613bbec88b: Create strict aligned code for OpenBSD/arm64. (authored by brad).
Create strict aligned code for OpenBSD/arm64.
Aug 16 2020, 4:15 AM

Aug 10 2020

brad committed rG5fe171321c01: [Sparc] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros on SPARCv9 (authored by brad).
[Sparc] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros on SPARCv9
Aug 10 2020, 9:05 PM

Aug 9 2020

brad committed rGf5fdb6141c5e: Re-enable OpenBSD PowerPC64 tests. (authored by brad).
Re-enable OpenBSD PowerPC64 tests.
Aug 9 2020, 5:53 PM
brad committed rG92e82a2890c3: int64_t and intmax_t are always (signed) long long on OpenBSD. (authored by brad).
int64_t and intmax_t are always (signed) long long on OpenBSD.
Aug 9 2020, 4:44 PM

Aug 8 2020

brad committed rGf4aba9d76c61: Backout a test that is dependent on an uncommited diff. Fix another. (authored by brad).
Backout a test that is dependent on an uncommited diff. Fix another.
Aug 8 2020, 3:41 PM
brad committed rG430db35bf215: fix typo (authored by brad).
fix typo
Aug 8 2020, 2:59 PM
brad committed rG4eb4ebf76a6e: Hook up OpenBSD 64-bit PowerPC support (authored by brad).
Hook up OpenBSD 64-bit PowerPC support
Aug 8 2020, 2:52 PM
brad committed rGcd5ab56bc406: Change the default target CPU for OpenBSD/i386 to i586 (authored by brad).
Change the default target CPU for OpenBSD/i386 to i586
Aug 8 2020, 10:50 AM

Jun 27 2020

brad committed rG66b7ba52b7b4: Add OpenBSD support to be able to retrieve the thread id (authored by brad).
Add OpenBSD support to be able to retrieve the thread id
Jun 27 2020, 11:27 PM

Jun 18 2020

brad committed rG0f92096c0a9a: Revert "Hook up OpenBSD 64-bit PowerPC support" (authored by brad).
Revert "Hook up OpenBSD 64-bit PowerPC support"
Jun 18 2020, 5:32 PM
brad committed rG3008609d4509: Hook up OpenBSD 64-bit PowerPC support (authored by brad).
Hook up OpenBSD 64-bit PowerPC support
Jun 18 2020, 4:27 PM

Jun 13 2020

brad added reviewers for D77737: [SPARC] Recognize and handle the %lm(sym) operator: jyknight, joerg, venkatra, dcederman.
Jun 13 2020, 10:42 AM · Restricted Project

Jun 9 2020

brad added a comment to D77737: [SPARC] Recognize and handle the %lm(sym) operator.

ping.

Jun 9 2020, 8:25 PM · Restricted Project
brad added a comment to D78193: [Sparc] Fixes for the internal assembler.

ping.

Jun 9 2020, 8:25 PM · Restricted Project
brad added a comment to D77569: Lower fp16 ops to libcalls for SPARC targets.

ping.

Jun 9 2020, 7:39 AM · Restricted Project

May 7 2020

brad added a comment to D79588: [llvm][Support] Use std::atomic for llvm::call_once.

OpenBSD 6.7 is just wrapping up and will be released in a few days. We have switched to Clang for our PowerPC system compiler and thus libc++. It should be Ok to remove OpenBSD from that bit of code.

May 7 2020, 6:28 PM · Restricted Project

Apr 9 2020

brad added a comment to D77672: [ELF] Support a few more SPARCv9 relocations.

My immediate reaction is "isn't Sparc an abandoned architecture?" See https://en.wikipedia.org/wiki/SPARC and https://lists.freebsd.org/pipermail/freebsd-sparc64/2020-January/010192.html

Though, no objection. You may still need some basic tests, similar to test/ELF/ppc32-* I tried hard to keep the number of tests small yet complete. Does sparc64 use TLS variant 2?

Apr 9 2020, 1:50 PM · Restricted Project

Apr 1 2020

brad added a comment to D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF.

Now that 10 is out, any chance of getting some movement on this to resolve this ABI issue with 32-bit PowerPC?

Apr 1 2020, 8:42 PM · Restricted Project

Jun 28 2019

brad committed rG642fe780abe8: Revert enabling frame pointer elimination on OpenBSD for now. (authored by brad).
Revert enabling frame pointer elimination on OpenBSD for now.
Jun 28 2019, 12:59 PM
brad committed rL364679: Revert enabling frame pointer elimination on OpenBSD for now..
Revert enabling frame pointer elimination on OpenBSD for now.
Jun 28 2019, 12:58 PM
brad committed rG4b733ca617e8: Default to Secure PLT on PPC for musl libc. (authored by brad).
Default to Secure PLT on PPC for musl libc.
Jun 28 2019, 12:50 PM
brad committed rL364675: Default to Secure PLT on PPC for musl libc..
Default to Secure PLT on PPC for musl libc.
Jun 28 2019, 12:50 PM

Apr 19 2019

brad committed rG4fccc0cedd28: Enable frame pointer elimination for OpenBSD on powerpc. (authored by brad).
Enable frame pointer elimination for OpenBSD on powerpc.
Apr 19 2019, 11:45 AM
brad committed rL358775: Enable frame pointer elimination for OpenBSD on powerpc..
Enable frame pointer elimination for OpenBSD on powerpc.
Apr 19 2019, 11:40 AM
brad committed rC358775: Enable frame pointer elimination for OpenBSD on powerpc..
Enable frame pointer elimination for OpenBSD on powerpc.
Apr 19 2019, 11:39 AM

Apr 11 2019

brad committed rG21375ca13602: Enable frame pointer elimination for OpenBSD on x86 and mips64. (authored by brad).
Enable frame pointer elimination for OpenBSD on x86 and mips64.
Apr 11 2019, 6:33 PM
brad committed rL358245: Enable frame pointer elimination for OpenBSD on x86 and mips64..
Enable frame pointer elimination for OpenBSD on x86 and mips64.
Apr 11 2019, 6:33 PM
brad committed rC358245: Enable frame pointer elimination for OpenBSD on x86 and mips64..
Enable frame pointer elimination for OpenBSD on x86 and mips64.
Apr 11 2019, 6:33 PM

Apr 7 2019

brad committed rG5f1e87ad4054: IAS is now enabled for all OS on MIPS64 (authored by brad).
IAS is now enabled for all OS on MIPS64
Apr 7 2019, 5:02 PM