Page MenuHomePhabricator

thakis (Nico Weber)
UserEmail Not Verified

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (471 w, 1 h)

Recent Activity

Today

thakis committed rG9122b5072aa7: [llvm] Remove an old bot cleanup command (authored by thakis).
[llvm] Remove an old bot cleanup command
Thu, Jan 20, 12:03 PM
thakis committed rG8b4fa2c98e07: clang: Auto-cleanup left-over file from before 3da69fb5a26c7b on bots (authored by thakis).
clang: Auto-cleanup left-over file from before 3da69fb5a26c7b on bots
Thu, Jan 20, 12:00 PM
thakis committed rG91eca967b9eb: [gn build] (manually) port f29256a64a (authored by thakis).
[gn build] (manually) port f29256a64a
Thu, Jan 20, 8:02 AM

Yesterday

thakis committed rG70002a7a62c9: [gn build] (manually) port 30c17e70a4d7 (authored by thakis).
[gn build] (manually) port 30c17e70a4d7
Wed, Jan 19, 6:15 PM
thakis added a comment to D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB.

The background here is that I found this patch in one of my old WIP branches. The next patch in the series was going to define LLDB_API to __attribute__((visibility("default"))) on the non-windows path (and make everything else hidden), but I have no idea why I wanted to do that. I mean, it does not sounds like an *un*reasonable thing to do, but am not going to do unless I find some benefit to it (maybe it saves size?)

Wed, Jan 19, 8:36 AM · Restricted Project
thakis committed rGcc639dde8c6d: [gn build] port c22329972f02 (lldb REPL/Clang) (authored by thakis).
[gn build] port c22329972f02 (lldb REPL/Clang)
Wed, Jan 19, 8:33 AM
thakis committed rG7260a926cfd8: [gn build] link lldb-vscode against ws2_32.lib (authored by thakis).
[gn build] link lldb-vscode against ws2_32.lib
Wed, Jan 19, 8:07 AM
thakis committed rGaaa50e54e60f: [gn build] port b2a162e63bd73 (liblldb.dll) (authored by thakis).
[gn build] port b2a162e63bd73 (liblldb.dll)
Wed, Jan 19, 7:50 AM
thakis added a comment to D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB.

So what happens now if you define LLDB_IN_LIBLLDB? Does dllexport explode if used in a static library?

Wed, Jan 19, 7:48 AM · Restricted Project
thakis added a comment to D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB.

Before this change, it was very easy to build liblldb as a static library (just don't define IMPORT_LIBLLDB and EXPORT_LIBLLDB). After this change, this is no longer possible on Windows (but it still works fine everywhere else). Is this intentional?

Wed, Jan 19, 7:04 AM · Restricted Project

Tue, Jan 18

thakis added a comment to D117567: [clang][dataflow] Add a test to justify skipping past references in UO_Deref.

This breaks tests on windows: http://45.33.8.238/win/52841/step_7.txt

Tue, Jan 18, 7:41 PM · Restricted Project

Fri, Jan 14

thakis added a comment to D113620: Skip exception cleanups when the innermost scope is EHTerminateScope..

Breaks a few tests on windows too: http://45.33.8.238/win/52616/step_7.txt

Fri, Jan 14, 3:56 PM · Restricted Project
thakis added a comment to D113620: Skip exception cleanups when the innermost scope is EHTerminateScope..

This breaks a bunch of tests on Mac: http://45.33.8.238/macm1/25623/step_7.txt

Fri, Jan 14, 3:55 PM · Restricted Project

Thu, Jan 13

thakis added a comment to D117266: [gn build] Add support for building using PGO or propeller.

Could use a short comment on how to use it ("build in one build dir with propellor_phase = 1, run perf, ...") maybe.

Thu, Jan 13, 5:43 PM · Restricted Project
thakis added a comment to D116919: [AST] Add RParen loc for decltype AutoTypeloc..

Since this is changing serialization format you might have to do something like https://reviews.llvm.org/rGb8b7a9dcdcbc as well (see https://reviews.llvm.org/D73202 for background). I doubt that's the cause of mstorsjo's repro given that LLVM_APPEND_VC_REV is on by default, but it seems like a good thing to do in the reland regardless.

Thu, Jan 13, 7:16 AM · Restricted Project, Restricted Project

Wed, Jan 12

thakis added a comment to D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..

(Reverted for now.)

Wed, Jan 12, 11:44 AM · Restricted Project
thakis added a reverting change for rG253ce92844f7: [JITLink][AArch64] Add support for splitting eh-frames on AArch64.: rG66b2ed477f90: Revert "[JITLink][AArch64] Add support for splitting eh-frames on AArch64.".
Wed, Jan 12, 11:40 AM
thakis committed rG66b2ed477f90: Revert "[JITLink][AArch64] Add support for splitting eh-frames on AArch64." (authored by thakis).
Revert "[JITLink][AArch64] Add support for splitting eh-frames on AArch64."
Wed, Jan 12, 11:40 AM
thakis committed rG6db04b97e6a2: [lld-macho] Port CallGraphSort from COFF/ELF (authored by lgrey).
[lld-macho] Port CallGraphSort from COFF/ELF
Wed, Jan 12, 7:58 AM
thakis closed D112164: [lld-macho] Port CallGraphSort from COFF/ELF.
Wed, Jan 12, 7:57 AM · Restricted Project, Restricted Project
thakis added a reverting change for rGaad49c8eb984: [llvm-readobj][XCOFF] dump auxiliary symbols.: rGd3b90f41041c: Revert "[llvm-readobj][XCOFF] dump auxiliary symbols.".
Wed, Jan 12, 6:43 AM
thakis committed rGd3b90f41041c: Revert "[llvm-readobj][XCOFF] dump auxiliary symbols." (authored by thakis).
Revert "[llvm-readobj][XCOFF] dump auxiliary symbols."
Wed, Jan 12, 6:43 AM
thakis added a reverting change for D113825: [llvm-readobj][XCOFF] dump auxiliary symbols.: rGd3b90f41041c: Revert "[llvm-readobj][XCOFF] dump auxiliary symbols.".
Wed, Jan 12, 6:43 AM · Restricted Project
thakis committed rG0f853930042f: [MachO] Port call graph profile section and directive (authored by lgrey).
[MachO] Port call graph profile section and directive
Wed, Jan 12, 6:23 AM
thakis closed D112160: [MachO] Port call graph profile section and directive.
Wed, Jan 12, 6:23 AM · Restricted Project
thakis added inline comments to D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..
Wed, Jan 12, 6:17 AM · Restricted Project
thakis added inline comments to D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..
Wed, Jan 12, 6:16 AM · Restricted Project
thakis added a comment to D113825: [llvm-readobj][XCOFF] dump auxiliary symbols..

This breaks tests on windows: http://45.33.8.238/win/52389/step_11.txt

Wed, Jan 12, 3:49 AM · Restricted Project

Tue, Jan 11

thakis added a comment to D113130: [llvm-libtool-darwin] Print a warning if object file names are repeated.

The test fails on Windows: http://45.33.8.238/win/52360/step_11.txt

Tue, Jan 11, 7:20 PM · Restricted Project
thakis added a comment to D117069: [lld-macho] Initialize separate time trace profiler for mapfile worker.

Seems to not fail every time though.

Tue, Jan 11, 7:16 PM · Restricted Project, Restricted Project
thakis committed rG37fc1a29cb41: [gn build] minor comment tweaks, no behavior change (authored by thakis).
[gn build] minor comment tweaks, no behavior change
Tue, Jan 11, 7:06 PM
thakis added a comment to D117069: [lld-macho] Initialize separate time trace profiler for mapfile worker.

This seems to break tests: http://45.33.8.238/macm1/25367/step_10.txt

Tue, Jan 11, 6:46 PM · Restricted Project, Restricted Project
thakis committed rGbf95d5e33488: [gn build] (manually) port 85e6e748d426 (llvm/lib/Target/X86/MCA) (authored by thakis).
[gn build] (manually) port 85e6e748d426 (llvm/lib/Target/X86/MCA)
Tue, Jan 11, 6:45 PM
thakis accepted D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Cool.

Tue, Jan 11, 1:09 PM · Restricted Project, Restricted Project
thakis accepted D112160: [MachO] Port call graph profile section and directive.

Nice! lgtm. One bikeshed comment about naming below (in two places, but about the same name).

Tue, Jan 11, 12:58 PM · Restricted Project
thakis committed rGfce1c6fb6798: [gn build] (manually) port f77d115cc136 more (authored by thakis).
[gn build] (manually) port f77d115cc136 more
Tue, Jan 11, 11:49 AM
thakis accepted D117024: [clang] Move `ApplyHeaderSearchOptions` from Frontend to Lex.

That was easy :) Thanks!

Tue, Jan 11, 8:15 AM · Restricted Project
thakis added a comment to D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date.

That's referring to the fact that once we allocate new DirectoryLookup with SpecificBumpPtrAllocator, address of that object won't change (unlike with std::vector). This means that we can take the address and use it without worrying about invalidation.

Tue, Jan 11, 7:17 AM · Restricted Project
thakis added a comment to D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date.
  1. which is stable thanks to the bump-ptr-allocation strategy. I don't understand this. In each slab, that's true, but why is it true between objects allocated in different slabs?
  2. This increases numbers of TUs compiled for LexTests by over 10%. Is there no way around that Frontend dep?
Tue, Jan 11, 6:49 AM · Restricted Project
thakis committed rG5fc9abe4749f: [gn build] (manually) port 8503c688d555 (authored by thakis).
[gn build] (manually) port 8503c688d555
Tue, Jan 11, 6:47 AM

Mon, Jan 10

thakis added a reverting change for rG37ec65e1d705: [clangd] Enable expand-auto for decltype(auto).: rGcf90b3cf7e46: Revert "[clangd] Enable expand-auto for decltype(auto).".
Mon, Jan 10, 9:03 AM
thakis committed rGcf90b3cf7e46: Revert "[clangd] Enable expand-auto for decltype(auto)." (authored by thakis).
Revert "[clangd] Enable expand-auto for decltype(auto)."
Mon, Jan 10, 9:03 AM
thakis added a reverting change for D116921: [clangd] Enable expand-auto for decltype(auto).: rGcf90b3cf7e46: Revert "[clangd] Enable expand-auto for decltype(auto).".
Mon, Jan 10, 9:03 AM · Restricted Project
thakis added a comment to D116921: [clangd] Enable expand-auto for decltype(auto)..

This broke check-clangd: http://45.33.8.238/linux/64747/step_9.txt (maybe triggered by the revert for D116919 which broke check-clang-tools.)

Mon, Jan 10, 8:55 AM · Restricted Project
thakis added a comment to D116919: [AST] Add RParen loc for decltype AutoTypeloc..

Looks like this breaks tests: http://45.33.8.238/linux/64726/step_8.txt

Mon, Jan 10, 5:50 AM · Restricted Project, Restricted Project

Fri, Jan 7

thakis added a reverting change for rG3ca692834421: Revert "[gn build] (manually) port 492de35df44": rG19c37223d7a9: [gn build] (manually) port feeff8a37c35.
Fri, Jan 7, 6:22 PM
thakis committed rG19c37223d7a9: [gn build] (manually) port feeff8a37c35 (authored by thakis).
[gn build] (manually) port feeff8a37c35
Fri, Jan 7, 6:22 PM
thakis added a comment to D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added.

Thanks for the patch!

Fri, Jan 7, 4:12 AM · Restricted Project

Thu, Jan 6

thakis accepted D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does.

Thanks!

Thu, Jan 6, 6:30 PM · Restricted Project
thakis added a reverting change for rGafdc6a0b8eee: [Hexagon] Some compound opportunities missed in presence of branches: rG6c255ac96953: Revert "[Hexagon] Some compound opportunities missed in presence of branches".
Thu, Jan 6, 12:33 PM
thakis committed rG6c255ac96953: Revert "[Hexagon] Some compound opportunities missed in presence of branches" (authored by thakis).
Revert "[Hexagon] Some compound opportunities missed in presence of branches"
Thu, Jan 6, 12:32 PM
thakis added a comment to D109112: [darwin/x86] Model cxx_fast_tlscc as not preserving r11.

Should we just land this and see what (if any) breaks?

Thu, Jan 6, 6:51 AM · Restricted Project
thakis added inline comments to D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does.
Thu, Jan 6, 6:50 AM · Restricted Project
thakis accepted D116705: [lld-macho] Increase slops to prevent thunk out of range.

For "why 100": My repro worked with 10, so I figured if I put in ten times that nobody should ever hit this again. Looks like that didn't work out 😓

Thu, Jan 6, 6:49 AM · Restricted Project, Restricted Project

Wed, Jan 5

thakis committed rG7e08a1208889: [clang] Fall back on Android triple w/o API level for runtimes search (authored by collinbaker).
[clang] Fall back on Android triple w/o API level for runtimes search
Wed, Jan 5, 1:08 PM
thakis closed D115049: Fall back on Android triple w/o API level for runtimes search.
Wed, Jan 5, 1:08 PM · Restricted Project
thakis accepted D115049: Fall back on Android triple w/o API level for runtimes search.

lg!

Wed, Jan 5, 12:56 PM · Restricted Project
thakis committed rGd5b2921faf51: [lld/tests] Stop setting the "asserts" and "debug" features (authored by thakis).
[lld/tests] Stop setting the "asserts" and "debug" features
Wed, Jan 5, 10:39 AM
thakis closed D115941: [lld/tests] Stop setting the "asserts" and "debug" features.
Wed, Jan 5, 10:39 AM · Restricted Project
thakis added a comment to D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`.".

Not sure what happened here but this change added back a whole bunch of old code. I reverted this in 085f078307bac264301b07f6e47e2a04e90a6f1d . Please carefully check git diff origin/main before committing next time :)

Wed, Jan 5, 10:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
thakis committed rG085f078307ba: Revert "Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."" (authored by thakis).
Revert "Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`.""
Wed, Jan 5, 10:11 AM
thakis added a reverting change for rG859ebca744e6: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`.": rG085f078307ba: Revert "Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."".
Wed, Jan 5, 10:11 AM
thakis added a reverting change for D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`.": rG085f078307ba: Revert "Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."".
Wed, Jan 5, 10:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
thakis added a reverting change for D109159: [amdgpu] Enable selection of `s_cselect_b64`.: rG085f078307ba: Revert "Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."".
Wed, Jan 5, 10:10 AM · Restricted Project
thakis committed rGdabc101ec0c5: [gn build] "port" 027ffb173a68 (authored by thakis).
[gn build] "port" 027ffb173a68
Wed, Jan 5, 9:57 AM
thakis committed rG5730d11c2b52: [lld-link] Consistently print all /verbose output to stderr (authored by thakis).
[lld-link] Consistently print all /verbose output to stderr
Wed, Jan 5, 8:52 AM
thakis closed D116667: [lld-link] Consistently print all /verbose output to stderr.
Wed, Jan 5, 8:52 AM · Restricted Project
thakis requested review of D116667: [lld-link] Consistently print all /verbose output to stderr.
Wed, Jan 5, 8:30 AM · Restricted Project

Tue, Jan 4

thakis added a comment to D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library.

Thanks for noticing that. It's back and happy now.

Tue, Jan 4, 7:04 AM · Restricted Project

Mon, Jan 3

thakis added a comment to D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library.

Still broken on windows: http://45.33.8.238/win/51764/step_4.txt

Mon, Jan 3, 3:06 PM · Restricted Project
thakis added a comment to D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library.

Breaks building on windows: http://45.33.8.238/win/51774/step_4.txt

Mon, Jan 3, 11:08 AM · Restricted Project

Sat, Jan 1

thakis added a comment to D116256: [-fms-extensions] Make some exception specification warnings/errors compatible with what cl.exe does.

Thanks for the patch! This looks roughly right to me.

Sat, Jan 1, 12:44 PM · Restricted Project
thakis added a reverting change for rG24d240558811: [lldb] Use nullptr instead of 0 or NULL (NFC): rG4f2eeb6a657a: Revert "[lldb] Use nullptr instead of 0 or NULL (NFC)".
Sat, Jan 1, 10:37 AM
thakis committed rG4f2eeb6a657a: Revert "[lldb] Use nullptr instead of 0 or NULL (NFC)" (authored by thakis).
Revert "[lldb] Use nullptr instead of 0 or NULL (NFC)"
Sat, Jan 1, 10:37 AM

Thu, Dec 23

thakis committed rGa6114ff0cd69: [gn build] "port" 71b3bfde9cd2 (authored by thakis).
[gn build] "port" 71b3bfde9cd2
Thu, Dec 23, 4:53 PM
thakis committed rGee4bbb50ae58: [gn build] (manually) port 7cd7b4d2f807 (sanitizer_symbolize_set_demangle) (authored by thakis).
[gn build] (manually) port 7cd7b4d2f807 (sanitizer_symbolize_set_demangle)
Thu, Dec 23, 3:07 PM
thakis committed rG5fd328c45f6d: [gn build] (manually) port f103ee2e9e3fc (sanitizer_symbolize_set_inline_frames) (authored by thakis).
[gn build] (manually) port f103ee2e9e3fc (sanitizer_symbolize_set_inline_frames)
Thu, Dec 23, 1:40 PM

Wed, Dec 22

thakis added a comment to D116137: [clang-tidy] Remove dead plugin code.

If this code is truly dead, this looks fine to me.

Wed, Dec 22, 1:45 PM · Restricted Project

Dec 21 2021

thakis committed rG0e9393f5221c: [gn build] (manually) port f68e89044a2ee (authored by thakis).
[gn build] (manually) port f68e89044a2ee
Dec 21 2021, 4:00 PM
thakis committed rGf2f6d09185d6: [gn build] (semiautomatically) port 9b4f179bf8d3 (authored by thakis).
[gn build] (semiautomatically) port 9b4f179bf8d3
Dec 21 2021, 5:11 AM

Dec 20 2021

thakis added a comment to D115651: [LV] Enable scalable vectorization by default for SVE cores..

Looks like this broke check-llvm: https://lab.llvm.org/buildbot/#/builders/109/builds/28397

Dec 20 2021, 9:09 AM · Restricted Project

Dec 17 2021

thakis committed rGc4b45eeb44fd: [lld/mac] Don't lose "weak ref" bit when doing LTO (authored by thakis).
[lld/mac] Don't lose "weak ref" bit when doing LTO
Dec 17 2021, 12:27 PM
thakis closed D115949: [lld/mac] Don't lose "weak ref" bit when doing LTO.
Dec 17 2021, 12:26 PM · Restricted Project, Restricted Project
thakis added a comment to D115949: [lld/mac] Don't lose "weak ref" bit when doing LTO.

Thanks!

Dec 17 2021, 12:22 PM · Restricted Project, Restricted Project
thakis updated the summary of D115949: [lld/mac] Don't lose "weak ref" bit when doing LTO.
Dec 17 2021, 12:20 PM · Restricted Project, Restricted Project
thakis updated the summary of D115949: [lld/mac] Don't lose "weak ref" bit when doing LTO.
Dec 17 2021, 9:41 AM · Restricted Project, Restricted Project
thakis requested review of D115949: [lld/mac] Don't lose "weak ref" bit when doing LTO.
Dec 17 2021, 9:36 AM · Restricted Project, Restricted Project
thakis requested review of D115941: [lld/tests] Stop setting the "asserts" and "debug" features.
Dec 17 2021, 7:07 AM · Restricted Project
thakis committed rG2438540a4a61: [gn build] (manually) port fb9a075c813c5 (authored by thakis).
[gn build] (manually) port fb9a075c813c5
Dec 17 2021, 7:02 AM
thakis committed rGa3096ca9b499: [lld/test] List one test dep per line (authored by thakis).
[lld/test] List one test dep per line
Dec 17 2021, 6:52 AM
thakis committed rG5dd8ff73804a: [asan/mac] Fix remaining -Wformat warnings (authored by thakis).
[asan/mac] Fix remaining -Wformat warnings
Dec 17 2021, 6:44 AM
thakis committed rG44f0e1453780: [asan/mac] Fix a few -Wformat warnings (authored by thakis).
[asan/mac] Fix a few -Wformat warnings
Dec 17 2021, 6:18 AM
thakis committed rGd412f35395be: [asan/mac] Fix a -Wformat warning (authored by thakis).
[asan/mac] Fix a -Wformat warning
Dec 17 2021, 6:18 AM
thakis committed rGfc01f85bf3ef: [gn build] (semiautomatically) port 3f5f687e2e8b (authored by thakis).
[gn build] (semiautomatically) port 3f5f687e2e8b
Dec 17 2021, 4:27 AM

Dec 16 2021

thakis added a reverting change for rG333d66b09494: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space…: rG770ef94097c0: Revert "[analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space….
Dec 16 2021, 5:51 PM
thakis committed rG770ef94097c0: Revert "[analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space… (authored by thakis).
Revert "[analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space…
Dec 16 2021, 5:51 PM
thakis added a comment to D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file.

reverted in 770ef94097c02205b3ec9e902f1d6a9c99b5189c. thanks!

Dec 16 2021, 5:51 PM · Restricted Project
thakis added a reverting change for D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file: rG770ef94097c0: Revert "[analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space….
Dec 16 2021, 5:51 PM · Restricted Project
thakis added a comment to D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file.

This breaks tests on macOS: http://45.33.8.238/macm1/23920/step_7.txt

Dec 16 2021, 5:00 PM · Restricted Project
thakis committed rG85f799730f2e: [gn build] Port 95946d2f8589 (authored by thakis).
[gn build] Port 95946d2f8589
Dec 16 2021, 3:39 PM