Page MenuHomePhabricator

thakis (Nico Weber)
UserEmail Not Verified

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (418 w, 3 d)

Recent Activity

Fri, Jan 15

thakis added a comment to D94734: [lit] Use os.cpu_count() to cleanup TODO.

Didn't look at the diff, but there's already code in the tree that requires python3 (eg subprocess.DEVNULL in compiler-rt/test/lit.common.cfg.py). So that part is fine.

Fri, Jan 15, 5:46 PM · Restricted Project

Thu, Jan 14

thakis committed rG0975604cc013: [gn build] (manually) port 387d3c24792f (authored by thakis).
[gn build] (manually) port 387d3c24792f
Thu, Jan 14, 1:19 PM

Wed, Jan 13

thakis added a comment to D74489: [libc++] Remove workarounds for the lack of clock_gettime on older macOS platforms.

We're looking into bumping libc++ in chromium, and this is a problem for us. We statically link libc++, and we still support 10.11. (We _just_ dropped support for 10.10 in our last release iirc.) What do you recommend as path forward?

Wed, Jan 13, 6:20 PM · Restricted Project
thakis added inline comments to D80391: [Driver] Don't make -gsplit-dwarf imply -g2.
Wed, Jan 13, 12:50 PM · Restricted Project
thakis added a comment to D80391: [Driver] Don't make -gsplit-dwarf imply -g2.

Do we emit a warning if we see -gsplit-dwarf alone? Should we?

Wed, Jan 13, 12:40 PM · Restricted Project
thakis added a reverting change for rG1854594b80b4: Hwasan InitPrctl check for error using internal_iserror: rG704831fe1f1f: Revert "Hwasan InitPrctl check for error using internal_iserror".
Wed, Jan 13, 5:31 AM
thakis committed rG704831fe1f1f: Revert "Hwasan InitPrctl check for error using internal_iserror" (authored by thakis).
Revert "Hwasan InitPrctl check for error using internal_iserror"
Wed, Jan 13, 5:30 AM
thakis added a reverting change for D94425: Hwasan InitPrctl check for error using internal_iserror: rG704831fe1f1f: Revert "Hwasan InitPrctl check for error using internal_iserror".
Wed, Jan 13, 5:30 AM · Restricted Project, Restricted Project
thakis added a comment to D94425: Hwasan InitPrctl check for error using internal_iserror.

I'll revert this for now to unbreak the bot since figuring out a way forward will likely take a few hours.

Wed, Jan 13, 5:29 AM · Restricted Project, Restricted Project
thakis updated subscribers of D94425: Hwasan InitPrctl check for error using internal_iserror.
Wed, Jan 13, 5:28 AM · Restricted Project, Restricted Project
thakis added a comment to D94425: Hwasan InitPrctl check for error using internal_iserror.

This breaks hwasan tests on my bot: http://45.33.8.238/linux/37054/step_10.txt

Wed, Jan 13, 5:27 AM · Restricted Project, Restricted Project

Tue, Jan 12

thakis added a comment to D94536: [dsymutil] Warn on timestmap mismatch between object file and debug map.

Looks like this breaks tests on windows even after all the fix attempts: http://45.33.8.238/win/31260/step_11.txt

Tue, Jan 12, 8:45 PM · Restricted Project
thakis committed rGacea470c167f: [gn build] Reorganize libcxx/include/BUILD.gn a bit (authored by thakis).
[gn build] Reorganize libcxx/include/BUILD.gn a bit
Tue, Jan 12, 6:30 PM
thakis committed rG25b3921f2fcd: [gn build] (manually) port 79f99ba65d96 (authored by thakis).
[gn build] (manually) port 79f99ba65d96
Tue, Jan 12, 5:31 PM
thakis added a reverting change for rGe8287cb2b292: [Test] Add failing test for PR48725: rGa06aa1037c17: Revert "[Test] Add failing test for PR48725".
Tue, Jan 12, 3:31 AM
thakis committed rGa06aa1037c17: Revert "[Test] Add failing test for PR48725" (authored by thakis).
Revert "[Test] Add failing test for PR48725"
Tue, Jan 12, 3:31 AM

Mon, Jan 11

thakis added a comment to D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base..

Hi, this broke check-clang everywhere as far as I can tell. Please run tests before committing. I've reverted this for now in 419ef38a50293c58078f830517f5e305068dbee6.

Mon, Jan 11, 6:52 AM · Restricted Project
thakis added a reverting change for rGc163aae45ef6: [attributes] Add a facility for enforcing a Trusted Computing Base.: rG419ef38a5029: Revert "[attributes] Add a facility for enforcing a Trusted Computing Base.".
Mon, Jan 11, 6:52 AM
thakis committed rG419ef38a5029: Revert "[attributes] Add a facility for enforcing a Trusted Computing Base." (authored by thakis).
Revert "[attributes] Add a facility for enforcing a Trusted Computing Base."
Mon, Jan 11, 6:52 AM
thakis added a reverting change for D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.: rG419ef38a5029: Revert "[attributes] Add a facility for enforcing a Trusted Computing Base.".
Mon, Jan 11, 6:52 AM · Restricted Project

Sun, Jan 10

thakis added a reverting change for rG80dee7965dff: [X86][SSE] Fold unpack(hop(),hop()) -> permute(hop()): rGd43a264a5dd3: Revert "[X86][SSE] Fold unpack(hop(),hop()) -> permute(hop())".
Sun, Jan 10, 5:27 PM
thakis committed rGd43a264a5dd3: Revert "[X86][SSE] Fold unpack(hop(),hop()) -> permute(hop())" (authored by thakis).
Revert "[X86][SSE] Fold unpack(hop(),hop()) -> permute(hop())"
Sun, Jan 10, 5:27 PM
thakis committed rG47991a15d192: [lld/mac] llvm style fix: no else after return (authored by thakis).
[lld/mac] llvm style fix: no else after return
Sun, Jan 10, 6:35 AM
thakis added inline comments to D94371: [lld/mac] Implement -u flag.
Sun, Jan 10, 6:19 AM

Sat, Jan 9

thakis requested review of D94371: [lld/mac] Implement -u flag.
Sat, Jan 9, 7:22 PM
thakis committed rG1198478c4208: [lld/mac] remove redundant null check (authored by thakis).
[lld/mac] remove redundant null check
Sat, Jan 9, 6:19 PM
thakis added a comment to D93263: [lld-macho] Implement option: -undefined TREATMENT.

As far as I can tell, ld64 only accepts -undefined warning and -undefined suppress with -flat_namespace (which lld/MachO doesn't yet implement). That makes sense since with a flat namespace the undefineds can be found at dynamic link time, but with two-level lookup they can't since they containing framework isn't known (…right?).

Sat, Jan 9, 6:03 PM · Restricted Project
thakis committed rG87d4ea243366: [gn build] Make an explicit `use_lld = true` on mac use lld.darwinnew (authored by thakis).
[gn build] Make an explicit `use_lld = true` on mac use lld.darwinnew
Sat, Jan 9, 11:06 AM

Fri, Jan 8

thakis accepted D94329: [lld-macho] Fix TLV data initialization.

Very nice!

Fri, Jan 8, 1:38 PM · Restricted Project

Thu, Jan 7

thakis committed rG2759041786e4: [gn build] (manually) merge a whole bunch of libc++ header files (authored by thakis).
[gn build] (manually) merge a whole bunch of libc++ header files
Thu, Jan 7, 7:10 PM

Wed, Jan 6

thakis added a comment to D92270: [ConstantFold] Fold more operations to poison.

It turned out to be UB in our code as far as I can tell, see https://bugs.chromium.org/p/angleproject/issues/detail?id=5500#c36 and the follow-on.

Wed, Jan 6, 6:22 PM · Restricted Project, Restricted Project
thakis added a comment to D92270: [ConstantFold] Fold more operations to poison.

We bisected a test failure to this (https://bugs.chromium.org/p/angleproject/issues/detail?id=5500#c17). Can you expand a bit on what this patch means in practice? I'm guessing it makes UB in C++ code have bad effects more often? If so, what type of UB?

Wed, Jan 6, 12:03 PM · Restricted Project, Restricted Project

Mon, Jan 4

thakis added a comment to D92296: [AARCH64] Improve accumulator forwarding for Cortex-A57 model.

Looks good, thanks for the quick fix :)

Mon, Jan 4, 5:26 AM · Restricted Project
thakis added a comment to D92296: [AARCH64] Improve accumulator forwarding for Cortex-A57 model.

Looks like this breaks tests on arm macs: http://45.33.8.238/macm1/1057/step_10.txt

Mon, Jan 4, 3:16 AM · Restricted Project

Sun, Jan 3

thakis added a comment to D93979: [clang-tidy] Fix windows tests.

Looks like this worked :)

Sun, Jan 3, 5:07 PM · Restricted Project
thakis accepted D93979: [clang-tidy] Fix windows tests.

I don't have a win machine at hand either, but let's land this and see what the win bot on http://45.33.8.238/ thinks about this. It should take at most 15 min to cycle.

Sun, Jan 3, 3:04 PM · Restricted Project

Sat, Jan 2

thakis added a reverting change for rGa92d01534f1c: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection…: rGfe9976c02c09: Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature….
Sat, Jan 2, 4:01 PM
thakis added a comment to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.

Reverted in fe9976c02c09f105751f787ec998abeb3414a235 for now. If you could wait with relanding during working hours, that'd be super appreciated. Thanks!

Sat, Jan 2, 4:01 PM · Restricted Project, Restricted Project
thakis added a reverting change for rG52d7e183bf25: [sanitizer] Include fstab.h on glibc/FreeBSD/NetBSD/macOS: rGfe9976c02c09: Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature….
Sat, Jan 2, 4:01 PM
thakis added a reverting change for rG34489da81b39: [sanitizer] Enable mallopt and mallinfo interceptors on Android after D93848: rGfe9976c02c09: Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature….
Sat, Jan 2, 4:01 PM
thakis added a reverting change for D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl: rGfe9976c02c09: Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature….
Sat, Jan 2, 4:01 PM · Restricted Project, Restricted Project
thakis added a reverting change for D93970: [sanitizer] Enable mallopt and mallinfo interceptors on Android after D93848: rGfe9976c02c09: Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature….
Sat, Jan 2, 4:01 PM · Restricted Project
thakis committed rGfe9976c02c09: Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature… (authored by thakis).
Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature…
Sat, Jan 2, 4:01 PM
thakis added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

Heads up: Breaks a test for us: https://bugs.chromium.org/p/chromium/issues/detail?id=1161542

(No reduced repro yet, might be UB, just fyi at this point.)

Thanks for headsup. For now i'll deal with the problem @nlopes pointed out above in a bit..

Sat, Jan 2, 8:14 AM · Restricted Project, Restricted Project

Fri, Jan 1

thakis committed rGb4c5e19da747: Temporarily disable to clang-tidy tests on Windows (authored by thakis).
Temporarily disable to clang-tidy tests on Windows
Fri, Jan 1, 8:20 PM
thakis committed rGc8dedfe269b1: fix typos to cycle bots (authored by thakis).
fix typos to cycle bots
Fri, Jan 1, 7:59 PM
thakis committed rG568824798f65: fix typo to cycle bots (authored by thakis).
fix typo to cycle bots
Fri, Jan 1, 7:28 PM
thakis committed rGfc3f53fcda1a: [gn build] (manually) port 5e31e226b5: Use Py3 for the build (authored by thakis).
[gn build] (manually) port 5e31e226b5: Use Py3 for the build
Fri, Jan 1, 7:14 PM

Wed, Dec 30

thakis committed rG8886be242de8: [lld/mac] Add -adhoc_codesign / -no_adhoc_codesign flags (authored by thakis).
[lld/mac] Add -adhoc_codesign / -no_adhoc_codesign flags
Wed, Dec 30, 6:01 PM
thakis committed rG51a292d99453: [gn build] Switch copy_bundle_data from pax to cpio (authored by thakis).
[gn build] Switch copy_bundle_data from pax to cpio
Wed, Dec 30, 10:59 AM

Tue, Dec 29

thakis added a comment to D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same.

Looks like this breaks tests on mac: http://45.33.8.238/macm1/897/step_10.txt

Tue, Dec 29, 4:55 PM · Restricted Project
thakis committed rGc1e85b6c1b4d: sanitizer: fix typo/spelling: Dissassemble → Disassemble (authored by stapelberg).
sanitizer: fix typo/spelling: Dissassemble → Disassemble
Tue, Dec 29, 9:28 AM
thakis closed D93902: sanitizer: fix typo/spelling: Dissassemble → Disassemble.
Tue, Dec 29, 9:27 AM · Restricted Project
thakis accepted D93902: sanitizer: fix typo/spelling: Dissassemble → Disassemble.
Tue, Dec 29, 9:27 AM · Restricted Project

Thu, Dec 24

thakis added a comment to D93682: [CodeGen] Add "noreturn" attirbute to _Unwind_Resume.

Looks like this breaks tests on arm64-apple-macos: http://45.33.8.238/macm1/761/step_10.txt

Thu, Dec 24, 4:16 AM · Restricted Project

Wed, Dec 23

thakis added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

Heads up: Breaks a test for us: https://bugs.chromium.org/p/chromium/issues/detail?id=1161542

Wed, Dec 23, 11:53 AM · Restricted Project, Restricted Project
thakis committed rG4c37453a04f9: clang: Build and run FrontendTests with CLANG_ENABLE_STATIC_ANALYZER=OFF too (authored by thakis).
clang: Build and run FrontendTests with CLANG_ENABLE_STATIC_ANALYZER=OFF too
Wed, Dec 23, 11:27 AM
thakis added a reverting change for rG70410a264949: [clang][cli] Let denormalizer decide how to render the option based on the…: rG1876a2914fe0: Revert more changes that landed on top of 741978d727.
Wed, Dec 23, 11:21 AM
thakis added a reverting change for rG63a24816f561: [clang][cli] Implement `getAllArgValues` marshalling: rG1876a2914fe0: Revert more changes that landed on top of 741978d727.
Wed, Dec 23, 11:21 AM
thakis committed rG1876a2914fe0: Revert more changes that landed on top of 741978d727 (authored by thakis).
Revert more changes that landed on top of 741978d727
Wed, Dec 23, 11:21 AM
thakis added a comment to D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

...and two more in 1876a2914fe0bedf50f7be6a305f5bf35493e496. Sorry for the churn!

Wed, Dec 23, 11:21 AM · Restricted Project, Restricted Project
thakis added a reverting change for D84189: [clang][cli] Let denormalizer decide how to render the option based on the option class: rG1876a2914fe0: Revert more changes that landed on top of 741978d727.
Wed, Dec 23, 11:21 AM · Restricted Project, Restricted Project
thakis added a reverting change for D93631: [clang][cli] Implement `getAllArgValues` marshalling: rG1876a2914fe0: Revert more changes that landed on top of 741978d727.
Wed, Dec 23, 11:21 AM · Restricted Project, Restricted Project
thakis added a reverting change for rG741978d727a4: [clang][cli] Port CodeGen option flags to new option parsing system: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM
thakis added a reverting change for rG383778e2171b: [clang][cli] Port LangOpts option flags to new option parsing system: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM
thakis added a reverting change for rGaec2991d083a: [clang][cli] Port LangOpts simple string based options to new option parsing…: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM
thakis added a reverting change for rG95d3cc67caac: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM
thakis added a reverting change for D83979: [clang][cli] Port LangOpts option flags to new option parsing system: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM · Restricted Project
thakis added a comment to D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

I reverted this (and a bunch of stuff that landed on top of it) in 7ad666798f12456d9e663e763e17e29007c3728d for now.

Wed, Dec 23, 9:59 AM · Restricted Project, Restricted Project
thakis added a reverting change for D84669: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM · Restricted Project
thakis added a reverting change for D84671: [clang][cli] Port LangOpts simple string based options to new option parsing system: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM · Restricted Project, Restricted Project
thakis added a reverting change for D83892: [clang][cli] Port CodeGen option flags to new option parsing system: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM · Restricted Project, Restricted Project
thakis added a reverting change for rG27b7d646886d: [clang][cli] Streamline MarshallingInfoFlag description: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM
thakis added a reverting change for D84675: [clang][cli] Streamline MarhsallingInfoFlag description: rG7ad666798f12: Revert 741978d727 and things that landed on top of it..
Wed, Dec 23, 9:59 AM · Restricted Project, Restricted Project
thakis committed rG7ad666798f12: Revert 741978d727 and things that landed on top of it. (authored by thakis).
Revert 741978d727 and things that landed on top of it.
Wed, Dec 23, 9:59 AM
thakis added a comment to D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

I verified it's due to this change. https://bugs.chromium.org/p/chromium/issues/detail?id=1161230#c15 has a stand-alone repro.

Wed, Dec 23, 9:36 AM · Restricted Project, Restricted Project
thakis added a comment to D83892: [clang][cli] Port CodeGen option flags to new option parsing system.

Heads-up: Looks like one of these changes, likely this one for CodeGen, made sanitizer output way larger: https://bugs.chromium.org/p/chromium/issues/detail?id=1161230

Wed, Dec 23, 7:51 AM · Restricted Project, Restricted Project
thakis added a comment to D93741: [lld-macho] Simulator & DriverKit executables should always be PIE.

(nit: Consider checking in obviously-behavior-preserving changes like stripping namespace prefixes without pre-commit review, and only send out the behavior-changing bits.)

Wed, Dec 23, 7:01 AM · Restricted Project
thakis accepted D93741: [lld-macho] Simulator & DriverKit executables should always be PIE.
Wed, Dec 23, 3:37 AM · Restricted Project

Tue, Dec 22

thakis committed rG77fb45e59e49: [lld/mac] Add --version flag (authored by thakis).
[lld/mac] Add --version flag
Tue, Dec 22, 7:07 PM
thakis closed D93491: [lld/mac] Add --version flag.
Tue, Dec 22, 7:07 PM · Restricted Project
thakis added a comment to D93491: [lld/mac] Add --version flag.

Thanks!

Tue, Dec 22, 7:05 PM · Restricted Project
thakis committed rG57ffbe020af6: glld/mac] Don't add names of unreferenced symbols to string table (authored by thakis).
glld/mac] Don't add names of unreferenced symbols to string table
Tue, Dec 22, 1:02 PM
thakis closed D93711: [lld/mac] Don't add names of unreferenced symbols to string table.
Tue, Dec 22, 1:02 PM · Restricted Project
thakis added a comment to D93711: [lld/mac] Don't add names of unreferenced symbols to string table.

Thanks!

Tue, Dec 22, 1:01 PM · Restricted Project
thakis added a comment to D91302: Handle template instantiations better in clang-tidy check.

Looks like this breaks tests on windows: http://45.33.8.238/win/30322/step_8.txt

Tue, Dec 22, 11:34 AM · Restricted Project
thakis updated the diff for D93491: [lld/mac] Add --version flag.

tweak -v help text

Tue, Dec 22, 9:07 AM · Restricted Project
thakis added a comment to D93491: [lld/mac] Add --version flag.

Thanks!

Tue, Dec 22, 9:06 AM · Restricted Project
Herald added a project to D33127: fix to swap all members in StringMapImpl::swap: Restricted Project.

I just found this and realized I missed it for a very long time. I tried adding a test case, but while doing so I think this change doesn't actually change behavior: StringMapImpl::swap is only used by StringMap<T>::operator=, which guarantees that lhs and rhs have the same T and the underlying StringMapImpls the same ItemSize for that reason.

Tue, Dec 22, 8:28 AM · Restricted Project
thakis requested review of D93711: [lld/mac] Don't add names of unreferenced symbols to string table.
Tue, Dec 22, 8:04 AM · Restricted Project
thakis added a reverting change for rG4d59c8fdb955: -fstack-clash-protection: Return an actual error when used on unsupported OS: rG00065d5cbd02: Revert "-fstack-clash-protection: Return an actual error when used on….
Tue, Dec 22, 3:52 AM
thakis committed rG00065d5cbd02: Revert "-fstack-clash-protection: Return an actual error when used on… (authored by thakis).
Revert "-fstack-clash-protection: Return an actual error when used on…
Tue, Dec 22, 3:52 AM
thakis added a reverting change for D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS: rG00065d5cbd02: Revert "-fstack-clash-protection: Return an actual error when used on….
Tue, Dec 22, 3:52 AM · Restricted Project, Restricted Project
thakis added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

reverted in 00065d5cbd02b0f3fccb34881b58bcd0852b3970

Tue, Dec 22, 3:52 AM · Restricted Project, Restricted Project
thakis added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

Also, rnk's comment above wasn't addressed as far as I can tell.

Tue, Dec 22, 3:51 AM · Restricted Project, Restricted Project
thakis added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

This seems to break all tests on all platforms: http://45.33.8.238/linux/35854/step_7.txt

Tue, Dec 22, 3:49 AM · Restricted Project, Restricted Project
thakis committed rG853770f24130: [gn build] (manually) port b8c37153d5393 (authored by thakis).
[gn build] (manually) port b8c37153d5393
Tue, Dec 22, 3:36 AM

Mon, Dec 21

thakis added a comment to D93609: [lld/mac] Implement support for private extern symbols.

Actual bench.py / ministat before/after data:

Mon, Dec 21, 6:47 PM · Restricted Project
thakis committed rG13f439a1872b: [lld/mac] Implement support for private extern symbols (authored by thakis).
[lld/mac] Implement support for private extern symbols
Mon, Dec 21, 6:26 PM
thakis closed D93609: [lld/mac] Implement support for private extern symbols.
Mon, Dec 21, 6:26 PM · Restricted Project