Page MenuHomePhabricator

thakis (Nico Weber)
UserEmail Not Verified

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (395 w, 5 d)

Recent Activity

Today

thakis added inline comments to D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+".
Wed, Aug 12, 9:40 AM · Restricted Project, Restricted Project

Mon, Aug 10

thakis added a comment to D85313: [DebugInfo] Don't error for zero-length arange entries.

I reverted this since it broke building obj2yaml on all bots, and the fix wasn't immediately clear to me. (We need to pass some warning handler, but I don't know which one's appropriate in obj2yaml.)

Mon, Aug 10, 5:21 AM · Restricted Project
thakis added a reverting change for rGcb3a598c87db: [DebugInfo] Don't error for zero-length arange entries: rGbc5d68dd8a17: Revert "[DebugInfo] Don't error for zero-length arange entries".
Mon, Aug 10, 5:21 AM
thakis committed rGbc5d68dd8a17: Revert "[DebugInfo] Don't error for zero-length arange entries" (authored by thakis).
Revert "[DebugInfo] Don't error for zero-length arange entries"
Mon, Aug 10, 5:21 AM
thakis added a reverting change for D85313: [DebugInfo] Don't error for zero-length arange entries: rGbc5d68dd8a17: Revert "[DebugInfo] Don't error for zero-length arange entries".
Mon, Aug 10, 5:21 AM · Restricted Project

Thu, Aug 6

thakis committed rGecbf2b3496cb: fix doc typo to cycle bots (authored by thakis).
fix doc typo to cycle bots
Thu, Aug 6, 6:03 PM
thakis committed rG92d58392975b: [gn build] mac: use frameworks instead of libs where appropriate (authored by markmentovai).
[gn build] mac: use frameworks instead of libs where appropriate
Thu, Aug 6, 4:00 PM
thakis closed D84219: [gn build] mac: use frameworks instead of libs where appropriate.
Thu, Aug 6, 3:59 PM · Restricted Project
thakis accepted D84219: [gn build] mac: use frameworks instead of libs where appropriate.

Thanks!

Thu, Aug 6, 3:40 PM · Restricted Project

Wed, Aug 5

thakis added a comment to D84219: [gn build] mac: use frameworks instead of libs where appropriate.

Fair enough, an assert seems ok then.

Wed, Aug 5, 7:23 PM · Restricted Project
thakis added a comment to D84610: [ELF] --icf: don't fold text sections with LSDA.

This probably breaks the build on systems where uint64_t and size_t are different types, such as apparently on macOS:

Wed, Aug 5, 4:45 PM · Restricted Project
thakis added a comment to D72904: [ELF] Allow SHF_LINK_ORDER sections to have sh_link=0.

This breaks tests on windows: http://45.33.8.238/win/21396/step_10.txt

Wed, Aug 5, 4:26 PM · Restricted Project
thakis added a reverting change for rG2ad56119f5dc: [gn build] (manually) port 10b1b4a23: rGcc2612185833: [gn build] (manually) merge 3ab01550b.
Wed, Aug 5, 5:56 AM
thakis added a reverting change for rG0bbaacc8cae0: [gn build] (manually) port 10b1b4a23 more: rGcc2612185833: [gn build] (manually) merge 3ab01550b.
Wed, Aug 5, 5:56 AM
thakis committed rGcc2612185833: [gn build] (manually) merge 3ab01550b (authored by thakis).
[gn build] (manually) merge 3ab01550b
Wed, Aug 5, 5:56 AM

Tue, Aug 4

thakis accepted D85228: [llvm-symbolizer] Add compatibility aliases for --inlining={true,false}.

Thanks!

Tue, Aug 4, 11:11 AM · Restricted Project
thakis committed rG6a4fd03698e1: [gn build] (manually) merge 593e1962 (authored by thakis).
[gn build] (manually) merge 593e1962
Tue, Aug 4, 10:06 AM

Sun, Aug 2

thakis added a comment to D83283: [Attributor] AAPotentialValues Interface.

If the fix is quick (< 15 min), you can fix too.

Sun, Aug 2, 6:08 AM · Restricted Project
thakis added a comment to D83283: [Attributor] AAPotentialValues Interface.

This causes:

Sun, Aug 2, 4:40 AM · Restricted Project

Fri, Jul 31

thakis committed rG2da9b44415ce: [gn build] (manually) merge 63d3aeb529 (authored by thakis).
[gn build] (manually) merge 63d3aeb529
Fri, Jul 31, 6:55 AM

Wed, Jul 29

thakis added a comment to D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`.

That did the trick, thanks!

Wed, Jul 29, 5:30 PM · Restricted Project, Restricted Project
thakis added a comment to D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`.

Looks like it's still failing with that change: http://45.33.8.238/win/20885/step_7.txt

Wed, Jul 29, 1:39 PM · Restricted Project, Restricted Project
thakis added a comment to D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`.

This breaks check-clang on Windows: http://45.33.8.238/win/20850/step_7.txt

Wed, Jul 29, 10:05 AM · Restricted Project, Restricted Project

Tue, Jul 28

thakis added a comment to D84486: [lld-macho] Support -filelist.

Looks like this breaks tests on win: http://45.33.8.238/win/20771/step_10.txt

Tue, Jul 28, 10:41 AM · Restricted Project

Mon, Jul 27

thakis committed rGb6902d977ac0: [gn build] Make syncing to single-line source files work after 1afd889d0b43 (authored by thakis).
[gn build] Make syncing to single-line source files work after 1afd889d0b43
Mon, Jul 27, 9:45 AM
thakis added inline comments to D83817: [clangd] Add option to use remote index as static index.
Mon, Jul 27, 9:34 AM · Restricted Project
thakis committed rG52dd18ab1d38: [gn build] (manually) merge 48c948abeb7 (authored by thakis).
[gn build] (manually) merge 48c948abeb7
Mon, Jul 27, 9:30 AM

Fri, Jul 24

thakis committed rG0bbaacc8cae0: [gn build] (manually) port 10b1b4a23 more (authored by thakis).
[gn build] (manually) port 10b1b4a23 more
Fri, Jul 24, 5:48 AM
thakis committed rG2ad56119f5dc: [gn build] (manually) port 10b1b4a23 (authored by thakis).
[gn build] (manually) port 10b1b4a23
Fri, Jul 24, 5:38 AM
thakis committed rG0ed660f9e574: [gn build] (manually) port 228f8d89 (authored by thakis).
[gn build] (manually) port 228f8d89
Fri, Jul 24, 5:29 AM

Thu, Jul 23

thakis committed rGab73b6da9575: [gn build] (manually) merge d054c7ee2e9 (authored by thakis).
[gn build] (manually) merge d054c7ee2e9
Thu, Jul 23, 7:28 PM
thakis added a comment to D83834: Add test utility 'split-file'.

It's maybe a bit surprising that we have both llvm-extract and extract that are unrelated binaries?

Thu, Jul 23, 7:27 PM · Restricted Project
thakis added inline comments to D84459: [llvm][NFC] Don't use llvm/Config/config.h in .h files.
Thu, Jul 23, 4:05 PM · Restricted Project
thakis added a comment to D84459: [llvm][NFC] Don't use llvm/Config/config.h in .h files.

I wouldn't worry about the Windows header. It's some pre-existing thing and nobody seems to care.

Thu, Jul 23, 4:05 PM · Restricted Project

Wed, Jul 22

thakis committed rGdfecad4ccfe6: [gn build] Remove something I missed in 1afd889d0 (authored by thakis).
[gn build] Remove something I missed in 1afd889d0
Wed, Jul 22, 1:36 PM
thakis accepted D84349: [llvm][NFC] Remove definition from build system of LLVM_HAVE_TF_AOT.

Thanks!

Wed, Jul 22, 11:14 AM · Restricted Project
thakis committed rGd074749423a7: [gn build] (manually) port 746b5fad5b (authored by thakis).
[gn build] (manually) port 746b5fad5b
Wed, Jul 22, 11:10 AM

Tue, Jul 21

thakis added a comment to D83592: [Coverage] Add comment to skipped regions.

Looks like this breaks tests on Windows: http://45.33.8.238/win/20315/step_7.txt

Tue, Jul 21, 6:41 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D83759: [clangd] Fixes in lit tests.

Looks like this breaks tests on macOS (and probably with non-gnu greps): http://45.33.8.238/mac/17611/step_9.txt

Tue, Jul 21, 1:06 PM · Restricted Project
thakis committed rG4fe912f1868c: Build: Move TF source file inclusion from build system to source files (authored by thakis).
Build: Move TF source file inclusion from build system to source files
Tue, Jul 21, 10:02 AM
thakis closed D84243: Build: Move TF source file inclusion from build system to source files.
Tue, Jul 21, 10:02 AM · Restricted Project
thakis added a comment to D84243: Build: Move TF source file inclusion from build system to source files.

Thanks!

Tue, Jul 21, 9:01 AM · Restricted Project
Herald added a project to D84243: Build: Move TF source file inclusion from build system to source files: Restricted Project.
Tue, Jul 21, 8:49 AM · Restricted Project
thakis added a comment to D84219: [gn build] mac: use frameworks instead of libs where appropriate.

Thanks for the patch!

Tue, Jul 21, 8:48 AM · Restricted Project
thakis added a comment to D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon .

We're seeing some build warnings in ffmpeg due to this not being in yet. Could you try to land it soon?

Tue, Jul 21, 7:18 AM · Restricted Project, Restricted Project
thakis committed rGe37b220442ec: [gn build] (manually) hack around 70f8d0ac8a3 (authored by thakis).
[gn build] (manually) hack around 70f8d0ac8a3
Tue, Jul 21, 3:36 AM

Fri, Jul 17

thakis accepted D83347: [ms] [llvm-ml] Add support for line continuations in MASM.
Fri, Jul 17, 12:07 PM · Restricted Project
thakis committed rG9551ae22fca6: [gn build] Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format` (authored by thakis).
[gn build] Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format`
Fri, Jul 17, 9:32 AM
thakis committed rG16458b5a6d62: [gn build] (manually) merge 6c43ed608 (authored by thakis).
[gn build] (manually) merge 6c43ed608
Fri, Jul 17, 9:27 AM
thakis committed rG1afd889d0b43: [gn build] Make sync_source_lists_from_cmake handle one-line sources lines (authored by thakis).
[gn build] Make sync_source_lists_from_cmake handle one-line sources lines
Fri, Jul 17, 8:54 AM
thakis committed rG63f0b10b8cef: [gn format] (manually) merge 6bddd099ac (authored by thakis).
[gn format] (manually) merge 6bddd099ac
Fri, Jul 17, 8:22 AM

Thu, Jul 16

thakis committed rG0beac5b815b3: [gn build] (manually) merge 9870f77441c (authored by thakis).
[gn build] (manually) merge 9870f77441c
Thu, Jul 16, 4:08 PM
thakis committed rG669b07093695: cmake list formatting fix (authored by thakis).
cmake list formatting fix
Thu, Jul 16, 3:30 PM
thakis committed rGd9b7a18ebdcf: [gn build] Fix merge script mishap (authored by thakis).
[gn build] Fix merge script mishap
Thu, Jul 16, 10:47 AM

Wed, Jul 15

thakis added a comment to D82702: [libc++] Use a proper CMake target to represent libc++ headers.

Is it ok to revert this then?

No.

The issue is that your builder builds with -DLIBCXX_ENABLE_SHARED=OFF -DLIBCXX_ENABLE_STATIC=OFF, but LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY is implicitly set to ON. In other words, you're trying to build the libc++ experimental library without building the static or the shared library. If you're trying to disable libc++ from the build, why include it in LLVM_ENABLE_PROJECTS?

Wed, Jul 15, 9:40 AM · Restricted Project

Tue, Jul 14

thakis committed rG75c0f0d762c8: [gn build] (manually) merge c1e2f73c (authored by thakis).
[gn build] (manually) merge c1e2f73c
Tue, Jul 14, 5:44 PM
Artem Dergachev <adergachev@apple.com> committed rG501ffc6b627c: [analyzer] Use IgnoreImpCasts() instead of reimplementing it. (authored by thakis).
[analyzer] Use IgnoreImpCasts() instead of reimplementing it.
Tue, Jul 14, 4:40 PM

Jul 13 2020

thakis added a comment to D83636: omp: Make OMP tablegen more like all other tablegens..

It puts the C++ code in C++ files :)

Jul 13 2020, 7:18 AM · Restricted Project

Jul 11 2020

thakis added a comment to D82930: [HIP] Fix rocm detection.

Great, thanks :)

Jul 11 2020, 7:36 PM · Restricted Project
thakis added inline comments to D83069: [lit] warn if explicitly specified test won't be run indirectly.
Jul 11 2020, 7:29 PM · Restricted Project
thakis accepted D83032: [utils] New script `check_ninja_deps.py`.
Jul 11 2020, 7:27 PM · Restricted Project
thakis added a comment to D83347: [ms] [llvm-ml] Add support for line continuations in MASM.

test?

Jul 11 2020, 7:25 PM · Restricted Project
thakis accepted D83346: [ms] [llvm-ml] Add support for MASM STRUCT casting field accessors: (<TYPE> PTR <value>).<field>.
Jul 11 2020, 7:24 PM · Restricted Project
thakis accepted D83345: [ms] [llvm-ml] Fix MASM support for nested unnamed STRUCTs and UNIONs.
Jul 11 2020, 7:23 PM · Restricted Project
thakis accepted D83344: [ms] [llvm-ml] Improve MASM STRUCT field accessor support.
Jul 11 2020, 7:19 PM · Restricted Project
thakis added a comment to D83636: omp: Make OMP tablegen more like all other tablegens..

As discussed a while ago in D81736. It's about half as much code.

Jul 11 2020, 7:17 PM · Restricted Project
Herald added a project to D83636: omp: Make OMP tablegen more like all other tablegens.: Restricted Project.
Jul 11 2020, 7:16 PM · Restricted Project
thakis added a comment to D82930: [HIP] Fix rocm detection.

…oh, njames said that already 5h ago :) I guess I'll wait another hour or two, and then I'll revert.

Jul 11 2020, 9:28 AM · Restricted Project
thakis added a comment to D82930: [HIP] Fix rocm detection.

This breaks check-clang on macOS: http://45.33.8.238/mac/17053/step_7.txt

Jul 11 2020, 9:27 AM · Restricted Project
thakis committed rG09a95f51fb1f: [gn build] (manually) merge 943660fd15f193 (authored by thakis).
[gn build] (manually) merge 943660fd15f193
Jul 11 2020, 3:45 AM

Jul 9 2020

thakis accepted D83479: [COFF] Error on unexpected .pdata size.

Nice!

Jul 9 2020, 8:49 AM · Restricted Project

Jul 8 2020

thakis added a comment to D83264: [ELF] Add -z dead-reloc-in-nonalloc=<section_glob>=<value>.

Cool. Could you check this in, please?

Jul 8 2020, 10:04 AM · Restricted Project

Jul 7 2020

thakis committed rGe885f336fd78: Revert "[X86] Add back the assert in getImpliedFeatures that I removed in… (authored by thakis).
Revert "[X86] Add back the assert in getImpliedFeatures that I removed in…
Jul 7 2020, 7:57 PM
thakis added a reverting change for rG91f70675cc6e: [X86] Add back the assert in getImpliedFeatures that I removed in…: rGe885f336fd78: Revert "[X86] Add back the assert in getImpliedFeatures that I removed in….
Jul 7 2020, 7:57 PM
thakis committed rGfe13ee875b10: [gn build] Port baca8f977ed (authored by thakis).
[gn build] Port baca8f977ed
Jul 7 2020, 7:29 PM
thakis accepted D83264: [ELF] Add -z dead-reloc-in-nonalloc=<section_glob>=<value>.

Thanks! Should the release notes grow an entry mentioning the behavior change and this flag?

Jul 7 2020, 5:17 PM · Restricted Project
thakis accepted D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support.
Jul 7 2020, 10:54 AM · Restricted Project
thakis accepted D83300: [GlobalOpt] Don't remove inalloca from musttail-called functions.
Jul 7 2020, 7:02 AM · Restricted Project

Jul 6 2020

thakis added inline comments to D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.
Jul 6 2020, 5:48 PM · Restricted Project
thakis committed rG003ea142205a: fix typos to cycle bots (authored by thakis).
fix typos to cycle bots
Jul 6 2020, 5:37 PM
thakis added a comment to D82828: [ELF] Don't resolve a relocation in .debug_line referencing an ICF folded symbol to the tombstone value.

Hello, this seems to increase runtime of some dwarf processing tools for us by several orders of magnitude (from "terminate in a few minutes" to "don't know how long they terminate; not before our timeouts"). https://bugs.chromium.org/p/chromium/issues/detail?id=1102223#c5 has repro steps.

Jul 6 2020, 2:03 PM · Restricted Project
thakis added a comment to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..

This seems to break tests everywhere, eg http://45.33.8.238/linux/22152/step_7.txt or
http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/11251

Jul 6 2020, 11:41 AM · Restricted Project

Jul 4 2020

thakis committed rG90a35bd074e2: [gn build] fix link of libclang_rt.asan_osx_dynamic.dylib if command line tools… (authored by thakis).
[gn build] fix link of libclang_rt.asan_osx_dynamic.dylib if command line tools…
Jul 4 2020, 5:51 PM
thakis committed rG7e2d27bc554e: Fix two -Wrange-loop-analysis warnings that Xcode 12 beta incorrectly complains… (authored by thakis).
Fix two -Wrange-loop-analysis warnings that Xcode 12 beta incorrectly complains…
Jul 4 2020, 5:51 PM
thakis committed rG05c5ff5ab0b4: [gn build] make stage2_unix_toolchain set clang_base_path (authored by thakis).
[gn build] make stage2_unix_toolchain set clang_base_path
Jul 4 2020, 4:47 PM

Jul 2 2020

thakis committed rG39f4b1c86eda: [gn build] get everything to build when llvm_targets_to_build is just AArch64 (authored by thakis).
[gn build] get everything to build when llvm_targets_to_build is just AArch64
Jul 2 2020, 4:14 PM
thakis committed rG425fb21e03b0: ld64.lld: Make janky support for tbd files actually work sometimes (authored by thakis).
ld64.lld: Make janky support for tbd files actually work sometimes
Jul 2 2020, 12:58 PM
thakis committed rG5416fc014ae5: [gn build] make building on an arm mac work (authored by thakis).
[gn build] make building on an arm mac work
Jul 2 2020, 11:53 AM

Jul 1 2020

thakis committed rGba5087f13025: ld64.lld: Add janky support for tbd files (authored by thakis).
ld64.lld: Add janky support for tbd files
Jul 1 2020, 9:11 PM
thakis committed rG7be1661fc6ed: lld/MachO: Remove a useless temporary (authored by thakis).
lld/MachO: Remove a useless temporary
Jul 1 2020, 9:11 PM
thakis committed rGac8d059c8e80: typo fixes to cycle bots (authored by thakis).
typo fixes to cycle bots
Jul 1 2020, 4:45 PM
thakis accepted D82992: clang CoverageMapping tests bot cleanup.
Jul 1 2020, 3:40 PM · Restricted Project
thakis added a comment to D82986: [Coroutines] Fix test breakage in D82928.

That's not enough, you also need to add an rm to remove the stale .LL file still on disk, see my comment on your original change.

Jul 1 2020, 2:04 PM · Restricted Project
thakis added inline comments to D82928: [Coroutines] Fix code coverage for coroutine.
Jul 1 2020, 12:59 PM · Restricted Project
thakis accepted D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

I think being compatible with ml64 by default is good, and making progress here seems better than holding this up for even longer.

Jul 1 2020, 7:33 AM · Restricted Project
thakis added a comment to D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers.

This (or a follow-up) broke tests on windows: http://45.33.8.238/win/18877/step_7.txt

Jul 1 2020, 3:44 AM · Restricted Project

Jun 30 2020

thakis added inline comments to D82410: [llvm-install-name-tool] Add -id option.
Jun 30 2020, 5:23 PM · Restricted Project
thakis committed rG679d101e7cbf: [gn build] (semi-manually) port ce6153a5282 (authored by thakis).
[gn build] (semi-manually) port ce6153a5282
Jun 30 2020, 4:51 PM
thakis accepted D82862: [ThinLTO] Always parse module level inline asm with At&t dialect.
Jun 30 2020, 7:33 AM · Restricted Project, Restricted Project

Jun 29 2020

thakis added a comment to D82606: [clangd] Config: config struct propagated through Context.

The test fails on mac and win:
http://45.33.8.238/mac/16341/step_9.txt
http://45.33.8.238/win/18704/step_9.txt

Jun 29 2020, 12:28 PM · Restricted Project