Page MenuHomePhabricator

[mlir] Updated SideEffect interface definitions to support tablegen Resource objects.
ClosedPublic

Authored by dfki-mako on Apr 27 2020, 4:53 AM.

Details

Summary

The SideEffect interface definitions currently use string expressions to reference custom resource objects. This CL introduces Resource objects in tablegen definitions to simplify linking of resource reference to resource objects.

Diff Detail

Event Timeline

dfki-mako created this revision.Apr 27 2020, 4:53 AM
dfki-mako added a project: Restricted Project.
dfki-mako edited the summary of this revision. (Show Details)
herhut accepted this revision.Apr 27 2020, 7:18 AM

I like the extra bit of structure, especially the DefaultResource is more readable than "". @rriddle created this, so wait for his approval.

This revision is now accepted and ready to land.Apr 27 2020, 7:18 AM

All right; let's wait for @rriddle's comments

This revision was automatically updated to reflect the committed changes.

Nice improvement!

All right; let's wait for @rriddle's comments

Did you get it?

@mehdi_amini Thanks a lot for your feedback. Unfortunately, I haven't received some comments from him.

@mehdi_amini Thanks a lot for your feedback. Unfortunately, I haven't received some comments from him.

From what I see above, this revision was not approved without these though? Why did this land?

@mehdi_amini Thanks a lot for your feedback. Unfortunately, I haven't received some comments from him.

From what I see above, this revision was not approved without these though? Why did this land?

We talked about this offline and decided to move forward with this change. We did not feel this was controversial and also easy to roll back in case there are comments later.

Resources in the current form are only temporary anyways, so i don't see a problem with this.