Page MenuHomePhabricator
People frgossen

frgossen (Frederik Gossen)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2020, 3:29 AM (41 w, 3 d)

Recent Activity
View All

Dec 15 2020

frgossen accepted D93313: [mlir] Add std.powf to ROCDL lowering..

Thanks!

Dec 15 2020, 9:29 AM · Restricted Project
frgossen accepted D93303: [mlir] Add NVVM lowering for std.pow.

Thanks!
Can you also add this for ROCM?
Can be a separate CL ofc.

Dec 15 2020, 8:38 AM · Restricted Project

Dec 14 2020

frgossen committed rG75d9a4609024: [MLIR] Add atan and atan2 lowerings to CUDA intrinsics (authored by frgossen).
[MLIR] Add atan and atan2 lowerings to CUDA intrinsics
Dec 14 2020, 1:46 AM
frgossen closed D93124: [MLIR] Add atan and atan2 lowerings to CUDA intrinsics.
Dec 14 2020, 1:45 AM · Restricted Project
frgossen committed rG1c6bc2c0b5af: [MLIR] Add lowerings for atan and atan2 to ROCDL intrinsics (authored by frgossen).
[MLIR] Add lowerings for atan and atan2 to ROCDL intrinsics
Dec 14 2020, 1:43 AM
frgossen closed D93123: [MLIR] Add lowerings for atan and atan2 to ROCDL intrinsics.
Dec 14 2020, 1:43 AM · Restricted Project

Dec 11 2020

frgossen updated the diff for D93123: [MLIR] Add lowerings for atan and atan2 to ROCDL intrinsics.

Add tests

Dec 11 2020, 9:00 AM · Restricted Project
frgossen added a reviewer for D93124: [MLIR] Add atan and atan2 lowerings to CUDA intrinsics: akuegel.
Dec 11 2020, 8:55 AM · Restricted Project
frgossen requested review of D93124: [MLIR] Add atan and atan2 lowerings to CUDA intrinsics.
Dec 11 2020, 8:55 AM · Restricted Project
frgossen added a reviewer for D93123: [MLIR] Add lowerings for atan and atan2 to ROCDL intrinsics: akuegel.
Dec 11 2020, 8:43 AM · Restricted Project
frgossen requested review of D93123: [MLIR] Add lowerings for atan and atan2 to ROCDL intrinsics.
Dec 11 2020, 8:42 AM · Restricted Project
frgossen accepted D93011: Add rsqrt lowering from standard to ROCDL..

Thanks!

Dec 11 2020, 4:04 AM · Restricted Project
frgossen accepted D93028: [mlir] Expose target configuration for lowering to ROCDL..

Thanks!

Dec 11 2020, 4:03 AM · Restricted Project

Dec 9 2020

frgossen accepted D92921: Add sqrt lowering from standard to ROCDL.
Dec 9 2020, 6:36 AM · Restricted Project
frgossen added a comment to D92921: Add sqrt lowering from standard to ROCDL.

Looks good. Thanks!
We probably want this for rsqrt, too.

Dec 9 2020, 6:36 AM · Restricted Project
frgossen added a comment to D92921: Add sqrt lowering from standard to ROCDL.

I saw the exact same failure and I'm pretty sure it is unrelated.

Dec 9 2020, 6:33 AM · Restricted Project
frgossen committed rGd53656900921: [MLIR] Expose target configuration for lowering to NVVM (authored by frgossen).
[MLIR] Expose target configuration for lowering to NVVM
Dec 9 2020, 1:30 AM
frgossen closed D92871: [MLIR] Expose target configuration for lowering to NVVM.
Dec 9 2020, 1:30 AM · Restricted Project

Dec 8 2020

frgossen added a reviewer for D92871: [MLIR] Expose target configuration for lowering to NVVM: pifon2a.
Dec 8 2020, 10:34 AM · Restricted Project
frgossen requested review of D92871: [MLIR] Expose target configuration for lowering to NVVM.
Dec 8 2020, 10:34 AM · Restricted Project
frgossen committed rGb4750f58d89f: Add sqrt lowering from standard to NVVM (authored by frgossen).
Add sqrt lowering from standard to NVVM
Dec 8 2020, 8:09 AM
frgossen closed D92850: Add sqrt lowering from standard to NVVM.
Dec 8 2020, 8:08 AM · Restricted Project
frgossen updated the diff for D92850: Add sqrt lowering from standard to NVVM.

Add test case

Dec 8 2020, 8:02 AM · Restricted Project
frgossen added reviewers for D92850: Add sqrt lowering from standard to NVVM: bkramer, pifon2a.
Dec 8 2020, 7:59 AM · Restricted Project
frgossen requested review of D92850: Add sqrt lowering from standard to NVVM.
Dec 8 2020, 7:58 AM · Restricted Project
frgossen committed rGbb7d43e7d5f6: Add rsqrt lowering from standard to NVVM (authored by frgossen).
Add rsqrt lowering from standard to NVVM
Dec 8 2020, 5:36 AM
frgossen closed D92838: Add rsqrt lowering from standard to NVVM.
Dec 8 2020, 5:36 AM · Restricted Project
frgossen added a reviewer for D92838: Add rsqrt lowering from standard to NVVM: pifon2a.
Dec 8 2020, 5:17 AM · Restricted Project
frgossen added a reviewer for D92838: Add rsqrt lowering from standard to NVVM: bkramer.
Dec 8 2020, 4:58 AM · Restricted Project
frgossen requested review of D92838: Add rsqrt lowering from standard to NVVM.
Dec 8 2020, 4:58 AM · Restricted Project

Nov 27 2020

frgossen committed rG6484567f1488: [MLIR][SCF] Find all innermost loops for parallel loop tiling (authored by frgossen).
[MLIR][SCF] Find all innermost loops for parallel loop tiling
Nov 27 2020, 1:41 AM
frgossen closed D92188: [MLIR][SCF] Find all innermost loops for parallel loop tiling.
Nov 27 2020, 1:41 AM · Restricted Project
frgossen retitled D92188: [MLIR][SCF] Find all innermost loops for parallel loop tiling from [MLIR][SCF] Find all innermost loops for prarallel loop tiling to [MLIR][SCF] Find all innermost loops for parallel loop tiling.
Nov 27 2020, 1:08 AM · Restricted Project
frgossen updated the diff for D92188: [MLIR][SCF] Find all innermost loops for parallel loop tiling.

Address comments

Nov 27 2020, 1:06 AM · Restricted Project

Nov 26 2020

frgossen requested review of D92188: [MLIR][SCF] Find all innermost loops for parallel loop tiling.
Nov 26 2020, 9:09 AM · Restricted Project
frgossen accepted D92032: [mlir][bufferize] Add argument materialization for bufferization.

Thanks!

Nov 26 2020, 4:35 AM · Restricted Project
frgossen accepted D92032: [mlir][bufferize] Add argument materialization for bufferization.

Sorry, I saw this only now.
Thank you!

Nov 26 2020, 2:08 AM · Restricted Project

Nov 24 2020

frgossen abandoned D82534: [MLIR][Shape] Lower `shape.size_eq` to the standard dialect.
Nov 24 2020, 5:08 AM · Restricted Project
frgossen abandoned D82531: [MLIR][Shape] Fold `shape.size_eq`.
Nov 24 2020, 5:08 AM · Restricted Project
frgossen abandoned D82628: [MLIR][Shape] Add `shape.size_eq` to the shape dialect.
Nov 24 2020, 5:08 AM · Restricted Project

Nov 23 2020

frgossen accepted D91070: [mlir] Add print functions for i64, index..
Nov 23 2020, 7:18 AM · Restricted Project

Nov 20 2020

frgossen accepted D91856: [mlir][std] Fold comparisons when the operands are equal.

Thanks!

Nov 20 2020, 2:54 AM · Restricted Project
frgossen accepted D91855: [mlir][std] Fold load(tensor_to_memref) into extract_element.

Thanks!

Nov 20 2020, 2:50 AM · Restricted Project
frgossen accepted D91854: [mlir][std] Canonicalize a dim(memref_reshape) into a load from the shape operand.

Thanks!

Nov 20 2020, 2:50 AM · Restricted Project

Nov 13 2020

frgossen added a comment to D85634: [MLIR][Standard] Fix cast materialization for incompatible types.

I believe this is still relevant as the FIXME is still present. The mlir-cuda-runner tests still fail.
@rriddle

Nov 13 2020, 6:23 AM · Restricted Project

Nov 5 2020

frgossen abandoned D90856: [MLIR] Fix missing namespaces in `mlir/unittests/TableGen/OpBuildGen.cpp`.

https://reviews.llvm.org/D90858

Nov 5 2020, 9:16 AM · Restricted Project
frgossen requested review of D90856: [MLIR] Fix missing namespaces in `mlir/unittests/TableGen/OpBuildGen.cpp`.
Nov 5 2020, 8:27 AM · Restricted Project

Nov 4 2020

frgossen committed rG1664462d70cc: [MLIR] Support walks over regions and blocks (authored by frgossen).
[MLIR] Support walks over regions and blocks
Nov 4 2020, 4:50 AM
frgossen closed D90753: [MLIR] Support walks over regions and blocks.
Nov 4 2020, 4:50 AM · Restricted Project
frgossen updated the summary of D90753: [MLIR] Support walks over regions and blocks.
Nov 4 2020, 4:48 AM · Restricted Project
frgossen added reviewers for D90753: [MLIR] Support walks over regions and blocks: stella.stamenova, bkramer.
Nov 4 2020, 3:03 AM · Restricted Project
frgossen requested review of D90753: [MLIR] Support walks over regions and blocks.
Nov 4 2020, 3:02 AM · Restricted Project

Nov 3 2020

frgossen added a comment to D90379: [MLIR] Support walks over regions and blocks.

Yes, I reverted it yesterday as it caused problems with the integrate. I will re-land this when I figure out how to install an old GCC version.

Nov 3 2020, 1:19 AM · Restricted Project

Nov 2 2020

frgossen added a reverting change for rGdbae3d50f114: [MLIR] Support walks over regions and blocks: rG327bf5c2d910: Revert "[MLIR] Support walks over regions and blocks".
Nov 2 2020, 8:22 AM
frgossen committed rG327bf5c2d910: Revert "[MLIR] Support walks over regions and blocks" (authored by frgossen).
Revert "[MLIR] Support walks over regions and blocks"
Nov 2 2020, 8:22 AM
frgossen added a reverting change for rG56299b1e58bf: [MLIR] Use `llvm::is_one_of` in walk templates: rG6b74a5aab11f: Revert "[MLIR] Use `llvm::is_one_of` in walk templates".
Nov 2 2020, 8:22 AM
frgossen added a reverting change for D90379: [MLIR] Support walks over regions and blocks: rG327bf5c2d910: Revert "[MLIR] Support walks over regions and blocks".
Nov 2 2020, 8:22 AM · Restricted Project
frgossen committed rG6b74a5aab11f: Revert "[MLIR] Use `llvm::is_one_of` in walk templates" (authored by frgossen).
Revert "[MLIR] Use `llvm::is_one_of` in walk templates"
Nov 2 2020, 8:22 AM
frgossen added a reverting change for D90449: [MLIR] Use `llvm::is_one_of` in walk templates: rG6b74a5aab11f: Revert "[MLIR] Use `llvm::is_one_of` in walk templates".
Nov 2 2020, 8:22 AM · Restricted Project
frgossen added a comment to D90379: [MLIR] Support walks over regions and blocks.

Unfortunately, I could not reproduce this failure,
I tried with gcc/g++ (Debian 10.2.0-9) 10.2.0.

Nov 2 2020, 2:09 AM · Restricted Project
frgossen accepted D90405: [mlir] Add shape.is_broadcastable..
Nov 2 2020, 1:32 AM · Restricted Project

Oct 30 2020

frgossen committed rG56299b1e58bf: [MLIR] Use `llvm::is_one_of` in walk templates (authored by frgossen).
[MLIR] Use `llvm::is_one_of` in walk templates
Oct 30 2020, 7:43 AM
frgossen closed D90449: [MLIR] Use `llvm::is_one_of` in walk templates.
Oct 30 2020, 7:43 AM · Restricted Project
frgossen added inline comments to D90379: [MLIR] Support walks over regions and blocks.
Oct 30 2020, 3:19 AM · Restricted Project
frgossen requested review of D90449: [MLIR] Use `llvm::is_one_of` in walk templates.
Oct 30 2020, 3:19 AM · Restricted Project

Oct 29 2020

frgossen accepted D90407: [mlir] Add lowering for IsBroadcastable to Std dialect..

Looks good!

Oct 29 2020, 10:04 AM · Restricted Project
frgossen accepted D90377: [mlir] Convert `memref_reshape` to LLVM..
Oct 29 2020, 8:59 AM · Restricted Project
frgossen committed rGdbae3d50f114: [MLIR] Support walks over regions and blocks (authored by frgossen).
[MLIR] Support walks over regions and blocks
Oct 29 2020, 7:35 AM
frgossen closed D90379: [MLIR] Support walks over regions and blocks.
Oct 29 2020, 7:34 AM · Restricted Project
frgossen added inline comments to D90379: [MLIR] Support walks over regions and blocks.
Oct 29 2020, 6:48 AM · Restricted Project
frgossen updated the diff for D90379: [MLIR] Support walks over regions and blocks.

Address comment

Oct 29 2020, 6:48 AM · Restricted Project
frgossen updated the diff for D90379: [MLIR] Support walks over regions and blocks.

Fix clang-tidy

Oct 29 2020, 6:18 AM · Restricted Project
frgossen requested review of D90379: [MLIR] Support walks over regions and blocks.
Oct 29 2020, 3:40 AM · Restricted Project
frgossen accepted D90375: [mlir] Reorder shape assuming bufferization..
Oct 29 2020, 3:06 AM · Restricted Project

Oct 28 2020

frgossen abandoned D90229: [MLIR] Define an order on `Value`s.

Thanks! Will do that

Oct 28 2020, 2:47 AM · Restricted Project

Oct 27 2020

frgossen accepted D90204: [mlir] Add bufferization for std.select op..
Oct 27 2020, 6:07 AM · Restricted Project
frgossen requested review of D90229: [MLIR] Define an order on `Value`s.
Oct 27 2020, 6:04 AM · Restricted Project

Oct 26 2020

frgossen accepted D90033: [mlir] Convert MemRefReinterpretCastOp to LLVM..
Oct 26 2020, 5:26 AM · Restricted Project
frgossen added a comment to D89902: [MLIR] Extract buffer alias analysis for reuse.
In D89902#2350128, @jpienaar wrote:

Is this change related to build breakage? (https://buildkite.com/mlir/mlir-core/builds/8813)

Oct 26 2020, 2:55 AM · Restricted Project

Oct 23 2020

frgossen committed rG8039b3f96680: [MLIR] Fix bad merge with buffer alias analysis. (authored by frgossen).
[MLIR] Fix bad merge with buffer alias analysis.
Oct 23 2020, 7:12 AM
frgossen committed rG6d83e3b44335: [MLIR] Extract buffer alias analysis for reuse (authored by frgossen).
[MLIR] Extract buffer alias analysis for reuse
Oct 23 2020, 6:24 AM
frgossen closed D89902: [MLIR] Extract buffer alias analysis for reuse.
Oct 23 2020, 6:24 AM · Restricted Project
frgossen updated the diff for D89902: [MLIR] Extract buffer alias analysis for reuse.

Rebase

Oct 23 2020, 6:20 AM · Restricted Project

Oct 21 2020

frgossen updated the diff for D89902: [MLIR] Extract buffer alias analysis for reuse.

Address comment

Oct 21 2020, 12:33 PM · Restricted Project
frgossen updated the diff for D89902: [MLIR] Extract buffer alias analysis for reuse.

Address comments

Oct 21 2020, 11:59 AM · Restricted Project
frgossen requested review of D89902: [MLIR] Extract buffer alias analysis for reuse.
Oct 21 2020, 11:19 AM · Restricted Project

Oct 19 2020

frgossen accepted D89594: [mlir] Add some more std bufferize patterns..
Oct 19 2020, 5:37 AM · Restricted Project

Sep 30 2020

frgossen committed rGcdda7822d6ce: [MLIR][Standard] Add `atan2` to standard dialect (authored by frgossen).
[MLIR][Standard] Add `atan2` to standard dialect
Sep 30 2020, 1:39 AM
frgossen closed D88168: [MLIR][Standard] Add `atan2` to standard dialect.
Sep 30 2020, 1:39 AM · Restricted Project

Sep 29 2020

frgossen updated the diff for D88168: [MLIR][Standard] Add `atan2` to standard dialect.

Address comments

Sep 29 2020, 3:27 AM · Restricted Project
frgossen added a reviewer for D88168: [MLIR][Standard] Add `atan2` to standard dialect: pifon2a.
Sep 29 2020, 12:38 AM · Restricted Project

Sep 28 2020

frgossen updated the diff for D88168: [MLIR][Standard] Add `atan2` to standard dialect.

Address comments

Sep 28 2020, 5:51 AM · Restricted Project
frgossen accepted D88258: [mlir][shape] Make conversion passes more consistent..

Thanks

Sep 28 2020, 5:29 AM · Restricted Project

Sep 24 2020

frgossen added a reviewer for D88168: [MLIR][Standard] Add `atan2` to standard dialect: ftynse.
Sep 24 2020, 5:02 AM · Restricted Project

Sep 23 2020

frgossen added a comment to D88168: [MLIR][Standard] Add `atan2` to standard dialect.

See https://llvm.discourse.group/t/standard-add-atan2-to-the-standard-dialect/1837

Sep 23 2020, 10:20 AM · Restricted Project
frgossen requested review of D88168: [MLIR][Standard] Add `atan2` to standard dialect.
Sep 23 2020, 10:19 AM · Restricted Project
frgossen added a comment to D88091: [MLIR][Standard] Add `atan` to standard dialect.

https://llvm.discourse.group/t/standard-add-atan2-to-the-standard-dialect/1837

Sep 23 2020, 6:27 AM · Restricted Project
frgossen added a comment to D88091: [MLIR][Standard] Add `atan` to standard dialect.

We do not intend to add a standard lowering for atan as there would be many possible approximations.
Like @bondhugula said, it helps us with the lowering from lmhlo to std where we can subsequently apply our approximation.
Sorry for the missing discussion on Discourse. Should I still post it?

Sep 23 2020, 2:16 AM · Restricted Project

Sep 22 2020

frgossen committed rGe952bb709ff7: [MLIR][Standard] Add `atan` to standard dialect (authored by frgossen).
[MLIR][Standard] Add `atan` to standard dialect
Sep 22 2020, 6:17 AM
frgossen closed D88091: [MLIR][Standard] Add `atan` to standard dialect.
Sep 22 2020, 6:17 AM · Restricted Project