Page MenuHomePhabricator

Kayjukh (Jean-Michel Gorius)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 31 2020, 3:33 AM (33 w, 6 d)

Recent Activity

Thu, Nov 12

Kayjukh committed rG62ed69b01d38: [clang][docs] Remove wrongly spaced \brief in Doxygen comment (NFC) (authored by Kayjukh).
[clang][docs] Remove wrongly spaced \brief in Doxygen comment (NFC)
Thu, Nov 12, 6:47 AM
Kayjukh committed rGe47805c99552: [mlir] Add plus, star and optional less/greater parsing (authored by Kayjukh).
[mlir] Add plus, star and optional less/greater parsing
Thu, Nov 12, 4:29 AM
Kayjukh closed D90907: [mlir] Add plus, star and optional less/greater parsing.
Thu, Nov 12, 4:29 AM · Restricted Project
Kayjukh updated the diff for D90907: [mlir] Add plus, star and optional less/greater parsing.

Add the missing tokens to the documentation and add question mark parsing functions

Thu, Nov 12, 4:25 AM · Restricted Project

Wed, Nov 11

Kayjukh updated the diff for D90907: [mlir] Add plus, star and optional less/greater parsing.

Add tests and rebase

Wed, Nov 11, 10:12 AM · Restricted Project

Fri, Nov 6

Kayjukh requested review of D90907: [mlir] Add plus, star and optional less/greater parsing.
Fri, Nov 6, 12:07 AM · Restricted Project

Mon, Oct 26

Kayjukh added inline comments to D89447: [MachineInstr] Add support for instructions with multiple memory operands..
Mon, Oct 26, 11:20 AM · Restricted Project

Oct 15 2020

Kayjukh updated subscribers of D89447: [MachineInstr] Add support for instructions with multiple memory operands..

This looks like the same as my old patch (https://reviews.llvm.org/D80161). There are additional details available on the commit's Phab page. To put it in a nutshell, some codes can trigger a very large amount of calls to the aliasing check (see the repro provided by @nemanjai: https://pastebin.com/tRtTQdSa), which results in a very large increase in compilation time.

Oct 15 2020, 1:20 AM · Restricted Project

Jul 1 2020

Kayjukh accepted D80860: Exact integer emptiness checks for FlatAffineConstraints.

Yes, sorry about blocking the revision. Note that there is still a clang-format issue in one of the files.

Jul 1 2020, 4:17 AM · Restricted Project, Restricted Project

Jun 26 2020

Kayjukh committed rG05b4ff0a4b1a: [mlir-tblgen] Use fully qualified names in generated code files (authored by Kayjukh).
[mlir-tblgen] Use fully qualified names in generated code files
Jun 26 2020, 6:31 AM
Kayjukh closed D82471: [mlir-tblgen] Use fully qualified names in generated code files.
Jun 26 2020, 6:31 AM · Restricted Project

Jun 25 2020

Kayjukh added a comment to D82471: [mlir-tblgen] Use fully qualified names in generated code files.

I'm wondering how hard it would be to have a linter check for TableGen files that reports whether there are lines longer than 80 characters. This could be useful for such situations: I had to change some locations in OpBase.td that went unnoticed during earlier reviews (e.g. the constBuilderCall for I32EnumAttr).

Jun 25 2020, 2:30 AM · Restricted Project
Kayjukh updated the diff for D82471: [mlir-tblgen] Use fully qualified names in generated code files.

Make sure that OpBase.td is wrapped at 80 characters.

Jun 25 2020, 2:09 AM · Restricted Project

Jun 24 2020

Kayjukh added a comment to D82471: [mlir-tblgen] Use fully qualified names in generated code files.

Not sure why clang-tidy complains about EnumsGenTest.h.inc here.

Jun 24 2020, 11:21 AM · Restricted Project
Kayjukh created D82471: [mlir-tblgen] Use fully qualified names in generated code files.
Jun 24 2020, 9:09 AM · Restricted Project

Jun 23 2020

Kayjukh committed rG1db1a08ddae6: [mlir] Avoid pontentially ambiguous class name (authored by Kayjukh).
[mlir] Avoid pontentially ambiguous class name
Jun 23 2020, 12:54 PM
Kayjukh closed D82371: [mlir] Avoid pontentially ambiguous class name.
Jun 23 2020, 12:54 PM · Restricted Project
Kayjukh added a comment to D82371: [mlir] Avoid pontentially ambiguous class name.

Yes, it's still in the mlir namespace. Moving it out of mlir would probably help, but I don't think there is enough coverage in it right now to have a meaningful impact. The issue fixed in this patch would not have been detected for example, since there are no custom passes in examples/standalone yet.

Jun 23 2020, 12:54 PM · Restricted Project
Kayjukh retitled D82336: [mlir] Added the dialect inliner to the SCF dialect from [mlir] Added the dailect inliner to the SCF dialect to [mlir] Added the dialect inliner to the SCF dialect.
Jun 23 2020, 5:49 AM · Restricted Project
Kayjukh created D82371: [mlir] Avoid pontentially ambiguous class name.
Jun 23 2020, 5:49 AM · Restricted Project

Jun 18 2020

Kayjukh added a comment to D82083: [MLIR][Shape] Canonicalize subsequent `size_to_index` and `index_to_size`.

nit: You may want to update the title before landing it

Jun 18 2020, 9:49 AM · Restricted Project
GitHub <noreply@github.com> committed rGb2f2adee003a: [llvm][docs] Document the LLVM_INSTALL_UTILS CMake option (NFC) (authored by Kayjukh).
[llvm][docs] Document the LLVM_INSTALL_UTILS CMake option (NFC)
Jun 18 2020, 7:03 AM
GitHub <noreply@github.com> committed rG8a82bc3ef356: [mlir] NFC: Fix link in traits documentation (authored by Kayjukh).
[mlir] NFC: Fix link in traits documentation
Jun 18 2020, 3:15 AM

Jun 5 2020

Kayjukh added a comment to D81283: [mlir] Fix a build error and a warning in mlir.

Maybe you could move to a slightly different directory structure and follow what other dialects are doing. Using a top-level CMakeLists.txt like

# lib/Dialect/Shape/CMakeLists.txt
add_subdirectory(IR)

and then add the dialect library generation directives in lib/Dialect/Shape/IR?
I think it would make sense to follow the same conventions as, say, the Linalg dialect.

Jun 5 2020, 3:10 PM · Restricted Project

Jun 2 2020

Kayjukh added a comment to D80860: Exact integer emptiness checks for FlatAffineConstraints.

It looks like there are clang-format errors (https://results.llvm-merge-guard.org/amd64_debian_testing_clang-1651/summary.html). Can you format your changes using git-clang-format HEAD^ and update the diff? This would allow us to have a clean build.

Jun 2 2020, 2:45 AM · Restricted Project, Restricted Project

Jun 1 2020

Kayjukh added a reviewer for D80860: Exact integer emptiness checks for FlatAffineConstraints: bondhugula.
Jun 1 2020, 11:18 AM · Restricted Project, Restricted Project
Kayjukh requested changes to D80860: Exact integer emptiness checks for FlatAffineConstraints.

Regarding the print and dump methods, I have no strong opinions. We may as well keep them as-is for now.
Simplex.cpp is apparently still using // for top-level comments.
Regarding the change to SmallVector instead of std::vector, it would probably make sense to use ArrayRef<T> for function parameters since it makes the API more flexible. If you need to mutate the parameter then I would suggest using SmallVectorImpl<T> instead of specifying the size of the internal buffer in the parameter type.

Jun 1 2020, 5:51 AM · Restricted Project, Restricted Project
Kayjukh added inline comments to D80860: Exact integer emptiness checks for FlatAffineConstraints.
Jun 1 2020, 3:09 AM · Restricted Project, Restricted Project

May 31 2020

Kayjukh requested changes to D80860: Exact integer emptiness checks for FlatAffineConstraints.

I added quite a lot of inline comments. To avoid redundancies for some of them, here are more general ones that apply to all the files:

  • Don't use Doxygen tags in your comments.
  • Use /// for top-level comments (e.g. outside of functions).
  • Prefer SmallVector over std::vector since the former can potentially be more efficient for small sizes.
  • Fraction and Matrix look like they are only ever used with int64_t elements. Is there a need for them to be template classes?
May 31 2020, 4:13 PM · Restricted Project, Restricted Project

May 28 2020

Kayjukh committed rGb0b2507717ca: [mlir] Add test to check if standalone dialect is registered (authored by marbre).
[mlir] Add test to check if standalone dialect is registered
May 28 2020, 4:00 PM
Kayjukh closed D80764: [mlir] Add test to check if standalone dialect is registered.
May 28 2020, 3:59 PM · Restricted Project
Kayjukh accepted D80764: [mlir] Add test to check if standalone dialect is registered.

LGTM

May 28 2020, 3:58 PM · Restricted Project
Kayjukh accepted D80737: [mlir] Extend standalone example by standalone-translate.

LGTM too, after adding the test case. Thanks!

May 28 2020, 12:38 PM · Restricted Project
Kayjukh added inline comments to D80737: [mlir] Extend standalone example by standalone-translate.
May 28 2020, 10:23 AM · Restricted Project
Kayjukh committed rGf5192d7fb756: [x86] Propagate memory operands during call frame optimization (authored by Kayjukh).
[x86] Propagate memory operands during call frame optimization
May 28 2020, 9:16 AM
Kayjukh closed D80062: [x86] Propagate memory operands during call frame optimization.
May 28 2020, 9:16 AM · Restricted Project
Kayjukh committed rGdb52a4901096: [mlir] Make translation libraries available through MLIRConfig.cmake (authored by Kayjukh).
[mlir] Make translation libraries available through MLIRConfig.cmake
May 28 2020, 8:44 AM
Kayjukh added a comment to D80497: Make mlir::Value's bool conversion operator explicit.

@ftynse This would suggest an update to this part of the docs then, right? https://llvm.org/docs/Phabricator.html#reviewing-code-with-phabricator

May 28 2020, 6:30 AM · Restricted Project

May 22 2020

Kayjukh committed rG65cd2c7a8015: Revert "[CodeGen] Add support for multiple memory operands in MachineInstr… (authored by Kayjukh).
Revert "[CodeGen] Add support for multiple memory operands in MachineInstr…
May 22 2020, 12:53 PM
Kayjukh added a reverting change for rG7019cea26dfe: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias: rG65cd2c7a8015: Revert "[CodeGen] Add support for multiple memory operands in MachineInstr….
May 22 2020, 12:53 PM
Kayjukh added a comment to rG7019cea26dfe: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

@nemanjai The changes were reverted by commit 65cd2c7a8015577fea15c861f41d2e4b5768961f.

May 22 2020, 12:52 PM
Kayjukh added a comment to rG7019cea26dfe: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Sure. I didn't realize it would cause such an overhead. If I remember correctly, some MachineInstr instances sometimes have duplicate memory operands for the same load or store.

May 22 2020, 12:52 PM

May 21 2020

Kayjukh committed rG7019cea26dfe: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias (authored by Kayjukh).
[CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias
May 21 2020, 2:07 PM
Kayjukh closed D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.
May 21 2020, 2:06 PM · Restricted Project
Kayjukh added a comment to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

@efriedma Thanks for your feedback! I had to make some minor adjustments to ARM test cases. If it's still good for you, I will land the patch.

May 21 2020, 1:33 PM · Restricted Project
Kayjukh updated the diff for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Update FileCheck directives in

llvm/test/CodeGen/ARM/cortex-a57-misched-vldm-wrback.ll
llvm/test/CodeGen/ARM/cortex-a57-misched-vstm-wrback.ll
llvm/test/CodeGen/ARM/cortex-a57-misched-vstm.ll

to avoid matching the new instruction scheduler debug output.

May 21 2020, 1:32 PM · Restricted Project
Kayjukh added a comment to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

On ARM specifically, operations don't usually more than one memoperand, with the exception of load store paired/multiple. So yes, I can see it would be hard to trigger outside of scheduling.

Maybe we could add some debug output to the scheduler showing when it does/does not add a dependency, and check that. So it would be checking scheduling, but not the final schedule.

May 21 2020, 11:53 AM · Restricted Project
Kayjukh updated the diff for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Add some debug output to the instruction sheduler to signal wether or not a chain dependency has been added between two given instructions. This change allows us to properly test the effect of handling multiple memory operands in alias queries on instruction scheduling.

May 21 2020, 11:53 AM · Restricted Project
Kayjukh committed rGb6917a86fbb5: [ADT][Analysis] NFC: Fix some more typos (authored by Kayjukh).
[ADT][Analysis] NFC: Fix some more typos
May 21 2020, 10:16 AM
Kayjukh committed rGcb2a8be8842a: [ADT] NFC: Fix typos in header comments (authored by Kayjukh).
[ADT] NFC: Fix typos in header comments
May 21 2020, 9:09 AM
Kayjukh committed rG439c8b2884a0: [x86] NFC: Fix typo in command line option description (authored by Kayjukh).
[x86] NFC: Fix typo in command line option description
May 21 2020, 8:04 AM

May 20 2020

Kayjukh updated the summary of D80062: [x86] Propagate memory operands during call frame optimization.
May 20 2020, 7:34 AM · Restricted Project
Kayjukh updated the diff for D80062: [x86] Propagate memory operands during call frame optimization.

Also propagate memory operands when folding non-MOV instructions. Add a test case.

May 20 2020, 7:34 AM · Restricted Project

May 19 2020

Kayjukh added a comment to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

I'd like to see an MIR test that shows the aliasing check actually working correctly.

I will have to find something that fits in a test case and covers this case. Working on it!

May 19 2020, 10:55 AM · Restricted Project
Kayjukh added a reviewer for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias: dmgreen.
May 19 2020, 5:22 AM · Restricted Project
Kayjukh updated the diff for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Simplify the method's control flow by wrapping the old dependency checking code in a helper lambda and calling it for each pair of memory operands.

May 19 2020, 5:22 AM · Restricted Project
Kayjukh added inline comments to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.
May 19 2020, 4:49 AM · Restricted Project
Kayjukh added a comment to D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

I'd like to see an MIR test that shows the aliasing check actually working correctly.

May 19 2020, 3:12 AM · Restricted Project

May 18 2020

Kayjukh updated the diff for D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.

Update instruction ordering in failing test cases.

May 18 2020, 5:22 PM · Restricted Project
Kayjukh created D80161: [CodeGen] Add support for multiple memory operands in MachineInstr::mayAlias.
May 18 2020, 2:07 PM · Restricted Project
Kayjukh committed rGcd12e79e6ddd: [x86] Propagate memory operands during ISel DAG postprocessing (authored by Kayjukh).
[x86] Propagate memory operands during ISel DAG postprocessing
May 18 2020, 1:01 PM
Kayjukh closed D80140: [x86] Propagate memory operands during ISel DAG postprocessing.
May 18 2020, 1:01 PM · Restricted Project
Kayjukh updated the diff for D80140: [x86] Propagate memory operands during ISel DAG postprocessing.

Add a test case.

May 18 2020, 11:21 AM · Restricted Project
Kayjukh added inline comments to D80113: [mlir] Support optional attributes in assembly formats.
May 18 2020, 11:21 AM · Restricted Project
Kayjukh added inline comments to D80113: [mlir] Support optional attributes in assembly formats.
May 18 2020, 10:13 AM · Restricted Project
Kayjukh added a reviewer for D80062: [x86] Propagate memory operands during call frame optimization: lebedev.ri.
May 18 2020, 10:13 AM · Restricted Project
Kayjukh updated the summary of D80062: [x86] Propagate memory operands during call frame optimization.
May 18 2020, 10:13 AM · Restricted Project
Kayjukh created D80140: [x86] Propagate memory operands during ISel DAG postprocessing.
May 18 2020, 10:13 AM · Restricted Project
Kayjukh updated the diff for D80062: [x86] Propagate memory operands during call frame optimization.

Split the call frame optimization patch from the ISel DAG postprocessing patch.

May 18 2020, 9:41 AM · Restricted Project
Kayjukh committed rGa4cb9bec1ca3: [mlir] Support optional attributes in assembly formats (authored by gysit).
[mlir] Support optional attributes in assembly formats
May 18 2020, 9:41 AM
Kayjukh closed D80113: [mlir] Support optional attributes in assembly formats.
May 18 2020, 9:41 AM · Restricted Project
Kayjukh accepted D80113: [mlir] Support optional attributes in assembly formats.

LGTM after fixing the use of curly braces.

May 18 2020, 9:40 AM · Restricted Project

May 16 2020

Kayjukh updated the diff for D80062: [x86] Propagate memory operands during call frame optimization.

Also propagate store memory operands during call frame optimization.

May 16 2020, 1:13 PM · Restricted Project
Kayjukh added inline comments to D80062: [x86] Propagate memory operands during call frame optimization.
May 16 2020, 1:13 PM · Restricted Project
Kayjukh added inline comments to D80062: [x86] Propagate memory operands during call frame optimization.
May 16 2020, 12:09 PM · Restricted Project
Kayjukh created D80062: [x86] Propagate memory operands during call frame optimization.
May 16 2020, 5:41 AM · Restricted Project

May 14 2020

Kayjukh accepted D79946: [mlir] Adopt changes in mlir-opt to standalone example.

LGTM, thanks!

May 14 2020, 9:10 AM · Restricted Project

May 5 2020

Kayjukh committed rG98b8b36d0009: [mlir][standalone] NFC: Update CMakeLists.txt to reflect best practices (authored by Kayjukh).
[mlir][standalone] NFC: Update CMakeLists.txt to reflect best practices
May 5 2020, 4:48 AM

Apr 28 2020

Kayjukh committed rGedb77864ef78: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with… (authored by maerhart).
[mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with…
Apr 28 2020, 9:39 AM
Kayjukh closed D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types.
Apr 28 2020, 9:39 AM · Restricted Project, Restricted Project
Kayjukh accepted D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types.
Apr 28 2020, 9:06 AM · Restricted Project, Restricted Project
Kayjukh added a comment to D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types.

nit: The commit message looks a little convoluted. Maybe you could simplify/structure it a little bit.
Otherwise, LGTM.

Apr 28 2020, 8:34 AM · Restricted Project, Restricted Project
Kayjukh added inline comments to D79004: [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types.
Apr 28 2020, 8:01 AM · Restricted Project, Restricted Project

Apr 24 2020

Kayjukh committed rG505685a67a77: [llvm][CodeGen] Check for memory instructions when querying for alias status (authored by Kayjukh).
[llvm][CodeGen] Check for memory instructions when querying for alias status
Apr 24 2020, 2:07 PM
Kayjukh closed D78823: [llvm][CodeGen] Check for memory instructions when querying for alias status.
Apr 24 2020, 2:07 PM · Restricted Project
Kayjukh added a comment to D78823: [llvm][CodeGen] Check for memory instructions when querying for alias status.

It is just a cleanup. I ran into an issue related to this missing check in an out-of-tree project.

Apr 24 2020, 1:33 PM · Restricted Project
Kayjukh created D78823: [llvm][CodeGen] Check for memory instructions when querying for alias status.
Apr 24 2020, 12:26 PM · Restricted Project

Apr 21 2020

Kayjukh committed rG585a0af3790a: [mlir][NFC] Fix typo in the standalone dialect README. (authored by Kayjukh).
[mlir][NFC] Fix typo in the standalone dialect README.
Apr 21 2020, 8:04 AM

Apr 7 2020

Kayjukh added a comment to D77643: Keep output file after successful execution of mlir-opt.

I think it would make sense to propagate the changes to mlir-opt as well.

The changes to mlir-opt.cpp propagate the change of the file-management to mlir-opt. Or did you refer to something else?

Apr 7 2020, 11:55 AM · Restricted Project
Kayjukh added inline comments to D77643: Keep output file after successful execution of mlir-opt.
Apr 7 2020, 11:55 AM · Restricted Project
Kayjukh added inline comments to D77643: Keep output file after successful execution of mlir-opt.
Apr 7 2020, 9:12 AM · Restricted Project
Kayjukh added a comment to D77643: Keep output file after successful execution of mlir-opt.

I think it would make sense to propagate the changes to mlir-opt as well.

Apr 7 2020, 9:12 AM · Restricted Project

Apr 6 2020

Kayjukh committed rGd3df2da4a94c: [mlir] Fix typo in docs/DefiningAttributesAndTypes.md (authored by Kayjukh).
[mlir] Fix typo in docs/DefiningAttributesAndTypes.md
Apr 6 2020, 10:52 AM

Apr 4 2020

Kayjukh added a comment to D77133: [mlir] Add an out-of-tree dialect example.

Thanks for taking the time to comment on this.

Apr 4 2020, 2:30 AM · Restricted Project

Apr 3 2020

Kayjukh added inline comments to D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 3:11 PM · Restricted Project
Kayjukh added inline comments to D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 10:15 AM · Restricted Project
Kayjukh accepted D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 8:02 AM · Restricted Project
Kayjukh updated the diff for D77133: [mlir] Add an out-of-tree dialect example.

Remove the using namespace directives in the standalone-opt source file. This follows standard coding guidelines and code styles of other out-of-tree MLIR projects.

Apr 3 2020, 8:02 AM · Restricted Project
Kayjukh accepted D77133: [mlir] Add an out-of-tree dialect example.
Apr 3 2020, 5:52 AM · Restricted Project
Kayjukh updated the diff for D77133: [mlir] Add an out-of-tree dialect example.

Minor update: remove unneeded braces at the end of the TableGen description for Standalone_Op.

Apr 3 2020, 2:39 AM · Restricted Project