Page MenuHomePhabricator

dfki-mako (Marcel Koester)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:29 AM (30 w, 3 d)

Recent Activity

Fri, Aug 7

dfki-mako retitled D85513: [mlir] WIP: Added support for loops in BufferPlacement transformation. from [mlir] Added support for loops in BufferPlacement transformation. to [mlir] WIP: Added support for loops in BufferPlacement transformation..
Fri, Aug 7, 3:39 AM · Restricted Project
dfki-mako requested review of D85513: [mlir] WIP: Added support for loops in BufferPlacement transformation..
Fri, Aug 7, 3:39 AM · Restricted Project

Jun 26 2020

dfki-mako added inline comments to D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Jun 26 2020, 4:52 AM · Restricted Project
dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Addressed reviewer comments.

Jun 26 2020, 4:51 AM · Restricted Project

Jun 25 2020

dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Added support for region-region control flow within operations that implement the RegionBranchOpInterface.
Added new test operations to verify more advanced region-region control-flow scenarios.

Jun 25 2020, 3:44 AM · Restricted Project

Jun 24 2020

dfki-mako retitled D81926: [mlir] Extended BufferPlacement to support nested region control flow. from [mlir] WIP: Extended BufferPlacement to support nested region control flow. to [mlir] Extended BufferPlacement to support nested region control flow..
Jun 24 2020, 4:16 AM · Restricted Project

Jun 23 2020

dfki-mako added inline comments to D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Jun 23 2020, 6:21 AM · Restricted Project
dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Refactored implementation and simplified the iteration over all successor regions.

Jun 23 2020, 6:21 AM · Restricted Project

Jun 19 2020

dfki-mako updated the diff for D81926: [mlir] Extended BufferPlacement to support nested region control flow..

Added extended support for the RegionOpInterface to query successor bindings for successor regions

Jun 19 2020, 5:53 AM · Restricted Project

Jun 17 2020

dfki-mako retitled D81926: [mlir] Extended BufferPlacement to support nested region control flow. from [mlir] Extended BufferPlacement to support nested region control flow. to [mlir] WIP: Extended BufferPlacement to support nested region control flow..
Jun 17 2020, 4:16 AM · Restricted Project

Jun 16 2020

dfki-mako added reviewers for D81926: [mlir] Extended BufferPlacement to support nested region control flow.: pifon2a, herhut.
Jun 16 2020, 4:23 AM · Restricted Project
dfki-mako created D81926: [mlir] Extended BufferPlacement to support nested region control flow..
Jun 16 2020, 4:23 AM · Restricted Project

Jun 15 2020

dfki-mako committed rG33879aa0bf00: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS. (authored by dfki-mako).
[mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS.
Jun 15 2020, 7:01 AM
dfki-mako closed D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 7:01 AM · Restricted Project
dfki-mako updated the diff for D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..

Refactored access to getSuccessorOperands to distinguish between read-only and write-enabled accesses.

Jun 15 2020, 6:28 AM · Restricted Project
dfki-mako added inline comments to D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 6:28 AM · Restricted Project
dfki-mako updated the diff for D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..

Added an additional comment and change to code to use the implicit OperandRange conversion operator.

Jun 15 2020, 5:24 AM · Restricted Project
dfki-mako updated the summary of D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 5:24 AM · Restricted Project
dfki-mako created D81839: [mlir] Fixed GCC compile issues and linking problems using SHARED_LIBS..
Jun 15 2020, 5:24 AM · Restricted Project
dfki-mako committed rGff4c51033766: [mlir] Extended BufferPlacement to support more sophisticated scenarios in… (authored by dfki-mako).
[mlir] Extended BufferPlacement to support more sophisticated scenarios in…
Jun 15 2020, 3:47 AM
dfki-mako closed D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
Jun 15 2020, 3:47 AM · Restricted Project, Restricted Project

Jun 9 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
Jun 9 2020, 3:15 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Resolved merge conflicts and integrated an additional test case into an existing one in order to capture an additional special case.

Jun 9 2020, 3:15 AM · Restricted Project, Restricted Project

Jun 3 2020

dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Updated processing of aliases to avoid the aggressive insertion of copy operations in special cases.
Reformatted test cases.

Jun 3 2020, 3:48 AM · Restricted Project, Restricted Project

May 27 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 27 2020, 4:17 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Fixed corner cases in which no copies have been created due to aliasing (see reviewer comments).
Added additional test cases to simulate such special control-flow scenarios.
Changed behavior of the BufferPlacement pass to ignore Alloc operations with multiple allocation results.

May 27 2020, 4:17 AM · Restricted Project, Restricted Project

May 20 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 20 2020, 1:02 AM · Restricted Project, Restricted Project

May 19 2020

dfki-mako added inline comments to D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 19 2020, 8:07 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..

Implemented a fix-point iteration to reduce the number of required copies.
Fixed minor issues (see review comments).

May 19 2020, 8:07 AM · Restricted Project, Restricted Project

May 18 2020

dfki-mako added a comment to D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..

@mehdi_amini Thanks a lot for your feedback. Unfortunately, I haven't received some comments from him.

May 18 2020, 1:01 AM · Restricted Project, Restricted Project

May 13 2020

dfki-mako committed rG881c3bb6a732: [mlir] Adapted standard Alloc and Alloca ops to use new side-effect resources. (authored by dfki-mako).
[mlir] Adapted standard Alloc and Alloca ops to use new side-effect resources.
May 13 2020, 5:22 AM
dfki-mako closed D79620: [mlir] Adapted standard Alloc and Alloca ops to use different side-effect resources..
May 13 2020, 5:21 AM · Restricted Project, Restricted Project
dfki-mako retitled D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow. from Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow. to [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 13 2020, 4:48 AM · Restricted Project, Restricted Project
dfki-mako created D79850: [mlir] Extended BufferPlacement to support more sophisticated scenarios in which allocations cannot be moved freely and can remain in divergent control flow..
May 13 2020, 4:48 AM · Restricted Project, Restricted Project

May 8 2020

dfki-mako created D79620: [mlir] Adapted standard Alloc and Alloca ops to use different side-effect resources..
May 8 2020, 1:34 AM · Restricted Project, Restricted Project
dfki-mako added reviewers for D79620: [mlir] Adapted standard Alloc and Alloca ops to use different side-effect resources.: rriddle, herhut, mehdi_amini.
May 8 2020, 1:34 AM · Restricted Project, Restricted Project
dfki-mako committed rG568787f81e07: [mlir] Updated SideEffect interface definitions to use tablegen Resource… (authored by dfki-mako).
[mlir] Updated SideEffect interface definitions to use tablegen Resource…
May 8 2020, 1:02 AM
dfki-mako closed D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..
May 8 2020, 1:01 AM · Restricted Project, Restricted Project

May 4 2020

dfki-mako committed rG67b466deda1d: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc. (authored by dfki-mako).
[mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc.
May 4 2020, 5:50 AM
dfki-mako closed D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..
May 4 2020, 5:50 AM · Restricted Project, Restricted Project

Apr 30 2020

dfki-mako added inline comments to D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..
Apr 30 2020, 7:55 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..

Addressed reviewer comments.

Apr 30 2020, 7:55 AM · Restricted Project, Restricted Project

Apr 29 2020

dfki-mako added a comment to D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..

All right; let's wait for @rriddle's comments

Apr 29 2020, 5:19 AM · Restricted Project, Restricted Project

Apr 28 2020

dfki-mako created D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..
Apr 28 2020, 4:15 AM · Restricted Project, Restricted Project
dfki-mako added reviewers for D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries.: mehdi_amini, herhut, pifon2a.
Apr 28 2020, 4:15 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries..

Removed todo comment.

Apr 28 2020, 4:15 AM · Restricted Project, Restricted Project
dfki-mako committed rG5c352e69e76a: Providing buffer assignment for MLIR (authored by dfki-ehna).
Providing buffer assignment for MLIR
Apr 28 2020, 1:35 AM
dfki-mako closed D78484: Providing buffer assignment for MLIR.
Apr 28 2020, 1:35 AM · Restricted Project, Restricted Project

Apr 27 2020

dfki-mako committed rG8e640ca5a838: [mlir] Fixed warning related to unused variable in Liveness. (authored by dfki-mako).
[mlir] Fixed warning related to unused variable in Liveness.
Apr 27 2020, 5:20 AM
dfki-mako closed D78912: [mlir] Fixed warning related to unused variable in Liveness..
Apr 27 2020, 5:20 AM · Restricted Project, Restricted Project
dfki-mako updated the summary of D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..
Apr 27 2020, 5:19 AM · Restricted Project, Restricted Project
dfki-mako added reviewers for D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects.: rriddle, herhut.
Apr 27 2020, 5:19 AM · Restricted Project, Restricted Project
dfki-mako created D78917: [mlir] Updated SideEffect interface definitions to support tablegen Resource objects..
Apr 27 2020, 5:19 AM · Restricted Project, Restricted Project
dfki-mako added a reviewer for D78912: [mlir] Fixed warning related to unused variable in Liveness.: herhut.
Apr 27 2020, 3:42 AM · Restricted Project, Restricted Project
dfki-mako created D78912: [mlir] Fixed warning related to unused variable in Liveness..
Apr 27 2020, 3:42 AM · Restricted Project, Restricted Project

Apr 23 2020

dfki-mako committed rGc79227cabb30: [mlir] Extended Liveness analysis to support nested regions. (authored by dfki-mako).
[mlir] Extended Liveness analysis to support nested regions.
Apr 23 2020, 7:34 AM
dfki-mako closed D77714: Extended Liveness analysis to support nested regions..
Apr 23 2020, 7:34 AM · Restricted Project, Restricted Project
dfki-mako added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 23 2020, 4:49 AM · Restricted Project, Restricted Project

Apr 22 2020

dfki-mako added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 22 2020, 4:49 AM · Restricted Project, Restricted Project
dfki-mako added inline comments to D78484: Providing buffer assignment for MLIR.
Apr 22 2020, 1:03 AM · Restricted Project, Restricted Project

Apr 21 2020

dfki-mako updated the diff for D77714: Extended Liveness analysis to support nested regions..

Reformatted and upated comments.

Apr 21 2020, 3:44 AM · Restricted Project, Restricted Project
dfki-mako added a project to D77714: Extended Liveness analysis to support nested regions.: Restricted Project.
Apr 21 2020, 2:07 AM · Restricted Project, Restricted Project

Apr 16 2020

dfki-mako added a comment to D77714: Extended Liveness analysis to support nested regions..

We have introduced a new utility function

Block *Region::findAncestorBlockInRegion(Block &block)

in order to remove the findInCurrent implementation.

Apr 16 2020, 5:36 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D77714: Extended Liveness analysis to support nested regions..

Applied comments and refactored findInCurrent functionality.

Apr 16 2020, 5:36 AM · Restricted Project, Restricted Project

Apr 15 2020

dfki-mako added inline comments to D77714: Extended Liveness analysis to support nested regions..
Apr 15 2020, 4:20 AM · Restricted Project, Restricted Project

Apr 9 2020

dfki-mako updated the diff for D77714: Extended Liveness analysis to support nested regions..

Applied comments and adapted test cases.

Apr 9 2020, 3:45 AM · Restricted Project, Restricted Project

Apr 8 2020

dfki-mako added reviewers for D77714: Extended Liveness analysis to support nested regions.: rriddle, herhut.
Apr 8 2020, 3:44 AM · Restricted Project, Restricted Project
dfki-mako updated the diff for D77714: Extended Liveness analysis to support nested regions..

Addressed formatting issues introduced by clang-format-6.

Apr 8 2020, 3:44 AM · Restricted Project, Restricted Project
dfki-mako created D77714: Extended Liveness analysis to support nested regions..
Apr 8 2020, 2:07 AM · Restricted Project, Restricted Project

Mar 27 2020

dfki-mako committed rG86bbbb317bce: [mlir] Extended Dominance analysis with a function to find the nearest common… (authored by dfki-mako).
[mlir] Extended Dominance analysis with a function to find the nearest common…
Mar 27 2020, 7:04 AM
dfki-mako closed D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..
Mar 27 2020, 7:04 AM · Restricted Project

Mar 25 2020

dfki-mako committed rG2b529a396d73: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no… (authored by dfki-mako).
[mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no…
Mar 25 2020, 9:11 AM
dfki-mako closed D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM..
Mar 25 2020, 9:10 AM · Restricted Project, Restricted Project

Mar 17 2020

dfki-mako updated the diff for D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM..

Removed unused filterIllegalLLVMIntrinsics function.

Mar 17 2020, 6:52 AM · Restricted Project, Restricted Project

Mar 9 2020

dfki-mako updated the diff for D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..

Fixed missing "be" in comment and changed output to "Nearest(x, y) = z".

Mar 9 2020, 9:08 AM · Restricted Project
dfki-mako updated the diff for D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..

Fixed invalid comment in TestDominance.cpp.

Mar 9 2020, 2:39 AM · Restricted Project

Mar 6 2020

dfki-mako updated the diff for D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..

Added support for nested regions.
Added test cases for dominance information.

Mar 6 2020, 4:24 AM · Restricted Project

Mar 3 2020

dfki-mako updated subscribers of D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..

@herhut Regarding your example that one block is in a nested region of the second block: you are right that you will not get the nearest common dominator in this case. In order to add support for these cases, we will have to check whether one region is nested into the other one. May we use the 'isProperAncestor' function to check whether a is nested into b or vice versa?

Mar 3 2020, 4:35 AM · Restricted Project
dfki-mako updated the diff for D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..

Fixed invalid indentation that was caused by automatic post-commit formatters.

Mar 3 2020, 2:37 AM · Restricted Project
dfki-mako created D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM..
Mar 3 2020, 2:11 AM · Restricted Project, Restricted Project
dfki-mako created D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks..
Mar 3 2020, 1:43 AM · Restricted Project