This is an archive of the discontinued LLVM Phabricator instance.

Move StandardOps/Ops.h to StandardOps/IR/Ops.h
ClosedPublic

Authored by rsuderman on Feb 20 2020, 5:50 PM.

Details

Summary

NFC - Moved StandardOps/Ops.h to a StandardOps/IR dir to better match surrounding
directories. This is to match other dialects, and prepare for moving StandardOps
related transforms in out for Transforms and into StandardOps/Transforms.

Diff Detail

Event Timeline

rsuderman created this revision.Feb 20 2020, 5:50 PM
rsuderman updated this revision to Diff 245776.Feb 20 2020, 5:54 PM

Missed CMakeLists.txt file for StandardOps folder.

mehdi_amini accepted this revision.Feb 20 2020, 6:16 PM

Thanks!

Can you use arc for your patch? I think the presubmit test don't seem to fire because of this.
(also "NFC" in commit title is nice to add to set expectations for reviewers)

This revision is now accepted and ready to land.Feb 20 2020, 6:16 PM
rsuderman edited the summary of this revision. (Show Details)Feb 20 2020, 6:17 PM
rriddle accepted this revision.Feb 20 2020, 6:18 PM

Awesome! Thank you for doing this!

mlir/include/mlir/Dialect/StandardOps/IR/Ops.h
13–14

Can you update this please?

Updated StandardOps/IR/Ops.h header guard

Updated header guard for new file location.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2020, 10:48 AM

(quickly correct place of _IR_)

rsuderman marked an inline comment as done.Feb 21 2020, 10:53 AM

Build failure is an unrelated clang-tidy error.

Rebase at head.

Fixed rebase build error.

This revision was automatically updated to reflect the committed changes.