- User Since
- Apr 23 2014, 2:13 AM (352 w, 5 d)
Wed, Jan 20
Wed, Jan 13
Re-base patch and fix lit test failures.
Dec 19 2020
Dec 12 2020
Dec 10 2020
Dec 9 2020
@tstellar, are you okay with the change?
Please, let us know if you have any additional questions.
Dec 8 2020
Fix clang-format issues.
Dec 7 2020
Move CodeGen crash fix to a separate review request: https://reviews.llvm.org/D92782
Dec 3 2020
Apply code review comment from @rjmccall
Nov 30 2020
I didn't sense any agreement or any sort of a conclusion on the RFC. Moreover, I didn't feel at all that the existing address space attribute was a good fit. I was suggesting to add a different attribute that isn't an address space attribute from Embedded C. I don't understand what you gain from the existing address space attribute at the moment.
Nov 24 2020
@etyurin, let me know when it's ready for commit.
I also suggest using CMake's ExternalProject_Add command to checkout sources instead of running a set of execute_process commands.
Nov 18 2020
Did anyone conclude there that the language address spaces should be added for SYCL? I can't see any of this. In fact I don't even think there was any conclusion on the RFC. You should first make your design clear and agreed before going ahead with the implementation. I personally still think that address space AST attribute is not the right path for SYCL. And I haven't seen any evidence that it is the best solution to what you are trying to achieve.
Nov 13 2020
Upload full patch after removing sycl_constant address space attribute support.
Remove support for sycl_constant address space attribute.
Nov 11 2020
Oct 26 2020
Oct 21 2020
Alternative approach with SYCL specific semantic attributes - https://reviews.llvm.org/D89909.
Sep 29 2020
Applied Ronan's suggestion.
Sep 28 2020
You might need add [OpenCL] tag to the commit message.
I'm okay with this change in general. One note though.
Sep 8 2020
Jul 29 2020
Jun 26 2020
Jun 17 2020
Jun 9 2020
Jun 5 2020
Jun 3 2020
Jun 1 2020
May 30 2020
May 29 2020
May 22 2020
May 21 2020
Fix formatting in clang/test/Sema/address_spaces.c
- Added C test case with address_space attribute.
- Move isAddressSpaceOverlapping from PointerType to QualType.
- Move C++ test case to clang/test/SemaCXX
Thanks for the review.
I've enabled the diagnostics for all the modes.
I also applied the refactoring suggested by @rjmccall. Hopefully I understand it correctly.
Enable diagnostics for non-OpenCL modes and applied refactoring proposed by John.
May 20 2020
Apr 2 2020
Mar 24 2020
Mar 12 2020
Mar 7 2020
Mar 1 2020
Feb 27 2020
Feb 22 2020
Any other comments?
Feb 20 2020
Feb 19 2020
Rebase to ToT and address comments from Ronan.
Feb 18 2020
Address comments from Victor and Alexey.
Feb 17 2020
Feb 11 2020
Applied review commits from Alexey.
Feb 7 2020
Applied code review comments.
Feb 6 2020
Ignore -sycl-std if it used in non-SYCL mode.
Applied Alexey's comments.
Applied suggestions from Alexey and Ruyman and rebased on ToT.