This is an archive of the discontinued LLVM Phabricator instance.

Refactor: Simplify boolean conditional return statements in lib/Transforms/ObjCARC
ClosedPublic

Authored by LegalizeAdulthood on May 25 2015, 11:15 AM.

Reviewers

Commits

Summary

Use clang-tidy to simplify boolean conditional return statements

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean conditional return statements in lib/Transforms/ObjCARC.

LegalizeAdulthood updated this object.

LegalizeAdulthood edited the test plan for this revision. (Show Details)

LegalizeAdulthood added a subscriber: Unknown Object (MLST).

Update to latest

LGTM.

This revision is now accepted and ready to land.Oct 24 2015, 2:51 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Transforms/

ObjCARC/

5 lines

Show First 20 Lines • Show All 2,004 Lines • ▼ Show 20 Lines	HasSafePathToPredecessorCall(const Value Arg, Instruction Retain,
auto Call = dyn_cast_or_null<CallInst>(DepInsts.begin());		auto Call = dyn_cast_or_null<CallInst>(DepInsts.begin());

// Check that the pointer is the return value of the call.		// Check that the pointer is the return value of the call.
if (!Call \|\| Arg != Call)		if (!Call \|\| Arg != Call)
return false;		return false;

// Check that the call is a regular call.		// Check that the call is a regular call.
ARCInstKind Class = GetBasicARCInstKind(Call);		ARCInstKind Class = GetBasicARCInstKind(Call);
if (Class != ARCInstKind::CallOrUser && Class != ARCInstKind::Call)		return Class == ARCInstKind::CallOrUser \|\| Class == ARCInstKind::Call;
return false;

return true;
}		}

/// Find a dependent retain that precedes the given autorelease for which there		/// Find a dependent retain that precedes the given autorelease for which there
/// is nothing in between the two instructions that can affect the ref count of		/// is nothing in between the two instructions that can affect the ref count of
/// Arg.		/// Arg.
static CallInst *		static CallInst *
FindPredecessorRetainWithSafePath(const Value Arg, BasicBlock BB,		FindPredecessorRetainWithSafePath(const Value Arg, BasicBlock BB,
Instruction *Autorelease,		Instruction *Autorelease,
▲ Show 20 Lines • Show All 225 Lines • Show Last 20 Lines