Page MenuHomePhabricator

[WebAssembly] Improve error messages regarding missing indirect function table. NFC

Authored by sbc100 on Apr 6 2021, 8:09 AM.



Use report_fatal_error here since this is an internal error, and not
something the user can/should be trying to fix.

Also distinguish between the symbol being missing and the symbol having
the wrong type.

We have a failure internally where the symbol is missing. Currently
trying to reduce the test case to something we can attach to an llvm

Diff Detail

Unit TestsFailed

1,070 msx64 debian > libomp.lock::omp_init_lock.c
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/lock/omp_init_lock.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/lock/Output/omp_init_lock.c.tmp -lm -latomic && /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/lock/Output/omp_init_lock.c.tmp

Event Timeline

sbc100 created this revision.Apr 6 2021, 8:09 AM
sbc100 requested review of this revision.Apr 6 2021, 8:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2021, 8:09 AM
sbc100 added a reviewer: wingo.Apr 6 2021, 8:10 AM
wingo accepted this revision.Apr 7 2021, 12:42 AM
This revision is now accepted and ready to land.Apr 7 2021, 12:42 AM