This is an archive of the discontinued LLVM Phabricator instance.

Differential D99858

[lit testing] Fix xfail-cl.py test worker count
ClosedPublic

Authored by luismarques on Apr 4 2021, 3:06 AM.

Details

Reviewers
davezarzycki
asb
Commits
rGb09df246cad9: [lit testing] Fix xfail-cl.py test worker count
Summary

This would fail in test environments with < 3 hardware threads.

Diff Detail

Unit TestsFailed

TimeTest
820 msx64 debian > libomp.lock::omp_init_lock.c

Event Timeline

luismarques created this revision.Apr 4 2021, 3:06 AM
Herald added a subscriber: delcypher. · View Herald TranscriptApr 4 2021, 3:06 AM
luismarques requested review of this revision.Apr 4 2021, 3:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2021, 3:06 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B97039: Diff 335139.Apr 4 2021, 3:59 AM
davezarzycki accepted this revision.Apr 6 2021, 2:08 AM

Good catch! Thanks

This revision is now accepted and ready to land.Apr 6 2021, 2:08 AM
This revision was landed with ongoing or failed builds.Apr 6 2021, 12:48 PM
Closed by commit rGb09df246cad9: [lit testing] Fix xfail-cl.py test worker count (authored by luismarques). · Explain Why
This revision was automatically updated to reflect the committed changes.
luismarques added a commit: rGb09df246cad9: [lit testing] Fix xfail-cl.py test worker count.

Revision Contents

PathSize
llvm/
utils/
lit/
tests/
2 lines

Diff 335139

llvm/utils/lit/tests/xfail-cl.py

# Check that regex-XFAILing works and can be configured via env var. # Check that regex-XFAILing works and can be configured via env var.
# #
# RUN: %{lit} --xfail 'false.txt;false2.txt' %{inputs}/xfail-cl | FileCheck --check-prefix=CHECK-FILTER %s # RUN: %{lit} --xfail 'false.txt;false2.txt' %{inputs}/xfail-cl | FileCheck --check-prefix=CHECK-FILTER %s
# RUN: env LIT_XFAIL='false.txt;false2.txt' %{lit} %{inputs}/xfail-cl | FileCheck --check-prefix=CHECK-FILTER %s # RUN: env LIT_XFAIL='false.txt;false2.txt' %{lit} %{inputs}/xfail-cl | FileCheck --check-prefix=CHECK-FILTER %s
# END. # END.
# CHECK-FILTER: Testing: 3 tests, 3 workers # CHECK-FILTER: Testing: 3 tests, {{[1-3]}} workers
# CHECK-FILTER-DAG: XFAIL: top-level-suite :: false.txt # CHECK-FILTER-DAG: XFAIL: top-level-suite :: false.txt
# CHECK-FILTER-DAG: XFAIL: top-level-suite :: false2.txt # CHECK-FILTER-DAG: XFAIL: top-level-suite :: false2.txt
# CHECK-FILTER-DAG: PASS: top-level-suite :: true.txt # CHECK-FILTER-DAG: PASS: top-level-suite :: true.txt