This is an archive of the discontinued LLVM Phabricator instance.

Differential D99838

[C++20, test] Fix use of undef FileCheck variable
ClosedPublic

Authored by thopre on Apr 3 2021, 6:54 AM.

Details

Reviewers
rsmith
EricWF
akhuang
• Quuxplusone
Commits
rG1cc9d949a123: [C++20, test] Fix use of undef FileCheck variable
Summary

Commit f495de43bd5da50286da6020e508d106cfc60f57 forgot two lines when
removing checks for strong and weak equality, resulting in the use of an
undefined FileCheck variable.

Diff Detail

Event Timeline

thopre requested review of this revision.Apr 3 2021, 6:54 AM
thopre created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2021, 6:54 AM
• Quuxplusone accepted this revision.Apr 3 2021, 6:56 AM
This revision is now accepted and ready to land.Apr 3 2021, 6:56 AM
Harbormaster completed remote builds in B96994: Diff 335087.Apr 3 2021, 7:30 AM
Closed by commit rG1cc9d949a123: [C++20, test] Fix use of undef FileCheck variable (authored by thopre). · Explain WhyApr 3 2021, 4:05 PM
This revision was automatically updated to reflect the committed changes.
thopre added a commit: rG1cc9d949a123: [C++20, test] Fix use of undef FileCheck variable.

Revision Contents

PathSize
clang/
test/
CodeGenCXX/
2 lines

Diff 335114

clang/test/CodeGenCXX/cxx2a-compare.cpp

// RUN: %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %itanium_abi_triple | \ // RUN: %clang_cc1 -std=c++2a -emit-llvm %s -o - -triple %itanium_abi_triple | \
// RUN: FileCheck %s \ // RUN: FileCheck %s \
// RUN: '-DSO="class.std::__1::strong_ordering"' \ // RUN: '-DSO="class.std::__1::strong_ordering"' \
// RUN: '-DPO="class.std::__1::partial_ordering"' \ // RUN: '-DPO="class.std::__1::partial_ordering"' \
// RUN: -DEQ=0 -DLT=-1 -DGT=1 -DUNORD=-127 -DNE=1 // RUN: -DEQ=0 -DLT=-1 -DGT=1 -DUNORD=-127 -DNE=1
#include "Inputs/std-compare.h" #include "Inputs/std-compare.h"
// Ensure we don't emit definitions for the global variables // Ensure we don't emit definitions for the global variables
// since the builtins shouldn't ODR use them. // since the builtins shouldn't ODR use them.
// CHECK-NOT: constant %[[SO]] // CHECK-NOT: constant %[[SO]]
// CHECK-NOT: constant %[[SE]]
// CHECK-NOT: constant %[[WE]]
// CHECK-NOT: constant %[[PO]] // CHECK-NOT: constant %[[PO]]
// CHECK-LABEL: @_Z11test_signedii // CHECK-LABEL: @_Z11test_signedii
auto test_signed(int x, int y) { auto test_signed(int x, int y) {
// CHECK: %[[DEST:retval|agg.result]] // CHECK: %[[DEST:retval|agg.result]]
// CHECK: %cmp.lt = icmp slt i32 %{{.+}}, %{{.+}} // CHECK: %cmp.lt = icmp slt i32 %{{.+}}, %{{.+}}
// CHECK: %sel.lt = select i1 %cmp.lt, i8 [[LT]], i8 [[GT]] // CHECK: %sel.lt = select i1 %cmp.lt, i8 [[LT]], i8 [[GT]]
// CHECK: %cmp.eq = icmp eq i32 %{{.+}}, %{{.+}} // CHECK: %cmp.eq = icmp eq i32 %{{.+}}, %{{.+}}
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines