This is an archive of the discontinued LLVM Phabricator instance.

Differential D99835

[flang][MSVC] Fix compilation of external-hello-world test with MSVC.
AbandonedPublic

Authored by MehdiChinoune on Apr 3 2021, 4:03 AM.

Details

Reviewers
Meinersbur
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

MehdiChinoune created this revision.Apr 3 2021, 4:03 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptApr 3 2021, 4:03 AM
MehdiChinoune requested review of this revision.Apr 3 2021, 4:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2021, 4:03 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B96989: Diff 335080.Apr 3 2021, 4:31 AM
Meinersbur added a comment.Apr 3 2021, 2:52 PM

Could you please update D96069 instead?

MehdiChinoune added a comment.Apr 3 2021, 8:35 PM
In D99835#2667759, @Meinersbur wrote:

Could you please update D96069 instead?

I lost access to my old account.

clementval added a subscriber: clementval.Apr 4 2021, 7:05 AM
In D99835#2667872, @MehdiChinoune wrote:
In D99835#2667759, @Meinersbur wrote:

Could you please update D96069 instead?

I lost access to my old account.

You can take control of the patch with your new account with the “Commandeer revision” action.

MehdiChinoune added a comment.Apr 4 2021, 7:19 AM
In D99835#2668075, @clementval wrote:
In D99835#2667872, @MehdiChinoune wrote:
In D99835#2667759, @Meinersbur wrote:

Could you please update D96069 instead?

I lost access to my old account.

You can take control of the patch with your new account with the “Commandeer revision” action.

Thanks, didn't know about that option.

MehdiChinoune abandoned this revision.Apr 4 2021, 7:19 AM

Revision Contents

PathSize
flang/
unittests/
Runtime/
7 lines

Diff 335080

flang/unittests/Runtime/external-hello.cpp

Context not available.
#include "../../runtime/main.h" #include "../../runtime/main.h"
#include "../../runtime/stop.h" #include "../../runtime/stop.h"
#include <cstring> #include <cstring>
#include <limits>
using namespace Fortran::runtime::io; using namespace Fortran::runtime::io;
Context not available.
IONAME(OutputReal64)(io, 0.0); IONAME(OutputReal64)(io, 0.0);
IONAME(OutputReal64)(io, 2.0 / 3.0); IONAME(OutputReal64)(io, 2.0 / 3.0);
IONAME(OutputReal64)(io, 1.0e99); IONAME(OutputReal64)(io, 1.0e99);
IONAME(OutputReal64)(io, 1.0 / 0.0); IONAME(OutputReal64)(io, std::numeric_limits<double>::infinity());
IONAME(OutputReal64)(io, -1.0 / 0.0); IONAME(OutputReal64)(io, -std::numeric_limits<double>::infinity());
IONAME(OutputReal64)(io, 0.0 / 0.0); IONAME(OutputReal64)(io, std::numeric_limits<double>::quiet_NaN());
IONAME(OutputComplex64)(io, 123.0, -234.0); IONAME(OutputComplex64)(io, 123.0, -234.0);
IONAME(OutputLogical)(io, false); IONAME(OutputLogical)(io, false);
IONAME(OutputLogical)(io, true); IONAME(OutputLogical)(io, true);
Context not available.