This is an archive of the discontinued LLVM Phabricator instance.

Differential D99832

[HIP, test] Fix use of undef FileCheck var
ClosedPublic

Authored by thopre on Apr 3 2021, 1:33 AM.

Details

Reviewers
yaxunl
ashi1
MaskRay
hliao
pcc
Commits
rG292726b6443c: [HIP, test] Fix use of undef FileCheck var
Summary

Clang test CodeGenCUDA/kernel-stub-name.cu uses never defined DKERN
variable in a CHECK-NOT directive. This commit replace the variable by a
regex, thereby avoiding the issue.

Diff Detail

Event Timeline

thopre requested review of this revision.Apr 3 2021, 1:33 AM
thopre created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2021, 1:33 AM
Harbormaster completed remote builds in B96981: Diff 335067.Apr 3 2021, 2:03 AM
yaxunl accepted this revision.Apr 4 2021, 6:11 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Apr 4 2021, 6:11 AM
Closed by commit rG292726b6443c: [HIP, test] Fix use of undef FileCheck var (authored by thopre). · Explain WhyApr 4 2021, 11:30 AM
This revision was automatically updated to reflect the committed changes.
thopre added a commit: rG292726b6443c: [HIP, test] Fix use of undef FileCheck var.

Revision Contents

PathSize
clang/
test/
CodeGenCUDA/
2 lines

Diff 335162

clang/test/CodeGenCUDA/kernel-stub-name.cu

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Linesvoid fun5() {
kernel_ptr = ckernel; kernel_ptr = ckernel;
launch((void *)kernel_ptr); launch((void *)kernel_ptr);
} }
// CHECK-LABEL: define{{.*}}@__hip_register_globals // CHECK-LABEL: define{{.*}}@__hip_register_globals
// CHECK: call{{.*}}@__hipRegisterFunction{{.*}}@[[HCKERN]]{{.*}}@[[CKERN]] // CHECK: call{{.*}}@__hipRegisterFunction{{.*}}@[[HCKERN]]{{.*}}@[[CKERN]]
// CHECK: call{{.*}}@__hipRegisterFunction{{.*}}@[[HNSKERN]]{{.*}}@[[NSKERN]] // CHECK: call{{.*}}@__hipRegisterFunction{{.*}}@[[HNSKERN]]{{.*}}@[[NSKERN]]
// CHECK: call{{.*}}@__hipRegisterFunction{{.*}}@[[HTKERN]]{{.*}}@[[TKERN]] // CHECK: call{{.*}}@__hipRegisterFunction{{.*}}@[[HTKERN]]{{.*}}@[[TKERN]]
// CHECK-NOT: call{{.*}}@__hipRegisterFunction{{.*}}@[[HDKERN]]{{.*}}@[[DKERN]] // CHECK-NOT: call{{.*}}@__hipRegisterFunction{{.*}}@[[HDKERN]]{{.*}}@{{[0-9]*}}