Refactor: Simplify boolean conditional return statements in llvm/lib/MC/MCParser

[LegalizeAdulthood]

Summary

Use clang-tidy to simplify boolean conditional return values

[craig.topper]

lib/MC/MCParser/AsmParser.cpp

3161–3162

Push negate through

[LegalizeAdulthood]

lib/MC/MCParser/AsmParser.cpp

3161–3162

Fixed.

[LegalizeAdulthood]

Update from comments, clang-format

[LegalizeAdulthood]

Not sure what's going on; this review was accepted and then re-opened for review.

[LegalizeAdulthood]

Discarding due to inaction by reviewers.

lib/MC/MCParser/AsmParser.cpp

static bool isValidEncoding(int64_t Encoding) {
   const unsigned Format = Encoding & 0xf;
   if (Format != dwarf::DW_EH_PE_absptr && Format != dwarf::DW_EH_PE_udata2 &&
       Format != dwarf::DW_EH_PE_udata4 && Format != dwarf::DW_EH_PE_udata8 &&
       Format != dwarf::DW_EH_PE_sdata2 && Format != dwarf::DW_EH_PE_sdata4 &&
       Format != dwarf::DW_EH_PE_sdata8 && Format != dwarf::DW_EH_PE_signed)
     return false;
 
   const unsigned Application = Encoding & 0x70;
-  if (Application != dwarf::DW_EH_PE_absptr &&
-      Application != dwarf::DW_EH_PE_pcrel)
-    return false;
-
-  return true;
+  return Application == dwarf::DW_EH_PE_absptr ||
+         Application == dwarf::DW_EH_PE_pcrel;
 }
 
 /// parseDirectiveCFIPersonalityOrLsda
 /// IsPersonality true for cfi_personality, false for cfi_lsda
 /// ::= .cfi_personality encoding, [symbol_name]
 /// ::= .cfi_lsda encoding, [symbol_name]
 bool AsmParser::parseDirectiveCFIPersonalityOrLsda(bool IsPersonality) {
   int64_t Encoding = 0;

lib/MC/MCParser/ELFAsmParser.cpp

for (;;) {
 
     Size += CurSize;
     SectionName = StringRef(FirstLoc.getPointer(), Size);
 
     // Make sure the following token is adjacent.
     if (PrevLoc.getPointer() + CurSize != getTok().getLoc().getPointer())
       break;
   }
-  if (Size == 0)
-    return true;
-
-  return false;
+  return Size == 0;
 }
 
 static unsigned parseSectionFlags(StringRef flagsStr, bool *UseLastGroup) {
   unsigned flags = 0;
 
   for (unsigned i = 0; i < flagsStr.size(); i++) {
     switch (flagsStr[i]) {
     case 'a':