Page MenuHomePhabricator

[AIX][test-suite] Fix 32-bit test-suite build on AIX
ClosedPublic

Authored by stevewan on Apr 1 2021, 11:05 AM.

Details

Summary

For 32-bit programs on AIX, the default maximum size for the programs data heap could be too small for some of the test-suite cases. This patch sets the maximum heap size to 0x80000000 such that cases requiring larger heap size can properly load at runtime.

Diff Detail

Repository
rT test-suite

Event Timeline

stevewan created this revision.Apr 1 2021, 11:05 AM
stevewan requested review of this revision.Apr 1 2021, 11:06 AM
stevewan edited the summary of this revision. (Show Details)Apr 1 2021, 11:07 AM
daltenty added inline comments.Wed, Apr 7, 3:47 PM
CMakeLists.txt
219

Just leaving a reference to this in case anyone wonders about the CMake behaviour: https://gitlab.kitware.com/cmake/cmake/-/issues/17636

daltenty accepted this revision.Wed, Apr 7, 3:50 PM

LGTM, thanks!

(hopefully someday we can set this based on something internal to the CMake configuration rather than OBJECT_MODE, but that's all we have for now)

This revision is now accepted and ready to land.Wed, Apr 7, 3:50 PM
This revision was automatically updated to reflect the committed changes.
stevewan retitled this revision from Fix 32-bit test-suite build on AIX to [AIX][test-suite] Fix 32-bit test-suite build on AIX.Thu, Apr 8, 9:31 AM