This is an archive of the discontinued LLVM Phabricator instance.

[nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

Authored by jankratochvil on Mar 31 2021, 5:01 AM.

Diff Detail

Event Timeline

jankratochvil created this revision.Mar 31 2021, 5:01 AM
clayborg requested changes to this revision.Mar 31 2021, 8:55 AM

Looks good as long as we fix to DWARFUnit::GetRnglist() to not return a full copy of the "llvm::Optional<llvm::DWARFDebugRnglistTable>" each time it is called.


Return "const llvm::Optional<llvm::DWARFDebugRnglistTable> &" to avoid making a copy.

This revision now requires changes to proceed.Mar 31 2021, 8:55 AM
jankratochvil marked an inline comment as done.Apr 1 2021, 7:43 AM
jankratochvil added inline comments.

That was horrible, thanks for catching it.

clayborg accepted this revision.Apr 1 2021, 9:41 AM
This revision is now accepted and ready to land.Apr 1 2021, 9:41 AM
This revision was landed with ongoing or failed builds.May 19 2021, 6:57 AM
This revision was automatically updated to reflect the committed changes.
jankratochvil marked an inline comment as done.