Page MenuHomePhabricator

[X86] add dwarf annotation for inline stack probe
ClosedPublic

Authored by YangKeao on Mar 30 2021, 5:02 AM.

Details

Summary

While probing stack, the stack register is moved without dwarf
information, which could cause panic if unwind the backtrace.
This commit only add annotation for the inline stack probe case.
Dwarf information for the loop case should be done in another
patch and need further discussion.

Diff Detail

Event Timeline

YangKeao created this revision.Mar 30 2021, 5:02 AM
YangKeao requested review of this revision.Mar 30 2021, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2021, 5:02 AM

@nagisa This is the inline part of D98789 😋 .

I installed clang-format later, and nothing found (there is no lint message). How could I update this patch and remove the "clang-format not found in user's PATH; not linting file." warning? (or just left it here 😋 )

nagisa accepted this revision.EditedMar 30 2021, 5:16 AM
nagisa added a reviewer: serge-sans-paille.

You can remove these notices by running arc diff again with clang-format in your PATH. It is also fine to just leave these messages in – CI will verify the formatting as well and fail if its not correct. Only then it is strictly necessary to rediff your code.

Do you have ability to commit this yourself, or would you need somebody to do it for you?

This revision is now accepted and ready to land.Mar 30 2021, 5:16 AM

Do you have ability to commit this yourself, or would you need somebody to do it for you?

Yes. I do need somebody to help me commit this patch.(Actually, this is my first patch to llvm🎉). Can you do this for me? Thank you🥺.

This revision was landed with ongoing or failed builds.Mar 31 2021, 2:33 PM
This revision was automatically updated to reflect the committed changes.

Landed this, thank you!

Landed this, thank you!

Thanks 🍻 .